Re: [dpdk-dev] [PATCH v3 4/4] net/virtio: remove useless pointers checks

On 06/05, Maxime Coquelin wrote: >This patch removes uses checks on 'prev' pointer, as it s/uses/useless/ >is always set before with a valid value. > >Reviewed-by: David Marchand >Signed-off-by: Maxime Coquelin >--- > drivers/net/virtio/virtio_rxtx.c | 15 --- > 1 file changed, 4 ins

Re: [dpdk-dev] [PATCH v3 4/4] net/virtio: remove useless pointers checks

On 6/6/19 9:15 AM, Ye Xiaolong wrote: On 06/05, Maxime Coquelin wrote: This patch removes uses checks on 'prev' pointer, as it s/uses/useless/ Thanks, will fix while applying. Maxime is always set before with a valid value. Reviewed-by: David Marchand Signed-off-by: Maxime Coquelin -

Re: [dpdk-dev] [PATCH 40/49] net/ice/base: code clean up

> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, June 5, 2019 8:07 PM > To: Rong, Leyi ; Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M > Subject: Re: [dpdk-dev] [PATCH 40/49] net/ice/base: code clean up > > > > On 6/4/19 7:42 A

[dpdk-dev] [PATCH v2 1/6] raw/ntb: introduce ntb rawdev driver

Introduce rawdev driver support for NTB (Non-transparent Bridge) which can help to connect two separate hosts with each other. Signed-off-by: Xiaoyun Li --- config/common_base| 5 + drivers/raw/Makefile | 1 + drivers/raw/meson.build

[dpdk-dev] [PATCH v2 0/6] rawdev driver for ntb

This patch set adds support for Intel NTB device with Skylake platform. It is a raw device for allowing two hosts to communicate with each other and access the peer memory. This patch set also provides a simple example to transmit a file between two hosts. But since there is no FIFO here, only sup

[dpdk-dev] [PATCH v2 3/6] raw/ntb: add handshake process

Add handshake process using doorbell so that two hosts can communicate to start and stop. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/ntb_rawdev.c | 335 +++- 1 file changed, 334 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c b/dr

[dpdk-dev] [PATCH v2 2/6] raw/ntb: add intel ntb support

Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 368 ++

[dpdk-dev] [PATCH v2 6/6] doc: update docs for ntb driver

Update related documents for ntb pmd and example. Signed-off-by: Xiaoyun Li --- MAINTAINERS| 8 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/ntb_rawdev.rst | 41 ++ doc/guides/rel_notes/release_19_08.rst | 16 ++

[dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb

In order to allow binding/unbinding of devices for use by the ntb_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. And only support skx platform right now. Signed-off-by: Xiaoyun Li --- usertools/dpdk-devbind.py | 9

[dpdk-dev] [PATCH v2 4/6] examples/ntb: enable an example for ntb

Enable an example for rawdev ntb. Support interactive mode to send file on one host and receive file from another host. The command line would be 'send [filepath]' and 'receive [filepath]'. But since the FIFO is not enabled right now, use rte_memcpy as the enqueue and dequeue functions and only su

Re: [dpdk-dev] [PATCH v4] eal: remove non-thread panic calls from init sequence

On Wed, Jun 5, 2019 at 5:44 PM Arnon Warshavsky wrote: > On Wed, Jun 5, 2019 at 10:50 AM David Marchand wrote: >> On Tue, Jun 4, 2019 at 5:45 PM Arnon Warshavsky wrote: >>> This patch changes some void functions to return a value, >>> so that the init sequence may tear down orderly >>> instead o

Re: [dpdk-dev] [PATCH v4 1/8] net/rte_ether: deinline non-critical functions

On 6/5/19 8:09 PM, Stephen Hemminger wrote: Formatting Ethernet address and getting a random value are not in critical path so they should not be inlined. Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Andrew Rybchenko --- lib/librte_net/Makefile| 1 + l

Re: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb

On Thu, Jun 06, 2019 at 03:43:02PM +0800, Xiaoyun Li wrote: > In order to allow binding/unbinding of devices for use by the > ntb_rawdev, we need to update the devbind script to add a new class > of device, and add device ids for the specific HW instances. And > only support skx platform right now.

Re: [dpdk-dev] [PATCH v2 3/3] baseband/fpga_lte_fec: meson support

On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote: > Adding support for meson build environment > for the new BBDEV PMD driver. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/fpga_lte_fec/meson.build | 7 +++ > drivers/baseband/meson.build | 2 +- > 2

[dpdk-dev] [PATCH v11] net/memif: introduce memory interface (memif) PMD

Shared memory packet interface (memif) PMD allows for DPDK and any other client using memif (DPDK, VPP, libmemif) to communicate using shared memory. The created device transmits packets in a raw format. It can be used with Ethernet mode, IP mode, or Punt/Inject. At this moment, only Ethernet mode

Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra and device probe

> -Original Message- > From: Luca Boccassi > Sent: Monday, June 3, 2019 4:48 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Cc: Satha Koteswara Rao Kottidi ; Vamsi Krishna > Attunuru > Subject: Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra > and device probe > > O

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

On 03.06.2019 19:13, David Marchand wrote: > > > On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets > wrote: > > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets

Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra and device probe

On Thu, 2019-06-06 at 08:32 +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Luca Boccassi < > > bl...@debian.org > > > > > Sent: Monday, June 3, 2019 4:48 PM > > To: Jerin Jacob Kollanukkaran < > > jer...@marvell.com > > >; > > dev@dpdk.org > > > > Cc: Satha Kotes

Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

On 6/4/2019 5:19 PM, David Harton (dharton) wrote: > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, June 04, 2019 12:00 PM >> To: Bruce Richardson ; David Harton (dharton) >> >> Cc: dev@dpdk.org; beilei.x...@intel.com; qi.z.zh...@intel.com >> Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

On 6/5/2019 12:55 PM, Ferruh Yigit wrote: > On 5/31/2019 7:22 AM, Jakub Grajciar wrote: >> Memory interface (memif), provides high performance >> packet transfer over shared memory. > > Almost there, can you please check below comments? I am hoping to merge next > version of the patch. > > Thanks

Re: [dpdk-dev] [PATCH] doc: fix a grammar mistake in rawdev guide

Though John has already acked it, and I was original culprit, more than one Ack doesn't look bad :D > -Original Message- > From: Xiaolong Ye > Sent: Tuesday, June 4, 2019 2:11 PM > To: Shreyansh Jain ; Hemant Agrawal > ; John McNamara ; Marko > Kovacevic > Cc: dev@dpdk.org; Xiaolong Ye

Re: [dpdk-dev] [PATCH v3 0/4] et/virtio: Fix packet segmentation bug

On 6/5/19 12:00 PM, Maxime Coquelin wrote: This series fixes a bug reported by Yaroslav, where segmented packets miss some segments and head segment's data_len was set to a wrong value. Last patch is not a fix, but it removes some useless checks in Rx paths. v3: - Fix properly haed segment's

Re: [dpdk-dev] [PATCH] net/vhost: release port upon close

On 6/5/19 11:42 AM, Tiwei Bie wrote: Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Tiwei Bie --- drivers/net/vhost/rte_eth_vhost.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Ap

Re: [dpdk-dev] [PATCH v3 5/5] eal/x86: force inlining of all memcpy and mov helpers

On 6/5/19 2:53 PM, Bruce Richardson wrote: On Wed, May 29, 2019 at 03:04:20PM +0200, Maxime Coquelin wrote: Some helpers in the header file are forced inlined other are only inlined, this patch forces inline for all. It will avoid it to be embedded as functions when called multiple times in

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> -Original Message- > From: Neil Horman > Sent: Wednesday, June 5, 2019 11:41 PM > To: Bruce Richardson > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas > Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Wed, Jun 05, 2019 at 05:45:41PM +0100, Bruc

[dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must return 0 or negative error code. Bus code returns positive values if device wasn't recognized by any driver, so the result of 'bus->plug/unplug()' must be converted. 'local_dev_probe()' and 'local_dev_remove()' also has their internal

Re: [dpdk-dev] [PATCH v2 3/3] baseband/fpga_lte_fec: meson support

On 6/6/2019 9:25 AM, Bruce Richardson wrote: > On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote: >> Adding support for meson build environment >> for the new BBDEV PMD driver. >> >> Signed-off-by: Nicolas Chautru >> --- >> drivers/baseband/fpga_lte_fec/meson.build | 7 +++ >> d

Re: [dpdk-dev] [PATCH v1 0/3] MCS queued lock implementation

From: David Marchand Sent: Thursday, June 6, 2019 12:30 AM To: Phil Yang (Arm Technology China) Cc: dev ; tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com; Honnappa Nagarahalli ; Gavin Hu (Arm Technology China) ; nd Subject: Re: [dpdk-dev] [PATCH v1 0/3] MCS queued lock impleme

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

> -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, May 26, 2019 3:48 PM > To: Adrien Mazarguil ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging > > One of the reasons to destroy a flow is the fact that no packet matches the > flow for "t

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 11:24 AM > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface > (memif) PMD > > On 6/5/2019 12:55 PM, Ferr

Re: [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps

On 6/5/2019 9:10 PM, Nicolas Chautru wrote: > The documentation is clarified to point to steps on building the > SDK libraries which are now publicly available. > I can see new SDK link is in the documentation, but can you please put that information into the commit log too, to highlight it? > S

Re: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action

> -Original Message- > From: dev On Behalf Of Yongseok Koh > Sent: Tuesday, June 4, 2019 3:03 AM > To: shah...@mellanox.com; tho...@monjalon.net; ferruh.yi...@intel.com; > arybche...@solarflare.com; adrien.mazarg...@6wind.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix lack of ip type for crypto session

> -Original Message- > From: Drost, MariuszX > Sent: Tuesday, June 4, 2019 11:07 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Lu, Wenzhuo > ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Drost, MariuszX > Subject: [PATCH 1/2] net/ixgbe: fix lack of ip type for crypto session > > When i

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

> -Original Message- > From: Drost, MariuszX > Sent: Tuesday, June 4, 2019 11:07 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Lu, Wenzhuo > ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Drost, MariuszX > Subject: [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes > >

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

Hi Jerin From: Jerin Jacob > > -Original Message- > > From: dev On Behalf Of Matan Azrad > > Sent: Sunday, May 26, 2019 3:48 PM > > To: Adrien Mazarguil ; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging > > > > One of the reasons to destroy a flow is the fac

[dpdk-dev] [PATCH v4 00/11] A new net PMD - hinic

This patch set adds support of a new net PMD for Huawei Intelligent nic. This patch provides supoort for basic RX/TX and the contorl path needed for it. Later on new features will be added like VLAN, VFs, etc. Basic features: 1. Basic device operations: probe, initialization, start/stop, config

[dpdk-dev] [PATCH v4 05/11] net/hinic/base: add eqs and context code

Add code for eq. Aeq is a kind queue for mgmt asynchronous message and mgmt command response message. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_ctx_def.h | 184 ++ drivers/net/hinic/base/hinic_pmd_dpdev.h | 146 + drivers/net/hinic/base/hinic_pmd_eqs.c | 725 +++

[dpdk-dev] [PATCH v4 06/11] net/hinic/base: add code for nic business

Add code for nic business, including qps structures, qps configuration, wqs configuration for qps, nic business configuration functionalities. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_nic.h| 85 ++ drivers/net/hinic/base/hinic_pmd_niccfg.c | 1376

[dpdk-dev] [PATCH v4 08/11] net/hinic: add hinic PMD build and doc files

Add build and doc files, and common code files. Signed-off-by: Ziyang Xuan --- MAINTAINERS | 9 + config/common_base | 5 + config/common_linux | 5 + config/defconfig_arm-armv7a-linuxapp-gcc | 1 + c

[dpdk-dev] [PATCH v4 10/11] net/hinic: add TX module

Add code for TX module Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile |2 +- drivers/net/hinic/hinic_pmd_tx.c | 1070 ++ drivers/net/hinic/meson.build|2 +- 3 files changed, 1072 insertions(+), 2 deletions(-) create mode 100644 drivers/ne

[dpdk-dev] [PATCH v4 11/11] net/hinic: add support for basic device operations

Add hinic PMD initialization and ethernet operatioins code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/hinic_pmd_ethdev.c| 2125 +++ drivers/net/hinic/rte_pmd_hinic_version.map |4 + 2 files changed, 2129 insertions(+) create mode 100644 drivers/net/hinic/rte_p

[dpdk-dev] [PATCH v4 01/11] net/hinic/base: add registers for Huawei Hi1822 NIC

Add the registers that comprise the Huawei Hi1822 NIC. There is no functionality in this patch. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_csr.h | 164 + 1 file changed, 164 insertions(+) create mode 100644 drivers/net/hinic/base/hinic_csr.h diff --

[dpdk-dev] [PATCH v4 02/11] net/hinic/base: add command channels code

Admin channels include api channel and command queue, Api channel is for mgmt module. And command queue is for ucode module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_api_cmd.c | 1037 drivers/net/hinic/base/hinic_pmd_api_cmd.h | 271 + drivers/net

[dpdk-dev] [PATCH v4 03/11] net/hinic/base: add mgmt module interactive code

Add the structures, functionalities for interaction with mgmt module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_hw_mgmt.h| 85 +++ drivers/net/hinic/base/hinic_pmd_mgmt.c | 617 ++ drivers/net/hinic/base/hinic_pmd_mgmt.h | 125 .../net/

[dpdk-dev] [PATCH v4 04/11] net/hinic/base: add code about hardware operation

Add code for hardware operation, including configuration, query and so on. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_cfg.c | 269 drivers/net/hinic/base/hinic_pmd_cfg.h | 264 drivers/net/hinic/base/hinic_pmd_hw.h| 49 + drivers/net/hinic/base/hinic_pm

[dpdk-dev] [PATCH v4 07/11] net/hinic/base: add various headers

Add various headers that define mgmt commands, cmdq commands, rx data structures, tx data structures and basic defines for use in the code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_compat.h | 239 drivers/net/hinic/base/hinic_port_cmd.h | 483 +++

[dpdk-dev] [PATCH v4 09/11] net/hinic: add RX module

Add code for RX module. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile | 2 +- drivers/net/hinic/hinic_pmd_rx.c | 902 +++ drivers/net/hinic/meson.build| 2 +- 3 files changed, 904 insertions(+), 2 deletions(-) create mode 100644 drivers/net/

[dpdk-dev] [PATCH v5 0/2] examples/ipsec-secgw: fix 1st pkt dropped

This patchset fixes the issue of the first inbound packet being dropped for inline crypto. Changes in v5: - The v2 patchset has been rebased to the latest master. The v4 patchset has been dropped as it caused issues with the lookaside code which we are unable to test. Bernard Iremo

[dpdk-dev] [PATCH v5 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

Inline crypto installs a flow rule in the NIC. This flow rule must be installed before the first inbound packet is received. The create_session() function installs the flow rule, create_session() has been refactored into create_inline_session() and create_lookaside_session(). The create_inline_ses

[dpdk-dev] [PATCH v5 2/2] examples/ipsec-secgw/test: fix inline test scripts

Remove workaround in tun_aesgcm_defs.sh and trs_aesgcm_defs.sh to get around the bug where the first inbound packet is dropped for inline crypto. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec

Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface (memif) PMD

On 6/6/2019 11:25 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, June 6, 2019 11:24 AM >> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) >> ; dev@dpdk.org >> Subject: Re: [dpdk

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 09:44:52AM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Wednesday, June 5, 2019 11:41 PM > > To: Bruce Richardson > > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas > > Monjalon > > Subject: Re: [EXT] [RFC PA

[dpdk-dev] [PATCH] ip_frag: fix IPv6 fragment size calculation

Take into account IPv6 fragment extension header when calculating data size for each fragment. Fixes: 7a838c8798a9 ("ip_frag: fix IPv6 when MTU sizes not aligned to 8 bytes") Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev ---

[dpdk-dev] [PATCH v12] net/memif: introduce memory interface (memif) PMD

Shared memory packet interface (memif) PMD allows for DPDK and any other client using memif (DPDK, VPP, libmemif) to communicate using shared memory. The created device transmits packets in a raw format. It can be used with Ethernet mode, IP mode, or Punt/Inject. At this moment, only Ethernet mode

[dpdk-dev] [PATCH v2 0/5] examples/ipsec-secgw: support packet

v1 -> v2 - merge with latest mainline - update sample app guide Add into ipsec-secgw ability to fragment packet bigger then mtu, and reassemble fragmented packet. To support these features ipsec-secgw relies on librte_ipsec ability to handle multi-segment packets. Also when reassemble/fragmentat

[dpdk-dev] [PATCH v2 3/5] examples/ipsec-secgw: add multi-segment test cases

Enhance test scripts to support fragmentation/reassemble functionality. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/common_defs.sh | 18 +++--- examples/ipsec-secgw/test/data_rxtx.sh | 18 ++ examples/ipsec-secgw/test/linux_test4.sh | 17

[dpdk-dev] [PATCH v2 2/5] examples/ipsec-secgw: support packet fragmentation and reassembly

Add optional ability to fragment packet bigger then mtu, and reassemble fragmented packet. To minimize possible performance effect, reassembly is implemented as RX callback. To support these features ipsec-secgw relies on librte_ipsec ability to handle multi-segment packets. Also when reassemble/fr

[dpdk-dev] [PATCH v2 1/5] examples/ipsec-secgw: fix invalid packet length

for packets smaller then 64B some NICs reports pkt_len=64B. As ipsec-secgw (and librte_ipsec) relies on pkt_len value to determine payload length, that causes problems for small packets. To fix the issue, check that pkt_len matches values in IPv4/IPv6 header and re-adjust pkt_len if necessary. Fix

[dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: add bypass test case

Add simple test-case with all traffic in BYPASS mode. Useful for some basic test of your network environment. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/bypass_defs.sh | 45 1 file changed, 45 insertions(+) create mode 100644 examples/ipsec-secgw/te

[dpdk-dev] [PATCH v2 5/5] doc: update ipsec-secgw guide

Update ipsec-secgw guide to reflect latest changes: support packets fragmentation/reassembly and related new command-line options. Signed-off-by: Konstantin Ananyev --- doc/guides/sample_app_ug/ipsec_secgw.rst | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --

[dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

Add a programmer's guide section for meson ut Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- v6: Updated comments v5: Modified v4: Typos corrected v3: Modified v2: Removed enhancement details --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/meson_ut.rst | 1

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 5:04 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 09:44:52AM +, Jerin

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

> -Original Message- > From: Matan Azrad > Sent: Thursday, June 6, 2019 4:22 PM > To: Jerin Jacob Kollanukkaran ; Adrien Mazarguil > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH] [RFC] ethdev: support flow aging > > Hi Jerin Hi Matan, > > From: Jerin Jacob > > > -Original Message

Re: [dpdk-dev] [PATCH] net/af_xdp: fix failure on rte_dev_remove

Ferruh, On Wed, Jun 5, 2019 at 5:30 PM Ferruh Yigit wrote: > On 6/1/2019 5:13 PM, Ye Xiaolong wrote: > > On 05/31, William Tu wrote: > >> When users call rte_eth_dev_close() and rte_dev_remove(), the af_xdp > >> pmd return -1 (EPERM) due to eth_dev == NULL. > >> > >> Since the af_xdp pmd driver

[dpdk-dev] [PATCH] net/mlx5: fix master device Netlink socket sharing

There is the patch [1] that uses master device Netlink socket to retrieve master device link settings. This is not thread safe because this resource may be in use by other call to the master device itself. Using the same Netlink socket concurrently from the multiple threads causes Netlink requests

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Neil Horman >> Sent: Thursday, June 6, 2019 5:04 PM >> To: Jerin Jacob Kollanukkaran >> Cc: Bruce Richardson ; dev@dpdk.org; >> Thomas Monjalon >> Subject: Re: [EXT] [RFC PATCH 0/2] in

Re: [dpdk-dev] [PATCH 3/8] raw/ioat: add register definition file

On Thu, May 30, 2019 at 04:53:05PM -0700, Stephen Hemminger wrote: > On Thu, 30 May 2019 22:25:20 +0100 > Bruce Richardson wrote: > > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > This a driver private file, why the C++ guard here? It's not just a private file, it's includ

[dpdk-dev] [PATCH] kni: remove PCI related information

As there is no ethtool support in KNI anymore, PCI related information is no longer needed. Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_dev.h| 3 --- kernel/linux/kni/kni_misc.c | 6 -- lib/librte_eal/linux/eal/include/rte_kni_common.h |

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 12:04:57PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 5:04 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PATC

Re: [dpdk-dev] [PATCH v1 3/3] test/mcslock: add mcs queued lock unit test

Hi, > > Unit test and perf test for MCS queued lock. Perf test is important of course, but first I think we need more robust functional test to make sure that lock does work properly. At least something like ticketlock test but probably with bigger number of iterations. 10K seems quite small he

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: > > > > On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > > wrote: > > > >> -Original Message- > >> From: Neil Horman > >> Sent: Thursday, June 6, 2019 5:04 PM > >> To: Jerin Jacob Kollanukkaran > >> Cc: Bruce Richar

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> On Jun 6, 2019, at 8:43 AM, Neil Horman wrote: > > On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: >> >> >>> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran >>> wrote: >>> -Original Message- From: Neil Horman Sent: Thursday, June 6, 2019 5:04

[dpdk-dev] DPDK Release Status Meeting 6/6/2019

Minutes 6 June 2019 --- Agenda: * Release Dates * Subtrees * OvS * Conferences * Opens Participants: * Debian/Microsoft * Intel * Marvell * NXP * Red Hat Release Dates - * v19.08 dates: * Proposal deadline passed, it was on 3 June * Integration/Merge/RC1 Mo

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 7:05 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 12:04:57PM +, Jerin

Re: [dpdk-dev] [PATCH v12] net/memif: introduce memory interface (memif) PMD

On 6/6/2019 12:38 PM, Jakub Grajciar wrote: > Shared memory packet interface (memif) PMD allows for DPDK and any other > client using memif (DPDK, VPP, libmemif) to communicate using shared > memory. The created device transmits packets in a raw format. It can be > used with Ethernet mode, IP mode,

Re: [dpdk-dev] [PATCH] kni: remove PCI related information

On 6/6/2019 2:26 PM, Igor Ryzhov wrote: > As there is no ethtool support in KNI anymore, > PCI related information is no longer needed. > > Signed-off-by: Igor Ryzhov Fixes: ea6b39b5b847 ("kni: remove ethtool support") Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value

rte_calloc functions returns a non-null pointer in case of success and null pointer in case of failure. The return value should be checked and the function flow should take that into consideration. This patch adds a check for rte_calloc return value in function flow_list_create. Fixes: 84c406e7

Re: [dpdk-dev] [PATCH] net/ena: fix counting of per-queue number of Tx pkts

On 5/14/2019 12:11 PM, Rafal Kozik wrote: > Instead of counting number of used NIC Tx bufs just count number > of Tx packets. > > Fixes: 45b6d86184fc ("net/ena: add per-queue software counters stats") > Cc: sta...@dpdk.org > > Signed-off-by: Rafal Kozik > Acked-by: Michal Krawczyk Applied to d

Re: [dpdk-dev] [PATCH v3] ipsec: include high order bytes of esn in pkt len

> -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@marvell.com] > Sent: Wednesday, June 5, 2019 4:31 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; ano...@marvell.com; Lukasz Bartosik > Subject: [PATCH v3] ipsec: include high order bytes of esn in pkt len > > When esn is

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 01:53:47PM +, Wiles, Keith wrote: > > > > On Jun 6, 2019, at 8:43 AM, Neil Horman wrote: > > > > On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: > >> > >> > >>> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > >>> wrote: > >>> > -Or

[dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

From: Jerin Jacob Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C language. ../lib/librte_acl/acl_run_neon.h: In function 'search_neon_4' ../lib/librt

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

Honnappa Nagarahalli writes: > > > > > From: Michael Santana Francisco > Sent: Wednesday, June 5, 2019 5:39 PM > To: Honnappa Nagarahalli ; Aaron Conole > ; tho...@monjalon.net > Cc: Ruifeng Wang (Arm Technology China) ; Gavin Hu (Arm > Technology > China) ; Dharmik Thakkar ; > jerin.ja...

Re: [dpdk-dev] [PATCH] net/ena: update Rx checksum errors on Rx path

On 5/28/2019 9:28 AM, Michal Krawczyk wrote: > Rx checksum flags and input errors shouldn't be updated on Tx, as it > would work only for packets forwarding. > > The ierrors statistic should be updated on Rx, right after checking > Rx checksum flags if the Rx checksum offload is enabled. > > Sign

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

> -Original Message- > From: dev On Behalf Of Michael Santana > Francisco > Sent: Thursday, June 6, 2019 4:09 AM > To: Honnappa Nagarahalli ; Aaron Conole > ; tho...@monjalon.net > Cc: Ruifeng Wang (Arm Technology China) ; Gavin > Hu (Arm Technology China) ; Dharmik Thakkar > ; jerin.ja...

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 7:05 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PATC

Re: [dpdk-dev] [PATCH] ethdev: add a check on mempool during rxq setup

On 6/5/2019 5:46 PM, Andrew Rybchenko wrote: > On 5/17/19 11:15 AM, David Marchand wrote: >> We currently have no check on the mempool pointer passed to >> rte_eth_rx_queue_setup. >> Let's avoid a plain crash when dereferencing it. >> >> Suggested-by: Jens Freimann >> Signed-off-by: David Marchand

Re: [dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

On 5/30/2019 3:58 PM, Dan Wei wrote: > Modify AFU configurations for new Blue Bitstream of A10 on N3000 card: > - AFU register access: RTL changes the UPL base address and the read/write > commands of register indirect access. > - Add delays to wait for the HW reset completion. > - Refine log for d

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 8:34 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin

Re: [dpdk-dev] [PATCH v1 00/58] OCTEON TX2 Ethdev driver

On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > This patchset adds support for OCTEON TX2 ethdev driver. > > This patch set is depended on "OCTEON TX2 common and mempool driver" series. > http://mails.dpdk.org/archives/dev/2019-June/133329.html Hi Jerin, I will wait for

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Thu, Jun 06, 2019 at 03:14:42PM +, Jerin Jacob Kollanukkaran wrote: > > > I don't have any strong opinion on name prefix vs marking as __rte_internal. > Or combination of both. I am fine any approach. > > I have only strong option on not to induce objdump dependency for > checkpatch. >

[dpdk-dev] [PATCH 0/4] net/enic: minor updates

The first two patches report the min/max MTU and speed capabilities to support applications that rely on them. The other two patches remove unnecessary/unsupported code from the flow implementation. We do not expect more patches for 19.08. Hyong Youb Kim (2): net/enic: set min and max MTU net/

[dpdk-dev] [PATCH 1/4] net/enic: set min and max MTU

These values correspond to those used in the MTU handler (enic_set_mtu). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index 80fbf595e

[dpdk-dev] [PATCH 2/4] net/enic: report speed capabilities

Available link speeds are based on VIC adapter model, which is encoded in PCI subsystem device ID. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/features/enic.ini | 1 + drivers/net/enic/enic_ethdev.c| 51 +++ 2 files changed,

[dpdk-dev] [PATCH 3/4] net/enic: remove support for flow count action

From: John Daley The firmware in 1400 series VIC adapters which would support COUNT flow action was postponed and reworked. The capability will be re-added in a future release when the firmware is available. This reverts the following commits. commit 86df6c4e2fce ("net/enic: support flow counter

[dpdk-dev] [PATCH 4/4] net/enic: remove locks from rte flow code

From: John Daley There is no requirement for thread safety in the flow PMD code and no need for the locks. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: sta...@dpdk.org Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic.h

Re: [dpdk-dev] [PATCH v1 01/58] net/octeontx2: add build infrastructure

On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding bare minimum PMD library and doc build infrastructure. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K > Signed-off-by: Pavan Nikhilesh > --- > config/common_base| 5 +++ >

[dpdk-dev] [PATCH] kernel/freebsd: fix module build on latest head

Internal changes in the freebsd kernel have meant that additional includes are now necessary to build the kernel modules for DPDK. Tested with latest bsd HEAD revision. Bugzilla ID: 282 Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- kernel/freebsd/contigmem/contigmem.c | 3 +++ kernel/

Re: [dpdk-dev] [PATCH v1 09/58] net/octeontx2: add context debug utils

On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Add RQ,SQ,CQ context and CQE structure dump utils. > > Signed-off-by: Jerin Jacob > Signed-off-by: Vivek Sharma <...> > @@ -23,6 +23,9 @@ nix_lf_err_irq(void *param) > > /* Clear interrupt */ > otx2_write64(

Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > The fields from CQE needs to be converted to > ptype and rx ol flags in mbuf. This patch adds > create lookup memory for those items to be > used in Fastpath. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K >

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

On 6/6/19 10:50 AM, jer...@marvell.com wrote: From: Jerin Jacob Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C language. ../lib/librte_acl/acl_run_

  1   2   >