On 06/05, Maxime Coquelin wrote:
>This patch removes uses checks on 'prev' pointer, as it
s/uses/useless/
>is always set before with a valid value.
>
>Reviewed-by: David Marchand <david.march...@redhat.com>
>Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
>---
> drivers/net/virtio/virtio_rxtx.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/net/virtio/virtio_rxtx.c
>b/drivers/net/virtio/virtio_rxtx.c
>index 358cc86627..ca40ba9c5d 100644
>--- a/drivers/net/virtio/virtio_rxtx.c
>+++ b/drivers/net/virtio/virtio_rxtx.c
>@@ -1517,9 +1517,7 @@ virtio_recv_pkts_inorder(void *rx_queue,
>
> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
>
>- if (prev)
>- prev->next = rxm;
>-
>+ prev->next = rxm;
> prev = rxm;
> seg_res -= 1;
> }
>@@ -1701,9 +1699,7 @@ virtio_recv_mergeable_pkts(void *rx_queue,
>
> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
>
>- if (prev)
>- prev->next = rxm;
>-
>+ prev->next = rxm;
> prev = rxm;
> seg_res -= 1;
> }
>@@ -1876,9 +1872,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
>
> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
>
>- if (prev)
>- prev->next = rxm;
>-
>+ prev->next = rxm;
> prev = rxm;
> seg_res -= 1;
> }
>@@ -1921,8 +1915,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
> } else {
> PMD_RX_LOG(ERR,
> "No enough segments for packet.");
>- if (prev)
>- virtio_discard_rxbuf(vq, prev);
>+ virtio_discard_rxbuf(vq, prev);
> rxvq->stats.errors++;
> break;
> }
>--
>2.21.0
>
