On 2019/4/25 23:51, Varghese, Vipin wrote:
Hi,
snipped
@@ -847,6 +847,10 @@ struct parse_val {
pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats);
if (pt->dir & RTE_PDUMP_FLAG_TX)
pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats);
+
+ /* Once p
Hi Kevin,
Thanks we will look into it.
Regards,
Hemant
> -Original Message-
> From: Kevin Traynor
> Sent: Thursday, April 25, 2019 11:13 PM
> To: Akhil Goyal ; dev@dpdk.org
> Cc: Hemant Agrawal ; sta...@dpdk.org
> Subject: [EXT] Re: [dpdk-dev] [PATCH 5/6] crypto/dpaa_sec: fix sess
> -Original Message-
> From: dev On Behalf Of Abhinandan Gujjar
> Sent: Wednesday, April 24, 2019 10:05 PM
> To: jerin.ja...@caviumnetworks.com; dev@dpdk.org
> Cc: narender.vang...@intel.com; abhinandan.guj...@intel.com;
> john.mcnam...@intel.com
> Subject: [dpdk-dev] [PATCH] eventdev: fix
@Andrew I applied your comments. Thanks.
On 2019-04-25 20:28, Wiles, Keith wrote:
What is a raw clock value? It took me a bit to find that it is in nano-seconds
need to document that point.
It is not in nanosecond, it has no units. Finding the relation between
the device clock and the real t
> -Original Message-
> From: dev On Behalf Of Honnappa Nagarahalli
> Sent: Friday, April 26, 2019 10:10 AM
> To: konstantin.anan...@intel.com; step...@networkplumber.org;
> paul...@linux.ibm.com; marko.kovace...@intel.com; dev@dpdk.org
> Cc: honnappa.nagaraha...@arm.com; gavin...@arm.com;
On 25-Apr-19 6:19 PM, Stephen Hemminger wrote:
Systemd uses this and it looks like a useful addition to the DPDK source
base. Especially since we now have Windows developers.
https://editorconfig.org/
I have suggested using clang-format in the past, but this would be a
good step too.
--
Th
On 4/25/19 8:19 PM, Stephen Hemminger wrote:
Systemd uses this and it looks like a useful addition to the DPDK source
base. Especially since we now have Windows developers.
https://editorconfig.org/
+1
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attempt to look at the index at RTE_MAX_LCORE,
which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to
RTE_MAX_LCORE_FREQS.
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
Coverity
coverity complains about a null-termination after a read,
so we terminate conditionally on whether idx is within
the buffer or at the end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: sta...@dpdk.org
Signed-off-by: David Hunt
---
example
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
CC: sta...@dpdk.org
Signed-off-by: David Hunt
---
examples/vm_power
On 22-Apr-19 7:15 AM, kirankum...@marvell.com wrote:
From: Kiran Kumar K
With current KNI implementation kernel module will work only in
IOVA=PA mode. This patch will add support for kernel module to work
with IOVA=VA mode.
The idea is to get the physical address from iova address using
api io
From: lilin24
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
buffer between qemu and backend.
Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the
shared buffer from backend. Then qemu should send it back
thro
According to manpage, ENOBUFS error indicates that either the
input or the output queue is full. This should be considered
an error, but it is treated as an "ignore" condition. Fix the
code to report an error instead.
Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: sta
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
CC: sta...@dpdk.org
Signed-
On 26-Apr-19 9:43 AM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate conditionally on whether idx is within
the buffer or at the end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: sta...@dpdk.o
Hi,
Looks like something in email format setting is affecting the style. Please
find my replies below
snipped
As per the current suggested code flow check is added to while loop in function
`dump_packets'.
Thanks for the reply. Since want to make it clean, the code was here.
However, it see
I will leave this suggestion open for comments from the maintainer.
snipped
Hi,
Looks like something in email format setting is affecting the style. Please
find my replies below
snipped
As per the current suggested code flow check is added to while loop in function
`dump_packets'.
Thanks f
Hi Anatoly,
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_powe
Hi Anatoly,
On 26/4/2019 11:33 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:43 AM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate conditionally on whether idx is within
the buffer or at the end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f (
coverity complains about a null-termination after a read,
so we terminate after exiting the do-while loop. The position
is conditional on whether idx is within the buffer or at the
end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: sta...@d
On 26-Apr-19 12:24 PM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate after exiting the do-while loop. The position
is conditional on whether idx is within the buffer or at the
end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f ("examples/pow
On 26-Apr-19 12:14 PM, Hunt, David wrote:
Hi Anatoly,
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue:
> -Original Message-
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com]
> Sent: Friday, April 26, 2019 5:40 AM
> To: Ananyev, Konstantin ;
> step...@networkplumber.org; paul...@linux.ibm.com; Kovacevic, Marko
> ; dev@dpdk.org
> Cc: honnappa.nagaraha...@arm.com; gavin...@
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion open for comments from the maintainer.
Hi,
Thanks for your suggestion. I have also tried to add an slave core to
monitor the primary status this afternoon. It works.
I doubt if it can be add an new option as you sug
> > > From: Ido Goshen
> > >
> > > 10BASE-T SFP+ copper transceivers become cheaper and popular So far
> > > those were blocked by ixgbe as “unsupported”.
> > > e.g.
> > > eth_ixgbe_dev_init(): Unsupported SFP+ Module
> > > eth_ixgbe_dev_init(): Hardware Initialization Failure: -19
> > > E
On Fri, Apr 26, 2019 at 12:56:08PM +0100, Burakov, Anatoly wrote:
> On 26-Apr-19 12:24 PM, David Hunt wrote:
> > coverity complains about a null-termination after a read,
> > so we terminate after exiting the do-while loop. The position
> > is conditional on whether idx is within the buffer or at t
On 26-Apr-19 1:03 PM, Burakov, Anatoly wrote:
On 26-Apr-19 12:14 PM, Hunt, David wrote:
Hi Anatoly,
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the
On 26-Apr-19 1:31 PM, Bruce Richardson wrote:
On Fri, Apr 26, 2019 at 12:56:08PM +0100, Burakov, Anatoly wrote:
On 26-Apr-19 12:24 PM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate after exiting the do-while loop. The position
is conditional on whet
> On Apr 26, 2019, at 3:13 AM, Burakov, Anatoly
> wrote:
>
> On 25-Apr-19 6:19 PM, Stephen Hemminger wrote:
>> Systemd uses this and it looks like a useful addition to the DPDK source
>> base. Especially since we now have Windows developers.
>> https://editorconfig.org/
>
> I have suggested
On 26-Apr-19 1:08 PM, Suanming.Mou wrote:
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion open for comments from the maintainer.
Hi,
Thanks for your suggestion. I have also tried to add an slave core to
monitor the primary status this afternoon. It works.
I doubt
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob
coverity complains about a null-termination after a read,
so we terminate once we exit the do-while read loop.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: sta...@dpdk.org
Signed-off-by: David Hunt
---
v2: Move null termination outside of do-while.
v
On 26-Apr-19 3:04 PM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate once we exit the do-while read loop.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: sta...@dpdk.org
Signed-off-by: David Hunt
---
v2: Mo
On 2019/4/26 21:46, Burakov, Anatoly wrote:
On 26-Apr-19 1:08 PM, Suanming.Mou wrote:
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion open for comments from the maintainer.
Hi,
Thanks for your suggestion. I have also tried to add an slave core to
monitor the prim
On 26-Apr-19 3:32 PM, Suanming.Mou wrote:
On 2019/4/26 21:46, Burakov, Anatoly wrote:
On 26-Apr-19 1:08 PM, Suanming.Mou wrote:
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion open for comments from the maintainer.
Hi,
Thanks for your suggestion. I have also tried
The rte_timer_alt_manage function should track which is the running
timer and whether or not it was updated by a callback in the priv_timer
structure that corresponds to the running lcore, so that restarting
or stopping the timer from the callback works correctly.
Fixes: c0749f7096c7 ("timer: allo
On 2019/4/26 22:39, Burakov, Anatoly wrote:
On 26-Apr-19 3:32 PM, Suanming.Mou wrote:
On 2019/4/26 21:46, Burakov, Anatoly wrote:
On 26-Apr-19 1:08 PM, Suanming.Mou wrote:
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion open for comments from the maintainer.
Hi,
On 26-Apr-19 3:49 PM, Suanming.Mou wrote:
On 2019/4/26 22:39, Burakov, Anatoly wrote:
On 26-Apr-19 3:32 PM, Suanming.Mou wrote:
On 2019/4/26 21:46, Burakov, Anatoly wrote:
On 26-Apr-19 1:08 PM, Suanming.Mou wrote:
On 2019/4/26 18:56, Varghese, Vipin wrote:
I will leave this suggestion op
> -Original Message-
> From: Babu Radhakrishnan, AgalyaX
> Sent: Wednesday, March 6, 2019 9:20 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma ; Richardson, Bruce
> ; Babu Radhakrishnan, AgalyaX
>
> Subject: [PATCH] app/test: enhance meson test run for FreeBSD and Linux
>
> From: Agalya Bab
On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote:
> > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote:
> > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote:
> > > > On Wed, Apr 24, 2019 at 10:22:04AM
Fix spelling errors in the guide docs.
Signed-off-by: John McNamara
---
doc/guides/compressdevs/overview.rst | 2 +-
doc/guides/contributing/patches.rst| 2 +-
doc/guides/cryptodevs/aesni_mb.rst | 2 +-
doc/guides/cryptodevs/overview.rst
Fix spelling errors in the doxygen docs.
Signed-off-by: John McNamara
---
drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h| 2 +-
drivers/common/qat/qat_adf/icp_qat_fw_pke.h| 2 +-
drivers/event/opdl/opdl_ring.h | 8
drivers/net/i40e/rte_pmd_i40e.h
This patch introduces a new version of the event timer adapter software
PMD [1]. In the original design, timer event producer lcores in the primary
and secondary processes enqueued event timers into a ring, and a service
core in the primary process dequeued them and processed them further. To
impr
This patch introduces a new version of the event timer adapter software
PMD. In the original design, timer event producer lcores in the primary
and secondary processes enqueued event timers into a ring, and a
service core in the primary process dequeued them and processed them
further. To improve
On Fri, 2019-04-26 at 15:56 +0100, Bruce Richardson wrote:
> On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote:
> > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote:
> > > > On Wed, 2019-04-24 at 11:41 +0100,
On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote:
> As part of the meson build, a pkg-config file for libdpdk is created,
> which
> allows apps to be compiled and linked against DPDK by taking the
> cflags and
> lib parameter from pkgconfig. The example app makefiles have been
> reworked
>
On Fri, Apr 26, 2019 at 05:11:18PM +0100, Luca Boccassi wrote:
> On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote:
> > As part of the meson build, a pkg-config file for libdpdk is created,
> > which
> > allows apps to be compiled and linked against DPDK by taking the
> > cflags and
> > lib
"VFIO group is not viable" error message is correct
but not very user friendly for something which can
usually be easily rectified.
Add some additional text to give more of a hint.
Signed-off-by: Kevin Traynor
---
lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
1 file changed, 3 insertions(+), 1
On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
"VFIO group is not viable" error message is correct
but not very user friendly for something which can
usually be easily rectified.
Add some additional text to give more of a hint.
Signed-off-by: Kevin Traynor
---
lib/librte_eal/linux/eal/eal_vfio.c
Add the experimental tag back to the Rx event adapter callback,
the Rx event callback register and the Rx event adapter statistics
retrieval functions due to an API change to be proposed in a
future patch.
This patch also adds the experimental tag to these
function definitions and adds the functio
On freebsd we need to include sys/socket.h to get the definition of
AF_INET in order to compile.
Fixes: d5ceea4ab160 ("examples/l3fwd: format IP addresses for printing")
Signed-off-by: Bruce Richardson
---
examples/l3fwd/l3fwd_lpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/l
When we install dpdk onto a system, we want to put the examples into
the /usr/share/dpdk (or /usr/local/share) directory for reference.
Signed-off-by: Bruce Richardson
Acked-by: Luca Boccassi
---
examples/meson.build | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff
As part of the meson build, a pkg-config file for libdpdk is created, which
allows apps to be compiled and linked against DPDK by taking the cflags and
lib parameter from pkgconfig. The example app makefiles have been reworked
to take account of this support, but the build of them against the .pc f
The pkg-config file generated as part of the build of DPDK should allow
applications to be built with an installed DPDK. We can test this as
part of the build by doing an install of DPDK to a temporary directory
within the build folder, and by then compiling up a few sample apps
using make working
The post-install script to symlink the PMDs from their own PMD directory to
the regular lib directory (so they would be found by ld at runtime) was
using the "-r" flag to ln to create relative symlinks. This flag is
unsupported by ln on FreeBSD causing the ninja install step to fail.
Reworking the
If libbsd is enabled in DPDK, the strlcpy and strlcat functions in
rte_string_fns.h redirect to the varients in libbsd, only using the
fallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs
to be called out as a DPDK dependency in the pkgconfig file.
To ensure that we don't have
The examples/meson.build file scanned the filesystem to find all examples
to build (for examples=all option) and install. However, using run_command
and scanning the filesystem prevented ninja from properly detecting the
addition or removal of any examples - one had to recreate the build
directory
Remove references to the (deleted) rte_event_port_enqueue_depth()
function in the Doxygen comments for rte_event_enqueue_burst() and
friends, and replace with references to rte_event_port_attr_get().
Fixes: 78ffab961155 ("eventdev: add port attribute function")
Signed-off-by: Erik Gabriel Carrill
On 26/04/2019 17:33, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback,
> the Rx event callback register and the Rx event adapter statistics
> retrieval functions due to an API change to be proposed in a
> future patch.
>
> This patch also adds the experimental tag
Hi Erik,
A quick question.
> -Original Message-
> From: dev On Behalf Of Erik Gabriel Carrillo
> Sent: Friday, April 26, 2019 10:14 AM
> To: jerin.ja...@caviumnetworks.com
> Cc: mattias.ronnb...@ericsson.com; pbhagavat...@caviumnetworks.com;
> dev@dpdk.org
> Subject: [dpdk-dev] [P
> -Original Message-
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com]
> Sent: Friday, April 26, 2019 1:51 PM
> To: Carrillo, Erik G ;
> jerin.ja...@caviumnetworks.com
> Cc: mattias.ronnb...@ericsson.com; pbhagavat...@caviumnetworks.com;
> dev@dpdk.org; Honnappa Nagaraha
NULL cipher algo of 4-byte multiple and other sizes caused firmware hang
due to use of wrong mode. Changed from ECB mode to CTR mode to fix.
Fixes: 98f060891615 ("crypto/qat: add symmetric session file")
cc: sta...@dpdk.org
Signed-off-by: Fiona Trahe
---
drivers/crypto/qat/qat_sym_session.c | 3
Added NULL algo tests into loop test mechanism used
by block cipher tests as easier to extend there.
Included chain, cipher-only and auth-only use-cases.
Extended to cover out-of-place use-cases and use-cases
where data length is not an 8-byte multiple.
Signed-off-by: Fiona Trahe
---
app/test/te
From: Krzysztof Kanas
Fix test_set_bonded_port_initialization_mac_assignment so that it works
after 're run' test_link_bonding.
Fixes: f2ef6f21ee2e ("bond: fix mac assignment to slaves")
Cc: declan.dohe...@intel.com
Signed-off-by: Krzysztof Kanas
---
app/test/test_link_bonding.c | 53
There are some physical link settings can be queried from
Ethernet devices: link status, link speed, speed capabilities,
duplex mode, etc. These setting do not make a lot of sense for
representors due to missing physical link. The new kernel drivers
dropped query for link settings for representors
The patches [1] and [2] are both related to Memory Regions sharing and their
applying order matters, this series just combines ones.
The multiport Infiniband device support was introduced [3].
All active ports, belonging to the same Infiniband device use the single
shared Infiniband context of tha
Mellanox mlx5 PMD implements the list of devices to process the memory
free events to reflect the actual memory state to Memory Regions.
Because this list contains the devices and devices may share the
same context the callback routine may be called multiple times
with the same parameter, that is n
The multiport Infiniband device support was introduced [1].
All active ports, belonging to the same Infiniband device use the single
shared Infiniband context of that device and share the resources:
- QPs are created within shared context
- Verbs flows are also created with specifying port inde
> On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> > "VFIO group is not viable" error message is correct
> > but not very user friendly for something which can
> > usually be easily rectified.
> >
> > Add some additional text to give more of a hint.
> >
> > Signed-off-by: Kevin Traynor
> > ---
Acked
69 matches
Mail list logo
