Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no IOVA contig mempools

2019-04-02 Thread Shahaf Shuler
Monday, April 1, 2019 4:50 PM, Burakov, Anatoly: > Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no > IOVA contig mempools > > On 01-Apr-19 11:34 AM, Shahaf Shuler wrote: > > providing a command line parameter to set the mempool flags accordingly. > > This mode is relevant o

[dpdk-dev] [PATCH v2] net/mlx5: fix flow counters using devx

2019-04-02 Thread Ori Kam
The API that was defined in OFED 4.5 was replaced both in OFED 4.6 and in upstream. This commit updates the API to match the upstream one. Fixes: f5bf91de738a ("net/mlx5: support flow counters using devx") Cc: mo...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Ori Kam --- v2: * change fix l

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: map anonymous memory for eth devices

2019-04-02 Thread Shahaf Shuler
Monday, April 1, 2019 4:28 PM, Burakov, Anatoly: > Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: map anonymous memory > for eth devices > > On 01-Apr-19 11:34 AM, Shahaf Shuler wrote: > > Mempools can be populated with anonymous memory when using > command > > line parameter --mp-alloc=anon. >

Re: [dpdk-dev] [PATCH v4 2/2] app/pdump: enhance to support multi-core capture

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 6:33 AM Vipin Varghese wrote: > Add option --multi, to enhance the pdump application to allow capture > on unique cores for each --pdump option. If option --multi is ignored > the default capture occurs on a single core for all --pdump options. > > Signed-off-by: Vipin Varg

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

2019-04-02 Thread Thomas Monjalon
02/04/2019 03:03, Jerin Jacob Kollanukkaran: > On Mon, 2019-04-01 at 22:53 +0200, Thomas Monjalon wrote: > > 01/04/2019 22:25, Ferruh Yigit: > > > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > > > From: Pavan Nikhilesh > > > > > > > > Optimize testpmd txonly mode by > > > > 1. Movi

Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD global data init

2019-04-02 Thread Shahaf Shuler
Tuesday, April 2, 2019 12:13 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 0/4] net/mlx5: rework IPC socket and PMD > global data init > > The existing socket-based IPC channel is replaced with the new rte_mp APIs > of EAL and extended to request stop/start of dataplane to secondary > processe

Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE

2019-04-02 Thread Thomas Monjalon
02/04/2019 03:01, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 01/04/2019 17:12, Ferruh Yigit: > > > On 4/1/2019 2:27 PM, Thomas Monjalon wrote: > > > > 01/04/2019 14:51, Ferruh Yigit: > > > >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: > > > >>> 26/03/2019 10:50, Ferruh

Re: [dpdk-dev] [PATCH v3 0/3] net/mlx4: add secondary process support

2019-04-02 Thread Shahaf Shuler
Tuesday, April 2, 2019 12:16 AM, Yongseok Koh: > Subject: [PATCH v3 0/3] net/mlx4: add secondary process support > > RFC: > https://mails.dpdk.org/archives/dev/2019-March/125516.html > > v3: > * rebase on the latest branch tip > * remove HAVE_IBV_MLX4_SECONDARY_PROCESS and make it determined > in

Re: [dpdk-dev] [PATCH v3 0/6] net/mlx: enable secondary process to register DMA memory

2019-04-02 Thread Shahaf Shuler
Tuesday, April 2, 2019 12:18 AM, Yongseok Koh: > Subject: [PATCH v3 0/6] net/mlx: enable secondary process to register DMA > memory > > RFC: > https://mails.dpdk.org/archives/dev/2019-March/125517.html > > v3: > * rebase on the latest branch tip > > v2: > * add more sanity check for eth_dev and

Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

2019-04-02 Thread Thomas Monjalon
02/04/2019 03:01, Pallavi Kadam: > > On 4/1/2019 4:22 PM, Thomas Monjalon wrote: > > 29/03/2019 00:24, Anand Rawat: > >> +The DPDK and its applications require the Clang-LLVM* C compiler and > >> MSVC* linker. > >> +The Meson* Build system is used to prepare the sources for compilation > >> with

[dpdk-dev] mlx5 FDIR rule comparison issue

2019-04-02 Thread benli ye
Hi Developers, I am adding two FDIR rule (one is for UDP and the other is for TCP) for mlx5 pmd driver. The rules are listed below. struct rte_eth_fdir_filter filt[MAX_FDIR_PROTO] = { { .input.flow_type = RTE_ETH_FLOW_NONFRAG_IPV4_TCP, .input.flow.tcp4_flow.ip.

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: fix DMA zone reserve not honoring size

2019-04-02 Thread Andrew Rybchenko
On 4/2/19 3:47 AM, Jerin Jacob Kollanukkaran wrote: On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote: External Email On 3/31/19 7:25 PM, Pavan Nikhilesh Bhagavatula wrote: From: Pavan Nikhilesh The `rte_eth_dma_zone_reserve()` is generally used to create HW rings. In some scenarios w

[dpdk-dev] [Bug 238] [tree-wide] enhance getopt_long usage

2019-04-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=238 Bug ID: 238 Summary: [tree-wide] enhance getopt_long usage Product: DPDK Version: unspecified Hardware: All OS: All Status: CONFIRMED Severity: enhancement

[dpdk-dev] [PATCH 1/1] net/mlx5: fix typos in comments

2019-04-02 Thread Viacheslav Ovsiienko
Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 14 +++--- drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++--- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/

Re: [dpdk-dev] Bug in IPv4 header checksum computation?

2019-04-02 Thread Andrew Rybchenko
Hi, added more people in CC. On 4/1/19 6:29 PM, N. Benes wrote: Hi, I wrote to the users list a bit more a week ago concerning the IPv4 Header Checksum computation and received no comments on it yet: https://mails.dpdk.org/archives/users/2019-March/004021.html https://mails.dpdk.org/archives/

Re: [dpdk-dev] [PATCH v4 2/2] app/pdump: enhance to support multi-core capture

2019-04-02 Thread Varghese, Vipin
Hi David, Thanks for the inputs, these are useful. Let me work on these and share v5 ASAP. Thanks Vipin Varghese From: David Marchand Sent: Tuesday, April 2, 2019 12:35 PM To: Varghese, Vipin Cc: dev ; Kovacevic, Marko ; Pattan, Reshma ; Wiles, Keith ; Mcnamara, John ; Byrne, Stephen1 ; Tam

[dpdk-dev] [PATCH v4 1/4] power: fix invalid socket indicator value

2019-04-02 Thread Hajkowski
From: Marcin Hajkowski Currently 0 is being used for not connected slot indication. This is not consistent with linux doc which identifies 0 as valid (connected) slot, thus modification was done to change it. Fixes: cd0d5547 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v4 2/4] power: extend guest channel api for reading

2019-04-02 Thread Hajkowski
From: Marcin Hajkowski Added new experimental API rte_power_guest_channel_receive_msg which gives possibility to receive messages send to guest. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h| 5 +++ lib/librte_power/guest_channel.c | 60

[dpdk-dev] [PATCH v4 0/4] bidirect guest channel

2019-04-02 Thread Hajkowski
From: Marcin Hajkowski Extend guest channel API to allow bidirectional communication. Modify power manager host and guest side to communicate in both directions. --- v4: * [vm_power_manager] treat 0 as valid socket id * [guest_manager] use user level logs * correct code formatting v3: * fix gl

[dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds

2019-04-02 Thread Hajkowski
From: Marcin Hajkowski Extend vm_power_guest to check incoming confirmations of messages previously sent to host. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/guest_cli/Makefile | 1 + .../guest_cli/vm_power_cli_guest.c| 72 +++ 2 files changed, 6

[dpdk-dev] [PATCH v4 4/4] power: send confirmation cmd to vm guest

2019-04-02 Thread Hajkowski
From: Marcin Hajkowski Use new guest channel API to send confirmation message for received power command. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/channel_monitor.c | 68 +++-- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/examples/vm_power

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: fix DMA zone reserve not honoring size

2019-04-02 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-04-02 at 10:36 +0300, Andrew Rybchenko wrote: > On 4/2/19 3:47 AM, Jerin Jacob Kollanukkaran wrote: > > On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote: > > > External Email > > > On 3/31/19 7:25 PM, Pavan Nikhilesh Bhagavatula wrote: > > > > From: Pavan Nikhilesh > > > > >

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

2019-04-02 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-04-02 at 09:06 +0200, Thomas Monjalon wrote: > 02/04/2019 03:03, Jerin Jacob Kollanukkaran: > > On Mon, 2019-04-01 at 22:53 +0200, Thomas Monjalon wrote: > > > 01/04/2019 22:25, Ferruh Yigit: > > > > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > > > > From: Pavan Nikhile

[dpdk-dev] [PATCH v6 1/9] mbuf: new function to generate raw Tx offload value

2019-04-02 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To help avoid such situation for tx_offload fields: introduce new enum for tx_offload bit-fields lengths and offsets, and new function to generate raw tx_offload value. Add new test-case into UT for introduced fu

[dpdk-dev] [PATCH v6 2/9] ipsec: add Tx offload template into SA

2019-04-02 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To avoid such negative effect, use tx_offload raw value and mask to update l2_len and l3_len fields within mbufs. Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_ipsec/sa.c | 23 +++

[dpdk-dev] [PATCH v6 3/9] ipsec: change the order in filling crypto op

2019-04-02 Thread Konstantin Ananyev
Right now we first fill crypto_sym_op part of crypto_op, then in a separate cycle we fill crypto op fields. It makes more sense to fill whole crypto-op in one go instead. Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_ipsec/sa.c | 46 -

[dpdk-dev] [PATCH v6 6/9] ipsec: reorder packet check for esp inbound

2019-04-02 Thread Konstantin Ananyev
Right now check for packet length and padding is done inside cop_prepare(). It makes sense to have all necessary checks in one place at early stage: inside pkt_prepare(). That allows to simplify (and later hopefully) optimize cop_prepare() part. Signed-off-by: Konstantin Ananyev Acked-by: Akhil G

[dpdk-dev] [PATCH v6 0/9] Few small improvements for ipsec library

2019-04-02 Thread Konstantin Ananyev
v6 -> v5 Fix endianness issue spotted by Olivier Added UT test-case for rte_mbuf_tx_offload() v5 -> v4 Few cosmetic changes in mbuf tx_offload patch requested by Olivier v4 -> v3 Address Akhil comments: - function/paramers names - add ipsec lib into shared libraries list v3 -> v2 Addres

[dpdk-dev] [PATCH v6 4/9] ipsec: change the way unprocessed mbufs are accounted

2019-04-02 Thread Konstantin Ananyev
As was pointed in one of previous reviews - we can avoid updating contents of mbuf array for successfully processed packets. Instead store indexes of failed packets, to move them beyond the good ones later. Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_ipsec/sa.c | 164

[dpdk-dev] [PATCH v6 5/9] ipsec: move inbound and outbound code into different files

2019-04-02 Thread Konstantin Ananyev
sa.c becomes too big, so decided to split it into 3 chunks: - sa.c - control path related functions (init/fini, etc.) - esp_inb.c - ESP inbound packet processing - esp_outb.c - ESP outbound packet processing Plus few changes in internal function names to follow the same code convention. No func

[dpdk-dev] [PATCH v6 8/9] ipsec: de-duplicate crypto op prepare code-path

2019-04-02 Thread Konstantin Ananyev
For sym_crypto_op prepare move common code into a separate function(s). Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_ipsec/esp_inb.c | 72 + lib/librte_ipsec/esp_outb.c | 57 +++-- 2 files changed, 80 inserti

[dpdk-dev] [PATCH v6 7/9] ipsec: reorder packet process for esp inbound

2019-04-02 Thread Konstantin Ananyev
Change the order of operations for esp inbound post-process: - read mbuf metadata and esp tail first for all packets in the burst first to minimize stalls due to load latency. - move code that is common for both transport and tunnel modes into separate functions to reduce code duplication. - ad

[dpdk-dev] [PATCH v6 9/9] doc: add ipsec lib into shared libraries list

2019-04-02 Thread Konstantin Ananyev
Add librte_ipsec into 'Shared Library Versions' list in the release notes. Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_19_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/releas

[dpdk-dev] [DRAFT v2] DPDK techboard minutes of March 27

2019-04-02 Thread Maxime Coquelin
Meeting notes for the DPDK technical board meeting held on 2019-03-27. Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Th

[dpdk-dev] DPDK techboard minutes of March 27

2019-04-02 Thread Maxime Coquelin
Meeting notes for the DPDK technical board meeting held on 2019-03-27. Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Th

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: fix DMA zone reserve not honoring size

2019-04-02 Thread Andrew Rybchenko
On 4/2/19 11:25 AM, Jerin Jacob Kollanukkaran wrote: On Tue, 2019-04-02 at 10:36 +0300, Andrew Rybchenko wrote: On 4/2/19 3:47 AM, Jerin Jacob Kollanukkaran wrote: On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote: External Email On 3/31/19 7:25 PM, Pavan Nikhilesh Bhagavatula wrote:

Re: [dpdk-dev] Bug in IPv4 header checksum computation?

2019-04-02 Thread Olivier Matz
Hi, On Tue, Apr 02, 2019 at 10:58:52AM +0300, Andrew Rybchenko wrote: > Hi, > > added more people in CC. > > On 4/1/19 6:29 PM, N. Benes wrote: > > Hi, > > > > I wrote to the users list a bit more a week ago concerning the IPv4 > > Header Checksum computation and received no comments on it yet:

Re: [dpdk-dev] [PATCH v6 1/9] mbuf: new function to generate raw Tx offload value

2019-04-02 Thread Olivier Matz
On Tue, Apr 02, 2019 at 09:34:36AM +0100, Konstantin Ananyev wrote: > Operations to set/update bit-fields often cause compilers > to generate suboptimal code. > To help avoid such situation for tx_offload fields: > introduce new enum for tx_offload bit-fields lengths and offsets, > and new function

Re: [dpdk-dev] [PATCH v6 3/4] config: add thunderx2 machine config

2019-04-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, March 19, 2019 12:50 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > jer...@marvell.com; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH v6 3/4] config: add thunderx2

Re: [dpdk-dev] [PATCH v6 4/4] config: add octeontx2 machine config

2019-04-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, March 19, 2019 12:50 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > jer...@marvell.com; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH v6 4/4] config: add octeontx2

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

2019-04-02 Thread Ali Alnubani
Hi Pavan, > -Original Message- > From: dev On Behalf Of Pavan Nikhilesh > Bhagavatula > Sent: Sunday, March 31, 2019 4:14 PM > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; arybche...@solarflare.com; > ferruh.yi...@intel.com; bernard.iremon...@intel.com > Cc: dev@dpdk.org; Pavan Nik

Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode

2019-04-02 Thread Pavan Nikhilesh Bhagavatula
Hi Ali, > -Original Message- > From: Ali Alnubani > Sent: Tuesday, April 2, 2019 2:33 PM > To: Pavan Nikhilesh Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Thomas > Monjalon ; arybche...@solarflare.com; > ferruh.yi...@intel.com; bernard.iremon...@intel.com > Subject: [EXT]

[dpdk-dev] [PATCH v5 0/2] app/pdump: enhance to support unique cores

2019-04-02 Thread Vipin Varghese
The patch series enhances application to support pdump capture to run on unique cores. Motivation == DPDK pdump capture tool currently runs as secondary on the default core 0. For all --pdump, core 0 iterates and capture packets. This leads to drops and delay in the capture. This introduc

[dpdk-dev] [PATCH v5 1/2] app/pdump: remove core restriction

2019-04-02 Thread Vipin Varghese
PDUMP application is being limited to run on default first core. The patch removes the restriction, allowing user to run on any of selected cores in EAL args. If no args are passed, logic runs on default master core. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 14 ++ 1 file

[dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

2019-04-02 Thread Vipin Varghese
Add option --multi, to enhance pdump application to allow capture on unique cores for each --pdump option. If option --multi is ignored the default capture occurs on single core for all --pdump options. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 95 +++

[dpdk-dev] [PATCH 02/12] net/sfc: improve TSO header length check in EF10 datapath

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Move the check inside xmit function to the branch in which the check is mandatory. It makes case when TSO header is not fragmented a bit more faster. Fixes: 6bc985e41155 ("net/sfc: support TSO in EF10 Tx datapath") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-b

[dpdk-dev] [PATCH 01/12] net/sfc: improve TSO header length check in EFX datapath

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Move the check inside xmit function to the branch in which the check is mandatory. It makes case when TSO header is not fragmented a bit more faster. Fixes: fec33d5bb3eb ("net/sfc: support firmware-assisted TSO") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by:

[dpdk-dev] [PATCH 03/12] net/sfc: make TSO descriptor numbers EF10-specific

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Numbers of extra descriptors required for TSO are EF10-specific in fact. Highlight it in define names. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_tx.c | 12 ++-- drivers/net/sfc/sfc_tso.c | 2 +- drivers/net/sfc/sfc

[dpdk-dev] [PATCH 00/12] net/sfc: add Tx prepare and encapsulated TSO

2019-04-02 Thread Andrew Rybchenko
Move and add missing Tx offloads checks to Tx prepare stage. Keep absolutely required checks in Tx burst to avoid spoil of memory and segmentation faults. There are few checkpatches.sh warnings since positive errno is used inside driver. The patch series depends on [1] and should be applied only

[dpdk-dev] [PATCH 11/12] net/sfc: improve log message about missing HW TSO support

2019-04-02 Thread Andrew Rybchenko
From: Ivan Malov Said message cannot be considered as warning since the PMD anyway reports available offload capabilities by means of device info interface. Make this log message informational and improve its formatting by placing the text itself on the same line. Signed-off-by: Ivan Malov Sign

[dpdk-dev] [PATCH 04/12] net/sfc: support Tx preparation in EFX datapath

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Implement generic checks in Tx prepare function and update Tx burst function accordingly. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/sfc/sfc_dp_tx.h| 24 dri

[dpdk-dev] [PATCH 05/12] net/sfc: support Tx preparation in EF10 datapath

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Implement tx_prepare callback and update Tx burst function accordingly. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_tx.c | 56 --- 1 file changed, 46 insertions(+), 10 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH 06/12] net/sfc: support Tx preparation in EF10 simple datapath

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Implement tx_prepare callback. The implementation checks for anything only in RTE debug mode. No checks are done otherwise because EF10 simple datapath ignores Tx offloads. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_tx.c | 59 ++

[dpdk-dev] [PATCH 10/12] net/sfc: factor out function to get IPv4 packet ID for TSO

2019-04-02 Thread Andrew Rybchenko
From: Ivan Malov As a result, code duplication will be avoided in the current TSO implementations (EFX and EF10 native). The future patch to add support for tunnel TSO will also reuse the new function. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_tx.c

[dpdk-dev] [PATCH 12/12] net/sfc: support tunnel TSO on EF10 native Tx datapath

2019-04-02 Thread Andrew Rybchenko
From: Ivan Malov Handle VXLAN and GENEVE TSO on EF10 native Tx datapath. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst| 2 +- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/sfc/sfc.c | 6 ++ drivers/net

[dpdk-dev] [PATCH 09/12] net/sfc: add TSO header length check to Tx prepare

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Make Tx prepare function able to detect packets with invalid header size when header linearization is required. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 11 ++- drivers/net/sfc/sfc_ef10_tx.c | 2 ++ drivers/net

[dpdk-dev] [PATCH 07/12] net/sfc: move TSO header checks from Tx burst to Tx prepare

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Tx offloads checks should be done in Tx prepare. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 12 +--- drivers/net/sfc/sfc_ef10_tx.c | 9 - drivers/net/sfc/sfc_tso.c | 9 - drivers/net/sfc/sfc_

[dpdk-dev] [PATCH 08/12] net/sfc: introduce descriptor space check in Tx prepare

2019-04-02 Thread Andrew Rybchenko
From: Igor Romanov Add descriptor space check to Tx prepare function to inform a caller that a packet that needs more than maximum Tx descriptors of a queue can not be sent. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 31

Re: [dpdk-dev] DPDK Release Status Meeting 28/3/2019

2019-04-02 Thread Bruce Richardson
On Mon, Apr 01, 2019 at 09:10:02PM +0200, David Marchand wrote: > On Mon, Apr 1, 2019 at 5:47 PM Mcnamara, John > wrote: > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, March 28, 2019 12:48 PM > > > To: Yigit, Ferruh ; Mcnamara, John < > > john.mcnam...@intel

Re: [dpdk-dev] [RFC 0/3] ci: enable unit tests for non-aarch64 platforms

2019-04-02 Thread Bruce Richardson
On Mon, Apr 01, 2019 at 09:29:51PM +0200, David Marchand wrote: > On Mon, Apr 1, 2019 at 9:28 PM Aaron Conole wrote: > > > David Marchand writes: > > > I tried using meson/ninja for the tests, something that bothered me is > > that I can't interrupt the tests. > > > I had to kill manually, meson

Re: [dpdk-dev] [PATCH] eal: remove exec-env directory

2019-04-02 Thread Bruce Richardson
On Tue, Apr 02, 2019 at 01:07:12AM +0200, Thomas Monjalon wrote: > Only one header file (rte_kni_common.h) was in the sub-directory > include/exec-env/ > This file was installed in a sub-directory of the same name. > Source and install directories are moved as below: > >lib/librte_eal/li

[dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop

2019-04-02 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Testpmd txonly copies the src/dst mac address of the port being processed to ethernet header structure on the stack for every packet. Move it outside the loop and reuse it. Signed-off-by: Pavan Nikhilesh --- v6 Changes - Rebase onto ToT. - Split the changes further v5

[dpdk-dev] [PATCH v6 4/4] app/testpmd: add mempool bulk get for txonly mode

2019-04-02 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them. If bulk get fails fallback to rte_mbuf_raw_alloc. Tested-by: Yingya Han Suggested-by: Andrew Rybchenko Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 35 ++-

[dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-02 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Move the packet prepare logic into a separate function so that it can be reused later. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 163 +- 1 file changed, 83 insertions(+), 80 deletions(-) diff --git a/app/test-pmd/t

[dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for allocating segments

2019-04-02 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use bulk ops for allocating segments instead of having a inner loop for every segment. This reduces the number of calls to the mempool layer. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

Re: [dpdk-dev] [PATCH] eal: remove exec-env directory

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon wrote: > Only one header file (rte_kni_common.h) was in the sub-directory > include/exec-env/ > This file was installed in a sub-directory of the same name. > Source and install directories are moved as below: > >lib/librte_eal/linux/eal/

Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 11:18 AM Vipin Varghese wrote: > @@ -28,6 +28,9 @@ > #include > > #define CMD_LINE_OPT_PDUMP "pdump" > +#define CMD_LINE_OPT_PDUMP_NUM 1 > +#define CMD_LINE_OPT_MULTI "multi" > +#define CMD_LINE_OPT_MULTI_NUM 2 > #define PDUMP_PORT_ARG "port" > #define PDUMP_PCI_ARG "d

Re: [dpdk-dev] [PATCH] eal: remove exec-env directory

2019-04-02 Thread Thomas Monjalon
02/04/2019 11:57, David Marchand: > On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon wrote: > > > Only one header file (rte_kni_common.h) was in the sub-directory > > include/exec-env/ > > This file was installed in a sub-directory of the same name. > > Source and install directories are mo

Re: [dpdk-dev] [RFC 0/3] ci: enable unit tests for non-aarch64 platforms

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 11:37 AM Bruce Richardson wrote: > On Mon, Apr 01, 2019 at 09:29:51PM +0200, David Marchand wrote: > > On Mon, Apr 1, 2019 at 9:28 PM Aaron Conole wrote: > > > > > David Marchand writes: > > > > I tried using meson/ninja for the tests, something that bothered me > is > >

Re: [dpdk-dev] [PATCH v7 0/6] Add lock-free ring and mempool handler

2019-04-02 Thread Ola Liljedahl
On Mon, 2019-04-01 at 19:23 +, Eads, Gage wrote: > > > > > > On Mon, 18 Mar 2019 21:49:44 + > > "Eads, Gage" wrote: > > > > > > > > Hi all, > > > > > > Friendly reminder that in order to get this feature into 19.08 (assuming > > folks also want that :)), the API deprecation notice nee

Re: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-02 Thread Ananyev, Konstantin
> Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > structures. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by:

Re: [dpdk-dev] Query : Does Binding with vfio-pci is supported inside qemu-kvm guest/vm instance.?

2019-04-02 Thread John Sucaet
Hi Anatoly, As you said: There's no reason to use igb_uio, ever! I would like to ask whether vfio-pci with or without vIOMMU should/could work for virtio-pci net devices in the case of a 32-bit dpdk application, on a 64-bit kernel (4.9) inside a guest VM (qemu-2.10.2-1.fc27)? I tried both a

[dpdk-dev] [PATCH v8 0/1] AF_XDP PMD

2019-04-02 Thread Xiaolong Ye
Hi, all Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP su

[dpdk-dev] [PATCH v8 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-02 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

Re: [dpdk-dev] [PATCH v3 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-02 Thread Ananyev, Konstantin
> > > Add RCU library supporting quiescent state based memory reclamation method. > > This library helps identify the quiescent state of the reader threads so > > that the writers can free the memory associated with the lock less data > > structures. > > > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH v3 2/3] test/rcu_qsbr: add API and functional tests

2019-04-02 Thread Ananyev, Konstantin
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Monday, April 1, 2019 6:11 PM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; gavin...@a

Re: [dpdk-dev] [PATCH v6 6/8] stack: add C11 atomic implementation

2019-04-02 Thread Honnappa Nagarahalli
> Subject: [PATCH v6 6/8] stack: add C11 atomic implementation > > This commit adds an implementation of the lock-free stack push, pop, and > length functions that use __atomic builtins, for systems that benefit from the > finer-grained memory ordering control. > > Signed-off-by: Gage Eads > Rev

Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library

2019-04-02 Thread Honnappa Nagarahalli
> Subject: [PATCH v6 1/8] stack: introduce rte stack library > > The rte_stack library provides an API for configuration and use of a bounded > stack of pointers. Push and pop operations are MT-safe, allowing concurrent > access, and the interface supports pushing and popping multiple pointers at

[dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case

2019-04-02 Thread Tomasz Cel
From: Tomasz Jozwiak This patch adds new test case in which max. size of chain mbufs has been used to compress random data dynamically. Signed-off-by: Tomasz Jozwiak --- app/test/test_compressdev.c | 158 ++-- 1 file changed, 136 insertions(+), 22 deleti

[dpdk-dev] [PATCH v2 0/1] add max mbuf size test case

2019-04-02 Thread Tomasz Cel
From: Tomasz Jozwiak This patch adds new test case in which max. size of chain mbufs has been used to compress random data dynamically. V2 changes: Added changes to new test_compressdev.c file location in app/test/ folder Tomasz Jozwiak (1): test/compress: add max mbuf size test case a

Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case

2019-04-02 Thread Cel, TomaszX
Hi Tomasz, > -Original Message- > From: Cel, TomaszX > Sent: Tuesday, April 2, 2019 1:17 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; Cel, TomaszX > Subject: [PATCH v2 1/1] test/compress: add max mbuf size test case > > From: Tomasz Jozwiak > > This patch adds new test ca

Re: [dpdk-dev] [PATCH v3] eal: increase max number of interrupt vectors

2019-04-02 Thread Thomas Monjalon
31/03/2019 16:55, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > MSI-X permits a device to allocate up to 2048 interrupts as per PCIe > spec. > Increase the max number of vectors to a reasonable value of 512. > > Signed-off-by: Pavan Nikhilesh Applied, thanks

Re: [dpdk-dev] [EXT] Re: [PATCH] eal: change init macro as exec environment specific

2019-04-02 Thread Thomas Monjalon
02/04/2019 03:15, Jerin Jacob Kollanukkaran: > On Thu, 2019-03-14 at 20:44 +, Jerin Jacob Kollanukkaran wrote: > > On Wed, 2019-03-13 at 14:14 +0530, Jerin Jacob wrote: > > > On Wed, 2019-03-13 at 09:16 +0100, Thomas Monjalon wrote: > > > > Then maybe you should send your patches so we can deci

Re: [dpdk-dev] [RFC 0/3] ci: enable unit tests for non-aarch64 platforms

2019-04-02 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 2, 2019 at 11:37 AM Bruce Richardson > wrote: > > On Mon, Apr 01, 2019 at 09:29:51PM +0200, David Marchand wrote: > > On Mon, Apr 1, 2019 at 9:28 PM Aaron Conole wrote: > > > > > David Marchand writes: > > > > I tried using meson/ninja for the tests,

Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific

2019-04-02 Thread Thomas Monjalon
11/10/2017 16:33, Jerin Jacob: > From: Thomas Monjalon > > 07/08/2017 14:04, Jerin Jacob: > > > baremetal execution environments may have a different > > > method to enable RTE_INIT instead of using compiler > > > constructor scheme. Move RTE_INIT* definition under > > > exec-env to support differ

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: initialize alarms early

2019-04-02 Thread Thomas Monjalon
01/04/2019 16:18, Darek Stojaczyk: > On linux, we currently initialize rte_alarms after > starting to listen for IPC hotplug requests, which gives > us a data race window. Upon receiving such hotplug > request we always try to set an alarm and this obviously > doesn't work if the alarms weren't ini

Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific

2019-04-02 Thread Wiles, Keith
> On Apr 2, 2019, at 7:57 AM, Thomas Monjalon wrote: > > 11/10/2017 16:33, Jerin Jacob: >> From: Thomas Monjalon >>> 07/08/2017 14:04, Jerin Jacob: baremetal execution environments may have a different method to enable RTE_INIT instead of using compiler constructor scheme. Move

Re: [dpdk-dev] Query : Does Binding with vfio-pci is supported inside qemu-kvm guest/vm instance.?

2019-04-02 Thread Burakov, Anatoly
On 02-Apr-19 11:38 AM, John Sucaet wrote: Hi Anatoly, As you said: There's no reason to use igb_uio, ever! That was partly tongue in cheek, but point taken :) I would like to ask whether vfio-pci with or without vIOMMU should/could work for virtio-pci net devices in the case of a 32-bit dpdk

[dpdk-dev] [PATCH v3 00/14] Add patch set for IPN3KE

2019-04-02 Thread Xu, Rosen
From: "Xu, Rosen" v3 updates: == - Fix v2 comments - Update MAC BAR of AFU index get ops - Remove OPAE share code dependency of libfdt v2 updates: == - Fix v1 comments - Add support for 10G Base Line Design Bitstream - Add support for 25G Base Line Design Bitstream This pa

[dpdk-dev] [PATCH v3 02/14] drivers/bus/ifpga: add function for AFU search by name

2019-04-02 Thread Xu, Rosen
From: Rosen Xu In many scenarios, AFU is needed searched by name, this function add the feature. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/ifpga_bus.c | 13 + drivers/bus/ifpga/rte_bus_ifpga.h | 9 + drivers/bus/ifpga/rt

[dpdk-dev] [PATCH v3 01/14] drivers/bus/ifpga: add AFU shared data

2019-04-02 Thread Xu, Rosen
From: Rosen Xu AFU can be implemented into many different acceleration devices, these devices need shared data to store private information when they are handled by users. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/rte_bus_ifpga.h | 7 +++ 1 file changed, 7 inse

[dpdk-dev] [PATCH v3 04/14] drivers/net/ipn3ke: add IPN3KE representor of PMD driver

2019-04-02 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA Acceleration NIC IPN3KE representor of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile | 1 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 14 + drivers/net/ipn3ke/ipn3ke_representor.

[dpdk-dev] [PATCH v3 03/14] drivers/net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-02 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- MAINTAINERS | 7 + config/common_base| 4 + doc/guides/nics/features/ipn3ke.in

[dpdk-dev] [PATCH v3 05/14] drivers/net/ipn3ke: add IPN3KE TM of PMD driver

2019-04-02 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA Acceleration NIC IPN3KE TM of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |3 + drivers/net/ipn3ke/ipn3ke_ethdev.h |

[dpdk-dev] [PATCH v3 08/14] raw/ifpga/base: store private features in FME and Port list

2019-04-02 Thread Xu, Rosen
From: "Zhang, Tianfei" Get private features attrubite like size, id, address after enumeration, and insert into FEM or Port dedicate list. when initial the private feature driver, we just compare the private feature id between the list and feature drivers array to match the proper drivers. This

[dpdk-dev] [PATCH v3 07/14] raw/ifpga/base: clean up code for ifpga share code

2019-04-02 Thread Xu, Rosen
From: "Zhang, Tianfei" clean up code: 1. use opae_memcpy instead of memcpy 2. use opae_memset instead of memset 3. disable opae_adapter_dump by default Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 2 +- drivers/raw/ifpga_rawdev/base/ifpga_feature

[dpdk-dev] [PATCH v3 06/14] drivers/net/ipn3ke: add IPN3KE Flow of PMD driver

2019-04-02 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA Acceleration NIC IPN3KE Flow of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |5 + drivers/net/ipn3ke/ipn3ke_ethdev.h |

[dpdk-dev] [PATCH v3 09/14] raw/ifpga/base: add SPI and MAX10 device driver

2019-04-02 Thread Xu, Rosen
From: "Zhang, Tianfei" There is a SPI bus link between A10 FPGA and MAX10 FPGA. MAX10 is in charge of board management, like power management, sensors, flash devices. Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/Makefile | 3 + drivers/raw/ifpga_rawdev/base/ifp

[dpdk-dev] [PATCH v3 11/14] raw/ifpga/base: add eth group driver

2019-04-02 Thread Xu, Rosen
From: "Zhang, Tianfei" There is two eth group devices in PAC N3000 card, each eth group include PHY device and MAC device. Exposing APIs for DPDK PMD driver to access those devices. Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/Makefile| 1 + drivers/raw/ifpga_r

[dpdk-dev] [PATCH v3 10/14] raw/ifpga/base: add I2C and at24 EEPROM driver

2019-04-02 Thread Xu, Rosen
From: "Zhang, Tianfei" 1. Add Altera I2C master device driver 2. Add at24 eeprom driver which is i2c slave device 3. Introducing a new ops for opae_manager: opae_manager_networking_ops. This ops will include some networking operation by FPGA, like vBNG operation, MAC ROM operation and so on. Sig

  1   2   3   >