02/04/2019 03:01, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 01/04/2019 17:12, Ferruh Yigit: > > > On 4/1/2019 2:27 PM, Thomas Monjalon wrote: > > > > 01/04/2019 14:51, Ferruh Yigit: > > > >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: > > > >>> 26/03/2019 10:50, Ferruh Yigit: > > > >>>>> Wenzhuo Lu (8): > > > >>>>> net/ice: fix Tx function setting > > > >>>>> net/ice: add pointer for queue buffer release > > > >>>>> net/ice: support vector SSE in RX > > > >>>>> net/ice: support Rx scatter SSE vector > > > >>>>> net/ice: support Tx SSE vector > > > >>>>> net/ice: support Rx AVX2 vector > > > >>>>> net/ice: support Rx scatter AVX2 vector > > > >>>>> net/ice: support vector AVX2 in TX > > > >>>> > > > >>>> This version (v7) pulled from next-net-intel to next-net. > > > >>> > > > >>> I assume these patches have been tested, or at least compiled. > > > >>> However, when running devtools/test-meson-builds.sh, there is a > > > >>> compilation error for build-x86-default: > > > >>> > > > >>> In file included from ../drivers/net/ice/ice_ethdev.h:10: > > > >>> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found > > > >> > > > >> I tested this with meson but not able to catch the issue. Perhaps > > > >> for my case dependencies were build fast enough to cause a problem. > > > > > > > > No, it's not a matter of speed. > > > > > > No it is not, > > > > > > > Are you running devtools/test-meson-builds.sh ? > > > > > > No, I am using with another script but not building 'default' > > > architecture with meson where problem happens, that is why not able to > > > catch this. Will try to catch next time.. > > > > Ferruh, why not using the scripts we are building in devtools? > I have a suggestion. Why not integrating all the compile check here, like > http://mails.dpdk.org/archives/test-report/2019-March/077966.html. If it > fails, the patch state should be changed to "compile error". It will not be > accepted. It can help everyone, especially the committer. > We cannot assume everyone knows everything. To me, have to say not familiar > with meson build.
Yes it would help to have meson tested in CI.
