On Tue, Apr 2, 2019 at 11:18 AM Vipin Varghese <vipin.vargh...@intel.com> wrote:
> @@ -28,6 +28,9 @@ > #include <rte_pdump.h> > > #define CMD_LINE_OPT_PDUMP "pdump" > +#define CMD_LINE_OPT_PDUMP_NUM 1 > +#define CMD_LINE_OPT_MULTI "multi" > +#define CMD_LINE_OPT_MULTI_NUM 2 > #define PDUMP_PORT_ARG "port" > #define PDUMP_PCI_ARG "device_id" > #define PDUMP_QUEUE_ARG "queue" > You'd better map to integers that do not collide with ascii characters (even if non printable). So values >= 256 are better. This is the reason for the comment here: https://git.dpdk.org/dpdk/tree/lib/librte_eal/common/eal_options.h#n19 @@ -139,12 +142,14 @@ struct parse_val { > static int num_tuples; > static struct rte_eth_conf port_conf_default; > static volatile uint8_t quit_signal; > +static uint8_t multiple_core_capture; > > /**< display usage */ > static void > pdump_usage(const char *prgname) > { > - printf("usage: %s [EAL options] -- --pdump " > + printf("usage: %s [EAL options] -- [--%s] " > + "--%s " > "'(port=<port id> | device_id=<pci id or vdev > name>)," > "(queue=<queue_id>)," > "(rx-dev=<iface or pcap file> |" > @@ -152,7 +157,7 @@ pdump_usage(const char *prgname) > "[ring-size=<ring size>default:16384]," > "[mbuf-size=<mbuf data size>default:2176]," > "[total-num-mbufs=<number of > mbufs>default:65535]'\n", > - prgname); > + prgname, CMD_LINE_OPT_MULTI, CMD_LINE_OPT_PDUMP); > } > > static int > You can concatenate the macro. - printf("usage: %s [EAL options] -- --pdump " + printf("usage: %s [EAL options] -- [--"CMD_LINE_OPT_MULTI"] " + "--"CMD_LINE_OPT_PDUMP" " -- David Marchand
