Re: [dpdk-dev] [PATCH v8 0/3] generic spinlock optimization and test case enhancements

2019-03-28 Thread Thomas Monjalon
> Gavin Hu (3): > test/spinlock: remove 1us delay for correct benchmarking > test/spinlock: amortize the cost of getting time > spinlock: reimplement with atomic one-way barrier builtins Applied, thanks

Re: [dpdk-dev] [PATCH v3 1/8] mbuf: new function to generate raw Tx offload value

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > Operations to set/update bit-fields often cause compilers > to generate suboptimal code. > To help avoid such situation for tx_offload fields: > introduce new enum for tx_offload bit-fields lengths and offsets, > and new function to generate raw t

Re: [dpdk-dev] [PATCH] mem: don't use address hint for mapping unless requested

2019-03-28 Thread Shahaf Shuler
Wednesday, March 27, 2019 1:50 PM, Burakov, Anatoly: > Subject: Re: [PATCH] mem: don't use address hint for mapping unless > requested > > On 21-Mar-19 8:21 PM, Shahaf Shuler wrote: > > patch[1] added an address hint as starting address for 64 bit systems > > in case an explicit base virtual addre

Re: [dpdk-dev] [PATCH v3 2/8] ipsec: add Tx offload template into SA

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > Operations to set/update bit-fields often cause compilers > to generate suboptimal code. To avoid such negative effect, > use tx_offload raw value and mask to update l2_len and l3_len > fields within mbufs. > > Signed-off-by: Konstantin Ananyev >

Re: [dpdk-dev] [PATCH v3 3/8] ipsec: change the order in filling crypto op

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > Right now we first fill crypto_sym_op part of crypto_op, > then in a separate cycle we fill crypto op fields. > It makes more sense to fill whole crypto-op in one go instead. > > Signed-off-by: Konstantin Ananyev > --- > Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v3 1/1] compress/isal: fix compression stream initialization

2019-03-28 Thread Tomasz Cel
This patch fixes ISAL internal state fields initialization. Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Cc: sta...@dpdk.org Signed-off-by: Tomasz Cel --- drivers/compress/isal/isal_compress_pmd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH v3 0/1] This patch fix compression stream initialization

2019-03-28 Thread Tomasz Cel
v3: - fixed cover letter v2: - removed isal_inflate_reset() function because is not neccesary, everything is cleared by the isal_inflate_init function at the begining Tomasz Cel (1): compress/isal: fix compression stream initialization drivers/compress/isal/isal_compress_pmd.c | 6 +- 1

Re: [dpdk-dev] [PATCH v4 00/14] net/mlx5: add support for multiport IB devices

2019-03-28 Thread Shahaf Shuler
Wednesday, March 27, 2019 3:16 PM, Viacheslav Ovsiienko: > Subject: [PATCH v4 00/14] net/mlx5: add support for multiport IB devices > > The Mellanox NICs support SR-IOV and have E-Switch feature. > When SR-IOV is set up in switchdev mode and E-Switch is enabled we have > so called VF representors

[dpdk-dev] [Bug 235] References section for Algorithms for Routing Lookups and Packet Classification is not working

2019-03-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=235 Bug ID: 235 Summary: References section for Algorithms for Routing Lookups and Packet Classification is not working Product: DPDK Version: 19.02 Hardware: All OS: Al

Re: [dpdk-dev] [PATCH v1] examples/distributor: detect high frequency cores

2019-03-28 Thread Hunt, David
Hi Anatoly, On 27/3/2019 1:58 PM, Burakov, Anatoly wrote: On 22-Feb-19 11:45 AM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses t

Re: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Iremonger, Bernard
Hi Yongseok, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Thursday, March 28, 2019 1:51 AM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; jer...@marvell.com; Ananyev, Konstantin > > Subject: [dpdk-dev] [PATCH v3] app/testpmd: ma

Re: [dpdk-dev] [PATCH] mem: don't use address hint for mapping unless requested

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 8:45 AM, Shahaf Shuler wrote: Wednesday, March 27, 2019 1:50 PM, Burakov, Anatoly: Subject: Re: [PATCH] mem: don't use address hint for mapping unless requested On 21-Mar-19 8:21 PM, Shahaf Shuler wrote: patch[1] added an address hint as starting address for 64 bit systems in case

[dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag

2019-03-28 Thread Ayuj Verma
Some PMDs can support RSA private key operations using CRT (quintuple) or exponent key only. Thus add a feature flag RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key type is supported to perform rsa private key op. App should query PMD featur

[dpdk-dev] [PATCH v3 2/4] crypto/openssl: set rsa private op feature flag

2019-03-28 Thread Ayuj Verma
openssl PMD support RSA private key operation using both qt and exp key type. Set rsa key type feature flag Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/op

[dpdk-dev] [PATCH v3 3/4] app/test: check for key type ff in asym unit test

2019-03-28 Thread Ayuj Verma
Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index a779e8f..539eda1 100644 --- a/app/test/test_cryptodev_asy

[dpdk-dev] [PATCH v3 1/4] lib/cryptodev: add rsa priv key feature flag

2019-03-28 Thread Ayuj Verma
Add feature flag to reflect RSA private key operation support using quintuple (crt) or exponent type key. if PMD support both, then it should set both. App should query cryptodev feature flag to check if Sign and Decryt with CRT keys or exponent is supported, thus call operation with relevant key

[dpdk-dev] [PATCH v3 4/4] doc: add rsa key type to feature list

2019-03-28 Thread Ayuj Verma
Add ff description in overview.rst and update feature support in Openssl PMD feature list Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- doc/guides/cryptodevs/features/openssl.ini | 2 ++ doc/guides/cryptodevs/overview.rst | 6 ++ 2 files changed, 8 insertions(+) diff --

Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check

2019-03-28 Thread Ali Alnubani
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 27, 2019 11:31 AM > To: Shahaf Shuler ; Dekel Peled > ; Ali Alnubani ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check > > On 3/25/2019 12:02 PM, Ferruh Yigit wrote: >

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-28 Thread Bruce Richardson
On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote: > 27/03/2019 21:33, Stojaczyk, Dariusz: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 26/03/2019 19:43, Darek Stojaczyk: > > > > We currently initialize rte_alarms after starting > > > > to listen for IPC hotplug reques

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-28 Thread Thomas Monjalon
28/03/2019 11:43, Bruce Richardson: > On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote: > > 27/03/2019 21:33, Stojaczyk, Dariusz: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 26/03/2019 19:43, Darek Stojaczyk: > > > > > We currently initialize rte_alarms after sta

Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type

2019-03-28 Thread Iremonger, Bernard
Hi Qiming, > > Subject: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to > > tunnel type > > > > This patch added new item "vxlan-gpe" to tunnel_type to support new > > VXLAN-GPE packet type, and its clasification. > > > > Signed-off-by: Qiming Yang > > --- > > app/test-pmd/cmdline.c | 1

Re: [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case

2019-03-28 Thread Thomas Monjalon
> Gavin Hu (1): > rwlock: reimplement with atomic builtins > > Joyce Kong (2): > test/rwlock: add perf test case on all available cores > test/rwlock: amortize the cost of getting time Applied, thanks

Re: [dpdk-dev] [PATCH v3 4/8] ipsec: change the way unprocessed mbufs are accounted

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > As was pointed in one of previous reviews - we can avoid updating > contents of mbuf array for successfully processed packets. > Instead store indexes of failed packets, to move them beyond the good > ones later. > > Signed-off-by: Konstantin Anan

Re: [dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint

2019-03-28 Thread Maxime Coquelin
On 3/27/19 10:08 PM, Stephen Hemminger wrote: Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed,

Re: [dpdk-dev] [PATCH 1/3] rcu: add RCU library supporting QSBR mechanism

2019-03-28 Thread Ananyev, Konstantin
> > > > > +#define RTE_QSBR_CNT_THR_OFFLINE 0 > > > +#define RTE_QSBR_CNT_INIT 1 > > > + > > > +/** > > > + * RTE thread Quiescent State structure. > > > + * Quiescent state counter array (array of 'struct > > > +rte_rcu_qsbr_cnt'), > > > + * whose size is dependent on the maximum number of reader

Re: [dpdk-dev] [PATCH v3 5/8] ipsec: move inbound and outbound code into different files

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > sa.c becomes too big, so decided to split it into 3 chunks: > - sa.c - control path related functions (init/fini, etc.) > - esp_inb.c - ESP inbound packet processing > - esp_outb.c - ESP outbound packet processing > > Plus few changes in int

Re: [dpdk-dev] [PATCH v3 0/8] Few small improvements for ipsec library

2019-03-28 Thread Akhil Goyal
Hi Konstantin, I do not see ipsec lib in Shared Library Versions in release notes. Could you also send that change. Thanks, Akhil On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > v3 -> v2 > Address comments: >- make rte_mbuf_tx_offload() always inline >- rename OL[2,3]_LEN to OUTL[2,3

Re: [dpdk-dev] [PATCH v3 6/8] ipsec: reorder packet check for esp inbound

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > Right now check for packet length and padding is done inside cop_prepare(). > It makes sense to have all necessary checks in one place at early stage: > inside pkt_prepare(). > That allows to simplify (and later hopefully) optimize cop_prepare() p

[dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid

2019-03-28 Thread Hajkowski
From: Marcin Hajkowski In current implementation lcoreid 1 is used regardless of currently available cores. This change introduce dynamic core selection for sending policy. Fixes: d191f08533 ("examples/guest_cli: add send policy to host") Cc: sta...@dpdk.org Signed-off-by: Marcin Hajkowski ---

Re: [dpdk-dev] [PATCH v3 8/8] ipsec: de-duplicate crypto op prepare code-path

2019-03-28 Thread Akhil Goyal
On 3/26/2019 9:13 PM, Konstantin Ananyev wrote: > For sym_crypto_op prepare move common code into a separate function(s). > > Signed-off-by: Konstantin Ananyev > --- > lib/librte_ipsec/esp_inb.c | 72 + > lib/librte_ipsec/esp_outb.c | 57 ++

Re: [dpdk-dev] [PATCH v3 0/8] Few small improvements for ipsec library

2019-03-28 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Konstantin, > > I do not see ipsec lib in Shared Library Versions in release notes. > Could you also send that change. Oops, completely forgot about that one. Will do in v4. Konstantin

[dpdk-dev] DPDK Release Status Meeting 28/3/2019

2019-03-28 Thread Ferruh Yigit
Minutes 28 March 2019 - Agenda: * Release Dates * Subtrees * Coverity * Opens Participants: * Arm * Intel * Marvell * Mellanox * NXP * RedHat Release Dates - * v19.05 dates, rc1 date pushed to Wednesday: * RC1: *Wednesday, 3 April* * Release: Friday, 10 May

Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Nowak, DamianX > Sent: Wednesday, March 27, 2019 9:45 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; Nowak, > DamianX > Subject: [PATCH v5 1/1] test: new test structure for asymmetric crypto > > This patch adds new test structure for mo

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-28 Thread Carrillo, Erik G
> On Mar 27, 2019, at 9:03 AM, Thomas Monjalon wrote: > > 21/03/2019 02:01, Carrillo, Erik G: >> Hi Robert, >> >> Thanks for the review and suggestions. I’m out of the office on bonding >> leave for the next few weeks, but I’ll update the patch to address your >> points below when I return.

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-03-28 Thread Konstantin Ananyev
acl_classify() returns zero value when no matching rule was found. Currently ipsec-secgw treats it as a valid SPI value, though it has to discard such packets. Error could be easily observed by sending outbound unmatched packets, user will see something like that in the log: IPSEC: No cryptodev: co

Re: [dpdk-dev] DPDK Release Status Meeting 28/3/2019

2019-03-28 Thread David Marchand
On Thu, Mar 28, 2019 at 1:04 PM Ferruh Yigit wrote: > Coverity > > > * Coverity is back on, John run a new scan with latest code: > https://scan.coverity.com/projects/dpdk-data-plane-development-kit The "components" mappings seem quite old/invalid to me: - we still have the old pmds

Re: [dpdk-dev] [PATCH v3 1/1] compress/isal: fix compression stream initialization

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Cel, TomaszX > Sent: Thursday, March 28, 2019 9:06 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ; Daly, Lee > ; Tucker, > Greg B ; Jozwiak, TomaszX > ; Cel, TomaszX > > Subject: [PATCH v3 1/1] compress/isal: fix compression stream initializati

Re: [dpdk-dev] [PATCH v3] test: add snow3g test cases when digest is encrypted

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Krakowiak, LukaszX > Sent: Monday, March 25, 2019 10:48 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Trahe, Fiona ; Krakowiak, LukaszX > > Subject: [PATCH v3] test: add snow3g test cases when digest is encrypted > > Add test case for encryption, dect

Re: [dpdk-dev] [PATCH v3] test: add snow3g test cases when digest is encrypted

2019-03-28 Thread Trahe, Fiona
Sorry, ignore last email - it was meant to be an ack - here's the correct one. > -Original Message- > From: Krakowiak, LukaszX > Sent: Monday, March 25, 2019 10:48 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Trahe, Fiona ; Krakowiak, LukaszX > > Subject: [PATCH v3] test: add snow3

[dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread David Hunt
The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power_get_capabilities() API to query the cores provided in the core mask, and if any high frequ

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 10:46 AM, Thomas Monjalon wrote: 28/03/2019 11:43, Bruce Richardson: On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote: 27/03/2019 21:33, Stojaczyk, Dariusz: From: Thomas Monjalon [mailto:tho...@monjalon.net] 26/03/2019 19:43, Darek Stojaczyk: We currently initiali

Re: [dpdk-dev] [PATCH v2] app/eventdev: add option to set global dequeue tmo

2019-03-28 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Thursday, March 28, 2019 10:56 AM > To: Pavan Nikhilesh Bhagavatula > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/eventdev: add option to set global > dequeue tmo > > On Wed, 2019-03-27 at 17:07 +, Pavan Ni

Re: [dpdk-dev] [PATCH v3 1/1] compress/isal: fix compression stream initialization

2019-03-28 Thread Daly, Lee
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, March 28, 2019 12:59 PM > To: Cel, TomaszX ; dev@dpdk.org > Cc: sta...@dpdk.org; Daly, Lee ; Tucker, Greg B > ; Jozwiak, TomaszX > Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream > initialization > > > > >

[dpdk-dev] [PATCH v5 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-03-28 Thread Arek Kusztal
This patchset adds Poll Mode Driver to use asymmetric cryptography functions using Intel QuickAssist Techology devices. Following functions are available with this patchset: * Modular Exponentiation * Modular Inverse This patch depends on a QAT PF driver for device initialization. See

[dpdk-dev] [PATCH v5 1/4] common/qat: add headers for asymmetric crypto

2019-03-28 Thread Arek Kusztal
This commit adds headers to be used in conjunction with asymmetric cryptography operations using Intel QuickAssist Technology driver Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h| 1538 drivers/common/qat/qat_adf/icp_qat_fw_pke.h

[dpdk-dev] [PATCH v5 2/4] crypto/qat: add asymmetric cryptography PMD

2019-03-28 Thread Arek Kusztal
This patch adds Poll Mode Driver for asymmetric crypto functions of Intel QuickAssist Technology hardware. It contains plain driver with no functions implmented, specific algorithms will be introduced in separate patches. This patch depends on a QAT PF driver for device initialization. See the fi

[dpdk-dev] [PATCH v5 3/4] crypto/qat: add modular exponentiation to qat asym pmd

2019-03-28 Thread Arek Kusztal
This commit adds modular exponentiation to Intel QuickAssist Technology driver. For capabilities or limitations please refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 2 + .../qat/qat_adf/qat_pke_functionality_ar

[dpdk-dev] [PATCH v5 4/4] crypto/qat: add modular inverse to qat asym pmd

2019-03-28 Thread Arek Kusztal
This commit adds modular multiplicative inverse to Intel QuickAssist Technology driver. For capabilities or limitations please refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + .../qat/qat_adf/qat_pke_functiona

Re: [dpdk-dev] [PATCH v5 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, March 28, 2019 1:37 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH v5 0/4] Add PMD for asymmetric cryptography operations using > Intel QuickAssist > Technolog

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power_get_capabilities() API to query the cores provid

Re: [dpdk-dev] [PATCH v8 0/3] ticketlock: implement ticketlock and add test case

2019-03-28 Thread Thomas Monjalon
> > Joyce Kong (3): > > eal/ticketlock: ticket based to improve fairness > > eal/ticketlock: enable generic ticketlock on all arch > > test/ticketlock: add ticket lock test case > > > > MAINTAINERS| 5 + > > app/test/Makefile

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 3:31 PM, Chas Williams wrote: > > > On 3/27/19 11:18 AM, Stephen Hemminger wrote: >> On Tue, 26 Mar 2019 18:38:57 -0400 >> Chas Williams <3ch...@gmail.com> wrote: >> >>> On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 1:32 AM, Andy Pei wrote: > print function name in ifpga log and a new line goes after every IFPGA log. > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen...@intel.com > Cc: andy@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Andy Pei (Carryi

Re: [dpdk-dev] [PATCH v5 1/1] compress/qat: add dynamic sgl allocation

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Tuesday, March 26, 2019 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH v5 1/1] compress/qat: add dynamic sgl allocation > > This patch adds dynamic SGL allocation instead of static one. > The number

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Hunt, David
On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power

[dpdk-dev] [PATCH v2] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Vipin Varghese
Enhance pdump application, to allow user to run on multiple cores. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 75 -- doc/guides/tools/pdump.rst | 5 +++ 2 files changed, 69 insertions(+), 11 deletions(-) diff --git a/app/pdump/main.c b/ap

Re: [dpdk-dev] [PATCH] drivers/qat: fix qp numa node

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Tuesday, March 26, 2019 2:21 PM > To: dev@dpdk.org; sta...@dpdk.org; Trahe, Fiona ; > Jozwiak, TomaszX > > Subject: [PATCH] drivers/qat: fix qp numa node > > This patch assigns QAT queue pair resources to the correct NUMA nodes. >

[dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Vipin Varghese
Enhance pdump application, to allow user to run on multiple cores. Signed-off-by: Vipin Varghese --- Change Log: V3: - correct the parse_usage - Vipin Varghese - add change log - Vipin Varghese V2: - Replace option '-c' to '-l' - Keith Wiles --- app/pdump/main.c | 75

Re: [dpdk-dev] [PATCH] app/compress-perf: add incompressible data handling

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, March 1, 2019 8:45 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH] app/compress-perf: add incompressible data handling > > Currently, compress-perf doesn't respect incompressible > data inside one

Re: [dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows

2019-03-28 Thread Thomas Monjalon
28/03/2019 03:21, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. It is OK to merge few limited workarounds in the master branch, in order to sta

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 2:42 PM, Hunt, David wrote: On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Hunt, David
On 28/3/2019 3:10 PM, Burakov, Anatoly wrote: On 28-Mar-19 2:42 PM, Hunt, David wrote: On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, th

[dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping

2019-03-28 Thread Bruce Richardson
If we have two NIC ports which have a different set of NIC stats we can end up having two different stats registered with xstats with the same name. [Since the stats are updated in bulk as a contiguous set, the second driver re-using the registration of the first is not possible.] This causes issu

Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Wiles, Keith
> On Mar 28, 2019, at 10:04 AM, Varghese, Vipin > wrote: > > Enhance pdump application, to allow user to run on multiple cores. > > Signed-off-by: Vipin Varghese > --- > > Change Log: > > V3: > - correct the parse_usage - Vipin Varghese > - add change log - Vipin Varghese > > V2: > - Rep

[dpdk-dev] [PATCH] power: update for error handling

2019-03-28 Thread Lukasz Krakowiak
Update for handling negative returned status from functions call. Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_manager.c | 4 ++-- examples/vm_power_manager/channel_monitor.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/vm_power_man

Re: [dpdk-dev] [PATCH v5] net/nfb: new netcope driver

2019-03-28 Thread Ferruh Yigit
On 3/22/2019 12:12 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay > --- > v2: remove unnecessary cast > remove unnecessary zeroing > move declaration to not mix with code > restore skeleton exam

[dpdk-dev] [PATCH] power: extend debugs on power instruction requests

2019-03-28 Thread Lukasz Krakowiak
Extend debugs on power instruction and cmd police destroy requests. Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_powe

[dpdk-dev] [PATCH v2 0/3] net/mlx5: Add Direct Rule support

2019-03-28 Thread Ori Kam
This patch set adds support for Direct Rules API for MLX5 driver. As more and more applications like OVS are inserting and removing large number of flows, the flow insertion rate become more critical. In current MLX5 PMD rules are inserted to the device using the FW, this limits the max insertion

[dpdk-dev] [PATCH v2 2/3] net/mlx5: add Direct Rules API

2019-03-28 Thread Ori Kam
Adds calls to the Direct Rules API inside the glue functions. Due to difference in parameters between the Direct Rules and Direct Verbs some of the glue functions API was updated. Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c | 16 dr

[dpdk-dev] [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-03-28 Thread Ori Kam
This is the first patch of a series that is designed to enable the Direct Rules API. The main difference between Direct Verbs and Direct Rules from API prespective, is that in Direct Rules each action has it's own create function and the object itself is of type void. In this patch I'm adding fun

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Pradeep Satyanarayana
Thomas Monjalon wrote on 03/27/2019 02:19:03 AM: > From: Thomas Monjalon > To: "prad...@us.ibm.com" , Chao Zhu > > Cc: dev@dpdk.org, Dekel Peled , Shahaf Shuler > , "bruce.richard...@intel.com" > , David Christensen , > "honnappa.nagaraha...@arm.com" , > "konstantin.anan...@intel.com" , > "o

[dpdk-dev] [PATCH v2 3/3] net/mlx5: add jump action support for NIC

2019-03-28 Thread Ori Kam
When using Direct Rules we can add actions to jump between tables. This is extra useful since rule insertion rate is much higher on other tables compared to table zero. if no group is selected the rule is added to group 0. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 6 + driv

Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-03-28 Thread Eads, Gage
> 04/03/2019 21:51, Gage Eads: > > --- a/lib/librte_eal/common/include/generic/rte_atomic.h > > +++ b/lib/librte_eal/common/include/generic/rte_atomic.h > > +#if defined(RTE_ARCH_X86_64) > > +/** > > + * 128-bit integer structure. > > + */ > > +RTE_STD_C11 > > +typedef struct { > > + RTE_STD_

Re: [dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get()

2019-03-28 Thread Ferruh Yigit
On 3/25/2019 2:20 PM, Ferruh Yigit wrote: > On 3/22/2019 1:01 PM, Ian Stokes wrote: >> This commit uses the mtu fields populated in rte_eth_dev_info_get() >> to validate the mtu value being passed in port_mtu_set(). >> >> Signed-off-by: Ian Stokes > > For patch title, I think 'rte_eth_dev_info_ge

Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info

2019-03-28 Thread Ferruh Yigit
On 3/22/2019 1:01 PM, Ian Stokes wrote: > Building upon the discussion around [1], this series introduces MTU min > and MTU max variables. It also provides updates to PMD implementations > for ixgbe, i40e and IGB devices so that these variables are populated > for use when retrieving device info. >

Re: [dpdk-dev] [PATCH] power: update for error handling

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 3:55 PM, Lukasz Krakowiak wrote: Update for handling negative returned status from functions call. Signed-off-by: Lukasz Krakowiak --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH] mbuf: move headers not fragmented check to checksum

2019-03-28 Thread Andrew Rybchenko
Ping? (I have a number of net/sfc patches which heavily depend on this one and must not be applied without this one) Andrew. On 2/19/19 9:30 AM, Andrew Rybchenko wrote: rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Req

Re: [dpdk-dev] [PATCH 0/2] minor lgtm warning fixes

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:08 PM, Stephen Hemminger wrote: > Looks like the LGTM checker complains about condition > checks that are always true. > > Stephen Hemminger (2): > net/netvsc: fix lgtm static checker complaint > net/virtio: fix lgtm static checker complaint Series applied to dpdk-next-net/mast

Re: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Yongseok Koh
> On Mar 28, 2019, at 3:24 AM, Iremonger, Bernard > wrote: > > Hi Yongseok, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh >> Sent: Thursday, March 28, 2019 1:51 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> >> Cc: dev@dpdk.org; jer...@marvell.

Re: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Iremonger, Bernard
Hi Yongseok, > >> Subject: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate > >> multiple flows > >> > >> Testpmd can generate multiple flows without taking much cost and this > >> could be a simple traffic generator for developer's quick tests. If > >> "--txonly-multi- flow" is spec

Re: [dpdk-dev] [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] ht

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Thomas Monjalon
28/03/2019 18:51, Pradeep Satyanarayana: > From: Pradeep Satyanarayana/Beaverton/IBM > > From: Thomas Monjalon > > > Pradeep, Chao, > > > > > > Do we have more news? > > > We must merge this patch for DPDK 19.05-rc1. > > > > > > I understand you want to try improving performance > > > by using lig

[dpdk-dev] [PATCH v4 0/8] Add stack library and new mempool handler

2019-03-28 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v4 2/8] mempool/stack: convert mempool to use rte stack

2019-03-28 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v4 3/8] test/stack: add stack test

2019-03-28 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 + app/test/test_stack.c | 4

[dpdk-dev] [PATCH v4 1/8] stack: introduce rte stack library

2019-03-28 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v4 4/8] test/stack: add stack perf test

2019-03-28 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v4 5/8] stack: add lock-free stack implementation

2019-03-28 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v4 6/8] stack: add C11 atomic implementation

2019-03-28 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads --- lib/librte_stack/Makefile| 3 +- lib/librte_stack/meson.build

[dpdk-dev] [PATCH v4 8/8] mempool/stack: add lock-free stack mempool handler

2019-03-28 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v4 7/8] test/stack: add lock-free stack tests

2019-03-28 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

Re: [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level

2019-03-28 Thread Thomas Monjalon
> Dharmik Thakkar (3): > test/hash: replace macro with log-level approach > test/efd: enable unit test compilation always > test/timer: enable unit test compilation always Applied, thanks

Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check

2019-03-28 Thread Ferruh Yigit
On 3/28/2019 10:29 AM, Ali Alnubani wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, March 27, 2019 11:31 AM >> To: Shahaf Shuler ; Dekel Peled >> ; Ali Alnubani ; >> dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value ch

Re: [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level

2019-03-28 Thread Thomas Monjalon
28/03/2019 19:26, Thomas Monjalon: > > Dharmik Thakkar (3): > > test/hash: replace macro with log-level approach > > test/efd: enable unit test compilation always > > test/timer: enable unit test compilation always > > Applied, thanks PS: for 32-bit build, I had to replace "%lu" by "%"PRIuP

Re: [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins

2019-03-28 Thread Thomas Monjalon
03/01/2019 10:49, Phil Yang: > '__sync' builtins are deprecated, use '__atomic' builtins instead for > packet_ordering. > > Fixes: 850f373 ("examples/packet_ordering: new sample app") > > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang Am I right there will be a n

Re: [dpdk-dev] [PATCH v7 5/5] net/af_xdp: enable zero copy

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > Try to check if external mempool (from rx_queue_setup) is fit for > af_xdp, if it is, it will be registered to af_xdp socket directly and > there will be no packet data copy on Rx and Tx. > > Signed-off-by: Xiaolong Ye > --- > drivers/net/af_xdp/rte_eth

[dpdk-dev] [PATCH v4] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Yongseok Koh
Testpmd can generate multiple flows without taking much cost and this could be a simple traffic generator for developer's quick tests. If "--txonly-multi-flow" is specified in the command line, IP source address is varied to gnerate multiple flows. Signed-off-by: Yongseok Koh --- v4: * use uint8

Re: [dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic

2019-03-28 Thread Thomas Monjalon
25/02/2019 18:52, Jerin Jacob Kollanukkaran: > On Tue, 2019-02-12 at 15:01 +0800, Ruifeng Wang wrote: > > Implemented signature compare function based on neon intrinsic. > > Hash bulk lookup had 3% - 6% performance gain after optimization. > > > > Signed-off-by: Ruifeng Wang > > Reviewed-by: Gavi

Re: [dpdk-dev] [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-28 Thread Luca Boccassi
On Thu, 2019-03-28 at 17:51 +, Ferruh Yigit wrote: > > @@ -143,6 +143,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += > > -lrte_mempool_dpaa2 > > endif > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > > -lrte_pmd_af_packet > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx4: add secondary process support

2019-03-28 Thread Yongseok Koh
> On Mar 26, 2019, at 12:33 PM, Shahaf Shuler wrote: > > Monday, March 25, 2019 9:18 PM, Yongseok Koh: >> To: Shahaf Shuler >> Cc: dev@dpdk.org >> Subject: [PATCH v2 3/3] net/mlx4: add secondary process support >> >> In order to support secondary process, a few features are required. >> >> a

  1   2   >