28/03/2019 03:21, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only.
It is OK to merge few limited workarounds in the master branch, in order to start compiling something on Windows, and regularly check that the work done is not broken by other patches coming in. It will be especially useful if we manage to have a CI for Windows. > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > common_objs = [] > +common_sources = files( > + 'eal_common_errno.c', > + 'eal_common_launch.c', > + 'eal_common_lcore.c', > + 'eal_common_log.c' > + ) > +if host_machine.system() != 'windows' > common_sources = files( > 'eal_common_bus.c', > 'eal_common_cpuflags.c', > 'eal_common_class.c', > 'eal_common_devargs.c', > 'eal_common_dev.c', > - 'eal_common_errno.c', > 'eal_common_fbarray.c', > 'eal_common_hexdump.c', > 'eal_common_hypervisor.c', > - 'eal_common_launch.c', > - 'eal_common_lcore.c', > - 'eal_common_log.c', > 'eal_common_memalloc.c', > 'eal_common_memory.c', > 'eal_common_memzone.c', > @@ -38,6 +41,7 @@ common_sources = files( > 'rte_reciprocal.c', > 'rte_service.c' > ) > +endif As discussed over the phone, it would be better to overwrite this list and keep the original one as is. Thanks
