Re: [dpdk-dev] [PATCH] net/mlx5: fix Verbs errors treatment in prio probing

2019-03-07 Thread Shahaf Shuler
Thursday, February 21, 2019 11:02 AM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Verbs errors treatment in prio > probing > > The mlx5 PMD probes the Verbs flow priorities supported with > ibv_create_flow() function. If rdma-core or kernel fails for some reason, the > return

Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy

2019-03-07 Thread Shahaf Shuler
Applied to next-net-mlx, thanks. From: Rami Rosen Sent: Monday, February 25, 2019 8:26 AM To: Thomas Monjalon Cc: Shahaf Shuler ; Yongseok Koh ; dev ; Ophir Munk Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy Checked on Fedora 28 Reviewed-by: Rami Rosen https://emea01.safelin

Re: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create

2019-03-07 Thread Shahaf Shuler
Wednesday, February 27, 2019 4:57 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx4: fix default flow rule create > > > > On Feb 24, 2019, at 1:41 AM, Dekel Peled wrote: > > > > Original patch changed logic of function mlx4_flow_merge_eth(). > > The setting of flow->promisc was wrongly remove

Re: [dpdk-dev] [PATCH] net/mlx5: fix hex dump of error CQE

2019-03-07 Thread Shahaf Shuler
Thursday, February 28, 2019 5:19 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix hex dump of error CQE > > struct mlx5_cqe is defined in MLX5 PMD code (mlx5_prm.h). > It includes 64 bytes padding in case of (RTE_CACHE_LINE_SIZE == 128). > > struct mlx5_err_cqe is defined in kernel, a

Re: [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions

2019-03-07 Thread Shahaf Shuler
Thursday, February 28, 2019 5:21 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx > completions > > Function mlx5_tx_complete() reads completion entry information from Tx > queue. > For some processors not having strongly-ordered memory model, there has > to be a

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 6, 2019 8:02 PM > To: Gaëtan Rivet ; Raslan Darawsheh > > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device > with shared data > > 06/03/2

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor recognition on kernels 5.x

2019-03-07 Thread Shahaf Shuler
Monday, February 25, 2019 1:01 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor recognition > on kernels 5.x > > The master device and VF representors were distinguished by presence of > port name, master device did not have one. The new Linux kernels starti

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-07 Thread Thomas Monjalon
07/03/2019 04:27, Anand Rawat: > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > 06/03/2019 05:16, Anand Rawat: > >> Added header files to support windows on x86 platforms. > >> Updated rte_config to include rte_windows.h for windows > >> build. > > [...] > >> --- a/config/rte_config.h > >> +++ b/c

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-07 Thread Ilya Maximets
On 07.03.2019 9:45, gavin hu wrote: > In weak memory models, like arm64, reading the {prod,cons}.tail may get > reordered after reading or writing the ring slots, which corrupts the ring > and stale data is observed. > > This issue was reported by NXP on 8-A72 DPAA2 board. The problem is most > li

Re: [dpdk-dev] [PATCH v2] net/mlx5: support new representors' naming format

2019-03-07 Thread Shahaf Shuler
Sunday, March 3, 2019 9:44 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: support new representors' > naming format Representors' -> representor > > Kernel update [1] introduce new format of representors names. > This patch implements RFC [2], updating MLX5 PMD to support the new >

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-07 Thread Thomas Monjalon
07/03/2019 02:04, Anand Rawat: > On 3/6/2019 3:52 AM, Richardson, Bruce wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >> 06/03/2019 12:20, Bruce Richardson: > >>> On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > 06/03/2019 05:16, Anand Rawat: > > +if hos

Re: [dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gaëtan Rivet > Sent: Tuesday, March 5, 2019 6:49 PM > To: Raslan Darawsheh > Cc: dev@dpdk.org; Thomas Monjalon ; > step...@networkplumber.org > Subject: Re: [PATCH v2 2/4] net/failsafe: change back-reference from sub- > device > > Beside the squash refer

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-07 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Ilya Maximets > Sent: Thursday, March 7, 2019 4:52 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Honnappa Nagarahalli > ; olivier.m...@6wind.com > S

Re: [dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-07 Thread Gaëtan Rivet
Hello Raslan, On Thu, Mar 07, 2019 at 09:01:11AM +, Raslan Darawsheh wrote: > Hi, > > > -Original Message- > > From: Gaëtan Rivet > > Sent: Tuesday, March 5, 2019 6:49 PM > > To: Raslan Darawsheh > > Cc: dev@dpdk.org; Thomas Monjalon ; > > step...@networkplumber.org > > Subject: Re:

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Gaëtan Rivet
On Thu, Mar 07, 2019 at 08:43:01AM +, Raslan Darawsheh wrote: > Hi, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, March 6, 2019 8:02 PM > > To: Gaëtan Rivet ; Raslan Darawsheh > > > > Cc: dev@dpdk.org; step...@networkplumber.org > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-07 Thread Ilya Maximets
On 07.03.2019 12:27, Gavin Hu (Arm Technology China) wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Thursday, March 7, 2019 4:52 PM >> To: Gavin Hu (Arm Technology China) ; >> dev@dpdk.org >> Cc: nd ; tho...@monjalon.net; jer...@marvell.com; >> hemant.agra...@nxp.com; n

Re: [dpdk-dev] [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped patch two

2019-03-07 Thread Iremonger, Bernard
Hi Konstantin, > Subject: RE: [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped patch > two > > > Hi Bernard, > > > > > Call create_inline_session() at initialisition in sa.c Call > > rte_ipsec_session_prepare() in fill_ipsec_session() for inline. > > Here and in other places - it pro

[dpdk-dev] [PATCH v3] build: move variable definition to top level

2019-03-07 Thread Andrius Sirvys
If for debugging we disable the driver directory in the meson.build file, we get an error because the variable "driver_classes" does not exist. This is because driver_classes is only defined in the drivers/meson.build file. Defining driver_classes in dpdk/meson.build file will make it easier for co

Re: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped

2019-03-07 Thread Iremonger, Bernard
Hi Akhil, > Subject: Re: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped > > Hi Bernard, > > On 3/6/2019 9:30 PM, Bernard Iremonger wrote: > > This patchset fixes the issue of the first inbound packet being > > dropped for inline crypto. It also improves the debug output in e

Re: [dpdk-dev] [PATCH v3] build: move variable definition to top level

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 09:56:31AM +, Andrius Sirvys wrote: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Def

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 09:45:57AM +0100, Thomas Monjalon wrote: > 07/03/2019 04:27, Anand Rawat: > > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > > 06/03/2019 05:16, Anand Rawat: > > >> Added header files to support windows on x86 platforms. > > >> Updated rte_config to include rte_windows.h fo

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-07 Thread Bernard Iremonger
Improve debug code in esp.c, sa.c and ipsec-secgw.c Fixes: f159e70b0922 ("examples/ipsec-secgw: support transport mode") Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") Fixes: 906257e965b7 ("examples/ip

[dpdk-dev] [PATCH v2] doc: announce ABI change for cryptodev config

2019-03-07 Thread Anoob Joseph
Add new field ff_disable in rte_cryptodev_config. This enables applications to control the features enabled on the crypto device. Proposed new layout: /** Crypto device configuration structure */ struct rte_cryptodev_config { int socket_id;/**< Socket to allocate resources on */

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-07 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Ilya Maximets > Sent: Thursday, March 7, 2019 5:48 PM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Honnappa Nagarahalli > ; olivier.m...@6wind.com > Sub

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor recognition on kernels 5.x

2019-03-07 Thread Slava Ovsiienko
> -Original Message- > From: Shahaf Shuler > Sent: Thursday, March 7, 2019 10:44 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor > recognition on kernels 5.x > > Monday, February 25, 2019 1:01 PM, Viacheslav Ovsiienko: > > Subjec

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-07 Thread Ananyev, Konstantin
Hi Gavin, > > >>> In weak memory models, like arm64, reading the {prod,cons}.tail may get > > >>> reordered after reading or writing the ring slots, which corrupts the > > >>> ring > > >>> and stale data is observed. > > >>> > > >>> This issue was reported by NXP on 8-A72 DPAA2 board. The problem

Re: [dpdk-dev] 18.08.1 patches review and test

2019-03-07 Thread Kevin Traynor
On 06/03/2019 17:36, Kevin Traynor wrote: > On 06/03/2019 16:45, Walker, Benjamin wrote: >> On Wed, 2019-01-30 at 16:27 +, Kevin Traynor wrote: >>> Hi all, >>> >>> Here is a list of patches targeted for stable release 18.08.1. Please >>> help review and test. The tentative date for the final re

[dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

2019-03-07 Thread Tomasz Cel
This patch adds query about CPU features Fixes: 53a9baa98c36 ("compress/isal: add basic PMD ops") Cc: sta...@dpdk.org Signed-off-by: Tomasz Cel --- drivers/compress/isal/isal_compress_pmd_ops.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/compres

[dpdk-dev] [PATCH v4] build: move variable definition to top level

2019-03-07 Thread Andrius Sirvys
If for debugging we disable the driver directory in the meson.build file, we get an error because the variable "driver_classes" does not exist. This is because driver_classes is only defined in the drivers/meson.build file. Defining driver_classes in dpdk/meson.build file will make it easier for co

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-07 Thread Thomas Monjalon
07/03/2019 11:24, Bruce Richardson: > On Thu, Mar 07, 2019 at 09:45:57AM +0100, Thomas Monjalon wrote: > > 07/03/2019 04:27, Anand Rawat: > > > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > > > 06/03/2019 05:16, Anand Rawat: > > > >> Added header files to support windows on x86 platforms. > > > >

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gaëtan Rivet > Sent: Thursday, March 7, 2019 11:48 AM > To: Raslan Darawsheh > Cc: Thomas Monjalon ; dev@dpdk.org; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device > with shared data > > On Thu,

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Gaëtan Rivet
On Thu, Mar 07, 2019 at 11:34:42AM +, Raslan Darawsheh wrote: > Hi, > > > -Original Message- > > From: Gaëtan Rivet > > Sent: Thursday, March 7, 2019 11:48 AM > > To: Raslan Darawsheh > > Cc: Thomas Monjalon ; dev@dpdk.org; > > step...@networkplumber.org > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-07 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, March 7, 2019 11:33 AM > To: Richardson, Bruce > Cc: Rawat, Anand ; dev@dpdk.org; Kadam, Pallavi > ; Menon, Ranjit ; Shaw, > Jeffrey B > Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header fi

[dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all...

2019-03-07 Thread Bruce Richardson
Right now with DPDK we have two sources of version information - the rte_version.h header file containing macros for C use, and the project version number in the project definition in meson.build. This is not optimal, so this patchset aims to provide a single source for the DPDK version. The option

[dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
Since we have the version number in a separate file at the root level, we should not need to duplicate this in rte_version.h too. Best approach here is to move the macros for specifying the year/month/etc. parts from the version header file to the build config file - leaving the other utility macro

[dpdk-dev] [PATCH 4/4] eal: remove unneeded version logic

2019-03-07 Thread Bruce Richardson
The version number in the DPDK_VERSION file will never have an offset that needs to be subtracted, so remove that logic from the version string generation. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_version.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

[dpdk-dev] [PATCH 3/4] build: move meson version handling to config directory

2019-03-07 Thread Bruce Richardson
To keep the top-level meson.build file as clean and clear as possible, we move the version handling - which was originally short but now is a lot longer - to the config/meson.build file, where the rest of the build configuration is already being set up. Signed-off-by: Bruce Richardson --- config

[dpdk-dev] [PATCH 1/4] build: add single source of DPDK version number

2019-03-07 Thread Bruce Richardson
Add a new file DPDK_VERSION to hold the current DPDK version number. Have meson use this file for it's project version, and have make use it for reporting out "showversion" and "showversionum". Signed-off-by: Bruce Richardson --- DPDK_VERSION| 1 + meson.build | 2 +- mk/rte.sd

[dpdk-dev] [PATCH v4 0/1] add dynamic sgl allocation

2019-03-07 Thread Tomasz Jozwiak
This patch adds dynamic sgl allocation in QAT PMD and depends on 'malloc: add rte_realloc_socket function patch' (1551429976-16297-1-git-send-email-tomaszx.jozw...@intel.com) which should be applied first. Changes -v2: added rte_realloc_socket instead of rte_realloc -v3: fixed subject in pat

[dpdk-dev] [PATCH v4 1/1] compress/qat: add dynamic sgl allocation

2019-03-07 Thread Tomasz Jozwiak
This patch adds dynamic SGL allocation instead of static one. The number of element in SGL can be adjusted in each operation depend of the request. Signed-off-by: Tomasz Jozwiak --- config/common_base | 1 - doc/guides/compressdevs/qat_comp.rst | 1 - doc/guides/cryptodevs/qa

Re: [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all...

2019-03-07 Thread Luca Boccassi
On Thu, 2019-03-07 at 11:54 +, Bruce Richardson wrote: > Right now with DPDK we have two sources of version information - the > rte_version.h header file containing macros for C use, and the > project > version number in the project definition in meson.build. This is not > optimal, so this patc

Re: [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all...

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 12:09:44PM +, Luca Boccassi wrote: > On Thu, 2019-03-07 at 11:54 +, Bruce Richardson wrote: > > Right now with DPDK we have two sources of version information - the > > rte_version.h header file containing macros for C use, and the project > > version number in the p

[dpdk-dev] DPDK Release Status Meeting 7/3/2019

2019-03-07 Thread Ferruh Yigit
Minutes 7 March 2019 Agenda: * Release Dates * Subtrees * Opens Participants: * Arm * Debian * Intel * Mellanox * NXP * RedHat Release Dates - * v19.05 dates, no change: * Proposal Deadline has ended on Friday, 1 March * RC1: Friday, 29 March * Release:

Re: [dpdk-dev] [PATCH 1/4] build: add single source of DPDK version number

2019-03-07 Thread David Marchand
On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson wrote: > Add a new file DPDK_VERSION to hold the current DPDK version number. > Have meson use this file for it's project version, and have make use > it for reporting out "showversion" and "showversionum". > > Signed-off-by: Bruce Richardson > --

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread David Marchand
On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson wrote: > Since we have the version number in a separate file at the root level, > we should not need to duplicate this in rte_version.h too. Best > approach here is to move the macros for specifying the year/month/etc. > parts from the version head

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread David Marchand
On Thu, Mar 7, 2019 at 1:37 PM David Marchand wrote: > > > On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > >> Since we have the version number in a separate file at the root level, >> we should not need to duplicate this in rte_version.h too. Best >> appr

[dpdk-dev] [PATCH v2 00/37] ice share code update.

2019-03-07 Thread Qi Zhang
Sync to latest kernel driver, main changes: 1. add DCB/FDIR support. 2. add more APIs in switch module. 3. code clean and bug fix. v2: - Enhanced the commit log. - Add missing fixed line. Qi Zhang (37): net/ice/base: add switch resource allocation and free net/ice/base: improve comments net

[dpdk-dev] [PATCH v2 01/37] net/ice/base: add switch resource allocation and free

2019-03-07 Thread Qi Zhang
Add two APIs ice_alloc_sw and ice_free_sw to support switch related resource allocation and free. These APIs is required when we enable switch flow. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 150 ++ dr

[dpdk-dev] [PATCH v2 03/37] net/ice/base: add two helper functions

2019-03-07 Thread Qi Zhang
Add two helper functions in common module. 1. ice_aq_set_mac_cfg to help configure maximum frame size with AQ command 2. ice_get_ctx help to extract context bits from a packet structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 +

[dpdk-dev] [PATCH v2 09/37] net/ice/base: add VSI queue context framework

2019-03-07 Thread Qi Zhang
Added code to allocate VSI queue contexts to save the queue specific information like bandwidth etc. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 52 +++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH v2 04/37] net/ice/base: add helper macros

2019-03-07 Thread Qi Zhang
1. Add macro ice_for_each_traffic_class to loop for each traffic class. 2. Add macro MIN_T to wrap min with type conversion. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 2 +- drivers/net/ice/base/ice_nvm.c| 7 --- drivers/net/ice/

[dpdk-dev] [PATCH v2 08/37] net/ice/base: add more APIs in switch module

2019-03-07 Thread Qi Zhang
Add below APIs in switch module 1. ice_aq_get_vsi_params - get VSI context info 2. ice_aq_add_update_mir_rule - add/update mirror rule 3. ice_aq_delete_mir_rule - delete mirror rule 4. ice_aq_set_storm_ctrl - set storm control configuration 5. ice_aq_get_storm_ctrl - get storm control configurati

[dpdk-dev] [PATCH v2 05/37] net/ice/base: allow package copy to be used after resets

2019-03-07 Thread Qi Zhang
For components that make a copy of an external pipeline package file (i.e. the Linux and FreeBSD drivers), save the size of the package file along with the copy so that both can be used when calling ice_init_pkg() after a CORER/GLOBR reset. Also, do not free the copy of the package file in ice_ini

[dpdk-dev] [PATCH v2 06/37] net/ice/base: code clean

2019-03-07 Thread Qi Zhang
Remove unnecessary macro and data structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 - drivers/net/ice/base/ice_flex_pipe.c | 2 - drivers/net/ice/base/ice_flow.c | 136 -- drivers/net/i

[dpdk-dev] [PATCH v2 07/37] net/ice/base: declare functions as external

2019-03-07 Thread Qi Zhang
Remove static of below functions and declare them as external APIs. ice_aq_add_vsi ice_aq_free_vsi ice_aq_update_vsi ice_aq_add_lan_txq ice_init_pkg So far the purpose is just to sync with kernel driver. They are reserved for future use. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v2 10/37] net/ice/base: add APIs to add remove ethertype filter

2019-03-07 Thread Qi Zhang
Add API ice_remove_eth_mac and ice_add_eth_mac to support adding / removing ethertype (or MAC) based filter rules. PMD driver can use these APIs to enable related rte_flow rule. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 57 ++

[dpdk-dev] [PATCH v2 11/37] net/ice/base: add APIs to get allocated resources

2019-03-07 Thread Qi Zhang
1. ice_aq_get_res_alloc - get allocated resources. 2. ice_aq_get_res_descs - get allocated resource descriptors. These APIs may help to PMD to enable some debug utilities to dump the resource allocation status. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base

[dpdk-dev] [PATCH v2 14/37] net/ice/base: add MAC filter with marker and counter

2019-03-07 Thread Qi Zhang
1. ice_add_mac_with_sw_marker - add filter with software marker. 2. ice_add_mac_with_counter - add filter with counter enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 328 ++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH v2 12/37] net/ice/base: add APIs to alloc/free resource counter

2019-03-07 Thread Qi Zhang
1. ice_alloc_res_cntr - allocate resource counter 2. ice_free_res_cntr - free resource counter 3. ice_alloc_vlan_res_counter - allocate vlan resource counter 4. ice_free_vlan_res_counter - free vlan resource counter These APIs will be used when try to count the number of a flow be hitted. Signed-

[dpdk-dev] [PATCH v2 13/37] net/ice/base: add APIs to get VSI promiscuous mode

2019-03-07 Thread Qi Zhang
1. ice_get_vsi_promisc - get promiscuous mode of give VSI. 2. ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI. PMD may use these APIs to check the real HW status, but not rely on a software flag when something abnormal. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v2 15/37] net/ice/base: add two helper functions for flow management

2019-03-07 Thread Qi Zhang
1. ice_rem_all_sw_rules_info - remove all switch rules. 2. ice_reply_all_fltr - replay all filters stored in book keeping list. These APIs will be used when switch rule feature is enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 107 ++

[dpdk-dev] [PATCH v2 17/37] net/ice/base: update macros

2019-03-07 Thread Qi Zhang
Update macros for metadata and package flags. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 36 - drivers/net/ice/base/ice_flow.h | 17 ++-- drivers/net/ice/base/ice_lan_tx_rx.h | 77 +++

[dpdk-dev] [PATCH v2 16/37] net/ice/base: minor fix

2019-03-07 Thread Qi Zhang
1. ICE_SW_LKUP_LAST need to be handled correctly in ice_aq_alloc_free_vsi_list and ice_update_vsi_list_rule 2. ICE_SW_LKUP_ETHERTYPE_MAC need to be handled correctly in ice_update_vsi_lkup_fltr 3. free package segment pointer during ice_deinit_hw Fixes: c7dd15931183 ("net/ice/base: add virtual swi

[dpdk-dev] [PATCH v2 19/37] net/ice/base: enable VSI queue context

2019-03-07 Thread Qi Zhang
The patch added to retrieve the queue context and update the queue handle for lan queues. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 60 --- drivers/net/ice/base/ice_common.h |

[dpdk-dev] [PATCH v2 20/37] net/ice/base: ensure only valid bits are set

2019-03-07 Thread Qi Zhang
In the ice_aq_set_phy_cfg AQ command, the 16.4 bit is reserved. This patch will make sure that this bit will never be set to 1. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 1 + drivers/net/ice/base/ice_common

[dpdk-dev] [PATCH v2 21/37] net/ice/base: enhance get link status command

2019-03-07 Thread Qi Zhang
Extend the functionality of the admin queue command by including additional status and ID bits to improve link topology configuration. Signed-off-by: Matthew Vick Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 7 ++- 1 file changed, 6

[dpdk-dev] [PATCH v2 18/37] net/ice/base: code clean

2019-03-07 Thread Qi Zhang
Change below function as static and also relocated code line to align with kernel driver. ice_aq_move_sched_elems ice_sched_get_agg_node ice_sched_set_node_bw_lmt ice_sched_cfg_node_bw_alloc ice_sched_add_agg_cfg ice_sched_rm_agg_cfg ice_sched_move_vsi_to_agg ice_sched_del_rl_profile ice_sched_rm_

[dpdk-dev] [PATCH v2 22/37] net/ice/base: add RSS key related macro and structures

2019-03-07 Thread Qi Zhang
Add define for 52 byte RSS hash key size, and add struct ice_aqc_get_set_rss_keys comments regarding setting 40 bytes and 52 byte hash key. Signed-off-by: Paul Greenwalt Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 13 + 1 f

[dpdk-dev] [PATCH v2 23/37] net/ice/base: do not write TCAM entries back

2019-03-07 Thread Qi Zhang
Profile TCAM entry removal is handled by the firmware when freeing the resource, so the driver does not need to write these default entries back with an update Package action. This patch removes writing of the TCAM entry using Update Package command when removing it, since the entry has already be

[dpdk-dev] [PATCH v2 24/37] net/ice/base: remove local VSIG allocations

2019-03-07 Thread Qi Zhang
If allocating a VSI to a VSIG fails the local allocations made for VSIG profiles and change-lists will not be removed. Adding calls to free these entries on error in VSIG management calls. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net

[dpdk-dev] [PATCH v2 27/37] net/ice/base: fix static analysis reported issues

2019-03-07 Thread Qi Zhang
Klocwork points out some code is unreachable in ice_get_itr_intrl_gran and ice_ptg_find_ptype. The patch removed the unreachable code and resolved the static analysis reported issues. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Fixes: 453d087ccaff ("net/ice/base: add common

[dpdk-dev] [PATCH v2 26/37] net/ice/base: update copyright time

2019-03-07 Thread Qi Zhang
Update copyright time to 2019. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 2 +- drivers/net/ice/base/ice_alloc.h | 2 +- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_common.h| 2 +- drive

[dpdk-dev] [PATCH v2 28/37] net/ice/base: return config error without queue to disable

2019-03-07 Thread Qi Zhang
If there is no queue to disable, return appropriate configuration error earlier without acquiring the lock. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 17 ++--- 1 file changed, 10 insertions(+)

[dpdk-dev] [PATCH v2 25/37] net/ice/base: minor fix

2019-03-07 Thread Qi Zhang
1. Fix some problems with filling the HW tables. 2. Fix a logic error in ice_rem_prof_from_list. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 18 +++--- 1 fil

[dpdk-dev] [PATCH v5] drivers: fix possible overflow with strcat

2019-03-07 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Cc

[dpdk-dev] [PATCH v2 29/37] net/ice/base: add function to check FW recovery mode

2019-03-07 Thread Qi Zhang
Code added to check the FW recovery mode. This function will be used by the drivers during init to check whether the FW is in recovery mode or not. If FW is in recovery mode then the drivers need to run in a recovery mode where it can allow only limited operations. Link should be down, allow only c

[dpdk-dev] [PATCH v2 31/37] net/ice/base: add DCB support

2019-03-07 Thread Qi Zhang
Add module to support DCB related features. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile |1 + drivers/net/ice/base/ice_adminq_cmd.h | 243 ++ drivers/net/ice/base/ice_common.c | 12 + drivers/net/ice/base/ice_dcb.c|

[dpdk-dev] [PATCH v2 30/37] net/ice/base: change profile id reference counting

2019-03-07 Thread Qi Zhang
Improved the profile reference counting, by moving it from being based on how many TCAM entries using the profile to how many profile map entries are using the profile. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c

[dpdk-dev] [PATCH v2 32/37] net/ice/base: add FDIR support

2019-03-07 Thread Qi Zhang
Add flow director related support base code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/Makefile | 1 + drivers/net/ice/base/ice_adminq_cmd.h | 13 + drivers/net/ice/base/ice_common.c | 36 ++ drivers/net/ice/base/ice_common.h | 1 +

[dpdk-dev] [PATCH v2 34/37] net/ice/base: fix duplicate resource allocations

2019-03-07 Thread Qi Zhang
This patch ensure that TCAM allocations made by a newly added VSIG that has the same characteristic list of an existing VSIG are removed. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v2 33/37] net/ice/base: change profile priority for RSS reply

2019-03-07 Thread Qi Zhang
1. Add call to replay RSS configurations 2. Add RSS configurations to end of list and not the head to avoid inversion on replay. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 - drivers/net/ice/base/ice_

[dpdk-dev] [PATCH v2 35/37] net/ice/base: minor fix

2019-03-07 Thread Qi Zhang
1. clean flow entry's action structure after remove it. 2. initialized priority when add a new flow entry 3. remove RSS configuration before deleting the flow profile. Fixes: aa1cd410fa64 ("net/ice/base: add flow module") Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-o

[dpdk-dev] [PATCH v2 37/37] net/ice/base: revert the workaround for resource allocation

2019-03-07 Thread Qi Zhang
Revert the workaround for allocating TCAM and FV entries to align with latest firmware. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 11 +- drivers/net/ice/base/ice_common.h| 2 +- drivers/net/ice/base/ic

[dpdk-dev] [PATCH v2 36/37] net/ice/base: increase prototol offset size

2019-03-07 Thread Qi Zhang
OS package's format is changed, field vector's protocol offset size is changed from 8 bit to 16 bit. So base code also need to align to this, or PMD will not be able to load OS package correctly. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_flex_type.h

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 01:37:08PM +0100, David Marchand wrote: >On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > Since we have the version number in a separate file at the root > level, > we should not need to duplicate this in rt

Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

2019-03-07 Thread Zhang, Qi Z
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Harton > Sent: Wednesday, March 6, 2019 11:24 PM > To: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: David Harton > Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

Re: [dpdk-dev] [PATCH 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
On Thu, Mar 07, 2019 at 01:42:36PM +0100, David Marchand wrote: >On Thu, Mar 7, 2019 at 1:37 PM David Marchand ><[1]david.march...@redhat.com> wrote: > >On Thu, Mar 7, 2019 at 12:55 PM Bruce Richardson ><[2]bruce.richard...@intel.com> wrote: > > Since we have the version numb

[dpdk-dev] [PATCH v4] net/nfb: new netcope driver

2019-03-07 Thread Rastislav Cernay
From: Rastislav Cernay Note: New netcope-commong pcg on which is support for pkg-config, will be released soon and uploaded on official site. Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- v2: remove unnecessary cast remove unnecessary zeroing move decla

[dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

2019-03-07 Thread Bruce Richardson
Add a new file DPDK_VERSION to hold the current DPDK version number. Have meson use this file for it's project version, and have make use it for reporting out "showversion" and "showversionum". Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- v2: fix typos and include Luca's ack. ---

[dpdk-dev] [PATCH v2 0/4] One versionfile to rule them all...

2019-03-07 Thread Bruce Richardson
Right now with DPDK we have two sources of version information - the rte_version.h header file containing macros for C use, and the project version number in the project definition in meson.build. This is not optimal, so this patchset aims to provide a single source for the DPDK version. The option

[dpdk-dev] [PATCH v2 2/4] build: use version number from config file

2019-03-07 Thread Bruce Richardson
Since we have the version number in a separate file at the root level, we should not need to duplicate this in rte_version.h too. Best approach here is to move the macros for specifying the year/month/etc. parts from the version header file to the build config file - leaving the other utility macro

[dpdk-dev] [PATCH v2 4/4] eal: remove unneeded version logic

2019-03-07 Thread Bruce Richardson
The version number in the DPDK_VERSION file will never have an offset that needs to be subtracted, so remove that logic from the version string generation. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- V2: No changes - added Luca's ack --- lib/librte_eal/common/include/rte_version

[dpdk-dev] [PATCH v2 3/4] build: move meson version handling to config directory

2019-03-07 Thread Bruce Richardson
To keep the top-level meson.build file as clean and clear as possible, we move the version handling - which was originally short but now is a lot longer - to the config/meson.build file, where the rest of the build configuration is already being set up. Signed-off-by: Bruce Richardson Acked-by: L

Re: [dpdk-dev] [PATCH] net/ixgbe: fix crash when on remove

2019-03-07 Thread Zhang, Qi Z
> -Original Message- > From: wangyunjian [mailto:wangyunj...@huawei.com] > Sent: Tuesday, February 26, 2019 3:22 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: xudingke ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix crash when on remove > > > > > -Original Message--

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix negative check on unsigned queue pairs

2019-03-07 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, March 6, 2019 12:31 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Kevin Traynor ; sta...@dpdk.org; > Yan, Zhirun > Subject: [PATCH 1/2] net/i40e: fix negative check on unsigned queue pairs > > Fix th

Re: [dpdk-dev] [PATCH v4] net/nfb: new netcope driver

2019-03-07 Thread Luca Boccassi
On Thu, 2019-03-07 at 14:24 +0100, Rastislav Cernay wrote: > From: Rastislav Cernay > > Note: New netcope-commong pcg on which is support for pkg-config, > will be released soon and uploaded on official site. > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay >

Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

2019-03-07 Thread David Harton (dharton)
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 07, 2019 8:11 AM > To: David Harton (dharton) ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef > > Hi > > > -Original Messag

[dpdk-dev] [PATCH 3/3] test: add UT for power turbo feature

2019-03-07 Thread Lukasz Krakowiak
Add UT check_power_turbo. Signed-off-by: Lukasz Krakowiak --- app/test/test_power_cpufreq.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index d099f2f47..c75c9bf1c 100644 --- a/app/test/test

[dpdk-dev] [PATCH 0/3] test: improve test coverage for power library

2019-03-07 Thread Lukasz Krakowiak
This patch rename test_power_acpi_cpufreq.c to test_power_cpufreq.c, remove prefix _acpi from UT power functions/test names, add UT for power turbo feature. Lukasz Krakowiak (3): test: rename test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c test: remove prefix _acpi from UT power

[dpdk-dev] [PATCH 2/3] test: remove prefix _acpi from UT power function/test names

2019-03-07 Thread Lukasz Krakowiak
This patch remove prefix _acpi from power UT function/test names. Signed-off-by: Lukasz Krakowiak --- app/test/autotest_data.py | 4 ++-- app/test/meson.build | 2 +- app/test/test_power_cpufreq.c | 12 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ap

  1   2   >