07/03/2019 04:27, Anand Rawat: > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > 06/03/2019 05:16, Anand Rawat: > >> Added header files to support windows on x86 platforms. > >> Updated rte_config to include rte_windows.h for windows > >> build. > > [...] > >> --- a/config/rte_config.h > >> +++ b/config/rte_config.h > >> +/* windows specific*/ > >> +#ifdef RTE_EXEC_ENV_WINDOWS > >> +#include <rte_windows.h> > >> +#endif > > > > Include in the config file looks wrong. > > >> --- /dev/null > >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > > > I think we could remove the sub-directory exec-env. > > Could we include this file from rte_common.h? > rte_windows.h defines types and substitution macros which are > needed to support common code on windows. So it should be > included as a global include for every library on windows. > rte_common.h is not included in all the source code and headers > we currently build for windows.
I think it is not an issue adding some rte_common.h include here and there.
