07/03/2019 02:04, Anand Rawat: > On 3/6/2019 3:52 AM, Richardson, Bruce wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >> 06/03/2019 12:20, Bruce Richardson: > >>> On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > >>>> 06/03/2019 05:16, Anand Rawat: > >>>>> +if host_machine.system() != 'windows' > >>>>> + common_sources = files( > >>>> > >>>> The definitive solution should be to compile all common EAL files. > >>>> Please explain what are the issues in the common files. > >>>> I think we should not remove them and fix them one by one. > >>>> You could provide a separate patch to skip some files for making > >>>> helloworld working. > >>>> > >>> > >>> I believe that is exactly what this patch is trying to do - it's > >>> skipping the files unneeded to get helloworld working, and the > >>> intention is to fix them one by one and add them back in later. > >>> Perhaps this sort of change should be a separate (precursor) patch > >>> where the cover letter can call this out explicitly? > >>> > >>>>> -deps += 'kvargs' > >>>>> +if host_machine.system() != 'windows' > >>>>> + deps += 'kvargs' > >>>>> +endif > >>>> > >>>> Why kvargs is removed? > >>> > >>> Again, I believe these actions are to disable the parts of DPDK that > >>> are not needed to enable helloworld, allowing later patches to come in > >>> and fix them. > >> > >> They are workarounds to build helloworld. > >> It is good to have progress in the draft tree, but I see no point in > >> merging this in master. > >> I think we should separate patches which are doing definitive changes from > >> temporary workaround patches disabling some files. > >> It is not an issue to merge some patches for Windows which are not > >> compiling. > > Bruce is right, we only compile required header and source files in > order to avoid compatibility errors on windows. Without these > change helloworld on windows would fail to compile. Adding windows > specific implementations of the common headers and sources would > bloat up individual patches as well the number of patches. kvargs is > removed as a dependency to have minimum viable product for helloworld. > If required for lcore mask, it'll added back in v3.
Please make separate patches for workarounds. I am interested to push some patches which are really required in master, but the workarounds should stay in the Windows draft repository.
