On 3/1/19 9:42 PM, Stephen Hemminger wrote:
On Fri, 1 Mar 2019 10:48:58 +0300
Andrew Rybchenko wrote:
On 3/1/19 1:47 AM, Stephen Hemminger wrote:
Don't need to use snprintf for simple name copy.
Signed-off-by: Stephen Hemminger
---
lib/librte_ethdev/rte_ethdev.c | 2 +-
1 file changed,
On Sat, Mar 2, 2019 at 1:10 PM Igor Russkikh
wrote:
> The patchset mainly fixes some Coverity issues,
> couple of minor bugs and overflows.
>
> It also improves eeprom get/set logic with ability of custom
> device address and dump length.
>
> Igor Russkikh (7):
> net/atlantic: Fix negative erro
On Fri, Mar 1, 2019 at 7:50 PM Stephen Hemminger
wrote:
> On Fri, 1 Mar 2019 15:37:34 +0100
> Rastislav Cernay wrote:
>
> > From: Rastislav Cernay
> >
> > Added new net driver for Netcope nfb cards
> >
> > Signed-off-by: Rastislav Cernay
> > ---
>
> Please fix these obvious style issues from
No space needed here:
./devtools/checkpatches.sh: line 65: res: command not found
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
04/03/2019 10:57, David Marchand:
> No space needed here:
> ./devtools/checkpatches.sh: line 65: res: command not found
>
> Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> Cc: sta...@dpdk.org
> Signed-off-by: David Marchand
Thank you
It is already submitted:
h
On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson
wrote:
> On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote:
> > Helloworld example for Windows.
> > Includes Windows-specific EAL changes and meson
> > changes to build the code on Windows.
> >
> > Anand Rawat (6):
> > eal: eal stub to a
Sorry Bruce, wrong dest :-)
--
David Marchand
On Mon, Mar 4, 2019 at 11:13 AM David Marchand
wrote:
>
>
> On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson <
> bruce.richard...@intel.com> wrote:
>
>> On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote:
>> > Helloworld example for Window
On Mon, Mar 4, 2019 at 11:13 AM Thomas Monjalon wrote:
> 04/03/2019 10:57, David Marchand:
> > No space needed here:
> > ./devtools/checkpatches.sh: line 65: res: command not found
> >
> > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
> > Cc: sta...@dpdk.org
> > Signed
On Fri, Mar 1, 2019 at 6:52 PM Thomas Monjalon wrote:
> 01/03/2019 18:08, Michael Santana:
> > Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> > as a command, rather than a simple variable assignment.
> >
> > Signe
build-tags.sh is broken because of removed 'test' folder, this breaks
helper make targets like 'make cscope', 'make tags', etc...
Fixing it by removing 'test' from source directories list.
Fixes: a9de470cc7c0 ("test: move to app directory")
Signed-off-by: Ferruh Yigit
---
Cc: bruce.richard...@i
According to the api, the q_errors[] per queue statistic is for reception
errors not transmit errors.
This is a first cleanup on statistics before looking at oerrors.
--
David Marchand
David Marchand (12):
net/af_packet: fix incorrect rxq errors stat
net/avp: fix incorrect rxq errors stat
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 577d3dced0dc ("net/bnxt: refactor the query stats")
Cc: sta...@dpdk.org
Cc: Ajit Khaparde
Cc: Somnath Kotur
Signed-off-by: David Marchand
---
drivers/net/bnxt/bnxt_hwrm.c | 1 -
1 file changed, 1 deletion(-)
dif
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
Cc: sta...@dpdk.org
Cc: John W. Linville
Signed-off-by: David Marchand
---
drivers/net/af_packet/rte_eth_af_packet.c | 3 +--
1 file changed,
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 5a5abe2de94b ("net/avp: add device statistics operations")
Cc: sta...@dpdk.org
Cc: Allain Legacy
Cc: Matt Peters
Signed-off-by: David Marchand
---
drivers/net/avp/avp_ethdev.c | 1 -
1 file changed, 1 deletion(-)
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 856505d303f4 ("cxgbe: add port statistics")
Fixes: a0a344a8f728 ("net/cxgbe: add VF port statistics")
Cc: sta...@dpdk.org
Cc: Rahul Lakkireddy
Signed-off-by: David Marchand
---
drivers/net/cxgbe/cxgbe_ethdev.c |
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
Cc: sta...@dpdk.org
Cc: Matan Azrad
Cc: Shahaf Shuler
Signed-off-by: David Marchand
---
drivers/net/mlx4/mlx4_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")
Cc: sta...@dpdk.org
Cc: Ferruh Yigit
Signed-off-by: David Marchand
---
drivers/net/kni/rte_eth_kni.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driv
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 87011737b715 ("mlx5: add software counters")
Fixes: 9f9a48eb2978 ("net/mlx5: fix Tx stats error counter definition")
Cc: sta...@dpdk.org
Cc: Shahaf Shuler
Cc: Yongseok Koh
Signed-off-by: David Marchand
---
driver
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 4c173302c307 ("pcap: add new driver")
Cc: sta...@dpdk.org
Cc: Ferruh Yigit
Signed-off-by: David Marchand
---
drivers/net/pcap/rte_eth_pcap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dr
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: c743e50c475f ("null: new poll mode driver")
Cc: sta...@dpdk.org
Cc: Tetsuya Mukawa
Signed-off-by: David Marchand
---
drivers/net/null/rte_eth_null.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: e1e4017751f1 ("ring: add new driver")
Cc: sta...@dpdk.org
Cc: Bruce Richardson
Signed-off-by: David Marchand
---
drivers/net/ring/rte_eth_ring.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: abef3dd62e7a ("szedata2: add new poll mode driver")
Cc: sta...@dpdk.org
Cc: Jan Remes
Signed-off-by: David Marchand
---
drivers/net/szedata2/rte_eth_szedata2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
Transmit errors must not be reported in q_errors[] which is for
reception.
Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
Cc: sta...@dpdk.org
Cc: Keith Wiles
Signed-off-by: David Marchand
---
drivers/net/tap/rte_eth_tap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --
On Fri, Mar 1, 2019 at 3:38 PM Rastislav Cernay wrote:
> diff --git a/drivers/net/nfb/nfb_stats.c b/drivers/net/nfb/nfb_stats.c
> new file mode 100644
> index 000..ffc27a5
> --- /dev/null
> +++ b/drivers/net/nfb/nfb_stats.c
> @@ -0,0 +1,78 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + *
On Mon, 2019-03-04 at 11:04 +, Ferruh Yigit wrote:
>
> ---
> build-tags.sh is broken because of removed 'test' folder, this breaks
> helper make targets like 'make cscope', 'make tags', etc...
>
> Fixing it by removing 'test' from so
As stated in 19.02 deprecation notice, this patch updates the
aesni_mb PMD to remove the support of older Intel-ipsec-mb
library version eariler than 0.52.
Signed-off-by: Fan Zhang
---
Although the PMD dependency to the library is changed, the ABI/API
are not updated as the APIs to access the PMD
Typically device works in promiscuous mode and filtering/processing is done
after
packets are received, use of MACS is a marginal case so we are not exactly
focused
on it. I will add random ethernet address so card can work in initial state
with multiple
devices.
On Fri, Mar 1, 2019 at 7:47 PM
> -Original Message-
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Monday, March 04, 2019 6:18 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Legacy, Allain; Peters, Matt
> Subject: [PATCH 02/12] net/avp: fix incorrect rxq errors stat
>
> Transmit errors must not be repor
>>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
struct rte_eth_stats {
...
uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
...
}
As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (16)
and struct rte_eth_stats eth_stats is allocated statically,
there is
On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay wrote:
> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>
> struct rte_eth_stats {
> ...
> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
> ...
> }
>
> As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (
On Mon, Mar 4, 2019 at 1:35 PM David Marchand
wrote:
>
>
> On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay
> wrote:
>
>> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>>
>> struct rte_eth_stats {
>> ...
>> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
>> ...
>> }
>>
>>>How about looping on min(nb_tx, RTE_ETHDEV_QUEUE_STAT_CNTRS) ?
This would lead to incomplete tx_total (and other total) stats. Maybe I
could just
add commentary, why it is written like this and leave it be?
On Mon, Mar 4, 2019 at 1:48 PM David Marchand
wrote:
> On Mon, Mar 4, 2019 at 1:35 PM
> On Mar 4, 2019, at 5:18 AM, David Marchand wrote:
>
> Transmit errors must not be reported in q_errors[] which is for
> reception.
>
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> Cc: sta...@dpdk.org
> Cc: Keith Wiles
> Signed-off-by: David Marchand
> ---
> drivers/net/tap/rt
Hi Fan,
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Monday, March 4, 2019 11:47 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Kusztal,
> ArkadiuszX
> ; Trahe, Fiona
> Subject: [PATCH] crypto/aesni_mb: support newer version library only
>
> As stated in 19.02
As stated in 19.02 deprecation notice, this patch updates the
aesni_mb PMD to remove the support of older Intel-ipsec-mb
library version eariler than 0.52.
Signed-off-by: Fan Zhang
---
v2:
- fixed incorrect version in documentation.
doc/guides/cryptodevs/aesni_mb.rst |8 +-
On 28.02.2019 18:31, Maxime Coquelin wrote:
> External backends may have specific requests to handle, and so
> we don't want the vhost-user lib to handle these requests as
> errors.
>
> This patch also changes the experimental API by introducing
> RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-use
On 3/4/19 4:25 PM, Ilya Maximets wrote:
On 28.02.2019 18:31, Maxime Coquelin wrote:
External backends may have specific requests to handle, and so
we don't want the vhost-user lib to handle these requests as
errors.
This patch also changes the experimental API by introducing
RTE_VHOST_MSG_RE
This patch adds new test structure for modexp and modinv
Signed-off-by: Damian Nowak
---
v2:
- coding style improved
---
test/test/test_cryptodev_asym.c | 278 ++
test/test/test_cryptodev_mod_test_vectors.h | 954
2 files changed, 1232 insertions(+)
diff --
This series introduces the ability for any github mirrors of the DPDK
project, including developer mirrors, to kick off builds under the
travis CI infrastructure. For now, this just means compilation - no
other kinds of automated run exists yet. In the future, this can be
expanded to execute and
GitHub is a service used by developers to store repositories. GitHub
provides service integrations that allow 3rd party services to access
developer repositories and perform actions. One of these services is
Travis-CI, a simple continuous integration platform.
This is a simple initial implementa
On 04.03.2019 19:02, Maxime Coquelin wrote:
>
>
> On 3/4/19 4:25 PM, Ilya Maximets wrote:
>> On 28.02.2019 18:31, Maxime Coquelin wrote:
>>> External backends may have specific requests to handle, and so
>>> we don't want the vhost-user lib to handle these requests as
>>> errors.
>>>
>>> This pat
>
> This patchset adds the AES-CTR and 3DES-CBC cipher algorithms
> support to ipsec library. The test scripts for ipsec-secgw
> sample application are added too.
>
> v3:
> - fixed a bug in 3DES.
>
> v2:
> - removed unsupported tests.
>
> Fan Zhang (4):
> ipsec: add AES-CTR algorithm suppo
dev.mlx5_core.1.hw.board_id: LNR3270110033
dev.mlx5_core.1.hw.fw_version: 12.17.2020
Thanks!
Mit Matelske
- Original Message -
From: "shahafs"
To: "Mit Matelske" , "stephen"
Cc: "Thomas Monjalon" , "dev" , "Yongseok
Koh"
Sent: Sunday, March 3, 2019 2:43:41 AM
Subject: RE: [dpdk-dev]
On 3/2/2019 10:42 AM, Hyong Youb Kim wrote:
> This patch series fixes bugs in enic's implementation of flow API and
> adds very limited support for RAW, RSS, and PASSTHRU. Limited RSS and
> PASSTHRU are intended to support partial offloads in OVS-DPDK and
> VPP. These apps use MARK + default RSS an
On 3/2/2019 10:42 AM, Hyong Youb Kim wrote:
> Inner packet matching is currently buggy in many cases.
>
> 1. Mishandling null spec ("match any").
> The copy_item functions do nothing if spec is null. This is incorrect,
> as all patterns should be appended to the L5 pattern buffer even for
> null s
On 3/1/19 4:08 PM, Thomas Monjalon wrote:
01/03/2019 21:24, Michael Santana Francisco:
On 3/1/19 12:51 PM, Thomas Monjalon wrote:
01/03/2019 18:43, Thomas Monjalon:
01/03/2019 18:08, Michael Santana:
+# Enable codespell by default. This can be overwritten from a config file.
+# You can also e
On Sat, Feb 02, 2019 at 10:28:26AM +, Hari Kumar Vemula wrote:
> Add a programmer's guide section for meson ut
>
> Signed-off-by: Hari Kumar Vemula
Acked-by: Bruce Richardson
NACK, see comments below
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Friday, March 1, 2019 4:46 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming
> Subject: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download
>
> Columbiaville requires a p
On 3/1/2019 11:10 AM, Rami Rosen wrote:
> This patch fixes a wrong tag in guides/nics/features.rst.
> The features tags should be, according to the
> "Features Overview" section in this doc, one of the following:
> "uses", "implements", "provides", or "related".
> Hence in Inner RSS section, it s
On Mon, 2019-03-04 at 11:12 -0500, Michael Santana wrote:
> GitHub is a service used by developers to store repositories. GitHub
> provides service integrations that allow 3rd party services to access
> developer repositories and perform actions. One of these services is
> Travis-CI, a simple con
Fixed a minor bug with variable assignment, as well as added an
option for checkpatches
v3->v4:
Support enabling codespell via environment variable.
v2->v3:
Also enable codespell by setting a path to a dictionary file.
v1->v2:
Enable codespell by default. Disable via config file
Michael S
Enable codespell by default.
codespell is a feature by checkpatch.pl that
checks for common spelling mistakes in patches.
This feature is disabled by default. To enable it one must add
the '--codespell' flag to the $options variable in
checkpatches.sh. With this change codespell is enabled by defa
Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.
Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: sta...@dpdk.org
Signed-off-by: Michael
On Mon, 4 Mar 2019 12:11:20 +0300
Andrew Rybchenko wrote:
> On 3/1/19 9:42 PM, Stephen Hemminger wrote:
> > On Fri, 1 Mar 2019 10:48:58 +0300
> > Andrew Rybchenko wrote:
> >
> >> On 3/1/19 1:47 AM, Stephen Hemminger wrote:
> >>> Don't need to use snprintf for simple name copy.
> >>>
> >>> Si
On Sun, 3 Mar 2019 07:14:07 +
Dekel Peled wrote:
> In current kernel implementation, the physical port name for representors is
> a numeric string (i.e. '0', '1', etc.).
>
>
>
> Kernel patch [1] implements an updated scheme for naming of representors
> ports.
>
> The new scheme gives a
> This operation can be used for non-blocking algorithms, such as a non-blocking
> stack or ring.
>
> Signed-off-by: Gage Eads
> ---
> .../common/include/arch/x86/rte_atomic_64.h| 33
> lib/librte_eal/common/include/generic/rte_atomic.h | 59
> ++
> 2 fil
[snip]
> > +/**
> > + * An atomic compare and set function used by the mutex functions.
> > + * (Atomically) Equivalent to:
> > + * if (*dst == exp)
> Should be, "if (*dst == *exp)"
>
> > + * *dst = src
> Should be "*dst = *src"
>
Good catches, will fix both.
> > + * else
> > + * *
Reviewed-by: Rami Rosen
>
>
This operation can be used for non-blocking algorithms, such as a
non-blocking stack or ring.
Signed-off-by: Gage Eads
Reviewed-by: Honnappa Nagarahalli
---
.../common/include/arch/x86/rte_atomic_64.h| 33
lib/librte_eal/common/include/generic/rte_atomic.h | 59
This patch addresses x86-64 only; other architectures can/will be supported
in the future. The __atomic intrinsic was considered for the implementation,
however libatomic was found[1] to use locks to implement the 128-bit CAS on at
least one architecture and so is eschewed here. The interface is mo
Reviewed-by: Rami Rosen
>
Reviewed-by: Rami Rosen
>
04/03/2019 20:07, Michael Santana:
> Fixed a minor bug with variable assignment, as well as added an
> option for checkpatches
>
> v3->v4:
> Support enabling codespell via environment variable.
>
> v2->v3:
> Also enable codespell by setting a path to a dictionary file.
>
> v1->v2:
> Enable
> > build-tags.sh is broken because of removed 'test' folder, this breaks
> > helper make targets like 'make cscope', 'make tags', etc...
> >
> > Fixing it by removing 'test' from source directories list.
> >
> > Fixes: a9de470cc7c0 ("test: move to app directory")
> >
> > Signed-off-by: Ferruh Y
The driver currently has a devarg to set the rewrite mode during
init. Some apps want to programatically set it after running
rte_eal_init() and finding that ports are VIC. Add a private function
to support such applications.
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/Makefile
The driver currently has a devarg to set the rewrite mode during
init. Some apps want to programatically set it after running
rte_eal_init() and finding that ports are VIC. Add a private function
to support such applications.
Signed-off-by: Hyong Youb Kim
---
v2:
* Move symbol to the experimental
66 matches
Mail list logo
