On Fri, Mar 1, 2019 at 7:50 PM Stephen Hemminger <step...@networkplumber.org>
wrote:
> On Fri, 1 Mar 2019 15:37:34 +0100
> Rastislav Cernay <cer...@netcope.com> wrote:
>
> > From: Rastislav Cernay <cer...@netcope.com>
> >
> > Added new net driver for Netcope nfb cards
> >
> > Signed-off-by: Rastislav Cernay <cer...@netcope.com>
> > ---
>
> Please fix these obvious style issues from checkpatches
>
> ERROR:SPACING: space required before the open brace '{'
> #934: FILE: drivers/net/nfb/nfb_ethdev.c:380:
> + if (!is_valid_assigned_ether_addr(mac_addr)){
>
> WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
> #935: FILE: drivers/net/nfb/nfb_ethdev.c:381:
> + return -EINVAL;;
>
And if you look carefully at checkpatches.sh output, you can see:
[dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh
### net/nfb: new netcope driver
[snip]
total: 1 errors, 2 warnings, 1884 lines checked
./devtools/checkpatches.sh: line 65: res: command not found
I will post a fix on checkpatches.sh for this, then a new warning appears:
Warning in /doc/guides/nics/nfb.rst:
Using explicit .svg extension instead of .*
--
David Marchand
