Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Varghese, Vipin
Hi Lee, Apologies if the logic is already done for my query snipped > + /* Set private xform checksum */ > + switch (xform->compress.chksum) { > + /* Raw deflate by default */ Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating compress/isal ins

Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

2018-12-17 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:11 AM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v4 03/10] vhost:

Re: [dpdk-dev] [PATCH v4 06/10] net/ifc: detect if VDPA mode is specified

2018-12-17 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:17 AM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v4 06/10] net/ifc

Re: [dpdk-dev] [PATCH v4 07/10] net/ifc: add devarg for LM mode

2018-12-17 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:21 AM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v4 07/10] net/ifc

Re: [dpdk-dev] [PATCH v4 09/10] net/ifc: support SW assisted VDPA live migration

2018-12-17 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:35 AM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v4 09/10] net/ifc

[dpdk-dev] [PATCH] net/af_packet: add docs guide

2018-12-17 Thread Tiago Lam
As of commit 364e08f2bbc0, DPDK allows an aplication to send and receive raw packets using an AF_PACKET and PACKET_MMAP, when using a Linux Kernel. This complements it by adding a simple guide with the following information: - An introduction, where a brief explanation of this driver is given, po

Re: [dpdk-dev] [PATCH v4 10/10] doc: update ifc NIC document

2018-12-17 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:36 AM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v4 10/10] doc: up

Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Daly, Lee
Hi Vipin, thanks for the question. > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 17, 2018 8:20 AM > To: Daly, Lee ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > support in driver > > Hi

Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU

2018-12-17 Thread Lam, Tiago
Hi Ferruh, On 28/11/2018 13:33, Ferruh Yigit wrote: > On 11/28/2018 1:12 PM, Lam, Tiago wrote: >> On 27/11/2018 17:43, Ferruh Yigit wrote: >>> On 11/20/2018 10:26 AM, Tiago Lam wrote: Use the underlying MTU to calculate the framsize to be used for the mmap RINGs. This is to make it more

[dpdk-dev] [PATCH] eal/option: fix option register duplicate detection

2018-12-17 Thread Gaetan Rivet
Missing brackets around the if means that the loop will end at its first iteration. Cc: sta...@dpdk.org Fixes: 2395332798d0 ("eal: add option register infrastructure") Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/rte_option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

Re: [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg

2018-12-17 Thread Gaëtan Rivet
Hi Keith, On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote: > Add a missing newline to a RTE_LOG message. > I think it might interest sta...@dpdk.org, and you might as well include a fixline reference. > Signed-off-by: Keith Wiles > --- > lib/librte_eal/common/rte_option.c | 2 +- >

Re: [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 9:25 AM, Gaetan Rivet wrote: Missing brackets around the if means that the loop will end at its first iteration. Cc: sta...@dpdk.org Fixes: 2395332798d0 ("eal: add option register infrastructure") Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/rte_option.c | 3 ++- 1 fil

Re: [dpdk-dev] [PATCH v2] mem: add --match-allocations

2018-12-17 Thread Burakov, Anatoly
On 14-Dec-18 5:13 PM, Jim Harris wrote: SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creates internal malloc_elem structures for these al

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Saturday, December 15, 2018 2:16 PM > To: Ananyev, Konstantin ; Pattan, Reshma > ; dev@dpdk.org; Dumitrescu, Cristian > ; jerin.ja...@caviumnetworks.com; Singh, > Jasvinder > Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH v2] mem: add --match-allocations

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 9:40 AM, Burakov, Anatoly wrote: On 14-Dec-18 5:13 PM, Jim Harris wrote: SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creat

Re: [dpdk-dev] [PATCH] bbdev: add missing APIs to map file

2018-12-17 Thread Akhil Goyal
Hi, On 12/14/2018 9:52 PM, Amr Mokhtar wrote: > some application facing functions are missing from > the map file. these are added by this patch. > > Signed-off-by: Amr Mokhtar > --- > lib/librte_bbdev/rte_bbdev_version.map | 4 > 1 file changed, 4 insertions(+) > > diff --git a/lib/librt

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Hideyuki Yamashita
Dear Thomas and all, I took a look on dpdk code. I firstly write qustions and my analisys on the current dpdk code follows after that. [1.Questions] I have several questions to ask again. Is my understanding correct about followings Q1: "EAL:ERROR, Invalid memory" is ignorable Q2: there is no

Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option

2018-12-17 Thread David Marchand
On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo wrote: > This command-line option will enable hotplug event detecting and enable > hotplug handling for device hotplug. > > Signed-off-by: Jeff Guo > Is there a reason why we would want this disabled by default and enabled via option ? diff --git a/lib

Re: [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection

2018-12-17 Thread David Marchand
On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet wrote: > Missing brackets around the if means that the loop will end at its first > iteration. > > Cc: sta...@dpdk.org > > Fixes: 2395332798d0 ("eal: add option register infrastructure") > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/rt

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: Dear Thomas and all, I took a look on dpdk code. I firstly write qustions and my analisys on the current dpdk code follows after that. [1.Questions] I have several questions to ask again. Is my understanding correct about followings Q1: "EAL:ERR

Re: [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip

2018-12-17 Thread Ferruh Yigit
On 12/14/2018 4:28 PM, Stephen Hemminger wrote: > On Fri, 14 Dec 2018 16:09:33 + > Ferruh Yigit wrote: > >> On 12/14/2018 1:26 AM, Stephen Hemminger wrote: >>> In some cases, VLAN stripping is not desireable. If necessary >>> re-insert stripped vlan tag. >>> >>> Signed-off-by: Stephen Hemming

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 10:23 AM, Burakov, Anatoly wrote: On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: Dear Thomas and all, I took a look on dpdk code. I firstly write qustions and my analisys on the current dpdk code follows after that. [1.Questions] I have several questions to ask again. Is my unde

Re: [dpdk-dev] [PATCH 2/3] net/netvsc: cleanup transmit descriptor pool

2018-12-17 Thread Ferruh Yigit
On 12/14/2018 1:26 AM, Stephen Hemminger wrote: > On device close or startup errors, the transmit descriptor pool > was being left behind. So this is fixing possible memory leak, should this be an "fix" commit, so that it can be backported to stable trees? > > Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Hideyuki Yamashita
> On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: > > Dear Thomas and all, > > > > I took a look on dpdk code. > > I firstly write qustions and my analisys > > on the current dpdk code follows after that. > > > > [1.Questions] > > I have several questions to ask again. > > Is my understanding corr

Re: [dpdk-dev] [PATCH 3/3] net/netvsc: not finding VF should not cause failure

2018-12-17 Thread Ferruh Yigit
On 12/14/2018 1:26 AM, Stephen Hemminger wrote: > It is possible that the VF device exists but DPDK doesn't know > about it. This could happen if device was blacklisted or more > likely the necessary device (Mellanox) was not part of the DPDK > configuration. > > In either case, the right thing to

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: firmware status check

2018-12-17 Thread Ferruh Yigit
On 12/14/2018 4:59 PM, Kevin Traynor wrote: > On 12/03/2018 08:07 AM, Zhang, Qi Z wrote: >> >> >>> -Original Message- >>> From: Li, Xiaoyun >>> Sent: Monday, December 3, 2018 3:08 PM >>> To: Zhang, Qi Z >>> Cc: dev@dpdk.org; Li, Xiaoyun >>> Subject: [PATCH v2] net/i40e: firmware status ch

Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

2018-12-17 Thread Maxime Coquelin
Hi Xiao, On 12/17/18 9:51 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Sunday, December 16, 2018 1:11 AM To: Wang, Xiao W ; Bie, Tiwei Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong ; Ye, Xiaolon

[dpdk-dev] [PATCH v2 14/20] net/ena: fix cleanup for out of order packets

2018-12-17 Thread Michal Krawczyk
From: Rafal Kozik When wrong req_id is detected some previous mbufs could be used for receiving different segments of received packets. In such cases chained mbufs will be twice returned to pool. To prevent it chained mbuf is now freed just after error detection. To simplify cleaning, pointers

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Hideyuki Yamashita
> On 17-Dec-18 10:23 AM, Burakov, Anatoly wrote: > > On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: > >> Dear Thomas and all, > >> > >> I took a look on dpdk code. > >> I firstly write qustions and my analisys > >> on the current dpdk code follows after that. > >> > >> [1.Questions] > >> I have s

[dpdk-dev] [PATCH v3 14/20] net/ena: fix cleanup for out of order packets

2018-12-17 Thread Michal Krawczyk
From: Rafal Kozik When wrong req_id is detected some previous mbufs could be used for receiving different segments of received packets. In such cases chained mbufs will be twice returned to pool. To prevent it chained mbuf is now freed just after error detection. To simplify cleaning, pointers

Re: [dpdk-dev] [PATCH v4 09/10] net/ifc: support SW assisted VDPA live migration

2018-12-17 Thread Maxime Coquelin
On 12/17/18 10:12 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Sunday, December 16, 2018 1:35 AM To: Wang, Xiao W ; Bie, Tiwei Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong ; Ye, Xiaolong Sub

Re: [dpdk-dev] [PATCH v6 0/5] add initial version of compress-perf

2018-12-17 Thread Verma, Shally
>-Original Message- >From: Tomasz Jozwiak >Sent: 12 December 2018 17:25 >To: dev@dpdk.org; fiona.tr...@intel.com; tomaszx.jozw...@intel.com; Verma, >Shally ; >akhil.go...@nxp.com >Subject: [PATCH v6 0/5] add initial version of compress-perf > >External Email > >This patchset adds initi

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote: On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: Dear Thomas and all, I took a look on dpdk code. I firstly write qustions and my analisys on the current dpdk code follows after that. [1.Questions] I have several questions to ask again. Is my un

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-17 Thread Ananyev, Konstantin
> -Original Message- > From: Dumitrescu, Cristian > Sent: Saturday, December 15, 2018 12:16 AM > To: Ananyev, Konstantin ; Pattan, Reshma > ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte

Re: [dpdk-dev] [PATCH v2 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-12-17 Thread Dumitrescu, Cristian
Hi Eelco, > -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Thursday, November 29, 2018 11:29 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH v2 1/2] lib/librte_meter: add RFC4115 trTCM meter support > > This patch adds support for RFC411

[dpdk-dev] [PATCH v5] eal_interrupts: add option for pending callback unregister

2018-12-17 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-17 Thread Thomas Monjalon
Hi Keith, 16/12/2018 18:46, Keith Wiles: > DFS stands for DPDK Filesystem, which helps expose data > and control files in a FUSE based filesystem. The dfs requires > libfuse3 and libjansson to be present in the Linux system. You presented this idea at the DPDK Summit in Dublin, and I have not see

Re: [dpdk-dev] [PATCH v2 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-12-17 Thread Eelco Chaudron
On 17 Dec 2018, at 12:23, Dumitrescu, Cristian wrote: Hi Eelco, -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Thursday, November 29, 2018 11:29 AM To: Dumitrescu, Cristian Cc: dev@dpdk.org Subject: [PATCH v2 1/2] lib/librte_meter: add RFC4115 trTCM mete

[dpdk-dev] [PATCH v6] eal_interrupts: add option for pending callback unregister

2018-12-17 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

[dpdk-dev] [PATCH v7] eal_interrupts: add option for pending callback unregister

2018-12-17 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] rte_eal_hotplug_remove() generates error message

2018-12-17 Thread Hideyuki Yamashita
> On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote: > >> On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote: > >>> Dear Thomas and all, > >>> > >>> I took a look on dpdk code. > >>> I firstly write qustions and my analisys > >>> on the current dpdk code follows after that. > >>> > >>> [1.Questions] > >

Re: [dpdk-dev] [PATCH 1/3] crypto/qat: handle error msg of block size properly

2018-12-17 Thread Kovacevic, Marko
Tested-by: Marko Kovacevic Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH 0/3] Fix handling of block size in qat for hash

2018-12-17 Thread Kovacevic, Marko
Series-acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v2] app/test-pmd: add IFPGA AFU register read/write access for testpmd

2018-12-17 Thread Xu, Rosen
Hi, > -Original Message- > From: Pattan, Reshma > Sent: Saturday, December 15, 2018 1:38 > To: Xu, Rosen ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Xu, Rosen ; Yigit, > Ferruh > Subject: RE: [dpdk-dev] [PATCH v2] app/test-pmd: add IFPGA AFU register > read/

Re: [dpdk-dev] [PATCH 2/3] crypto/qat: fix message for CCM when setting unused counter

2018-12-17 Thread Kovacevic, Marko
Tested-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v2] app/test-pmd: add IFPGA AFU register read/write access for testpmd

2018-12-17 Thread Xu, Rosen
Hi Bernard, > -Original Message- > From: Iremonger, Bernard > Sent: Friday, December 14, 2018 18:19 > To: Xu, Rosen ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Subject: RE: [PATCH v2] app/test-pmd: add IFPGA AFU register read/write > access for testpmd > > Hi Rose

[dpdk-dev] [PATCH v3] app/test-pmd: add IFPGA AFU register access fuction for testpmd

2018-12-17 Thread Rosen Xu
Currently register read/write of testpmd is only for PCI device, but more and more IFPGA based AFU devices need this feature to access registers, this patch will add support for it. Signed-off-by: Rosen Xu --- app/test-pmd/config.c | 116 - app/te

[dpdk-dev] [PATCH v8] eal_interrupts: add option for pending callback unregister

2018-12-17 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Varghese, Vipin
Thanks for the update > -Original Message- > From: Daly, Lee > Sent: Monday, December 17, 2018 2:50 PM > To: Varghese, Vipin ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > support in driver > > Hi Vipin, th

[dpdk-dev] KNI @ FreeBSD

2018-12-17 Thread Dobri Dobrev
Hello, I’d like to know why KNI module is not being developed for FreeBSD. Regards D

[dpdk-dev] [PATCH v4] app/test-pmd: add IFPGA AFU register access function for testpmd

2018-12-17 Thread Rosen Xu
Currently register read/write of testpmd is only for PCI device, but more and more IFPGA based AFU devices need this feature to access registers, this patch will add support for it. Signed-off-by: Rosen Xu --- app/test-pmd/config.c | 116 - app/te

Re: [dpdk-dev] KNI @ FreeBSD

2018-12-17 Thread Burakov, Anatoly
On 17-Dec-18 12:39 PM, Dobri Dobrev wrote: Hello, I’d like to know why KNI module is not being developed for FreeBSD. Regards D Hi, Most likely answer is because no one has bothered to do so. Patches are always welcome :) -- Thanks, Anatoly

Re: [dpdk-dev] [RFC 2/3] tqs: add thread quiescent state library

2018-12-17 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > + > > > > > > > +/* Add a reader thread, running on an lcore, to the list of > > > > > > > +threads > > > > > > > + * reporting their quiescent state on a TQS variable. > > > > > > > + */ > > > > > > > +int __rte_experimental > > > > > > > +rte_tqs_register_lcore(stru

[dpdk-dev] DPDK techboard minutes 5th december

2018-12-17 Thread Olivier Matz
Meeting notes for the DPDK technical board meeting held on 2018-12-05 = Attendees: - Bruce Richardson - Ferruh Yigit - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon 1) Status of the Meson build system ---

Re: [dpdk-dev] [RFC] cryptodev/asymm: propose changes to modexp and modinv API

2018-12-17 Thread Kusztal, ArkadiuszX
Hi Shally, Thanks for your answers :). My answers in [AK-v2] > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, December 17, 2018 6:45 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan > ; Kanaka Durga Kotamarthy > ;

Re: [dpdk-dev] [PATCH v5 2/2] net/i40e: support PF respond VF request more queues

2018-12-17 Thread Ferruh Yigit
On 12/17/2018 11:10 AM, Zhirun Yan wrote: > This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and > process to allocated more queues for the requested VF. If successful, > PF will notify VF to reset. If unsuccessful, PF will send message to > inform VF. Hi Zhirun, Is this request sup

Re: [dpdk-dev] [PATCH v5 1/2] net/i40e: support VF request more queues

2018-12-17 Thread Ferruh Yigit
On 12/17/2018 11:10 AM, Zhirun Yan wrote: > Before this patch, VF gets a default number of queues from the PF. > This patch enables VF to request a different number. When VF configures > more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request > more queues, if success, PF will reset t

Re: [dpdk-dev] [PATCH v5 1/2] net/i40e: support VF request more queues

2018-12-17 Thread Ferruh Yigit
On 12/17/2018 11:10 AM, Zhirun Yan wrote: > Before this patch, VF gets a default number of queues from the PF. > This patch enables VF to request a different number. When VF configures > more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request > more queues, if success, PF will reset t

Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

2018-12-17 Thread Wang, Xiao W
Thanks for the confirmation. BRs, Xiao > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, December 17, 2018 7:03 PM > To: Wang, Xiao W ; Bie, Tiwei > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject:

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-17 Thread Wiles, Keith
> On Dec 17, 2018, at 5:45 AM, Thomas Monjalon wrote: > > Hi Keith, > > 16/12/2018 18:46, Keith Wiles: >> DFS stands for DPDK Filesystem, which helps expose data >> and control files in a FUSE based filesystem. The dfs requires >> libfuse3 and libjansson to be present in the Linux system. > >

Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include

2018-12-17 Thread Rami Rosen
Reviewed-by: Rami Rosen On Fri, 14 Dec 2018 at 18:43, Jeff Shaw wrote: > > Prior to this patch, the two affected .c files include > unnecessarily. This commit removes the include lines. > > Signed-off-by: Jeff Shaw > --- > lib/librte_eal/common/eal_common_lcore.c | 1 - > lib/librte_eal/commo

Re: [dpdk-dev] [PATCH v13 01/10] net/virtio: add packed virtqueue defines

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_pci.h | 1 + drivers/net/virtio/virtio_ring.h | 30 ++ drivers/net/virtio/virtqueue.h | 6 ++ 3 files changed, 37 insertions(+) Reviewed-by: Maxime

Re: [dpdk-dev] net/i40e: VF with vlan ID set from host does not work

2018-12-17 Thread Min Tang
More information: the i40e driver on host (ubuntu16.04) was 2.2.4, but I tried the latest 2.7.26 i40e driver and it had the same problem. DPDK 17.05 was running in a linux VM, but I don't think the latest DPDK has solved the problem. It's easy to reproduce. On Fri, Dec 14, 2018 at 4:28 PM Min Tang

[dpdk-dev] [PATCH 0/2] prevent out of bounds read with checksum

2018-12-17 Thread Bruce Richardson
The functions for checksumming the packet payload don't perform bounds checks, and are used by the TAP driver which does not do any bounds checks on the incoming packet either. This means a packet received with an incorrect IP header can read beyond the end of the mbuf. In the worst case, where th

[dpdk-dev] [PATCH 1/2] net: fix underflow for checksum of invalid IPv4 packets

2018-12-17 Thread Bruce Richardson
If we receive a packet with an invalid IP header, where the total packet length is reported as less than the IP header length, we would end up getting an underflow in the length subtraction. This could cause us to checksum e.g. 4GB of data in the case where the result of the subtraction was -1. We

[dpdk-dev] [PATCH 2/2] net/tap: add buffer overflow checks before checksum

2018-12-17 Thread Bruce Richardson
The checksum calculation APIs take only the packet headers pointers as parameters, so they assume that the lengths reported in those headers are correct. However, a malicious packet could claim to be far larger than it is, so we need to check the header lengths in the driver before calling the chec

Re: [dpdk-dev] [PATCH v13 02/10] net/virtio: add packed virtqueue helpers

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_pci.h | 6 +++ drivers/net/virtio/virtqueue.h | 91 - 2 files changed, 95 insertions(+), 2

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-17 Thread Thomas Monjalon
Thanks for your detailed answer Keith. Honestly, I do not have much more to say, except some implementation details that I may comment later. I hope we will read more opinions from the community. 17/12/2018 16:01, Wiles, Keith: > > On Dec 17, 2018, at 5:45 AM, Thomas Monjalon wrote: > > 16/12/2

Re: [dpdk-dev] [PATCH v13 03/10] net/virtio: vring init for packed queues

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Add and initialize descriptor data structures. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 32 ++-- drivers/net/virtio/virtio_ring.h | 34 --

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-17 Thread Wiles, Keith
> On Dec 16, 2018, at 4:22 PM, Luca Boccassi wrote: > > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote: >> --- /dev/null >> +++ b/lib/librte_dfs/meson.build >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2018 Intel Corporation >> + >> +version = 1 > >

Re: [dpdk-dev] [PATCH v13 02/10] net/virtio: add packed virtqueue helpers

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: +static inline void +_set_desc_avail(struct vring_packed_desc *desc, int wrap_counter) +{ + desc->flags |= VRING_DESC_F_AVAIL(wrap_counter) | + VRING_DESC_F_USED(!wrap_counter); +} + +static inline void +set_desc_avail(struct

Re: [dpdk-dev] [PATCH v13 05/10] net/virtio: implement transmit path for packed queues

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 57 --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: firmware status check

2018-12-17 Thread Kevin Traynor
On 12/17/2018 10:57 AM, Ferruh Yigit wrote: > On 12/14/2018 4:59 PM, Kevin Traynor wrote: >> On 12/03/2018 08:07 AM, Zhang, Qi Z wrote: >>> >>> -Original Message- From: Li, Xiaoyun Sent: Monday, December 3, 2018 3:08 PM To: Zhang, Qi Z Cc: dev@dpdk.org; Li, Xiaoyun

Re: [dpdk-dev] [PATCH v13 06/10] net/virtio: implement receive path for packed queues

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Implement the receive part. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 58 +++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_rxtx.c | 375 ++

Re: [dpdk-dev] [PATCH v13 07/10] net/virtio: add virtio send command packed queue support

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Use packed virtqueue format when reading and writing descriptors to/from the ring. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 90 ++ 1 file changed, 90 insertions(+) Reviewed-by: Maxime Coque

Re: [dpdk-dev] [PATCH v13 08/10] net/virtio-user: add option to use packed queues

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- .../net/virtio/virtio_user/virtio_user_dev.c | 18 ++ .../net/virtio/virtio_user/virtio_user_dev.h | 2 +-

Re: [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq

2018-12-17 Thread Maxime Coquelin
I think you meant control queue in the title? On 12/14/18 4:59 PM, Jens Freimann wrote: Until we have support for ctrl virtqueues let's disable it and fail device initalization if specified as a parameter. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10

Re: [dpdk-dev] [PATCH v13 10/10] net/virtio: enable packed virtqueues by default

2018-12-17 Thread Maxime Coquelin
On 12/14/18 4:59 PM, Jens Freimann wrote: Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-17 Thread Pattan, Reshma
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, December 17, 2018 11:21 AM > To: Dumitrescu, Cristian ; Pattan, Reshma > ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte

[dpdk-dev] [Bug 165] checkpatches.sh doesn't detect rte_exit() / rte_panic() instances

2018-12-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=165 Bug ID: 165 Summary: checkpatches.sh doesn't detect rte_exit() / rte_panic() instances Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRM

Re: [dpdk-dev] [PATCH] pkg: remove RPM recipe

2018-12-17 Thread Thomas Monjalon
27/11/2018 12:09, Bruce Richardson: > On Mon, Nov 26, 2018 at 09:26:59PM +0100, Thomas Monjalon wrote: > > This RPM recipe is not well maintained and probably not used a lot. > > Each distribution has its own constraints and recipes. > > It may not be a good idea to try maintaining packaging recipe

Re: [dpdk-dev] [RFC] cryptodev/asymm: propose changes to modexp and modinv API

2018-12-17 Thread Trahe, Fiona
Hi Shally, Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, December 17, 2018 7:25 AM > To: Verma, Shally > Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan > ; Kanaka Durga Kotamarthy > ; Sunila Sahu > ; Kotamarthy, Kanaka ; Sahu, > Sunila > ; Cel, TomaszX ; Jozwi

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Pattan, Reshma > Sent: Monday, December 17, 2018 5:15 PM > To: Ananyev, Konstantin ; Dumitrescu, > Cristian ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition > >

Re: [dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

2018-12-17 Thread Maxime Coquelin
On 12/17/18 3:41 PM, Wang, Xiao W wrote: Thanks for the confirmation. Please note that CI reports a checkpatch issue: http://patches.dpdk.org/patch/48935/ Thanks, Maxime BRs, Xiao -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, December

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-17 Thread Luca Boccassi
On Mon, 2018-12-17 at 16:26 +, Wiles, Keith wrote: > > On Dec 16, 2018, at 4:22 PM, Luca Boccassi > > wrote: > > > > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote: > > > --- /dev/null > > > +++ b/lib/librte_dfs/meson.build > > > @@ -0,0 +1,47 @@ > > > +# SPDX-License-Identifier: BSD-3-

Re: [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq

2018-12-17 Thread Jens Freimann
On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote: I think you meant control queue in the title? On 12/14/18 4:59 PM, Jens Freimann wrote: Until we have support for ctrl virtqueues let's disable it and fail device initalization if specified as a parameter. Signed-off-by: Jens Fre

Re: [dpdk-dev] [PATCH v2 1/2] cryptodev: change queue pair configure structure

2018-12-17 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Tuesday, December 11, 2018 3:34 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v2 1/2] cryptodev: change queue pair configure > structure >

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-17 Thread Mattias Rönnblom
On 2018-12-17 10:41, Dumitrescu, Cristian wrote: -Original Message- From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Saturday, December 15, 2018 2:16 PM To: Ananyev, Konstantin ; Pattan, Reshma ; dev@dpdk.org; Dumitrescu, Cristian ; jerin.ja...@caviumnetworks.com; Si

Re: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session structure

2018-12-17 Thread Trahe, Fiona
Hi Fan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Tuesday, December 11, 2018 3:34 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session > structure

Re: [dpdk-dev] [PATCH v3 1/2] eal: add new rte color definition

2018-12-17 Thread Thomas Monjalon
13/12/2018 19:08, Reshma Pattan: > Added new rte_color definition in eal to > consolidate color definition which is currently replicated > in various places such as rte_meter.h, rte_tm.h and rte_mtr.h I don't think EAL is the right place for such definition. Why ethdev would not rely on definition

Re: [dpdk-dev] [PATCH v3] eventdev: fix eth Tx adapter queue count checks

2018-12-17 Thread Jerin Jacob Kollanukkaran
On Mon, 2018-12-17 at 10:09 +0530, Nikhil Rao wrote: > rte_event_eth_tx_adapter_queue_add() - add a check > that returns an error if the ethdev has zero Tx queues > configured. > > rte_event_eth_tx_adapter_queue_del() - remove the > checks for ethdev queue count, instead check for > queues added t

[dpdk-dev] [PATCH v14 00/10] implement packed virtqueues

2018-12-17 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf A packed

[dpdk-dev] [PATCH v14 03/10] net/virtio: vring init for packed queues

2018-12-17 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 32 -- drivers/net/virtio/virtio_ring.h | 28 ++ drivers/net/virtio/v

[dpdk-dev] [PATCH v14 02/10] net/virtio: add packed virtqueue helpers

2018-12-17 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_pci.h | 6 +++ drivers/net/virtio/virtqueue.h | 72 - 2 files changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virt

[dpdk-dev] [PATCH v14 01/10] net/virtio: add packed virtqueue defines

2018-12-17 Thread Jens Freimann
Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_pci.h | 1 + drivers/net/virtio/virtio_ring.h | 30 ++ drivers/net/virtio/virtqueue.h | 6 ++ 3 files changed, 37 insertions(+) diff --git a/drivers/net/virtio/virtio_pci

[dpdk-dev] [PATCH v14 06/10] net/virtio: implement receive path for packed queues

2018-12-17 Thread Jens Freimann
Implement the receive part. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 56 +++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_rxtx.c | 375 - drivers/net/vir

[dpdk-dev] [PATCH v14 07/10] net/virtio: add virtio send command packed queue support

2018-12-17 Thread Jens Freimann
Use packed virtqueue format when reading and writing descriptors to/from the ring. Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 96 ++ 1 file changed, 96 insertions(+) diff --git a/drivers/net/virtio/virtio_ethde

[dpdk-dev] [PATCH v14 04/10] net/virtio: dump packed virtqueue data

2018-12-17 Thread Jens Freimann
Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtqueue.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h inde

[dpdk-dev] [PATCH v14 05/10] net/virtio: implement transmit path for packed queues

2018-12-17 Thread Jens Freimann
This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 56 --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v14 09/10] net/virtio-user: fail if cq used with packed vq

2018-12-17 Thread Jens Freimann
Until we have support for control virtqueues let's disable it and fail device initalization if specified as a parameter. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/vi

  1   2   >