Hi Maxime, > -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Sunday, December 16, 2018 1:11 AM > To: Wang, Xiao W <xiao.w.w...@intel.com>; Bie, Tiwei <tiwei....@intel.com> > Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong > <zhihong.w...@intel.com>; Ye, Xiaolong <xiaolong...@intel.com> > Subject: Re: [PATCH v4 03/10] vhost: provide helpers for virtio ring relay > > > > On 12/14/18 10:16 PM, Xiao Wang wrote: > > This patch provides two helpers for vdpa device driver to perform a > > relay between the guest virtio ring and a mediate virtio ring. > > s/mediate/mediated/ ? > I'm not 100% sure, but if it is mediated, please change everywhere else > in the patch.
"mediate" can also be used as an adjective, so "mediate" is OK here. > > > > > The available ring relay will synchronize the available entries, and > > helps to do desc validity checking. > > s/helps/help/ Yes, will update. > > > > > The used ring relay will synchronize the used entries from mediate ring > > to guest ring, and helps to do dirty page logging for live migration. > > s/helps/help/ Will update. Thanks for the comments, Xiao > > > > > The next patch will leverage these two helpers. > > > > Signed-off-by: Xiao Wang <xiao.w.w...@intel.com> > > --- > > lib/librte_vhost/rte_vdpa.h | 39 +++++++ > > lib/librte_vhost/rte_vhost_version.map | 2 + > > lib/librte_vhost/vdpa.c | 194 > +++++++++++++++++++++++++++++++++ > > lib/librte_vhost/vhost.h | 40 +++++++ > > lib/librte_vhost/virtio_net.c | 39 ------- > > 5 files changed, 275 insertions(+), 39 deletions(-) > > > > > Appart from that: > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > Thanks, > Maxime
