On 12/17/2018 10:57 AM, Ferruh Yigit wrote:
> On 12/14/2018 4:59 PM, Kevin Traynor wrote:
>> On 12/03/2018 08:07 AM, Zhang, Qi Z wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Li, Xiaoyun
>>>> Sent: Monday, December 3, 2018 3:08 PM
>>>> To: Zhang, Qi Z <qi.z.zh...@intel.com>
>>>> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>
>>>> Subject: [PATCH v2] net/i40e: firmware status check
>>>>
>>>> Check the firmware status at init time. If the firmware is in recovery
>>>> mode, alert
>>>> the user to check it.
>>>>
>>>> Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com>
>>>
>>> Acked-by: Qi Zhang <qi.z.zh...@intel.com>
>>>
>>> Applied to dpdk-next-net-intel.
>>>
>>
>> This was applied with a 'Cc:stable' tag, but no 'Fixes' tag.
>
> This fixes a behavior in the driver, but not a specific code/commit, and
> author
> request this behavior change to backport. This request makes sense to me but
> what do you think from stable tree point of view? Are you OK with this kind of
> request?
>
It makes sense to me also to backport, I guess it can be seen as a fix
for the original pmd which was missing this code:
Fixes: 4861cde46116 ("i40e: new poll mode driver")
or if only relevant since some base driver/firmware change, then Fixes:
from that update.
>> What stable branches is it relevant for?
>
> I agree it is hard to define the scope of the fix without having the code that
> is fixed. Do you have any suggestion how to formalize the request for these
> kind
> of issues?
>
I tend to think if it's a *fix*, then some code was previously added
that was incorrect, or had a missing piece, or became incorrect at some
point due to another other change, so 'Fixes:' should almost always be
possible.
However, if for some reason it's not clear and there's not too many,
then a simple solution is to reply to thread (cc'ing stable) saying
which which stable branches it is relevant for. I will check the thread
for info when I see a patch like that. 'Fixes:' is much preferred
though, so not to have manual checking of email threads.
Kevin.
>>
>>> Thanks
>>> Qi
>>>
>>>
>>
>
