Hi, Lucero, Thomas
This patch set will cause deadlock during memory initialization.
rte_memseg_walk and try_expand_heap both will lock
the file &mcfg->memory_hotplug_lock. So dead lock will occur.
#0 rte_memseg_walk
#1 <-rte_eal_check_dma_mask
#2 <-alloc_pages_on_heap
#3 <-try_expand_
29/10/2018 09:23, Yao, Lei A:
> Hi, Lucero, Thomas
>
> This patch set will cause deadlock during memory initialization.
> rte_memseg_walk and try_expand_heap both will lock
> the file &mcfg->memory_hotplug_lock. So dead lock will occur.
>
> #0 rte_memseg_walk
> #1 <-rte_eal_check_dma_ma
One more comment about this issue,
There was no reply to the question asked by Alejandro on October 11th:
http://mails.dpdk.org/archives/dev/2018-October/115402.html
and there were no more reviews despite all my requests:
http://mails.dpdk.org/archives/dev/2018-October/117475.html
Can we have the configuration triggering this issue?
On Mon, Oct 29, 2018 at 9:07 AM Thomas Monjalon wrote:
> One more comment about this issue,
>
> There was no reply to the question asked by Alejandro on October 11th:
> http://mails.dpdk.org/archives/dev/2018-October/115402.html
> and
> -Original Message-
> From: Yongseok Koh
> Sent: Saturday, October 27, 2018 0:57
> To: Slava Ovsiienko
> Cc: Shahaf Shuler ; dev@dpdk.org
> Subject: Re: [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation
> routine
>
> On Fri, Oct 26, 2018 at 01:39:38AM -0700, Slava Ovsiienko wrote:
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, October 29, 2018 4:43 PM
> To: Yao, Lei A
> Cc: Alejandro Lucero ; dev@dpdk.org;
> Xu, Qian Q ; Lin, Xueqin ;
> Burakov, Anatoly
> Subject: Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DM
Hi, Lucero
My server info:
Intel(R) Xeon(R) Platinum 8180 CPU @ 2.50GHz
Hugepage: 1G
Kernel: 4.15.0
OS: Ubuntu
Steps are simple:
1. Bind one i40e/ixgbe NIC to igb_uio
2. Launch testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd -c 0x03 -n 4 --log-level=eal,8 -- -i
BRs
Lei
From:
29/10/2018 10:36, Yao, Lei A:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 29/10/2018 09:23, Yao, Lei A:
> > > Hi, Lucero, Thomas
> > >
> > > This patch set will cause deadlock during memory initialization.
> > > rte_memseg_walk and try_expand_heap both will lock
> > > the file &mcfg->m
On Sat, 2018-10-27 at 23:54 +0200, Thomas Monjalon wrote:
> 20/09/2018 15:51, Timothy Redaelli:
> > On Thu, 20 Sep 2018 14:22:08 +0100
> > Luca Boccassi wrote:
> >
> > > From: Bruce Richardson
> > >
> > > Signed-off-by: Bruce Richardson
> > > Signed-off-by: Luca Boccassi
> >
> > Tested on Fe
Hi Dekel,
Thursday, October 25, 2018 11:08 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct
> Verbs flow in MLX5 PMD
>
> This series adds support of encap and decap actions in DV format.
> L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support u
Thursday, October 25, 2018 11:08 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v6 1/6] net/mlx5: add flow action functions to
> glue
>
> This patch adds glue functions for operations:
> - Create packet reformat (encap/decap) flow action.
> - Destroy flow action.
>
> The new operations depend on H
Hi Dekel,
Thursday, October 25, 2018 11:08 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v6 2/6] net/mlx5: add VXLAN encap action to
> Direct Verbs
>
> This patch implements the VXLAN encap action in DV flow for MLX5 PMD.
>
> Signed-off-by: Dekel Peled
> ---
> drivers/net/mlx5/mlx5_flow.h|
Thursday, October 25, 2018 11:08 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v6 6/6] net/mlx5: add raw data encap decap to
> Direct Verbs
>
> This patch implements the encap and decap actions, using raw data, in DV
> flow for MLX5 PMD.
>
> Signed-off-by: Dekel Peled
> ---
> drivers/net/mlx5/m
Thursday, October 25, 2018 11:08 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v6 3/6] net/mlx5: add VXLAN decap action to
> Direct Verbs
>
> This patch implements the VXLAN decap action in DV flow for MLX5 PMD.
>
> Signed-off-by: Dekel Peled
> ---
> drivers/net/mlx5/mlx5_flow.h| 1 +
> d
I know what is going on.
In patchset version 3 I forgot to remove an old code. Anatoly spotted that
and I was going to send another version for fixing it. Before sending the
new version I saw that report about a problem with dma_mask and I'm afraid
I did not send another version with the fix ...
Apologies. Forget my previous email. Just using the wrong repo.
Looking at solving this asap.
On Mon, Oct 29, 2018 at 10:11 AM Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
> I know what is going on.
>
> In patchset version 3 I forgot to remove an old code. Anatoly spotted that
> and
-Original Message-
> Date: Mon, 29 Oct 2018 02:57:17 +
> From: "Gavin Hu (Arm Technology China)"
> To: Jerin Jacob , Thomas Monjalon
>
> CC: "dev@dpdk.org" , Honnappa Nagarahalli
> , "sta...@dpdk.org" , Ola
> Liljedahl , "olivier.m...@6wind.com"
> , "chao...@linux.vnet.ibm.com"
>
-Original Message-
> Date: Sun, 28 Oct 2018 20:37:23 +
> From: "Ananyev, Konstantin"
> To: Jerin Jacob
> CC: "dev@dpdk.org" , "Awal, Mohammad Abdul"
> , "Joseph, Anoob"
> , "Athreya, Narayana Prasad"
>
> Subject: RE: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API
>
>
> Hi
29/10/2018 11:16, Jerin Jacob:
> From: "Gavin Hu (Arm Technology China)"
> >
> > Hi Thomas and Jerin,
> >
> > The patches were extensively reviewed by Arm internally, as the 1st patch
> > was not able to be concluded, I created a new patch series(2 patches).
> > How can I clean up this mess?
>
-Original Message-
> Date: Mon, 29 Oct 2018 11:47:05 +0100
> From: Thomas Monjalon
> To: Jerin Jacob , "Gavin Hu (Arm Technology
> China)"
> Cc: "dev@dpdk.org" , Honnappa Nagarahalli
> , "sta...@dpdk.org" , Ola
> Liljedahl , "olivier.m...@6wind.com"
> , "chao...@linux.vnet.ibm.com"
>
I got a patch that solves a bug when calling rte_eal_dma_mask using the
mask instead of the maskbits. However, this does not solves the deadlock.
Interestingly, the problem looks like a compiler one. Calling
rte_memseg_walk does not return when calling inside rt_eal_dma_mask, but if
you modify the
29/10/2018 12:39, Alejandro Lucero:
> I got a patch that solves a bug when calling rte_eal_dma_mask using the
> mask instead of the maskbits. However, this does not solves the deadlock.
The deadlock is a bigger concern I think.
> Interestingly, the problem looks like a compiler one. Calling
> rte
rte_mp_request_sync() says that the caller is responsible
for freeing one of its parameters afterwards. EAL didn't
do that, causing a memory leak.
Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Cc: qi.z.zh...@intel.com
Cc: anatoly.bura...@intel.com
Signed-off-by: Darek Stojaczyk
--
> -Original Message-
> From: Yongseok Koh
> Sent: Saturday, October 27, 2018 1:43
> To: Slava Ovsiienko
> Cc: Shahaf Shuler ; dev@dpdk.org
> Subject: Re: [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices
> management
>
> On Fri, Oct 26, 2018 at 02:35:24AM -0700, Slava Ovsiienko wrote
> -Original Message-
> From: Burakov, Anatoly
> Sent: Friday, October 26, 2018 4:22 PM
> To: Stojaczyk, Dariusz ; dev@dpdk.org
> Cc: Zhang, Qi Z ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak
> on device hotplug
>
>
>
> This is correct but incom
Check should be on parameter uio_fd instead of
local variable job_ring
Fixes: e7a45f3cc2 ("crypto/caam_jr: add UIO specific operations")
Signed-off-by: Gagandeep Singh
---
changes:
* fixed incorrect check in free_job_ring (comment by Ferruh)
drivers/crypto/caam_jr/caam_jr_uio.c | 2 +-
1 file
Hi
> -Original Message-
> From: Ferruh Yigit
> Sent: Sunday, October 28, 2018 6:05 AM
> To: Gagandeep Singh ; dev@dpdk.org; Akhil Goyal
>
> Cc: Hemant Agrawal
> Subject: Re: [dpdk-dev] [PATCH v5 04/15] crypto/caam_jr: add UIO specific
> operations
>
> On 10/22/2018 3:57 PM, Gagandeep S
On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon
wrote:
> 29/10/2018 12:39, Alejandro Lucero:
> > I got a patch that solves a bug when calling rte_eal_dma_mask using the
> > mask instead of the maskbits. However, this does not solves the deadlock.
>
> The deadlock is a bigger concern I think.
>
>
From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
Sent: Monday, October 29, 2018 8:56 PM
To: Thomas Monjalon
Cc: Yao, Lei A ; dev ; Xu, Qian Q
; Lin, Xueqin ; Burakov, Anatoly
; Yigit, Ferruh
Subject: Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask
On Mon, Oct 2
On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote:
>
>
>
>
> *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
> *Sent:* Monday, October 29, 2018 8:56 PM
> *To:* Thomas Monjalon
> *Cc:* Yao, Lei A ; dev ; Xu, Qian Q <
> qian.q...@intel.com>; Lin, Xueqin ; Burakov,
> Anatoly ; Yigit
> On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote:
>> On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote:
>> > A Kbuild is also included to allow users to use DKMS natively
>> > without
>> > additional code.
>> >
>> > Signed-off-by: Luca Boccassi
>> > ---
>> > v2: add local d
29/10/2018 14:40, Alejandro Lucero:
> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote:
> > *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
> > On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon
> > wrote:
> >
> > 29/10/2018 12:39, Alejandro Lucero:
> > > I got a patch that solves
> -Original Message-
> From: Stojaczyk, Dariusz
> Sent: Monday, October 29, 2018 7:02 AM
> To: Burakov, Anatoly ; dev@dpdk.org
> Cc: Zhang, Qi Z ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on
> device hotplug
>
> > -Original Message-
Hi Stepehen,
> > > This is a very big macro, better have static function for this instead of
> macro.
> > >
> >
> > There are two thoughts in choosing MACRO over function.
> > 1. The information need to display in certain format within the same
> > context.
> > 2. As the API are modified, co lo
On Mon, Oct 29, 2018 at 2:18 PM Thomas Monjalon wrote:
> 29/10/2018 14:40, Alejandro Lucero:
> > On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote:
> > > *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
> > > On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon
> > > wrote:
> > >
> >
Thanks, PSB.
> -Original Message-
> From: Shahaf Shuler
> Sent: Monday, October 29, 2018 12:03 PM
> To: Dekel Peled ; Yongseok Koh
>
> Cc: dev@dpdk.org; Ori Kam
> Subject: RE: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to
> Direct Verbs flow in MLX5 PMD
>
> Hi Dekel,
>
> Thu
On Mon, 2018-10-29 at 17:09 +0300, Ilya Maximets wrote:
> > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote:
> > > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote:
> > > > A Kbuild is also included to allow users to use DKMS natively
> > > > without
> > > > additional code.
On Fri, Oct 5, 2018 at 2:47 PM Alejandro Lucero
wrote:
>
> Linux kernel uses a really high address as starting address for
> serving mmaps calls. If there exist addressing limitations and
> IOVA mode is VA, this starting address is likely too high for
> those devices. However, it is possible to us
> -Original Message-
> From: Yigit, Ferruh
> Sent: Saturday, October 27, 2018 6:09 PM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org
> Subject: [PATCH 2/3] service: fix possible NULL access
>
> Fixes: 21698354c832 ("service: introduce service cores concept")
>
Please find comments inline.
> -Original Message-
> From: Yongseok Koh
> Sent: Wednesday, October 03, 2018 9:56 PM
> To: Ophir Munk
> Cc: dev@dpdk.org; Asaf Penso ; Shahaf Shuler
> ; Thomas Monjalon ;
> Olga Shern
> Subject: Re: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS
> -Original Message-
> From: Shahaf Shuler
> Sent: Sunday, October 07, 2018 2:21 PM
> To: Yongseok Koh ; Ophir Munk
>
> Cc: dev@dpdk.org; Asaf Penso ; Thomas Monjalon
> ; Olga Shern
> Subject: RE: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS
>
> > > On Oct 3, 2018, at 10:3
Hi Dariousz,
On Mon, Oct 29, 2018 at 4:08 PM Dariusz Stojaczyk
wrote:
> On Fri, Oct 5, 2018 at 2:47 PM Alejandro Lucero
> wrote:
> >
> > Linux kernel uses a really high address as starting address for
> > serving mmaps calls. If there exist addressing limitations and
> > IOVA mode is VA, this s
Thanks, PSB.
> -Original Message-
> From: Shahaf Shuler
> Sent: Monday, October 29, 2018 12:03 PM
> To: Dekel Peled ; Yongseok Koh
>
> Cc: dev@dpdk.org; Ori Kam
> Subject: RE: [dpdk-dev] [PATCH v6 2/6] net/mlx5: add VXLAN encap action to
> Direct Verbs
>
> Hi Dekel,
>
> Thursday, Octob
Thanks, PSB.
> -Original Message-
> From: Shahaf Shuler
> Sent: Monday, October 29, 2018 12:03 PM
> To: Dekel Peled ; Yongseok Koh
>
> Cc: dev@dpdk.org; Ori Kam
> Subject: RE: [dpdk-dev] [PATCH v6 3/6] net/mlx5: add VXLAN decap action to
> Direct Verbs
>
> Thursday, October 25, 2018 11:
Thanks, PSB.
> -Original Message-
> From: Shahaf Shuler
> Sent: Monday, October 29, 2018 12:03 PM
> To: Dekel Peled ; Yongseok Koh
>
> Cc: dev@dpdk.org; Ori Kam
> Subject: RE: [dpdk-dev] [PATCH v6 6/6] net/mlx5: add raw data encap decap
> to Direct Verbs
>
> Thursday, October 25, 2018 1
Add freeing of allocated memroy before exiting on mlx5dv error.
Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")
Cc: or...@mellanox.com
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_flow_dv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers
Hi Jerin,
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Saturday, October 27, 2018 9:48 AM
> To: dev@dpdk.org; Trahe, Fiona ; De Lara Guarch, Pablo
> ; Gupta, Ashish
> Cc: tho...@monjalon.net; Jacob, Jerin
> Subject: [dpdk-dev] [PATCH] compress/
> On Oct 28, 2018, at 11:03 PM, Ori Kam wrote:
>
> Why should DV prepare function return the list of actions?
>
> The only reason I can think of, is if you want to remove the for loop in
> dv_translate. And then in flow_dv_create_action change the switch case
> to ifs.
Then, I should ask you a
On Mon, Oct 29, 2018 at 02:33:03AM -0700, Slava Ovsiienko wrote:
> > -Original Message-
> > From: Yongseok Koh
> > Sent: Saturday, October 27, 2018 0:57
> > To: Slava Ovsiienko
> > Cc: Shahaf Shuler ; dev@dpdk.org
> > Subject: Re: [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation
> >
On Mon, Oct 29, 2018 at 04:53:34AM -0700, Slava Ovsiienko wrote:
> > -Original Message-
> > From: Yongseok Koh
> > Sent: Saturday, October 27, 2018 1:43
> > To: Slava Ovsiienko
> > Cc: Shahaf Shuler ; dev@dpdk.org
> > Subject: Re: [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices
> >
> On Oct 29, 2018, at 9:09 AM, Dekel Peled wrote:
>
> Add freeing of allocated memroy before exiting on mlx5dv error.
>
> Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")
> Cc: or...@mellanox.com
>
> Signed-off-by: Dekel Peled
> ---
Nice catch!
Acked-by: Yongseok Koh
T
> On Oct 29, 2018, at 7:18 AM, Thomas Monjalon wrote:
>
> 29/10/2018 14:40, Alejandro Lucero:
>> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote:
>>> *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
>>> On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon
>>> wrote:
>>>
>>> 29/1
On Mon, Oct 29, 2018 at 6:54 PM Yongseok Koh wrote:
>
> > On Oct 29, 2018, at 7:18 AM, Thomas Monjalon
> wrote:
> >
> > 29/10/2018 14:40, Alejandro Lucero:
> >> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote:
> >>> *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com]
> >>> On Mon,
It looks like it's choking on a figure in the mvpp2.rst file:
guides/nics/mvpp2.rst:.. figure:: img/mvpp2_tm.svg
Reverting commit 0ba610ca1d178cbeedba6e033ee399dfe773801e fixes it.
This fixes it too:
diff --git a/doc/guides/nics/mvpp2.rst b/doc/guides/nics/mvpp2.rst
index 59fa0e10d..10303a1c1 1
Don't use .svg extension on ..figure references. PDF versions of
the documents use .png images generated from the .svg images.
Fixes: 0ba610ca1d17 ("net/mvpp2: document MTR and TM usage")
Cc: nsams...@marvell.com
Signed-off-by: Dan Gora
---
doc/guides/nics/mvpp2.rst | 2 +-
1 file changed, 1 i
Add txqs_min_vec parameter to configure the maximum number of Tx queues to
enable vectorized Tx. And its default value is set according to the
architecture and device type.
Signed-off-by: Yongseok Koh
---
doc/guides/nics/mlx5.rst | 16 +++-
drivers/net/mlx5/mlx5.c |
Hi,
The commit 6e20a08 ("test/pmd_ring: restructure and cleanup") has already fixed
this issue.
Abandon this one.
Thanks,
Phil Yang
> -Original Message-
> From: dev On Behalf Of Phil Yang
> Sent: Friday, October 19, 2018 7:12 PM
> To: dev@dpdk.org
> Cc: nd
> Subject: [dpdk-dev] [PATCH
Hi Lucero&Thomas,
Find the patch can’t fix multi-process cases.
Steps:
1. Setup primary process successfully
./hotplug_mp --proc-type=auto
2. Fail to setup secondary process
./hotplug_mp --proc-type=auto
EAL: Detected 88 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Auto-detected p
The change adds note for previous colour in colour blind and DROP
in profile table actions. In colour blind mode only valid previous
colour is GREEN. To drop packets based on new colour one needs to
set action as DROP in profile table.
Signed-off-by: Vipin Varghese
---
V2:
changed wording from 0
Patches has to be validated for meson builds. Updating documentation
for meson build steps in Checking Compilation category.
Signed-off-by: Vipin Varghese
---
doc/guides/contributing/patches.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/contributing/patches.rst
b/d
60 matches
Mail list logo
