> On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: >> On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: >> > A Kbuild is also included to allow users to use DKMS natively >> > without >> > additional code. >> > >> > Signed-off-by: Luca Boccassi <bluca at debian.org> >> > --- >> > v2: add local directory to -I and build sources list recursively to >> > fix build on Fedora >> > >> >> Yep, now seems to build for me on Fedora. One minor suggestion is to >> look >> to use the "console" keyword on the custom_target if possible. It >> should >> help prevent noticable stalls as make runs in the background. >> [Unfortunately, it's meson 0.48 onward only, so if conditionals are >> needed, >> just ignore this suggestion] > > Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there are > no complaints or errors, it's simply ignored in the older versions.
Hmm. I have following on my Ubuntu 18.04 with dpdk v18.11-rc1: $ meson --version 0.45.1 $ meson build <...> kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument "console". WARNING: This will become a hard error in the future. WARNING: Unknown keyword arguments in target rte_kni: console <...> It builds, but prints above warning. Best regards, Ilya Maximets. > >> Also, do we want to use "make -j" for this, given the number of >> files? >> [Maybe -j4 just?] > > Yeah makes sense, added j4. > > Sent v3 with both changes and the ack, thanks. > > -- > Kind regards, > Luca Boccassi
