Hi > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@intel.com> > Sent: Sunday, October 28, 2018 6:05 AM > To: Gagandeep Singh <g.si...@nxp.com>; dev@dpdk.org; Akhil Goyal > <akhil.go...@nxp.com> > Cc: Hemant Agrawal <hemant.agra...@nxp.com> > Subject: Re: [dpdk-dev] [PATCH v5 04/15] crypto/caam_jr: add UIO specific > operations > > On 10/22/2018 3:57 PM, Gagandeep Singh wrote: > > caam_jr need support from kernel caam driver for job ring > > initialisation. So to access register space for job ring and allow re > > configure and map to userspace UIO interface is used. This also allows > > to handle the caam interrupts from the user space. > > > > This patch adds UIO specific operations > > > > Signed-off-by: Gagandeep Singh <g.si...@nxp.com> > > Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com> > > Acked-by: Akhil Goyal <akhil.go...@nxp.com> > > <...> > > > +void > > +free_job_ring(uint32_t uio_fd) > > +{ > > + struct uio_job_ring *job_ring = NULL; > > + int i; > > + > > + if (!job_ring->uio_fd) > > + return; > > It seems this function is not called. Can the intention be: > > if (!uio_fd) > return;
Patch has been sent http://patchwork.dpdk.org/patch/47557/