Re: [dpdk-dev] [PATCH v6] net/pcap: physical interface MAC address support

2018-10-01 Thread Kuusisaari, Juhamatti (Coriant - FI/Espoo)
Hello Ferruh, > On 9/10/2018 5:55 PM, Juhamatti Kuusisaari wrote: > > At the moment, PCAP interfaces use dummy MAC by default. This change > > adds support for selecting PCAP physical interface MAC with phy_mac=1 > > devarg. This allows to setup packet flows using the physical interface > > MAC.

Re: [dpdk-dev] [PATCH v1 4/5] pci: add req handler field to generic pci device

2018-10-01 Thread Burakov, Anatoly
On 29-Sep-18 7:15 AM, Jeff Guo wrote: On 9/26/2018 8:22 PM, Burakov, Anatoly wrote: On 17-Aug-18 11:51 AM, Jeff Guo wrote: There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, it could be useful for device error monitor

Re: [dpdk-dev] [PATCH v11 0/7] hot-unplug failure handle mechanism

2018-10-01 Thread Stephen Hemminger
On Sun, 30 Sep 2018 19:29:56 +0800 Jeff Guo wrote: > Hotplug is an important feature for use-cases like the datacenter device's > fail-safe and for SRIOV Live Migration in SDN/NFV. It could bring higher > flexibility and continuality to networking services in multiple use-cases > in the industry.

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Bruce Richardson
On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > Allow users and packagers to override the default dpdk/drivers > subdirectory where the PMDs get installed under $lib. > > Signed-off-by: Luca Boccassi > --- I'm ok with this change, but what is the current location used by distro'

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Bruce Richardson
On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > Allow users and packagers to override the default dpdk/drivers > > subdirectory where the PMDs get installed under $lib. > > > > Signed-off-by: Luca Boccassi > >

[dpdk-dev] [PATCH v6 1/8] net/mvneta: add neta PMD skeleton

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add neta pmd driver skeleton providing base for the further development. Signed-off-by: Natalie Samsonov Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak Signed-off-by: Andrzej Ostruszka --- MAINTAINERS

[dpdk-dev] [PATCH v6 2/8] net/mvneta: add Rx/Tx support

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add part of PMD for actual reception/transmission. Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 3 + doc/guides/nics/mvneta.rst | 4 + drivers/net/mvneta/Makefile |

[dpdk-dev] [PATCH v6 0/8] Add Marvell NETA PMD

2018-10-01 Thread Andrzej Ostruszka
From: Andrzej Ostruszka This patch series introduces new PMD for Marvell NETA adapters (MVNETA). See the documentation for more info. It is split for easier reviewing. v6: * add missing call to rte_eth_dev_probing_finish() * update doc to point to MUSDK 18.09 * add mvep lib to LDLIBS in m

[dpdk-dev] [PATCH v6 3/8] net/mvneta: support for setting of MTU

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add callback for setting of MTU. Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 78 + 3 files chang

[dpdk-dev] [PATCH v6 5/8] net/mvneta: support for promiscuous

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add callbacks for enabling/disabling of promiscuous mode. Signed-off-by: Yelena Krivosheev Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 54 ++

[dpdk-dev] [PATCH v6 4/8] net/mvneta: add link update

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add callback for updating information about link status/info. Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 71 +++

[dpdk-dev] [PATCH v6 6/8] net/mvneta: add MAC filtering

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add callbacks for adding/removing MAC addresses. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev.c | 69 ++

[dpdk-dev] [PATCH v6 8/8] net/mvneta: add reset statistics callback

2018-10-01 Thread Andrzej Ostruszka
From: Natalie Samsonov Add support for resetting of driver statistics. Signed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 40 +++--- drivers/net/mvneta/mvneta_ethdev.h | 1 + 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/

[dpdk-dev] [PATCH v6 7/8] net/mvneta: add support for basic stats

2018-10-01 Thread Andrzej Ostruszka
From: Zyta Szpak Add support for getting of basic statistics for the driver. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- doc/guides/nics/features/mvneta.ini | 1 + doc/guides/nics/mvneta.rst | 1 + drivers/net/mvneta/mvneta_ethdev

Re: [dpdk-dev] [PATCH v5 1/8] net/mvneta: add neta PMD skeleton

2018-10-01 Thread Andrzej Ostruszka
First of all sorry for late reply. I was trying to do some more testing with this NETA and got stuck into what turned out to be HW issue. On 24.09.2018 12:03, Ferruh Yigit wrote: > On 9/20/2018 10:05 AM, Andrzej Ostruszka wrote: [...] >> +MVNETA_LOG(INFO, "Perform MUSDK initializations"); >>

Re: [dpdk-dev] [PATCH 1/4] driver/crypto: enable meson support for the aesni gcm

2018-10-01 Thread Bruce Richardson
On Sat, Sep 29, 2018 at 01:00:58PM +0100, Hari Kumar Vemula wrote: > Added new meson.build files for aesni_gcm > Exported dependency library path through meson_options.txt file > > Signed-off-by: Hari Kumar Vemula > --- > drivers/crypto/aesni_gcm/meson.build | 17 + > drivers/cry

Re: [dpdk-dev] [PATCH v5 1/8] net/mvneta: add neta PMD skeleton

2018-10-01 Thread Andrzej Ostruszka
On 24.09.2018 11:38, Ferruh Yigit wrote: > On 9/24/2018 10:35 AM, Ferruh Yigit wrote: [...] >>> Is there a specific build param required for musdk for neta support? >> >> I found it: --enable-bpool-dma=64 --enable-pp2=no --enable-neta, > > btw, getting "configure: WARNING: unrecognized options: --

Re: [dpdk-dev] [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc

2018-10-01 Thread Bruce Richardson
On Sun, Sep 30, 2018 at 11:01:38AM +0100, Luca Boccassi wrote: > On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote: > > 1/4: enablement of aesni_gcm pmd in meson 2/4: enablement of aesni_mb > > pmd in meson 3/4: enablement of kasumi pmd enable in meson 4/4: > > enablement of zuc pmd enable

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Luca Boccassi
On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > Allow users and packagers to override the default dpdk/drivers > > > subdirectory where the PMDs ge

Re: [dpdk-dev] [PATCH v2 2/4] eal: modify device event callback process func

2018-10-01 Thread Andrew Rybchenko
On 9/30/18 5:16 PM, Jeff Guo wrote: This patch modify the device event callback process function name to be more explicit, change the variable to be const and exposure the API out from private eal. The bus drivers and eal device would directly use this API to process device event callback. Sorr

Re: [dpdk-dev] [PATCH v2 3/4] pci: add req handler field to generic pci device

2018-10-01 Thread Andrew Rybchenko
On 9/30/18 5:16 PM, Jeff Guo wrote: There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, they could be useful for device error monitoring. And these corresponding interrupt handler is different from the other interrupt handl

Re: [dpdk-dev] [PATCH v2 1/4] eal: add a new req notifier to eal interrupt

2018-10-01 Thread Andrew Rybchenko
On 9/30/18 5:16 PM, Jeff Guo wrote: Add a new req notifier in eal interrupt for enable vfio hotplug. Signed-off-by: Jeff Guo --- v2->v1: no change --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++ 2

Re: [dpdk-dev] [PATCH v2 4/4] vfio: enable vfio hotplug by req notifier handler

2018-10-01 Thread Andrew Rybchenko
On 9/30/18 5:16 PM, Jeff Guo wrote: When device is be hot-unplugged, the vfio kernel module will sent req notifier to request user space to release the allocated resources at first. After that, vfio kernel module will detect the device disappear, and then delete the device in kernel. This patch

[dpdk-dev] "Incompatible UPT version” error when running DPDK on VMWare with VMXNET3 interface ,ESXI Version 6.5/6.7

2018-10-01 Thread Puneet singh
Hi Everyone, We're trying to run DPDK test-pmd app in a guest machine running Red Hat 7.5. The host is ESXi version 6.5/6.7. I'm building dpdk on the guest machine , I've tried both DPDK versions 18.08 and 17.11. We have created three interfaces on esxi for connection to our guest. One manage

Re: [dpdk-dev] [PATCH v11 0/7] hot-unplug failure handle mechanism

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Mon, 1 Oct 2018 11:00:12 +0200 > From: Stephen Hemminger > To: Jeff Guo > Cc: bruce.richard...@intel.com, ferruh.yi...@intel.com, > konstantin.anan...@intel.com, gaetan.ri...@6wind.com, > jingjing...@intel.com, tho...@monjalon.net, mo...@mellanox.com, > ma...

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Bruce Richardson
On Mon, Oct 01, 2018 at 10:46:02AM +0100, Luca Boccassi wrote: > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > > Allow users and packagers to

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-01 Thread Thomas Monjalon
24/09/2018 13:36, Joseph, Anoob: > Hi Fiona, > > Can you please comment on this? > > We are adding all capabilities of octeontx-crypto PMD as a macro in > otx_cryptodev_capabilites.h file and then we are using it from > otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. As >

[dpdk-dev] [PATCH v9 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-10-01 Thread Liang Ma
Add empty poll mode command line example ChangeLogs: v9: update the document Signed-off-by: Liang Ma --- doc/guides/sample_app_ug/l3_forward_power_man.rst | 69 +++ 1 file changed, 69 insertions(+) diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides

Re: [dpdk-dev] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 12:49:04 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , > vipin.vargh...@intel.com, sta...@dpdk.org > Subject: [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for > skeleton PMD > X-Mailer:

Re: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Fri, 28 Sep 2018 17:11:33 +0530 > From: pavan.bhagavat...@cavium.com > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support > X-Mailer: git-send-email 2.19.0 > > From: Pava

[dpdk-dev] [PATCH v4] port: add sym crypto port

2018-10-01 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch adds the symmetric crypto support to port library. The crypto port acts as a shim layer to DPDK cryptodev library and supports in-place crypto workload processing. Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- v4: - fixed a compiler warning

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Timothy Redaelli
On Mon, 01 Oct 2018 10:46:02 +0100 Luca Boccassi wrote: > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > > Allow users and packagers to

Re: [dpdk-dev] [PATCH 2/4] hash: add memory ordering to avoid race conditions

2018-10-01 Thread Ola Liljedahl
On 28/09/2018, 02:43, "Wang, Yipeng1" wrote: Some general comments for the various __atomic_store/load added, 1. Although it passes the compiler check, but I just want to confirm that if we should use GCC/clang builtins, or if There are higher level APIs in DPDK to do atomic

[dpdk-dev] [PATCH v2] app/testpmd: fix metering and policing cli command

2018-10-01 Thread Jasvinder Singh
Fixes bad arguments error for cli commands related to adding meter profile for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. error log: testpmd> add port meter profile trtcm_rfc2698 2 0 312500 312500 250 250 Bad arguments Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic m

Re: [dpdk-dev] [PATCH v5 10/10] doc/vm_power_manager: add JSON interface API info

2018-10-01 Thread Hunt, David
Hi Lei, On 29/9/2018 3:42 AM, Yao, Lei A wrote: +:Pair Name: "avg_packet_thresh" +:Description: Threshold below which the frequency will be set to min for + the TRAFFIC policy. If the traffic rate is above this and below max, the + frequency will be set to medium. +:Type: integer +:Values: Th

Re: [dpdk-dev] [PATCH v5 07/10] examples/power: add json string handling

2018-10-01 Thread Hunt, David
Hi Lei, On 30/9/2018 2:54 AM, Yao, Lei A wrote: +#ifdef USE_JANSSON +static int +parse_json_to_pkt(json_t *element, struct channel_packet *pkt) +{ + const char *key; + json_t *value; + int ret; + + memset(pkt, 0, sizeof(struct channel_packet)); + + pkt->nb_mac_to_m

Re: [dpdk-dev] [PATCH] doc: fix eventdev shared library version

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 18:42:41 +0530 > From: Jerin Jacob > To: dev@dpdk.org > Cc: tho...@monjalon.net, nikhil@intel.com, Jerin Jacob > , sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix eventdev shared library version > X-Mailer: git-send-email 2.19.0 > >

[dpdk-dev] [PATCH v7 00/21] Support externally allocated memory in DPDK

2018-10-01 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH v7 04/21] mem: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

[dpdk-dev] [PATCH v7 12/21] malloc: allow destroying heaps

2018-10-01 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH v7 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-10-01 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. Signed-off-by: Anatoly Burakov --- config/common_base

[dpdk-dev] [PATCH v7 01/21] mem: add length to memseg list

2018-10-01 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. Signed-off-by: Anatoly Burakov Acked-by: Shr

[dpdk-dev] [PATCH v7 10/21] malloc: add function to check if socket is external

2018-10-01 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v7 11/21] malloc: allow creating malloc heaps

2018-10-01 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst| 2 + .../common/include/rte_eal_memconfig.h| 3 ++

[dpdk-dev] [PATCH v7 21/21] doc: add external memory feature to programmer's guide

2018-10-01 Thread Anatoly Burakov
Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 37 +++ 1 file changed, 37 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guid

[dpdk-dev] [PATCH v7 20/21] doc: add external memory feature to the release notes

2018-10-01 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 5065ec1af..4248ff4f9

[dpdk-dev] [PATCH v7 19/21] app/testpmd: add support for external memory

2018-10-01 Thread Anatoly Burakov
Currently, mempools can only be allocated either using native DPDK memory, or anonymous memory. This patch will add two new methods to allocate mempool using external memory (regular or hugepage memory), and add documentation about it to testpmd user guide. It adds a new flag "--mp-alloc", with fo

[dpdk-dev] [PATCH v7 05/21] flow_classify: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Bernard Iremonger --- lib/librte_flow_classify/rte_flow_cl

[dpdk-dev] [PATCH v7 18/21] test: add unit tests for external memory support

2018-10-01 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v7 16/21] malloc: allow detaching from external memory

2018-10-01 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 +++ lib/librte_eal/common/rte_malloc.c | 31 +- lib/librte_eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v7 17/21] malloc: enable event callbacks for external memory

2018-10-01 Thread Anatoly Burakov
When adding or removing external memory from the memory map, there may be actions that need to be taken on account of this memory (e.g. DMA mapping). Add support for triggering callbacks when adding, removing, attaching or detaching external memory. Some memory event callback handlers will need ad

[dpdk-dev] [PATCH v7 06/21] pipeline: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline.c

[dpdk-dev] [PATCH v7 15/21] malloc: allow attaching to external memory chunks

2018-10-01 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH v7 09/21] malloc: add function to query socket ID of named heap

2018-10-01 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH v7 13/21] malloc: allow adding memory to named heaps

2018-10-01 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH v7 08/21] malloc: add name to malloc heaps

2018-10-01 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst |

[dpdk-dev] [PATCH v7 07/21] sched: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_sched/rte_sched.c | 2 +

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Bruce Richardson
On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote: > On Mon, 01 Oct 2018 10:46:02 +0100 > Luca Boccassi wrote: > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > > On Fri, Sep 28, 2018 at

[dpdk-dev] [PATCH v7 02/21] mem: allow memseg lists to be marked as external

2018-10-01 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so bump the EAL library ABI version and document the change in r

[dpdk-dev] [PATCH v7 14/21] malloc: allow removing memory from named heaps

2018-10-01 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-01 Thread Luca Boccassi
On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote: > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote: > > On Mon, 01 Oct 2018 10:46:02 +0100 > > Luca Boccassi wrote: > > > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > > > On Mon, Oct 01, 2018 at 10:17

Re: [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions

2018-10-01 Thread Andrew Rybchenko
On 9/28/18 7:21 PM, Thomas Monjalon wrote: rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it has been renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their imple

Re: [dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function

2018-10-01 Thread Andrew Rybchenko
On 9/28/18 7:21 PM, Thomas Monjalon wrote: The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future.

Re: [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

2018-10-01 Thread Andrew Rybchenko
On 9/28/18 7:21 PM, Thomas Monjalon wrote: These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v3 4/4] eal: simplify parameters of hotplug functions

2018-10-01 Thread Andrew Rybchenko
On 9/28/18 7:21 PM, Thomas Monjalon wrote: All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex an

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-10-01 Thread Akhil Goyal
Hi Konstantin, On 10/1/2018 2:30 AM, Ananyev, Konstantin wrote: Hi Akhil, Hi Konstantin, On 9/24/2018 4:21 PM, Ananyev, Konstantin wrote: Hi Akhil, Hi Konstantin, On 9/18/2018 6:12 PM, Ananyev, Konstantin wrote: I am not saying this should be the ONLY way to do as it does not work very

[dpdk-dev] [PATCH v8 05/21] flow_classify: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Bernard Iremonger --- lib/librte_flow_classify/rte_flow_cl

[dpdk-dev] [PATCH v8 08/21] malloc: add name to malloc heaps

2018-10-01 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. This breaks the ABI, so document the change. Signed-off-by: Anatoly Burakov --- doc/

[dpdk-dev] [PATCH v8 01/21] mem: add length to memseg list

2018-10-01 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. This breaks ABI, so bump the EAL ABI version

[dpdk-dev] [PATCH v8 09/21] malloc: add function to query socket ID of named heap

2018-10-01 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH v8 12/21] malloc: allow destroying heaps

2018-10-01 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH v8 11/21] malloc: allow creating malloc heaps

2018-10-01 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. This breaks the ABI, so document the change. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst| 2 + .../comm

[dpdk-dev] [PATCH v8 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-10-01 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. This breaks the ABI, so document the changes. Signed-off-by:

[dpdk-dev] [PATCH v8 15/21] malloc: allow attaching to external memory chunks

2018-10-01 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH v8 17/21] malloc: enable event callbacks for external memory

2018-10-01 Thread Anatoly Burakov
When adding or removing external memory from the memory map, there may be actions that need to be taken on account of this memory (e.g. DMA mapping). Add support for triggering callbacks when adding, removing, attaching or detaching external memory. Some memory event callback handlers will need ad

[dpdk-dev] [PATCH v8 21/21] doc: add external memory feature to programmer's guide

2018-10-01 Thread Anatoly Burakov
Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 37 +++ 1 file changed, 37 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guid

[dpdk-dev] [PATCH v8 14/21] malloc: allow removing memory from named heaps

2018-10-01 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

[dpdk-dev] [PATCH v8 19/21] app/testpmd: add support for external memory

2018-10-01 Thread Anatoly Burakov
Currently, mempools can only be allocated either using native DPDK memory, or anonymous memory. This patch will add two new methods to allocate mempool using external memory (regular or hugepage memory), and add documentation about it to testpmd user guide. It adds a new flag "--mp-alloc", with fo

[dpdk-dev] [PATCH v8 06/21] pipeline: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline.c

[dpdk-dev] [PATCH v8 20/21] doc: add external memory feature to the release notes

2018-10-01 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index cb6308b1f..9c5f24af

[dpdk-dev] [PATCH v8 10/21] malloc: add function to check if socket is external

2018-10-01 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v8 04/21] mem: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

[dpdk-dev] [PATCH v8 18/21] test: add unit tests for external memory support

2018-10-01 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v8 07/21] sched: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_sched/rte_sched.c | 2 +

[dpdk-dev] [PATCH v8 16/21] malloc: allow detaching from external memory

2018-10-01 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 +++ lib/librte_eal/common/rte_malloc.c | 31 +- lib/librte_eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v8 00/21] Support externally allocated memory in DPDK

2018-10-01 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH v8 02/21] mem: allow memseg lists to be marked as external

2018-10-01 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so document the change in release notes. This also breaks a few

[dpdk-dev] [PATCH v8 13/21] malloc: allow adding memory to named heaps

2018-10-01 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-01 Thread Iremonger, Bernard
Hi Jens, > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Friday, September 21, 2018 2:27 PM > To: dev@dpdk.org > Cc: ai...@redhat.com; jan.scheur...@ericsson.com; Richardson, Bruce > ; tho...@monjalon.net; > maxime.coque...@redhat.com; Ananyev, Konstantin >

Re: [dpdk-dev] [PATCH 0/3] crypto/mvsam: align with MUSDK 18.09

2018-10-01 Thread Akhil Goyal
On 9/4/2018 7:29 PM, Tomasz Duszynski wrote: This patch series aligns MVSAM PMD with MUSDK 18.09. Dmitri Epshtein (2): doc: update mvsam documentation crypto/mvsam: get number of CIOs dynamically Tomasz Duszynski (1): crypto/mvsam: update features list doc/guides/cryptodevs/featu

Re: [dpdk-dev] [PATCH v2 0/3] crypto/mvsam: yet another round of features

2018-10-01 Thread Akhil Goyal
On 9/21/2018 6:54 PM, Andrzej Ostruszka wrote: Following changes are introduced in this patch series: * Add S/G support. * Start using common/mvep for DMA memory initialization. * Add dynamic logging support. Note that 'crypto/mvsam: common use initialization' relies on 'net/mvpp2: use commo

[dpdk-dev] [PATCH 0/3] app: add initial version of compress-perf

2018-10-01 Thread Tomasz Jozwiak
This patchset adds initial version of compression performance test. Tomasz Jozwiak (3): app/compress-perf: add parser app/compress-perf: add performance measurement doc/guides/tools: add doc file MAINTAINERS | 5 + app/Makefile

[dpdk-dev] [PATCH 3/3] doc/guides/tools: add doc file

2018-10-01 Thread Tomasz Jozwiak
Added initial version of compression performance test description file. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- MAINTAINERS| 5 +++ doc/guides/tools/comp_perf.rst | 73 ++ 2 files changed, 78 insertions(

[dpdk-dev] [PATCH 1/3] app/compress-perf: add parser

2018-10-01 Thread Tomasz Jozwiak
Added parser part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/Makefile | 4 + app/meson.build | 1 + app/test-compress-perf/Makefile | 16 + app

[dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-01 Thread Tomasz Jozwiak
Added performance measurement part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/main.c | 844 ++ 1 file changed, 844 insertions(+) diff --git a/app/test-compress-perf/main.c b/

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-10-01 Thread Akhil Goyal
On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote: This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: sta...@dpdk.org to couple of patches

Re: [dpdk-dev] [PATCH] compressdev: fix compression api description

2018-10-01 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, September 28, 2018 2:14 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; sta...@dpdk.org; akhil.go...@nxp.com > Subject: [PATCH] compressdev: fix compression api description > > This patch fixes description of API f

Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Cc: sta...@dpdk.org > Cc: jiayu...@intel.com > > Signed-off-by: Jerin Jacob > --- > lib/librte_mbuf/rte_mbuf.h | 3 ++- >

Re: [dpdk-dev] [PATCH 4/4] ethdev: add Tx offload outer L4 checksum definitions

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM, DEV_TX_OFFLOAD_OUTER_TCP_CKSUM > and DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and > > PKT_TX_OUTER_L4_NO_CKSUM, PKT_TX_OUTER_TCP_CKSUM, PKT_TX_OUTER_SCTP_CKSUM > and PKT_TX_OUTER_UDP_CKSUM mbuf ol_flags to e

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob > --- > app/test-pmd/config.c | 9 + > doc/guides/nics/features.rst | 4 ++-- > lib/librte_ethdev/rte_ethdev.c | 1 + > lib/librte_ethdev/rte_ethdev.h | 1 + > 4 files changed, 13 insertions(+), 2 deletions(-

  1   2   >