Re: [dpdk-dev] [PATCH v2 1/3] ethdev: support metadata as flow rule criteria

2018-09-18 Thread Xueming(Steven) Li
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Sunday, September 16, 2018 10:38 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; > dev@dpdk.org; > olivier.m...@6wind.com; Adrien Mazarguil ; Thomas > Monjalon > ; ferruh.yi...@intel.co

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-09-18 Thread Xiaoyu Min
> > static int > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index f8ba71cdb..48c3c606e 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1505,6 +1505,34 @@ enum rte_flow_action_type { >* error. >*/ > RTE_F

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support metadata as flow rule criteria

2018-09-18 Thread Xueming(Steven) Li
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Sunday, September 16, 2018 10:38 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; > dev@dpdk.org; > olivier.m...@6wind.com; Adrien Mazarguil ; Thomas > Monjalon > ; ferruh.yi...@intel.co

[dpdk-dev] [PATCH v1] e1000: support dev reset

2018-09-18 Thread Gaetan Rivet
Add support for passive device reset on IGB ports. Signed-off-by: Gaetan Rivet --- drivers/net/e1000/igb_ethdev.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 64dfe6836..4dbf46b28 100644 -

[dpdk-dev] [PATCH v1] testpmd: eeprom display

2018-09-18 Thread Gaetan Rivet
The interactive command show port eeprom will dump the content of the EEPROM for the selected port. Dumping eeprom of all ports at once is not supported. Signed-off-by: Gaetan Rivet --- app/test-pmd/cmdline.c | 9 +++-- app/test-pmd/config.c | 32 app/

[dpdk-dev] DEV_RX_OFFLOAD_SCATTER not available in i40e an cxgbe

2018-09-18 Thread Martin Weiser
Hi, is there a specific reason that the rx offload capability DEV_RX_OFFLOAD_SCATTER is not available in the i40e and cxgbe drivers in DPDK 18.08? We previously used this feature with DPDK 17.11 to handle jumbo frames while using 2k mbufs and it worked without a problem. It also seems that simply

Re: [dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-09-18 Thread Xiaoyu Min
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 638331c17..f60be0862 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3713,6 +3713,14 @@ This section lists suppo

[dpdk-dev] [PATCH v6] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-18 Thread Jens Freimann
This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footprint utilization from va

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-09-18 Thread Thomas Monjalon
25/07/2018 20:20, Stephen Hemminger: > No need for profanity in comments. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnx2x/elink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c > index 34a29373af3

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-09-18 Thread Thomas Monjalon
26/07/2018 11:41, Burakov, Anatoly: > On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: > > There is no need to call rte_exit and crash the application here; > > better to let the application handle the error itself. > > > > Remove the gratuitous profanity which would be visible if > > the rte_exit w

Re: [dpdk-dev] [dpdk-stable] [PATCH] pdump: remove dependency on libpthread

2018-09-18 Thread Thomas Monjalon
07/08/2018 16:41, Reshma Pattan: > pdump library now uses generic multi process channel > and it is no more dependent on the pthreads, so remove > the dependency from the Makefile. > Fixes: 660098d61f57 ("pdump: use generic multi-process channel") > CC: sta...@dpdk.org > > Signed-off-by: Reshma

Re: [dpdk-dev] [PATCH 11/11] telemetry: add collectd plugin patch

2018-09-18 Thread Thomas Monjalon
23/08/2018 14:08, Ciara Power: > This patch adds the patch for the collectd plugin developed for use > with the DPDK Telemetry library. The patch is included here to allow > users to apply the patch to collectd when using DPDK Telemetry. > Further details on applying the collectd patch can be found

Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

2018-09-18 Thread Bruce Richardson
On Mon, Sep 17, 2018 at 09:58:59PM +0200, Thomas Monjalon wrote: > 17/09/2018 21:34, Bruce Richardson: > > On Mon, Sep 17, 2018 at 06:44:52PM +0200, Thomas Monjalon wrote: > > > 17/09/2018 17:17, Bruce Richardson: > > > > On Mon, Sep 17, 2018 at 03:38:58PM +0200, Thomas Monjalon wrote: > > > > > 17

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-09-18 Thread Burakov, Anatoly
On 18-Sep-18 10:43 AM, Thomas Monjalon wrote: 26/07/2018 11:41, Burakov, Anatoly: On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would

Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

2018-09-18 Thread Thomas Monjalon
18/09/2018 12:15, Bruce Richardson: > On Mon, Sep 17, 2018 at 09:58:59PM +0200, Thomas Monjalon wrote: > > 17/09/2018 21:34, Bruce Richardson: > > > On Mon, Sep 17, 2018 at 06:44:52PM +0200, Thomas Monjalon wrote: > > > > 17/09/2018 17:17, Bruce Richardson: > > > > > On Mon, Sep 17, 2018 at 03:38:5

[dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

2018-09-18 Thread Bruce Richardson
Versions of meson prior to 0.47 flattened the parameters to the "set_variable" function, which meant that the function could not take array variables as a parameter. Therefore, we need to disable driver tracking for those older versions, in order to maintain compatibility with the minimum supported

[dpdk-dev] [PATCH v7 1/2] librte_lpm: Improve performance of the delete and add functions

2018-09-18 Thread Alex Kiselev
lpm6: store rules in hash table for lpm6 Rework the lpm6 rule subsystem and replace current rules algorithm complexity O(n) with hashtables which allow dealing with large (50k) rule sets. Signed-off-by: Alex Kiselev Acked-by: Bruce Richardson --- lib/Makefile | 2 +- lib/librte

[dpdk-dev] [PATCH v7 2/2] librte_lpm: Improve performance of the delete and add functions

2018-09-18 Thread Alex Kiselev
lpm6: add incremental update on delete rework the delete function and add additional internal data structures to support incremental LPM tree update rather than full tree rebuild Signed-off-by: Alex Kiselev Acked-by: Bruce Richardson --- lib/librte_lpm/rte_lpm6.c | 712 ++

Re: [dpdk-dev] [PATCH v5] doc: add cross compile part for sample applications

2018-09-18 Thread Jerin Jacob
-Original Message- > Date: Mon, 17 Sep 2018 18:53:43 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin...@arm.com, honnappa.nagaraha...@arm.com, > jerin.ja...@caviumnetworks.com, sta...@dpdk.org > Subject: [PATCH v5] doc: add cross compile part for sample applications > X-Mailer: git-

Re: [dpdk-dev] [PATCH v1] testpmd: eeprom display

2018-09-18 Thread Gaëtan Rivet
Hi, I am looking at support on e1000/IGB ports, and I have used this command to verify support. It works for fiber but not for copper. I can see in the get_module_info callback that copper SFPs are not supported. Same thing as the kernel driver. Is it possible to use MDIO for dumping the SFP EEP

[dpdk-dev] [Bug 91] Unable to build on Ubuntu 18.04

2018-09-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=91 Bug ID: 91 Summary: Unable to build on Ubuntu 18.04 Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: CONFIRMED Severity: critical Priori

Re: [dpdk-dev] [PATCH 1/3] event: add function for reading unlink in progress

2018-09-18 Thread Elo, Matias (Nokia - FI/Espoo)
> > +/** > + * Returns the number of unlinks in progress. > + * > + * This function provides the application with a method to detect when an > + * unlink has been completed by the implementation. See > *rte_event_port_unlink* > + * on how to issue unlink requests. > + * > + * @param dev_id > + *

Re: [dpdk-dev] [PATCH 02/10] crypto/caam_jr: introduce basic driver

2018-09-18 Thread Akhil Goyal
Hi Gagan, On 9/13/2018 11:38 AM, Gagandeep Singh wrote: From: Hemant Agrawal This patch introduces basic support for caam_jr crypto driver. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- config/common_base| 8 + config/common_linuxapp

Re: [dpdk-dev] [PATCH 01/10] doc: add caam jr cryptodev details

2018-09-18 Thread Akhil Goyal
++John Hi Gagan, Please make this patch as last patch in your patchset for v2. On 9/13/2018 11:38 AM, Gagandeep Singh wrote: From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/caam_jr.rst | 159 ++ doc/guides/cryptodevs/index.rst |

Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

2018-09-18 Thread Shreyansh Jain
On Monday 17 September 2018 06:30 PM, Burakov, Anatoly wrote: On 17-Sep-18 1:16 PM, Shahaf Shuler wrote: Monday, September 17, 2018 1:07 PM, Burakov, Anatoly: Subject: Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK On 13-Sep-18 8:44 AM, Shahaf Shuler wrote: [...]

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Akhil Goyal
Hi Anoob, On 9/17/2018 7:43 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related chan

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Joseph
Hi Akhil, On 18-09-2018 18:01, Akhil Goyal wrote: > External Email > > Hi Anoob, > > On 9/17/2018 7:43 PM, Joseph, Anoob wrote: >> Hi Akhil, >> >> >> On 17-09-2018 17:50, Akhil Goyal wrote: >>> External Email >>> >>> On 9/17/2018 5:12 PM, Joseph, Anoob wrote: >>> Hi Akhil, On 17-09-2018

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-18 Thread Ananyev, Konstantin
> > I am not saying this should be the ONLY way to do as it does not work > > very well with non NPU/FPGA class of SoC. > > > > So how about making the proposed IPSec library as plugin/driver to > > rte_security. > > As I mentioned above, I don't think that pushing whole IPSec data-path into >

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-18 Thread Akhil Goyal
On 9/18/2018 6:10 PM, jos...@dpdk.org wrote: Hi Akhil, On 18-09-2018 18:01, Akhil Goyal wrote: External Email Hi Anoob, On 9/17/2018 7:43 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On

Re: [dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

2018-09-18 Thread Timothy Redaelli
On Tue, 18 Sep 2018 11:55:52 +0100 Bruce Richardson wrote: > Versions of meson prior to 0.47 flattened the parameters to the > "set_variable" function, which meant that the function could not take > array variables as a parameter. Therefore, we need to disable driver > tracking for those older ve

[dpdk-dev] [PATCH v4 00/10] A Distributed Software Event Device

2018-09-18 Thread Mattias Rönnblom
v4: * Reworded DSW introduction in the documentation. * Updated the MAINTAINERS file and the 18.11 release notes. v3: * Fixed incorrect headline prefixes. * Removed dummy dsw_event_schedule() function. * Removed redundant output buffer flush. v2: * Added support for Meson builds. * Eventdev 'xsta

[dpdk-dev] [PATCH v4 02/10] event/dsw: add DSW device and queue configuration

2018-09-18 Thread Mattias Rönnblom
Allow queue- and device-level configuration for and retrieval of contextual information from a DSW event device. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 87 +++ drivers/event/dsw/dsw_evdev.h | 28 +++ 2 files changed, 115 insert

[dpdk-dev] [PATCH v4 03/10] event/dsw: add DSW port configuration

2018-09-18 Thread Mattias Rönnblom
Allow port setup and release in the DSW event device. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 60 +++ drivers/event/dsw/dsw_evdev.h | 28 2 files changed, 88 insertions(+) diff --git a/drivers/event/dsw/dsw_evdev.c b/d

[dpdk-dev] [PATCH v4 05/10] event/dsw: add DSW event scheduling and device start/stop

2018-09-18 Thread Mattias Rönnblom
With this patch, the DSW event device can be started and stopped, and also supports scheduling events between ports. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/Makefile| 2 +- drivers/event/dsw/dsw_evdev.c | 125 drivers/event/dsw/dsw_evdev.h | 56 ++ drivers/e

[dpdk-dev] [PATCH v4 04/10] event/dsw: add support in DSW for linking/unlinking ports

2018-09-18 Thread Mattias Rönnblom
Added support for linking and unlinking ports to queues in a DSW event device. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 67 +++ drivers/event/dsw/dsw_evdev.h | 1 + 2 files changed, 68 insertions(+) diff --git a/drivers/event/dsw/dsw_e

[dpdk-dev] [PATCH v4 07/10] event/dsw: add load balancing to the DSW event device

2018-09-18 Thread Mattias Rönnblom
The DSW event device will now attempt to migrate (move) flows between ports in order to balance the load. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 27 ++ drivers/event/dsw/dsw_evdev.h | 80 drivers/event/dsw/dsw_event.c | 735 +-

[dpdk-dev] [PATCH v4 01/10] event/dsw: add DSW device registration and build system

2018-09-18 Thread Mattias Rönnblom
This patch contains the Meson and GNU Make build system extensions required for the Distributed Event Device, and also the initialization code for the driver itself. Signed-off-by: Mattias Rönnblom --- config/common_base| 5 ++ drivers/event/Makefile

[dpdk-dev] [PATCH v4 08/10] event/dsw: let DSW event device sort events on dequeue

2018-09-18 Thread Mattias Rönnblom
With this patch, the DSW event device will (optionally) sort the event burst before giving it to the application. The sorting will primarily be on queue id, and secondary on flow id. The sorting is an attempt to optimize data and instruction cache usage for the application, at the cost of addition

[dpdk-dev] [PATCH v4 06/10] event/dsw: add DSW port load measurements

2018-09-18 Thread Mattias Rönnblom
The DSW event device port now attempts to estimate its load (i.e. how busy it is). This is required for load balancing to work (although load balancing is not included in this patch), and may also be useful for debugging purposes. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c

[dpdk-dev] [PATCH v4 09/10] event/dsw: implement eventdev 'xstats' counters in DSW

2018-09-18 Thread Mattias Rönnblom
The DSW event device now implements the 'xstats' interface and a number of port- and device-level counters. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/Makefile | 3 +- drivers/event/dsw/dsw_evdev.c | 5 +- drivers/event/dsw/dsw_evdev.h | 19 +++ drivers/event/dsw/dsw_event.

[dpdk-dev] [PATCH v4 10/10] event/dsw: include DSW event device documentation

2018-09-18 Thread Mattias Rönnblom
The DSW event device is documented in DPDK Programmer's Guide. The MAINTAINERS file and the 18.11 release notes are updated. Signed-off-by: Mattias Rönnblom --- MAINTAINERS| 5 ++ doc/guides/eventdevs/dsw.rst | 96 ++ doc/guides/eve

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix non-matching parameters documentation

2018-09-18 Thread Ferruh Yigit
On 9/17/2018 10:07 PM, Yongseok Koh wrote: > >> On Sep 17, 2018, at 9:03 AM, Asaf Penso wrote: >> >> tso and vlan parameters were removed from the signature >> of txq_mbuf_to_swp function. >> >> The documentation of the function was not updated accordingly. >> >> Remove the tso and vlan documenta

Re: [dpdk-dev] [PATCH v7] net/i40e: add interface to use latest vec path

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 3:22 AM, Xiaoyun Li wrote: > For IA, the AVX2 vector path is only recommended to be used on later > platforms (identified by AVX512 support, like SKL etc.) This is because > performance benchmark shows downgrade when running AVX2 vector path on > early platform (BDW/HSW) in some cases.

[dpdk-dev] [PATCH v3 1/2] doc: create a platorm specific page for NXP DPAA platform

2018-09-18 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- v3: merge the patches doc/guides/cryptodevs/dpaa_sec.rst | 25 +- doc/guides/eventdevs/dpaa.rst | 48 ++ doc/guides/nics/dpaa.rst | 59 +- doc/guides/platform/dpaa.rst | 100

[dpdk-dev] [PATCH v3 2/2] doc: create a platorm specific page for NXP DPAA2 platform

2018-09-18 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- v3: merge the patches doc/guides/cryptodevs/dpaa2_sec.rst | 28 +++ doc/guides/eventdevs/dpaa2.rst | 50 ++- doc/guides/nics/dpaa2.rst | 49 ++- doc/guides/platform/dpaa2.rst | 98 +

Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 6:44 AM, Beilei Xing wrote: > Remove driver log when no interrupt event indicated > in alarm handler for both PF and VF, otherwise there > will be lots of prints which makes console unusable. > > Signed-off-by: Beilei Xing Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] devtools/test-meson-build: use shared libraries to save space

2018-09-18 Thread Thomas Monjalon
14/09/2018 18:21, Luca Boccassi: > On Fri, 2018-09-14 at 17:17 +0100, Bruce Richardson wrote: > > For usability, the default build type in meson is static, so that > > binaries can be run from the build directory easily. However, static > > builds take more space, so for build-testing purposes defa

Re: [dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-18 Thread Luca Boccassi
Hi, The application must already stop and close before detaching (which will call uninit). Quoting from the documentation: "*  Before detaching, they must be stopped and closed.     DPDK applications must call "rte_eth_dev_stop()" and     "rte_eth_dev_close()" APIs before detaching ports. These

[dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

2018-09-18 Thread Bruce Richardson
Compiling with all warnings turned on causes errors about unused variables and an unused label. Remove these to allow building without having to disable those warnings. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting") Fixes: d6bde

[dpdk-dev] [PATCH v2 2/2] net/avf: fix missing compiler error flags

2018-09-18 Thread Bruce Richardson
The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means that a number of compilation errors were getting missed. This patch adds in the flag and fixes most of the errors, just disabling the strict-aliasing ones. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Fixes: 69dd4c3d0898 ("n

Re: [dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

2018-09-18 Thread Thomas Monjalon
18/09/2018 14:44, Timothy Redaelli: > On Tue, 18 Sep 2018 11:55:52 +0100 > Bruce Richardson wrote: > > > Versions of meson prior to 0.47 flattened the parameters to the > > "set_variable" function, which meant that the function could not take > > array variables as a parameter. Therefore, we need

[dpdk-dev] [PATCH v2 01/13] net/dpaa: configure frame queue on MAC ID basis

2018-09-18 Thread Hemant Agrawal
The current code has the hardcoded seq for fq allocation. It require multiple changes, when some of the interfaces are assigned to kernel stack. Changing it on the mac id basis provide the flexibility to assign any interface to kernel. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethd

[dpdk-dev] [PATCH v2 00/13] NXP DPAA driver enhancements

2018-09-18 Thread Hemant Agrawal
Misc fixes for dpaa driver V2: remove the unused function from map file Add description/details in git commit logs. Hemant Agrawal (9): net/dpaa: configure frame queue on MAC ID basis net/dpaa: fix jumbo buffer config net/dpaa: implement scatter offload support net/dpaa: minor debug

[dpdk-dev] [PATCH v2 03/13] net/dpaa: implement scatter offload support

2018-09-18 Thread Hemant Agrawal
This patch implement the sg support, which can be enabled/disabled w.r.t configuration. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 62 +++--- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 8 +++--- drivers/ne

[dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

2018-09-18 Thread Hemant Agrawal
Avoid return after the jumbo buffer config in dev config API Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v2 05/13] net/dpaa: minor debug log enhancements

2018-09-18 Thread Hemant Agrawal
Improving the debug message for event mode and reducing the log level for less important log Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev

[dpdk-dev] [PATCH v2 06/13] bus/dpaa: add interrupt based portal fd support

2018-09-18 Thread Hemant Agrawal
This patch add supports in bus driver for qbman to support and configure portal based FDs, which can be used for interrupt based processing. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/bman_driver.c | 17 ++ drivers/bus/dpaa/base/qbman/qman.c| 52 +++

[dpdk-dev] [PATCH v2 04/13] net/dpaa: fix link speed based on MAC type

2018-09-18 Thread Hemant Agrawal
From: Sachin Saxena The link speed shall be on the basis of mac type. Fixes: 799db4568c76 ("net/dpaa: support device info and speed capability") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 11 +-- 1 file changed, 9 i

[dpdk-dev] [PATCH v2 08/13] bus/dpaa: avoid using be conversions for contextb

2018-09-18 Thread Hemant Agrawal
From: Nipun Gupta minor optimization in packet handling path Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 71d

[dpdk-dev] [PATCH v2 07/13] bus/dpaa: avoid tag Set for eqcr in Tx path

2018-09-18 Thread Hemant Agrawal
From: Nipun Gupta Minor optimization for TX path. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 8730550..71da275 100644 --- a/drivers/bus/d

[dpdk-dev] [PATCH v2 10/13] net/dpaa: separate Rx function for LS1046

2018-09-18 Thread Hemant Agrawal
This is to avoid the checks in datapath and help in performance. LS1046 has different data stash settings. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 +-- drivers/net/dpaa/dpaa_rxtx.c | 60 +- drivers/net/dpaa/dpaa_rxtx.h

[dpdk-dev] [PATCH v2 09/13] net/dpaa: rearranging of atomic queue support code

2018-09-18 Thread Hemant Agrawal
From: Sunil Kumar Kori This is to align the code with dpaa2 to ease out maintaince of both driver code bases. Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_rxtx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_r

[dpdk-dev] [PATCH v2 11/13] net/dpaa: tune prefetch in Rx path

2018-09-18 Thread Hemant Agrawal
As part of performance optimization excercise, tuning the prefetch placement. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 2c57741..c4471

[dpdk-dev] [PATCH v2 12/13] bus/dpaa: add check for re-definition in compat

2018-09-18 Thread Hemant Agrawal
Few fields in compat are giving re-defination error with new drivers such as caam_jr. Checks have been added. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/bus/dpaa/include/com

[dpdk-dev] [PATCH v2 13/13] mempool/dpaa: change the debug log level to DP

2018-09-18 Thread Hemant Agrawal
When the system goes out of buffers temporarily, the logs further slow down the system. There is no need for this continuos logs. Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/dpaa/dpaa_me

Re: [dpdk-dev] [PATCH 03/10] crypto/caam_jr: add HW config for job rings

2018-09-18 Thread Akhil Goyal
Hi Gagan, On 9/13/2018 11:38 AM, Gagandeep Singh wrote: From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/Makefile | 6 + drivers/crypto/caam_jr/caam_jr.c | 329 +++- drivers/crypto/caam_jr/caam

Re: [dpdk-dev] [PATCH v5 4/4] build: generate API documentation with Meson

2018-09-18 Thread Thomas Monjalon
11/09/2018 22:42, Luca Boccassi: > Signed-off-by: Luca Boccassi > Acked-by: Bruce Richardson Series applied, thanks

Re: [dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 2:17 PM, Bruce Richardson wrote: > Compiling with all warnings turned on causes errors about unused variables > and an unused label. Remove these to allow building without having to > disable those warnings. > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > Fixes: 3fd7a37

Re: [dpdk-dev] [PATCH v7] net/i40e: add interface to use latest vec path

2018-09-18 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 18, 2018 9:01 PM > To: Li, Xiaoyun ; Xing, Beilei ; > Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Zhiyong ; > tho...@monjalon.net; Richardson, Bruce > Subject: Re: [PATCH v7] net/i40e: add interface to use latest vec path >

Re: [dpdk-dev] [PATCH v2 2/2] net/avf: fix missing compiler error flags

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 2:17 PM, Bruce Richardson wrote: > The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means > that a number of compilation errors were getting missed. This patch adds > in the flag and fixes most of the errors, just disabling the > strict-aliasing ones. > > Fixes: 22b123

Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log

2018-09-18 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 18, 2018 9:04 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log > > On 9/18/2018 6:44 AM, Beilei Xing wrote: > > Remove driver log when no interrup

Re: [dpdk-dev] [PATCH 04/10] crypto/caam_jr: add device configuration routines

2018-09-18 Thread Akhil Goyal
Hi Gagan, On 9/13/2018 11:38 AM, Gagandeep Singh wrote: From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 100 +++- drivers/crypto/caam_jr/caam_jr.h | 257 +++ 2 files changed, 356

Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

2018-09-18 Thread Thomas Monjalon
18/09/2018 15:31, Hemant Agrawal: > Avoid return after the jumbo buffer config in dev config API > > Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant Agrawal Thanks for adding some comments in this series. About this fix

Re: [dpdk-dev] [PATCH 05/10] crypto/caam_jr: add queue config functions

2018-09-18 Thread Akhil Goyal
Hi Gagan, On 9/13/2018 11:38 AM, Gagandeep Singh wrote: From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 64 1 file changed, 64 insertions(+) diff --git a/drivers/crypto/caam_jr/caam_

Re: [dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

2018-09-18 Thread Bruce Richardson
On Tue, Sep 18, 2018 at 02:51:27PM +0100, Ferruh Yigit wrote: > On 9/18/2018 2:17 PM, Bruce Richardson wrote: > > Compiling with all warnings turned on causes errors about unused variables > > and an unused label. Remove these to allow building without having to > > disable those warnings. > > > >

Re: [dpdk-dev] [PATCH 00/10] Introducing the NXP CAAM job ring driver

2018-09-18 Thread Akhil Goyal
Hi Gagan, On 9/13/2018 11:38 AM, Gagandeep Singh wrote: The caam_jr PMD provides poll mode crypto driver support for NXP SEC 4.x+ (CAAM) hardware accelerator. This patch has dependancy on below patches: http://patchwork.dpdk.org/patch/43986/ http://patchwork.dpdk.org/patch/43964/ Hemant Agrawa

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

2018-09-18 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Friday, September 14, 2018 4:42 PM > To: Wang, Xiao W > Cc: Bie, Tiwei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready > > Looks good to me. > > R

[dpdk-dev] [PATCH v3 1/2] net/avf: fix unused variables and label

2018-09-18 Thread Bruce Richardson
Compiling with all warnings turned on causes errors about unused variables and an unused label. Remove these to allow building without having to disable those warnings. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting") Fixes: d6bde

[dpdk-dev] [PATCH v3 2/2] net/avf: fix missing compiler error flags

2018-09-18 Thread Bruce Richardson
The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means that a number of compilation errors were getting missed. This patch adds in the flag and fixes most of the errors, just disabling the strict-aliasing ones. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Fixes: 69dd4c3d0898 ("n

[dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD

2018-09-18 Thread Luca Boccassi
Use same autoconf generation mechanism as the MLX4/5 PMDs Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/tap/meson.build | 41 + 2 files changed, 42 insertions(+) create mode 100644 drivers/net/tap/meson.build diff --git a/d

[dpdk-dev] [PATCH v5 3/9] build: add Meson file for crypto scheduler PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- drivers/crypto/meson.build | 2 +- drivers/crypto/scheduler/meson.build | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/scheduler/meson.build diff --git a/drivers/crypto/meson.build b/driver

[dpdk-dev] [PATCH v5 4/9] build: add Meson files for avf PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- drivers/net/avf/base/meson.build | 20 drivers/net/avf/meson.build | 19 +++ drivers/net/meson.build | 1 + 3 files changed, 40 insertions(+) create mode 100644 drivers/net/avf/base/meson.build create mode 1006

[dpdk-dev] [PATCH v5 2/9] build: add Meson file for vdev_netvsc PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/vdev_netvsc/meson.build | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 drivers/net/vdev_netvsc/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build inde

[dpdk-dev] [PATCH v5 5/9] build: add Meson files for qede PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi Acked-by: Shahed Shaikh --- config/rte_config.h | 3 ++ drivers/net/meson.build | 2 +- drivers/net/qede/base/meson.build | 57 +++ drivers/net/qede/meson.build | 12 +++ 4 files changed, 73 insertions(+)

[dpdk-dev] [PATCH v5 6/9] build: add Meson file for bbdev_null PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- drivers/baseband/meson.build | 7 +++ drivers/baseband/null/meson.build | 7 +++ drivers/meson.build | 1 + 3 files changed, 15 insertions(+) create mode 100644 drivers/baseband/meson.build create mode 100644 drivers/baseband/null/meso

[dpdk-dev] [PATCH v5 8/9] build: add Meson file for opdl_event PMD

2018-09-18 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- drivers/event/meson.build | 2 +- drivers/event/opdl/meson.build | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/event/opdl/meson.build diff --git a/drivers/event/meson.build b/drivers/event/meson.build index e

[dpdk-dev] [PATCH v5 7/9] event/opdl: rename map file to match library name

2018-09-18 Thread Luca Boccassi
So that it can be used from Meson as well Signed-off-by: Luca Boccassi --- drivers/event/opdl/Makefile | 2 +- ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/event/opdl/{rte_p

[dpdk-dev] [PATCH v5 9/9] build: add Meson file for vmxnet3_uio PMD

2018-09-18 Thread Luca Boccassi
Note that the library built by meson will not have the _uio suffix: librte_pmd_vmxnet3.so - as it follows the directory name, while the legacy makefile rename it to librte_pmd_vmxnet3_uio.so. Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 4 +++- drivers/net/vmxnet3/meson.bu

Re: [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

2018-09-18 Thread Luca Boccassi
On Thu, 2018-09-13 at 17:16 +0100, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- >  drivers/net/meson.build |  4 +++- >  drivers/net/vmxnet3/meson.build | 18 ++ >  2 files changed, 21 insertions(+), 1 deletion(-) >  create mode 100644 drivers/net/vmxnet3/meson.b

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-09-18 Thread Stephen Hemminger
On Tue, 18 Sep 2018 11:40:28 +0200 Thomas Monjalon wrote: > 25/07/2018 20:20, Stephen Hemminger: > > No need for profanity in comments. > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/bnx2x/elink.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --g

Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

2018-09-18 Thread Burakov, Anatoly
On 18-Sep-18 1:29 PM, Shreyansh Jain wrote: On Monday 17 September 2018 06:30 PM, Burakov, Anatoly wrote: On 17-Sep-18 1:16 PM, Shahaf Shuler wrote: Monday, September 17, 2018 1:07 PM, Burakov, Anatoly: Subject: Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK On 13-S

Re: [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

2018-09-18 Thread Bruce Richardson
On Tue, Sep 18, 2018 at 04:00:12PM +0100, Luca Boccassi wrote: > On Thu, 2018-09-13 at 17:16 +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > >  drivers/net/meson.build |  4 +++- > >  drivers/net/vmxnet3/meson.build | 18 ++ > >  2 files changed, 21 ins

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-18 Thread Ferruh Yigit
On 9/14/2018 3:45 AM, Jerin Jacob wrote: > -Original Message- >> Date: Thu, 13 Sep 2018 23:45:31 + >> From: Honnappa Nagarahalli >> To: Jerin Jacob >> CC: Ola Liljedahl , "Kokkilagadda, Kiran" >> , "Gavin Hu (Arm Technology China)" >> , Ferruh Yigit , "Jacob, Jerin" >> , "dev@dpdk

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-18 Thread Ferruh Yigit
On 9/12/2018 12:29 AM, Dan Gora wrote: > Set the carrier state to 'off' when the interface is instantiated > or when it is marked 'up' or 'down'. This is necessary to set the > interface to a known operational state until the carrier state is > changed with rte_kni_update_link(). Why setting to n

Re: [dpdk-dev] [PATCH] kni: return failure for all ioctls

2018-09-18 Thread Ferruh Yigit
On 9/13/2018 10:46 PM, Dan Gora wrote: > Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead > of 0. > > This is necessary because the Wicked (and possibly other) network > interface managers will perform the SIOCGIWNAME ioctl to check if > the interface is a wireless interface. I

Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

2018-09-18 Thread Hemant
On 9/18/2018 7:33 PM, Thomas Monjalon wrote: 18/09/2018 15:31, Hemant Agrawal: Avoid return after the jumbo buffer config in dev config API Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Thanks for adding some c

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 5:15 PM, Ferruh Yigit wrote: > On 9/12/2018 12:29 AM, Dan Gora wrote: >> Set the carrier state to 'off' when the interface is instantiated >> or when it is marked 'up' or 'down'. This is necessary to set the >> interface to a known operational state until the carrier state is >> chang

Re: [dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface

2018-09-18 Thread Ferruh Yigit
On 9/12/2018 12:29 AM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link status for KNI network interfaces in > the linux kernel. > > Signed-off-by: Dan Gora +1 to sysfs implementation. But right now this API is not used at al

[dpdk-dev] [PATCH v4 00/10] net/softnic: implement metering and policing API

2018-09-18 Thread Jasvinder Singh
This series is prepared on top of following patchset; https://mails.dpdk.org/archives/dev/2018-September/111379.html v4 changes - introduce the table meter profile check in softnic pipeline table meter profile add function (rte_eth_softnic_thread.c) - change the table action check function to mo

[dpdk-dev] [PATCH v4 02/10] net/softnic: add meter profile

2018-09-18 Thread Jasvinder Singh
Implement meter profile add function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 3 + drivers/net/softnic/rte_eth_softnic_internals.h | 31 ++ drivers/net/softnic/rte_eth_softnic_meter.c | 122 +++- 3 files changed, 155 ins

  1   2   >