Re: [dpdk-dev] [PATCH] vhost: fix return value on enqueue path

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 06:59 AM, Tiwei Bie wrote: Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions") Fixes: a922401f35cc ("vhost: add Rx support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 7 --- 1 file ch

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support

2018-09-12 Thread Maxime Coquelin
Hi Fan, On 06/22/2018 02:36 PM, Fan Zhang wrote: Originally vhost_crypto sample application only supports single core. This patch adds the multi-core support with more flexible options. Signed-off-by: Fan Zhang --- doc/guides/sample_app_ug/vhost_crypto.rst | 26 +- examples/vhost_crypto/ma

[dpdk-dev] Using example flow_filtering

2018-09-12 Thread Matteo Lanzuisi
Hi all, maybe a bug or something I'm doing wrong: I'm using the example flow_filtering on a RedHat 7.5, kernel 3.10.0-862.6.3.el7.x86_64 with i40e and X710. DPDK is 18.08 and configuration is x86_64-native-linuxapp-gcc I changed the SRC_IP and DST_IP this way #define SRC_IP ((83<<24) + (175

Re: [dpdk-dev] [PATCH v4] net/i40e: add interface to choose latest vector path

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, September 10, 2018 6:18 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Zhiyong ; Richardson, > Bruce ; Hunt, David ; Li, > Xiaoyun > Subject: [PATCH v4] net/i40e: add interface to choose latest vector path > > Rig

Re: [dpdk-dev] [PATCH v4] net/i40e: add interface to choose latest vector path

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, September 12, 2018 3:45 PM > To: Li, Xiaoyun ; Xing, Beilei > Cc: dev@dpdk.org; Yang, Zhiyong ; Richardson, > Bruce ; Hunt, David > Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: ad

Re: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed queues

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: vq->vq_free_cnt = vq->vq_nentries; memset(vq->vq_descx, 0, sizeof(struct vq_desc_extra) * vq->vq_nentries); + vq->vq_used_cons_idx = 0; + vq->vq_avail_idx = 0; + if (vtpci_packed_queue(vq->hw)) { +

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-09-12 Thread Ilya Maximets
On 12.09.2018 09:49, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Monday, September 10, 2018 11:09 PM >> To: Zhang, Qi Z ; dev@dpdk.org >> Cc: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Laurent Hardy >> ; Dai, Wei ; >> sta...@dpd

[dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets

2018-09-12 Thread Raslan Darawsheh
verbosity for the received/sent packets is needed in all of the forwarding engines so moving it to be in a separate function. Signed-off-by: Raslan Darawsheh --- app/test-pmd/Makefile | 1 + app/test-pmd/testpmd.h | 2 + app/test-pmd/util.c| 143 +

[dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

2018-09-12 Thread Raslan Darawsheh
use the generic function to dump packets for several forwarding engines. To dump received packets first bit of verbosity need to be set and for sent packets verbosity second bit need to be set. for example: dump rx : set verbose 1 dump tx : set verbose 2 dump rx and tx : s

Re: [dpdk-dev] Deadlock when start virtio_user + vhost_kernel

2018-09-12 Thread Jason Wang
On 2018年09月12日 12:27, Tiwei Bie wrote: On Wed, Sep 12, 2018 at 11:47:20AM +0800, Jason Wang wrote: Hi: Try to launch virtio_user + vhost_kernel with: testpmd --vdev=virtio_user0,path=/dev/vhost-net -- -i It seems we get a deadlock on rte_rwlock_read_lock(&mcfg->memory_hotplug_lock) Yes, yo

Re: [dpdk-dev] [PATCH v5 03/11] net/virtio: add packed virtqueue helpers

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 26 ++ drivers/net/virtio/virtqueue.h | 19 +++ 2 files changed, 45 ins

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, September 12, 2018 4:05 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Dai, Wei ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe:

[dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array

2018-09-12 Thread Dekel Peled
Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx. If new Tx offload capabilities are defined, they also must be mentioned in rte_tx_offload_names in rte_ethdev.c file. This patch adds the required lines in array rte_tx_offload_names. Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UD

Re: [dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array

2018-09-12 Thread Andrew Rybchenko
On 09/12/2018 11:28 AM, Dekel Peled wrote: Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx. If new Tx offload capabilities are defined, they also must be mentioned in rte_tx_offload_names in rte_ethdev.c file. This patch adds the required lines in array rte_tx_offload_names. Fixes: 5

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe

2018-09-12 Thread Jeff Guo
hi, ferruh On 8/25/2018 12:22 AM, Ferruh Yigit wrote: On 7/11/2018 12:51 PM, Jeff Guo wrote: This patch aim to enable hotplug detect in ixgbe PMD. Firstly it set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug ability, and then use rte_eth_dev_event_handler_install to insta

[dpdk-dev] Reg: "Query in DPDK HQOS "

2018-09-12 Thread Prabakar Prabakar
Hi i have query with respect to HQos. why number of queues in traffic class is fixed to *4*. And it was mentioned that "*cannot be changed*". RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS *4* link : http://doc.dpdk.org/api-17.11/rte__sched_8h.html#a326fddd15331c0fd66c7a181a6b43e29 Any reason behind this

[dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-12 Thread Jasvinder Singh
Fixes bad arguments error for cli commands related to adding meter profile for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. error log: testpmd> add port meter profile trtcm_rfc2698 2 0 312500 312500 250 250 Bad arguments Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic

Re: [dpdk-dev] [PATCH v5 03/11] net/virtio: add packed virtqueue helpers

2018-09-12 Thread Jens Freimann
On Wed, Sep 12, 2018 at 10:25:57AM +0200, Maxime Coquelin wrote: On 09/06/2018 08:19 PM, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 26 ++ drivers/net/virtio/v

Re: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed queues

2018-09-12 Thread Jens Freimann
On Wed, Sep 12, 2018 at 10:02:30AM +0200, Maxime Coquelin wrote: On 09/06/2018 08:19 PM, Jens Freimann wrote: vq->vq_free_cnt = vq->vq_nentries; memset(vq->vq_descx, 0, sizeof(struct vq_desc_extra) * vq->vq_nentries); + vq->vq_used_cons_idx = 0; + vq->vq_avail_idx

Re: [dpdk-dev] [PATCH v5 04/11] net/virtio: flush packed receive virtqueues

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: Flush used descriptors in packed receive virtqueue. As descriptors can be chained we need to look at the stored number of used descriptors to find out the length of the chain. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.c | 17

Re: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue data

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virt

Re: [dpdk-dev] [PATCH v5 06/11] net/virtio-user: add option to use packed queues

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 -- drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +- d

Re: [dpdk-dev] Change in binary name w/ meson build

2018-09-12 Thread Bruce Richardson
On Wed, Sep 12, 2018 at 06:21:06AM +, Shahaf Shuler wrote: > Friday, September 7, 2018 6:24 PM, Bruce Richardson: > > Subject: Re: [dpdk-dev] Change in binary name w/ meson build > > > > On Fri, Sep 07, 2018 at 03:13:43PM +0100, Bruce Richardson wrote: > > > On Wed, Sep 05, 2018 at 11:52:10AM

Re: [dpdk-dev] Change in binary name w/ meson build

2018-09-12 Thread Luca Boccassi
On Wed, 2018-09-12 at 10:30 +0100, Bruce Richardson wrote: > On Wed, Sep 12, 2018 at 06:21:06AM +, Shahaf Shuler wrote: > > Friday, September 7, 2018 6:24 PM, Bruce Richardson: > > > Subject: Re: [dpdk-dev] Change in binary name w/ meson build > > > > > > On Fri, Sep 07, 2018 at 03:13:43PM +01

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

2018-09-12 Thread Bruce Richardson
On Tue, Sep 11, 2018 at 10:47:58PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 21:36 +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 17:13 +0100, Bruce Richardson wrote: > > > Signed-off-by: Bruce Richardson > > > --- > > > NOTE: this patch depends upon: > > > http://patches.dpdk.org

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

2018-09-12 Thread Luca Boccassi
On Wed, 2018-09-12 at 10:36 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 10:47:58PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 21:36 +0100, Luca Boccassi wrote: > > > On Tue, 2018-09-11 at 17:13 +0100, Bruce Richardson wrote: > > > > Signed-off-by: Bruce Richardson > > > > -

Re: [dpdk-dev] [PATCH v5 04/11] net/virtio: flush packed receive virtqueues

2018-09-12 Thread Jens Freimann
On Wed, Sep 12, 2018 at 11:12:50AM +0200, Maxime Coquelin wrote: On 09/06/2018 08:19 PM, Jens Freimann wrote: [...] + if (vtpci_packed_queue(vq->hw)) { + i = vq->vq_used_cons_idx; + while (desc_is_used(&descs[i], &vq->vq_ring) && + i < vq-

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

2018-09-12 Thread Bruce Richardson
On Wed, Sep 12, 2018 at 10:48:15AM +0100, Luca Boccassi wrote: > On Wed, 2018-09-12 at 10:36 +0100, Bruce Richardson wrote: > > On Tue, Sep 11, 2018 at 10:47:58PM +0100, Luca Boccassi wrote: > > > On Tue, 2018-09-11 at 21:36 +0100, Luca Boccassi wrote: > > > > On Tue, 2018-09-11 at 17:13 +0100, Bru

Re: [dpdk-dev] [PATCH v2] app/testpmd: optimize membuf pool allocation

2018-09-12 Thread Iremonger, Bernard
> -Original Message- > From: phil.y...@arm.com [mailto:phil.y...@arm.com] > Sent: Wednesday, September 12, 2018 2:54 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; gavin...@arm.com; > sta...@dpdk.org; phil.y...@arm.com > Subject: [PATCH v2] app/testpmd: optimize membuf pool allocation >

[dpdk-dev] [PATCH v5] net/i40e: add interface to choose latest vector path

2018-09-12 Thread Xiaoyun Li
Right now, vector path is limited to only use on later platform. This patch adds a devarg use-latest-vec to allow the users to use the latest vector path that the platform supported. Namely, using AVX2 vector path on broadwell is possible. Signed-off-by: Xiaoyun Li --- v5: * Simpify the rx set f

Re: [dpdk-dev] [PATCH v1 2/7] lib/power: add changes for host commands/policies

2018-09-12 Thread Hunt, David
Hi Stephen, On 30/8/2018 5:59 PM, Stephen Hemminger wrote: On Thu, 30 Aug 2018 11:54:17 +0100 David Hunt wrote: Signed-off-by: David Hunt --- lib/librte_power/channel_commands.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power

Re: [dpdk-dev] [PATCH v1 1/7] examples/power: add checks around hypervisor

2018-09-12 Thread Hunt, David
Hi Stephen, On 30/8/2018 5:59 PM, Stephen Hemminger wrote: On Thu, 30 Aug 2018 11:54:16 +0100 David Hunt wrote: Minor nits +static unsigned int global_hypervisor_available; Please use bool for boolean values. Will change in next revision. /* * Represents a single Virtual Machine

Re: [dpdk-dev] [PATCH v1 5/7] examples/power: add json string handling

2018-09-12 Thread Hunt, David
Hi Stephen, On 30/8/2018 6:00 PM, Stephen Hemminger wrote: On Thu, 30 Aug 2018 11:54:20 +0100 David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user gu

Re: [dpdk-dev] Reg: "Query in DPDK HQOS "

2018-09-12 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Prabakar Prabakar > Sent: Wednesday, September 12, 2018 10:01 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Reg: "Query in DPDK HQOS " > > Hi > i have query with respect to HQos. > > why number of queues in traffi

Re: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info

2018-09-12 Thread Hunt, David
Hi Lei, On 4/9/2018 6:17 AM, Yao, Lei A wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt Sent: Thursday, August 30, 2018 6:54 PM To: dev@dpdk.org Cc: Mcnamara, John ; Hunt, David Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSO

Re: [dpdk-dev] [PATCH 01/21] net/atlantic: atlantic PMD driver skeleton

2018-09-12 Thread Igor Russkikh
On 11.09.2018 20:02, Stephen Hemminger wrote: > On Fri, 7 Sep 2018 18:21:39 +0300 > Igor Russkikh wrote: > >> +#CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value >> +CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args > > Can't you fix your code to get rid of these e

Re: [dpdk-dev] [PATCH v1 4/7] examples/power: add host channel to power manager

2018-09-12 Thread Hunt, David
Hi Lei, On 4/9/2018 8:31 AM, Yao, Lei A wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt Sent: Thursday, August 30, 2018 6:54 PM To: dev@dpdk.org Cc: Mcnamara, John ; Hunt, David Subject: [dpdk-dev] [PATCH v1 4/7] examples/power: add host chan

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

2018-09-12 Thread Luca Boccassi
On Wed, 2018-09-12 at 11:13 +0100, Bruce Richardson wrote: > On Wed, Sep 12, 2018 at 10:48:15AM +0100, Luca Boccassi wrote: > > On Wed, 2018-09-12 at 10:36 +0100, Bruce Richardson wrote: > > > On Tue, Sep 11, 2018 at 10:47:58PM +0100, Luca Boccassi wrote: > > > > On Tue, 2018-09-11 at 21:36 +0100,

Re: [dpdk-dev] [PATCH v2] eal: add strscpy function

2018-09-12 Thread Ferruh Yigit
On 9/11/2018 4:00 PM, Gaetan Rivet wrote: > The strncpy function has long been deemed unsafe for use, > in favor of strlcpy or snprintf. > > While snprintf is standard and strlcpy is still largely available, > they both have issues regarding error checking and performance. > > Both will force rea

[dpdk-dev] [PATCH v2 0/7] add json power policy interface for containers

2018-09-12 Thread David Hunt
Patch v2: * Fixed review comments from Stephen Hemminger and Lei A Yao. * Added a check in the Makefile for libjansson-dev. Will Warn user and build without JSON functionality if not present, will build including JSON functionality if it is present. The current vm_power_manager example

[dpdk-dev] [PATCH v2 1/7] examples/power: add checks around hypervisor

2018-09-12 Thread David Hunt
Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent. Signed-off-by: David Hunt --- examples/vm_pow

[dpdk-dev] [PATCH v2 3/7] examples/power: add necessary changes to guest app

2018-09-12 Thread David Hunt
The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type). Signed-off-by: David Hunt --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 +

[dpdk-dev] [PATCH v2 2/7] lib/power: add changes for host commands/policies

2018-09-12 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_power/channel_commands.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h index ee638eefa..e7b93a797 100644 --- a/lib/librte_power/channel_commands.h +++ b/lib/librte_power/

[dpdk-dev] [PATCH v2 4/7] examples/power: add host channel to power manager

2018-09-12 Thread David Hunt
This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0 Signed-off-by: David Hunt --- examples/vm_power_manager/channel_manager.c | 108 +++ examples/vm_power

[dpdk-dev] [PATCH v2 5/7] examples/power: add json string handling

2018-09-12 Thread David Hunt
Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson, a C library for encoding, decoding and m

[dpdk-dev] [PATCH v2 6/7] doc/vm_power_manager: add JSON interface API info

2018-09-12 Thread David Hunt
Signed-off-by: David Hunt --- .../sample_app_ug/vm_power_management.rst | 236 ++ 1 file changed, 236 insertions(+) diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst index 855570d6b..b5b0179d2 100644 --- a/doc/gu

[dpdk-dev] [PATCH v2 7/7] examples/power: add json example files

2018-09-12 Thread David Hunt
This patch provides some example files in the json_examples sub-directory for sending to the fifo. Signed-off-by: David Hunt --- examples/vm_power_manager/json_examples/README| 6 ++ examples/vm_power_manager/json_examples/create.json | 8 examples/vm_power_manager

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-12 Thread Thomas Monjalon
10/09/2018 10:54, Andrew Rybchenko: > On 09/10/2018 11:42 AM, Thomas Monjalon wrote: > > 10/09/2018 10:03, Andrew Rybchenko: > >> On 09/08/2018 02:39 AM, Thomas Monjalon wrote: > >>> After closing a port, it cannot be restarted. > >>> So there is no reason to not free all associated resources. > >>

Re: [dpdk-dev] [PATCH v5 07/11] net/virtio: implement transmit path for packed queues

2018-09-12 Thread Maxime Coquelin
On 09/06/2018 08:19 PM, Jens Freimann wrote: This implements the transmit path for devices with support for packed virtqueues. Add the feature bit and enable code to add buffers to vring and mark descriptors as available. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-09-12 Thread Ananyev, Konstantin
Hi Robert, > -Original Message- > From: robertshear...@gmail.com [mailto:robertshear...@gmail.com] > Sent: Friday, August 24, 2018 5:35 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Robert Shearman > > Subject: [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF >

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets

2018-09-12 Thread Thomas Monjalon
12/09/2018 10:06, Raslan Darawsheh: > verbosity for the received/sent packets is needed in all of the > forwarding engines so moving it to be in a separate function. > > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/Makefile | 1 + > app/test-pmd/testpmd.h | 2 + > app/test-pmd/util.

Re: [dpdk-dev] eventdev: method for finding out unlink status

2018-09-12 Thread Van Haaren, Harry
> From: Elo, Matias (Nokia - FI/Espoo) [mailto:matias@nokia.com] > Sent: Wednesday, September 5, 2018 8:49 AM > To: Van Haaren, Harry > Cc: Jerin Jacob ; dev@dpdk.org > Subject: Re: [dpdk-dev] eventdev: method for finding out unlink status > > > >> > >> I'm not sure I understand the issue he

Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup

2018-09-12 Thread Nikolay Nikolaev
Hello Maxime, I'll rebase and fix Ilya's comments. Thanks for the reviews. regards, Nikolay Nikolaev On Tue, Sep 11, 2018 at 12:38 PM Maxime Coquelin wrote: > Hi Nikolay, > > On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > > vhost: vhost_user.c code cleanup > > > > This patchesries introduce

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-12 Thread Andrew Rybchenko
On 09/12/2018 05:57 PM, Thomas Monjalon wrote: 10/09/2018 10:54, Andrew Rybchenko: On 09/10/2018 11:42 AM, Thomas Monjalon wrote: 10/09/2018 10:03, Andrew Rybchenko: On 09/08/2018 02:39 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free

[dpdk-dev] [PATCH 1/3] event: add function for reading unlink in progress

2018-09-12 Thread Harry van Haaren
This commit introduces a new function in the eventdev API, which allows applications to read the number of unlink requests in progress on a particular port of an eventdev instance. This information allows applications to verify when no more packets from a particular queue (or any queue) will arriv

[dpdk-dev] [PATCH 3/3] event/sw: add unit test for unlinks in progress

2018-09-12 Thread Harry van Haaren
This commit adds a unit test that checks the behaviour of the unlinks_in_progress() function, ensuring that the returned values are the number of unlinks requested, until the scheduler runs and "acks" the requests, after which the count should be zero again. Signed-off-by: Harry van Haaren --- d

[dpdk-dev] [PATCH 2/3] event/sw: implement unlinks in progress function

2018-09-12 Thread Harry van Haaren
This commit adds a counter to each port, which counts the number of unlinks that have been performed. When the scheduler thread starts its scheduling routine, it "acks" all unlinks that have been requested, and the application is gauranteed that no more events will be scheduled to the port from the

[dpdk-dev] [PATCH v2 01/10] net/softnic: add metering and policing support

2018-09-12 Thread Jasvinder Singh
Enable metering and policing support for softnic. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 1 + drivers/net/softnic/rte_eth_softnic.c | 10 drivers/net/softnic/rte_eth_softnic_

[dpdk-dev] [PATCH v2 00/10] net/softnic: implement metering and policing API

2018-09-12 Thread Jasvinder Singh
This patchset adds the metering and policing API support for the softnic. The metering and policing action can be enabled through the flow rules. This series is prepared on top of following patchset; https://mails.dpdk.org/archives/dev/2018-September/111379.html v2 changes: - fix copyright year f

[dpdk-dev] [PATCH v2 02/10] net/softnic: add meter profile

2018-09-12 Thread Jasvinder Singh
Implement meter profile add function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 3 + drivers/net/softnic/rte_eth_softnic_internals.h | 31 ++ drivers/net/softnic/rte_eth_softnic_meter.c | 122 +++- 3 files changed, 155 ins

[dpdk-dev] [PATCH v2 03/10] net/softnic: delete meter profile

2018-09-12 Thread Jasvinder Singh
Implement meter profile delete function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_meter.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_sof

[dpdk-dev] [PATCH v2 04/10] net/softnic: create meter object

2018-09-12 Thread Jasvinder Singh
implement meter object create function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_internals.h | 15 +++ drivers/net/softnic/rte_eth_softnic_meter.c | 123 +++- 2 files changed, 137 insertions(+), 1 deletion(-) diff --git a/drivers/net/softni

[dpdk-dev] [PATCH v2 05/10] net/softnic: destroy meter object

2018-09-12 Thread Jasvinder Singh
Implement meter object destroy function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_meter.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_sof

[dpdk-dev] [PATCH v2 06/10] net/softnic: update meter profile

2018-09-12 Thread Jasvinder Singh
Implement meter profile update function Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_internals.h | 14 drivers/net/softnic/rte_eth_softnic_meter.c | 104 +++- drivers/net/softnic/rte_eth_softnic_pipeline.c | 12 +++ 3 files changed, 129 i

[dpdk-dev] [PATCH v2 10/10] net/softnic: enable flow rule with meter action

2018-09-12 Thread Jasvinder Singh
Implement flow rules with meter action. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_flow.c | 153 + 1 file changed, 153 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers/net/softnic/rte_eth_softnic_flow.c inde

[dpdk-dev] [PATCH v2 07/10] net/softnic: update dscp table

2018-09-12 Thread Jasvinder Singh
Implement meter object dscp table update. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_internals.h | 1 + drivers/net/softnic/rte_eth_softnic_meter.c | 54 - drivers/net/softnic/rte_eth_softnic_pipeline.c | 1 + 3 files changed, 55 inserti

[dpdk-dev] [PATCH v2 09/10] net/softnic: meter stats read

2018-09-12 Thread Jasvinder Singh
Implement meter object stats read function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_meter.c | 115 +++- 1 file changed, 114 insertions(+), 1 deletion(-) diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth

[dpdk-dev] [PATCH v2 08/10] net/softnic: update policer actions

2018-09-12 Thread Jasvinder Singh
Implement meter object policer actions function. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_meter.c | 96 - 1 file changed, 95 insertions(+), 1 deletion(-) diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte

Re: [dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array

2018-09-12 Thread Ferruh Yigit
On 9/12/2018 9:33 AM, Andrew Rybchenko wrote: > On 09/12/2018 11:28 AM, Dekel Peled wrote: >> Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx. >> If new Tx offload capabilities are defined, they also must be mentioned >> in rte_tx_offload_names in rte_ethdev.c file. >> >> This patch adds

[dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir

2018-09-12 Thread Luca Boccassi
Add -r option to ln, otherwise the link will be absolute and contain the build path and break packaging among other things: lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1 -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/ drivers/librte_mempool_dpa

Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir

2018-09-12 Thread Timothy Redaelli
On Wed, 12 Sep 2018 18:21:34 +0100 Luca Boccassi wrote: > Add -r option to ln, otherwise the link will be absolute and contain > the build path and break packaging among other things: > > lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 > librte_mempool_dpaa.so.1.1 > -> /home/bluca/git/dpdk/testt4//

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-12 Thread Ananyev, Konstantin
Hi Anoob, > > Hi Konstantin, > Please see inline. > > > This RFC introduces a new library within DPDK: librte_ipsec. > The aim is to provide DPDK native high performance library for IPsec > data-path processing. > The library is supposed to utilize existing DPDK crypto-dev and > security API to

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-09-12 Thread Malvika Gupta
Hi Konstantin, I installed the clang version 4.0.1 to check for the issue you were facing with -O2 compilation. I was able to compile with -O2 and -O0 optimization without any errors. Please see the exact command I used and the following output for your reference: $ clang -O2 -target bpf -I /u

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-12 Thread Honnappa Nagarahalli
Hi Michel, I applied your patch and tweaked the code to run few performance tests on Arm (Cortex-A72, 1.3GHz) and x86 (Intel Xeon CPU E5-2660 v4 @ 2.00GHz). The perf code looks as follows: count_b = rte_rdtsc_precise(); int k = 0; rte_hash_iterator_init(tbl_rw_tes

[dpdk-dev] rte_memcpy() moves data incorrectly on Ubuntu 18.04 on Intel Skylake.

2018-09-12 Thread Yongseok Koh
Hi, Christian We've recently encountered a weird issue with Ubuntu 18.04 on the Skylake server. I can always reproduce this crash and I could narrowed it down. I guess it could be a GCC issue. [1] How to reproduce - ConnectX-4Lx/ConnectX-5 with mlx5 PMD in DPDK 18.02.1 - Ubuntu 18.04 on Intel Sk

Re: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed device

2018-09-12 Thread Ophir Munk
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Saturday, September 08, 2018 12:10 AM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com > Subject: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed > device > > In the devargs

Re: [dpdk-dev] rte_memcpy() moves data incorrectly on Ubuntu 18.04 on Intel Skylake.

2018-09-12 Thread Yongseok Koh
> On Sep 12, 2018, at 1:56 PM, Yongseok Koh wrote: > > Hi, Christian > > We've recently encountered a weird issue with Ubuntu 18.04 on the Skylake > server. I can always reproduce this crash and I could narrowed it down. I > guess > it could be a GCC issue. > > > [1] How to reproduce > - Conn

Re: [dpdk-dev] [PATCH v5] net/i40e: add interface to choose latest vector path

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, September 12, 2018 6:12 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Zhiyong ; Li, Xiaoyun > > Subject: [PATCH v5] net/i40e: add interface to choose latest vector path > > Right now, vector path is limited to on

Re: [dpdk-dev] [PATCH 0/8] update ixgbe base code

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Tuesday, September 11, 2018 12:38 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [dpdk-dev] [PATCH 0/8] update ixgbe base code > > Update the ixgbe base code to version cid-

Re: [dpdk-dev] [PATCH] net/ixgbe: firmware status check

2018-09-12 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Friday, September 7, 2018 11:01 PM > To: Lu, Wenzhuo ; dev@dpdk.org; Zhang, Helin > ; Wu, Jingjing > Cc: Li, Xiaoyun > Subject: [dpdk-dev] [PATCH] net/ixgbe: firmware status check > > Check

Re: [dpdk-dev] [PATCH] net/ifc: do not notify before HW ready

2018-09-12 Thread Ye Xiaolong
Hi, Xiao On 09/10, Xiao Wang wrote: >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Could you help describe what problem is without this fix in commit log? Thanks, Xiaolong > >Signed-off-by: Xiao Wang >--- > drivers/net/ifc/ifcvf_vdpa.c | 8 > 1 file changed, 4 insertions(+),

[dpdk-dev] [PATCH 00/10] Introducing the NXP CAAM job ring driver

2018-09-12 Thread Gagandeep Singh
The caam_jr PMD provides poll mode crypto driver support for NXP SEC 4.x+ (CAAM) hardware accelerator. This patch has dependancy on below patches: http://patchwork.dpdk.org/patch/43986/ http://patchwork.dpdk.org/patch/43964/ Hemant Agrawal (10): doc: add caam jr cryptodev details crypto/caam_

[dpdk-dev] [PATCH 01/10] doc: add caam jr cryptodev details

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/caam_jr.rst | 159 ++ doc/guides/cryptodevs/index.rst | 1 + 2 files changed, 160 insertions(+) create mode 100644 doc/guides/cryptodevs/caam_jr.rst diff --git a/doc/guides/cryptodevs/

[dpdk-dev] [PATCH 02/10] crypto/caam_jr: introduce basic driver

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal This patch introduces basic support for caam_jr crypto driver. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- config/common_base| 8 + config/common_linuxapp| 1 + config/defconfig_arm64-dpaa-linuxa

[dpdk-dev] [PATCH 03/10] crypto/caam_jr: add HW config for job rings

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/Makefile | 6 + drivers/crypto/caam_jr/caam_jr.c | 329 +++- drivers/crypto/caam_jr/caam_jr_config.h | 207 drivers/crypto/caam_jr/caam_

[dpdk-dev] [PATCH 04/10] crypto/caam_jr: add device configuration routines

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 100 +++- drivers/crypto/caam_jr/caam_jr.h | 257 +++ 2 files changed, 356 insertions(+), 1 deletion(-) create mode 100644 drivers/crypt

[dpdk-dev] [PATCH 06/10] crypto/caam_jr: add basic session config routines

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal The current support is limited to crypto only. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drive

[dpdk-dev] [PATCH 09/10] crypto/caam_jr: add stats support

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 55 1 file changed, 55 insertions(+) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c index d582b2fcb..f51f

[dpdk-dev] [PATCH 05/10] crypto/caam_jr: add queue config functions

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 64 1 file changed, 64 insertions(+) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c index 43fe5233b..f05e

[dpdk-dev] [PATCH 08/10] crypto/caam_jr: add auth cipher and aead session support

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 710 ++- 1 file changed, 707 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c inde

[dpdk-dev] [PATCH 10/10] crypto/caam_jr: add security offload support

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 361 ++- drivers/crypto/caam_jr/caam_jr_pvt.h | 3 + 2 files changed, 354 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_j

[dpdk-dev] [PATCH 07/10] crypto/caam_jr: add enqueue and dequeue routines

2018-09-12 Thread Gagandeep Singh
From: Hemant Agrawal Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/caam_jr/caam_jr.c | 621 +- drivers/crypto/caam_jr/caam_jr_desc.h | 289 2 files changed, 908 insertions(+), 2 deletions(-) create mode 100644 drivers

Re: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed device

2018-09-12 Thread Ophir Munk
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Saturday, September 08, 2018 2:10 AM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com > Subject: [dpdk-dev] [RFC] eal: allow hotplug to skip an already probed device > > In the devargs syn

Re: [dpdk-dev] [PATCH 1/3] mbuf: add sanity checks on segment metadata

2018-09-12 Thread David Marchand
Hello Yongseok, On Tue, Sep 11, 2018 at 8:16 PM, Yongseok Koh wrote: > >> On Sep 9, 2018, at 10:45 PM, David Marchand wrote: >> >> Add some basic checks on the segments offset and length metadata: >> always funny to have a < 0 tailroom cast to uint16_t ;-). >> >> Signed-off-by: David Marchand >