Re: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed queues

[Maxime Coquelin]

On 09/06/2018 08:19 PM, Jens Freimann wrote:

        vq->vq_free_cnt = vq->vq_nentries;
        memset(vq->vq_descx, 0, sizeof(struct vq_desc_extra) * vq->vq_nentries);
+       vq->vq_used_cons_idx = 0;
+       vq->vq_avail_idx     = 0;
+       if (vtpci_packed_queue(vq->hw)) {
+               vring_desc_init_packed(vr, size);
+       } else {
+               vq->vq_desc_head_idx = 0;
+               vq->vq_desc_tail_idx = (uint16_t)(vq->vq_nentries - 1);

- vring_desc_init(vr->desc, size);

+               vring_desc_init(vr->desc, size);
+       }

Maybe worth renaming to vring_desc_init_split() for consistency.

Maxime