Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

2018-09-03 Thread Ilya Maximets
On 03.09.2018 05:26, Tiwei Bie wrote: > On Thu, Aug 30, 2018 at 09:54:50AM +0300, Ilya Maximets wrote: >> On 30.08.2018 09:06, Tiwei Bie wrote: >>> On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: Any thoughts on this? >>> >>> Hi Ilya, >>> >>> Currently, the errors happened durin

[dpdk-dev] [PATCH] bus/pci: fix unexpected resource mapping override

2018-09-03 Thread Qi Zhang
When scanning an already plugged device, the virtual address of mapped PCI resource in rte_pci_device will be overridden with 0, that may cause driver does not work correctly. The fix is not to update any rte_pci_device's field if the being scanned device's driver is already probed. Bugzilla ID: 8

[dpdk-dev] [PATCH] bus/vdev: fix wrong error log on secondary device scan

2018-09-03 Thread Qi Zhang
When a secondary process handles VDEV_SCAN_ONE mp action, it is possible the device is already be inserted. This happens when we have multiple secondary processes which cause multiple broadcasts from primary during bus->scan. So we don't need to log any error for -EEXIST. Bugzilla ID: 84 Fixes: cd

[dpdk-dev] [PATCH v2] bus/vdev: fix wrong error log on secondary device scan

2018-09-03 Thread Qi Zhang
When a secondary process handles VDEV_SCAN_ONE mp action, it is possible the device is already be inserted. This happens when we have multiple secondary processes which cause multiple broadcasts from primary during bus->scan. So we don't need to log any error for -EEXIST. Bugzilla ID: 84 Fixes: cd

Re: [dpdk-dev] [Bug 87] build dpdk and example with different gcc version issue

2018-09-03 Thread Ferruh Yigit
On 8/31/2018 6:08 PM, Jerin Jacob wrote: > -Original Message- >> Date: Fri, 31 Aug 2018 11:04:06 +0100 >> From: Ferruh Yigit >> To: bugzi...@dpdk.org, dev@dpdk.org, Jerin Jacob >> , Santosh Shukla >> >> CC: Ajit Khaparde , Thomas Monjalon >> >> Subject: Re: [dpdk-dev] [Bug 87] build d

Re: [dpdk-dev] [PATCH 1/4] mk: use script to generate examples.dox

2018-09-03 Thread Luca Boccassi
On Mon, 2018-09-03 at 02:54 +0200, Thomas Monjalon wrote: > 31/08/2018 20:20, Luca Boccassi: > > +# SC2129 - avoid multiple individual redirects > > What is SC2129 ? shellcheck - will clarify in v2 > > +{ \ > > +printf '/**\n'; \ > > +printf '@page examples DPDK Example Programs\n\n'; \

Re: [dpdk-dev] [PATCH 2/4] mk: use templated doxygen config, modified on the fly

2018-09-03 Thread Luca Boccassi
On Mon, 2018-09-03 at 03:03 +0200, Thomas Monjalon wrote: > Good idea. > While at putting all in the same file (template), > we can re-organize the template a bit. > > 31/08/2018 20:20, Luca Boccassi: > > --- /dev/null > > +++ b/doc/api/doxy-api.conf.in > > @@ -0,0 +1,96 @@ > > +# SPDX-License-Ide

Re: [dpdk-dev] [PATCH v3] ppc64: fix compilation of when AltiVec is enabled

2018-09-03 Thread Adrien Mazarguil
Hi Christian, Couldn't follow up on this last week, however I still have some concerns and comments, please see below. On Thu, Aug 30, 2018 at 01:59:59PM +0200, Christian Ehrhardt wrote: > The definition of almost any newer standard like --stc=c11 will drop > __APPLCE_ALTIVEC__ which otherwise wo

[dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64

2018-09-03 Thread Jerin Jacob
Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. The GCC "internal compiler error" was observed only for arm64 architecture so disable the PMD only for arm64. Cc: sta...@dpdk.org Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Sign

Re: [dpdk-dev] [PATCH 4/4] build: generate API documentation with Meson

2018-09-03 Thread Luca Boccassi
On Mon, 2018-09-03 at 03:09 +0200, Thomas Monjalon wrote: > 31/08/2018 20:20, Luca Boccassi: > > Both a configuration-time "enable_docs" boolean option and an > > optional > > 'ninja doc' target are available. Note that due to a Meson bug for > > now > > the latter will only build, but not install

[dpdk-dev] [PATCH v2] vhost-user: drop connection on message handling failures

2018-09-03 Thread Ilya Maximets
There are a lot of cases where vhost-user massage handling could fail and end up in a fully not recoverable state. For example, allocation failures of shadow used ring and batched copy array are not recoverable and leads to the segmentation faults like this on the receiving/transmission path: Pr

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-09-03 Thread Zhang, Qi Z
Hi Robert: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > robertshear...@gmail.com > Sent: Saturday, August 25, 2018 12:35 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Robert Shearman > > Subject: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-I

Re: [dpdk-dev] [PATCH] doc: update for GTPv1 package release

2018-09-03 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Monday, September 3, 2018 1:41 PM > To: Mcnamara, John ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: [PATCH] doc: update for GTPv1 package release > > Add link of GTPv1 package release. > > Signed-off-by: Beilei Xing > --- > doc/guide

Re: [dpdk-dev] [PATCH] net/e1000: Typos (rx_offload<->tx_offload)

2018-09-03 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yaroslav Brustinov > Sent: Wednesday, August 8, 2018 5:45 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yaroslav Brustinov > Subject: [dpdk-dev] [PATCH] net/e1000: Typos (rx_offload<->tx_offload) > > Signed-off-by: Ya

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-03 Thread Joseph, Anoob
Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is s

Re: [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-09-03 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi > Sent: Tuesday, August 21, 2018 7:07 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > Subject: [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in > rte_eth_dev_reset >

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-09-03 Thread Robert Shearman
Hi Qi, On 03/09/2018 12:45, Zhang, Qi Z wrote: Hi Robert: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of robertshear...@gmail.com Sent: Saturday, August 25, 2018 12:35 AM To: dev@dpdk.org Cc: Lu, Wenzhuo ; Ananyev, Konstantin ; Robert Shearman Subject: [dpdk-d

Re: [dpdk-dev] [PATCH] mk: disable OcteonTx for buggy compilers only on arm64

2018-09-03 Thread Ferruh Yigit
On 9/3/2018 10:31 AM, Jerin Jacob wrote: > Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal > compiler error" for aarch64. The GCC "internal compiler error" was > observed only for arm64 architecture so disable the PMD only > for arm64. > > Cc: sta...@dpdk.org > Fixes: 4f760550

[dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Ferruh Yigit
Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC Rx offload capability. Applications that require keeping CRC should check PMD capability first and

[dpdk-dev] [PATCH] net/pcap: Generate unique MAC addresses for interfaces

2018-09-03 Thread Cian Ferriter
The MAC addresses are generated in the same manner as in the TAP PMD, where the address is based on the number of PCAP ports created. Signed-off-by: Cian Ferriter --- drivers/net/pcap/rte_eth_pcap.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/pcap/rt

[dpdk-dev] [PATCH v2] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-09-03 Thread Luca Boccassi
In case of a temporary failure the ixgbe driver can return the internal error IXGBE_ERR_RESET_FAILED to the application. Instead, return -EAGAIN as per the public API specification. Fixes: cddaf87a1ecb ("lib: fix unused values") Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- v2: added fixe

Re: [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-09-03 Thread Luca Boccassi
On Mon, 2018-09-03 at 12:54 +, Zhang, Qi Z wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi > > Sent: Tuesday, August 21, 2018 7:07 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > > > Subject: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [RFC 0/2] CPU non-blocking delay

2018-09-03 Thread Ilya Maximets
On 31.08.2018 16:39, Bruce Richardson wrote: > On Fri, Aug 31, 2018 at 03:45:15PM +0300, Ilya Maximets wrote: >> Sending as RFC because I failed to force meson to >> build without deprecation warnings. I tried a lot >> of different combinations of 'allow_experimental_apis' >> and '-DALLOW_EXPERIMEN

Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code

2018-09-03 Thread Ilya Maximets
On 31.08.2018 16:35, Bruce Richardson wrote: > The driver setting of "allow_experimental_apis" was not being used when > building the base code. To allow this we can manually put in a check > in the base code files for the setting and set the appropriate cflag > if it's needed. > > Signed-off-by:

[dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-09-03 Thread Ilya Maximets
For meson build without deprecation warnings following patch should be applied first: http://patches.dpdk.org/patch/44129/ Ilya Maximets (2): eal: add nanosleep based delay function drivers/net: use sleep delay by default for intel NICs drivers/net/avf/Makefile | 1

[dpdk-dev] [PATCH v1 1/2] eal: add nanosleep based delay function

2018-09-03 Thread Ilya Maximets
Add a new rte_delay_us_sleep() function that uses nanosleep(). This function can be used by applications to not implement their own nanosleep() based callback and by internal DPDK code if CPU non-blocking delay needed. Signed-off-by: Ilya Maximets --- lib/librte_eal/common/eal_common_timer.c

[dpdk-dev] [PATCH v1 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Ilya Maximets
NICs uses different delays up to a second during their configuration. It makes no sense to busy-wait so long wasting CPU cycles and preventing any other threads to execute on the same CPU core. These busy polling are the rudiments that came from the kernel drivers where you can not sleep in interru

Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code

2018-09-03 Thread Ilya Maximets
On 03.09.2018 17:41, Ilya Maximets wrote: > On 31.08.2018 16:35, Bruce Richardson wrote: >> The driver setting of "allow_experimental_apis" was not being used when >> building the base code. To allow this we can manually put in a check >> in the base code files for the setting and set the appropria

Re: [dpdk-dev] [PATCH] net/pcap: Generate unique MAC addresses for interfaces

2018-09-03 Thread Ferruh Yigit
On 9/3/2018 3:08 PM, Cian Ferriter wrote: > The MAC addresses are generated in the same manner as in the TAP PMD, > where the address is based on the number of PCAP ports created. > > Signed-off-by: Cian Ferriter > --- > drivers/net/pcap/rte_eth_pcap.c |6 ++ > 1 files changed, 6 inserti

Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code

2018-09-03 Thread Bruce Richardson
On Mon, Sep 03, 2018 at 05:52:58PM +0300, Ilya Maximets wrote: > On 03.09.2018 17:41, Ilya Maximets wrote: > > On 31.08.2018 16:35, Bruce Richardson wrote: > >> The driver setting of "allow_experimental_apis" was not being used when > >> building the base code. To allow this we can manually put in

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Andrew Rybchenko
On 09/03/2018 05:45 PM, Ferruh Yigit wrote: Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC Rx offload capability. Applications that require keep

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Wiles, Keith
> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: > > NICs uses different delays up to a second during their > configuration. It makes no sense to busy-wait so long wasting > CPU cycles and preventing any other threads to execute on the > same CPU core. These busy polling are the rudiments t

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Ilya Maximets
On 03.09.2018 18:14, Wiles, Keith wrote: > > >> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: >> >> NICs uses different delays up to a second during their >> configuration. It makes no sense to busy-wait so long wasting >> CPU cycles and preventing any other threads to execute on the >> same

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Wiles, Keith
> On Sep 3, 2018, at 4:33 PM, Ilya Maximets wrote: > > On 03.09.2018 18:14, Wiles, Keith wrote: >> >> >>> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: >>> >>> NICs uses different delays up to a second during their >>> configuration. It makes no sense to busy-wait so long wasting >>> C

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Ilya Maximets
On 03.09.2018 18:39, Wiles, Keith wrote: > > >> On Sep 3, 2018, at 4:33 PM, Ilya Maximets wrote: >> >> On 03.09.2018 18:14, Wiles, Keith wrote: >>> >>> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: NICs uses different delays up to a second during their configuration. It

Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs

2018-09-03 Thread Wiles, Keith
> On Sep 3, 2018, at 4:50 PM, Ilya Maximets wrote: > > On 03.09.2018 18:39, Wiles, Keith wrote: >> >> >>> On Sep 3, 2018, at 4:33 PM, Ilya Maximets wrote: >>> >>> On 03.09.2018 18:14, Wiles, Keith wrote: > On Aug 31, 2018, at 1:45 PM, Ilya Maximets wrote: > > NICs

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: fix illegal memory access when parsing flow match items

2018-09-03 Thread Ferruh Yigit
On 8/27/2018 1:53 PM, Rahul Lakkireddy wrote: > From: Shagun Agrawal > > Coverity issue: 293096 > Fixes: ee61f511 ("net/cxgbe: parse and validate flows") > Cc: sta...@dpdk.org > > Signed-off-by: Shagun Agrawal > Signed-off-by: Rahul Lakkireddy Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch

2018-09-03 Thread Ferruh Yigit
On 8/29/2018 8:16 AM, Andrew Rybchenko wrote: > From: Ian Dolzhansky > > Signed-off-by: Ian Dolzhansky > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd/cmdline.c | 91 ++ > doc/guides/rel_notes/release_18_11.rst | 6 ++ > 2 files changed, 97 inser

[dpdk-dev] Tx vlan offload problem with igb and DPDK v17.11

2018-09-03 Thread Victor Huertas
Hi all, I have realized that the PKT_TX_VLAN_PKT flag for Tx Vlan Offload doesn't work in my application. According to the NICs I have (IGB) there seems to be a problem with this vlan offload tx feature and this version of DPDK according to the Bug 17 : https://bugs.dpdk.org/show_bug.cgi?id=17 I

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-03 Thread Ananyev, Konstantin
Hi Anoob, > Hi Konstantin, > > Few comments. Please see inline. > > Thanks, > > Anoob > > On 24-08-2018 22:23, Konstantin Ananyev wrote: > > External Email > > > > This RFC introduces a new library within DPDK: librte_ipsec. > > The aim is to provide DPDK native high performance library for IP

Re: [dpdk-dev] [PATCH v2 02/10] kni: separate releasing netdev from freeing KNI interface

2018-09-03 Thread Dan Gora
Hi Ferruh, thanks for your feedback.. I apologize for the delay getting back to you on this.. On Wed, Aug 29, 2018 at 7:59 AM, Ferruh Yigit wrote: > You are right, that problem exits. > Although I don't see problem related to holding the kni_list_lock, polling > thread terminated before unregist

Re: [dpdk-dev] [PATCH v2 02/10] kni: separate releasing netdev from freeing KNI interface

2018-09-03 Thread Dan Gora
Hi Ferruh, I remembered now the motivation behind separating rte_kni_release() and rte_kni_free(). The problem is that the DPDK thread which calls rte_kni_release() _cannot_ be the same thread which handles callbacks from the KNI driver via rte_kni_handle_request(). This is because the thread wh

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

2018-09-03 Thread Dan Gora
Hi All, One other problem with using the sysfs method to change the link state rather than this ioctl method. The sysfs/netdev method to change the carrier was only introduced in kernel 3.9. For older kernels, we would just be out of luck. The ioctl method will work with any kernel version (2.6

Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, August 31, 2018 11:04 PM > To: Hunt, David > Cc: dev@dpdk.org; Yao, Lei A ; Nicolau, Radu > ; Burakov, Anatoly ; > Geary, John ; Ma, Liang J > Subject: [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control > > 1. A

Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: Ma, Liang J > Sent: Friday, August 31, 2018 11:04 PM > To: Hunt, David > Cc: dev@dpdk.org; Yao, Lei A ; Nicolau, Radu > ; Burakov, Anatoly ; > Geary, John ; Ma, Liang J > Subject: [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control > > 1. A

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-09-03 Thread Zhang, Qi Z
> -Original Message- > From: Robert Shearman [mailto:robertshear...@gmail.com] > Sent: Monday, September 3, 2018 9:14 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Robert Shearman > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VL

[dpdk-dev] [PATCH v2 00/33] Adding Cavium's OcteonTX crypto PMD

2018-09-03 Thread Anoob Joseph
Ankur Dwivedi (5): config: add Cavium OcteonTX crypto PMD skeleton common/cpt: add common logging support crypto/octeontx: add PCI probe and remove crypto/octeontx: add register addresses test: adds validation test Anoob Joseph (5): common/cpt: add common code for init routine crypto

[dpdk-dev] [PATCH v2 02/33] common/cpt: add common logging support

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Add common logging macros Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt

[dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Adding basic PCI probe/remove functions for OcteonTX crypto device. Initialization function for logging is also added. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman

[dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding code identified common for OcteonTX family crypto devices. This patch is adding the code required by the structures and code path of init routine. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Si

[dpdk-dev] [PATCH v2 08/33] crypto/octeontx: add hardware register access for misc poll

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding hardware register accesses required for misc poll Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree K

[dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim responsibility. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragot

[dpdk-dev] [PATCH v2 04/33] crypto/octeontx: add register addresses

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx/otx_cryptodev_hw_acce

[dpdk-dev] [PATCH v2 07/33] common/cpt: add hardware register defines

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_hw_types.h | 517 ++

[dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR This patch adds the symmetric algorithms capabilities supported by octeontx crypto hardware. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubra

[dpdk-dev] [PATCH v2 06/33] crypto/octeontx: add hardware init routine

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph Adding hardware init routine for OcteonTX crypto device. A place holder is added for misc polling routine. That will be added in the further patches. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed

[dpdk-dev] [PATCH v2 10/33] common/cpt: add PMD ops helper functions

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding pmd ops helper functions. Control path accessed APIs would be added as helper functions. Adding microcode defined macros etc as dependencies to the helper functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nit

[dpdk-dev] [PATCH v2 11/33] crypto/octeontx: add global resource init

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding initialization of global resources. This will be saved as metadata in cptvf and would be used by common code. Exit path for failure case is also added along with the new routines. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Sign

[dpdk-dev] [PATCH v2 15/33] crypto/octeontx: add queue pair functions

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding queue pair setup and release functions Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj

[dpdk-dev] [PATCH v2 17/33] crypto/octeontx: add session management ops

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding routines for session configure, session clear and get session size ops. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S

[dpdk-dev] [PATCH v2 14/33] common/cpt: add common macros for queue pair ops

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common macros required by queue pair op functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Teja

[dpdk-dev] [PATCH v2 16/33] common/cpt: add common code required for session management

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for session configure, session clear and get session size ops routines Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by:

[dpdk-dev] [PATCH v2 18/33] common/cpt: add common code for fill session data

2018-09-03 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for filling session data for AEAD, cipher & auth sessions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubra

[dpdk-dev] [PATCH v2 13/33] crypto/octeontx: add basic dev ops

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding the following dev ops, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - stats_get - stats_reset Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayarama

[dpdk-dev] [PATCH v2 12/33] crypto/octeontx: add mailbox routines

2018-09-03 Thread Anoob Joseph
From: Murthy NSSR Adding mailbox routines to interact with the pf driver Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kond

[dpdk-dev] [PATCH v2 23/33] common/cpt: add crypo op enqueue request manager framework

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding crypto enqueue op request manager framework. This routine won't submit to the hardware yet. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-b

[dpdk-dev] [PATCH v2 21/33] common/cpt: add microcode interface for encryption

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting encryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v2 20/33] common/cpt: add common defines for microcode

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_mcode_defines.h

[dpdk-dev] [PATCH v2 22/33] common/cpt: add microcode interface for decryption

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting decryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v2 24/33] common/cpt: add support for zuc and snow3g

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting ZUC and SNOW3G. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: T

[dpdk-dev] [PATCH v2 19/33] crypto/octeontx: add supported sessions

2018-09-03 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding AEAD, cipher & auth sessions support. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondo

[dpdk-dev] [PATCH v2 25/33] common/cpt: add support for kasumi

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting kasumi. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v2 26/33] common/cpt: add support for hash

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting verify and authentication Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v2 27/33] crypto/octeontx: add routines to prepare instructions

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Adding hardware specific routines which prepare cpt instructions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-o

[dpdk-dev] [PATCH v2 29/33] crypto/octeontx: add enqueue burst op

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx/otx_cryptodev_hw_ac

[dpdk-dev] [PATCH v2 28/33] common/cpt: add common code for enqueuing cpt instruction

2018-09-03 Thread Anoob Joseph
From: Srisivasubramanian S Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h |

[dpdk-dev] [PATCH v2 30/33] common/cpt: add common code for cpt dequeue

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h| 1

[dpdk-dev] [PATCH v2 31/33] crypto/octeontx: add dequeue burst op

2018-09-03 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx/otx_cryptodev_hw_ac

[dpdk-dev] [PATCH v2 32/33] test: adds validation test

2018-09-03 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds validation tests for octeontx crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejas

[dpdk-dev] [PATCH v2 33/33] doc: adds doc file

2018-09-03 Thread Anoob Joseph
From: Anoob Joseph This patch adds the features file and the document containing help to compile and use octeontx crypto. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: S

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Shahaf Shuler
Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. >

Re: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info

2018-09-03 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, August 30, 2018 6:54 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON > interface API info > > Signed-o

Re: [dpdk-dev] [PATCH 2/2] app/test-eventdev: add Tx adapter support

2018-09-03 Thread Rao, Nikhil
Hi Pavan, Few comments below. On 8/31/2018 4:10 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 216 +++- app/test-eve

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Andrew Rybchenko
On 09/04/2018 08:17 AM, Shahaf Shuler wrote: Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-09-03 Thread Zhang, Qi Z
Hi Ilya: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets > Sent: Friday, August 31, 2018 8:40 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Dai, Wei ; Ilya Maximets > ; sta...@dpdk.org > Subject: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt completion queue index wrapping

2018-09-03 Thread Shahaf Shuler
Tuesday, August 28, 2018 9:59 PM, Yongseok Koh: > wrapping > > > On Aug 23, 2018, at 4:10 PM, Xueming Li wrote: > > > > Rxq cq_ci was 16 bits while hardware is expecting to wrap around 24 > > bits, this caused interrupt failure after burst of packets. > > > > Fixes: 43e9d9794cde ("net/mlx5: suppo