Re: [dpdk-dev] 17.11.4 patches review and test

On Wed, 2018-08-22 at 23:29 +, Yongseok Koh wrote: > > On Aug 21, 2018, at 12:38 AM, Marco Varlese wrote: > > > > On Mon, 2018-08-20 at 22:35 +, Mody, Rasesh wrote: > > > > From: dev On Behalf Of Marco Varlese > > > > Sent: Monday, August 20, 2018 2:21 AM > > > > > > > > Hi, > > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

Hi From: Eric Kinzie > On Wed Aug 22 11:42:37 + 2018, Matan Azrad wrote: > > Hi Luca > > > > From: Luca Boccassi > > > On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > > > > Hi Chas > > > > > > > > From: Chas Williams > > > > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad > > > > >

Re: [dpdk-dev] vhost: initializing iotlb memory only when IOMMU feature is enabled.

Hi Ilya, Thanks for your comments. I haven't tested with IOMMU enabled. I covered more of memory utilization by testing OVS with DPDK. I will test out by enabling IOMMU and send the updated patch. Regards, Nitin -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sen

Re: [dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata

Hi David, On Mon, Aug 13, 2018 at 06:03:45PM +0200, David Marchand wrote: > Add some basic check on the segments offset and length metadata: > always funny to have a < 0 tailroom cast to uint16_t ;-). > > Signed-off-by: David Marchand > --- > lib/librte_mbuf/rte_mbuf.c | 2 ++ > 1 file changed,

Re: [dpdk-dev] 17.11.4 patches review and test

On Thu, 2018-08-23 at 09:04 +0200, Marco Varlese wrote: > On Wed, 2018-08-22 at 23:29 +, Yongseok Koh wrote: > > > On Aug 21, 2018, at 12:38 AM, Marco Varlese wrote: > > > > > > On Mon, 2018-08-20 at 22:35 +, Mody, Rasesh wrote: > > > > > From: dev On Behalf Of Marco Varlese > > > > > Se

[dpdk-dev] 18.11 Intel Roadmap

Now that the 18.08 release is complete, we need to update the roadmap for 18.11. The features that we plan to contribute are described below. We'll submit a patch to update the roadmap page with this info. Add Crypto Support to Packet Framework: A new Crypto port type will be added to the port

Re: [dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata

On Thu, Aug 23, 2018 at 9:39 AM, Olivier Matz wrote: > On Mon, Aug 13, 2018 at 06:03:45PM +0200, David Marchand wrote: >> Add some basic check on the segments offset and length metadata: >> always funny to have a < 0 tailroom cast to uint16_t ;-). >> >> Signed-off-by: David Marchand >> --- >> li

[dpdk-dev] [PATCH] doc: fix style and syntax errors in flow API guide

Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") Cc: sta...@dpdk.org Signed-off-by: Ilya Maximets --- doc/guides/howto/rte_flow.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/guides/howto/rte_flow.rst b/doc/guides/howto/rte_flow.rst in

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

On Thursday, August 08/23/18, 2018 at 07:45:27 +0530, Jack MIN wrote: > On Tue, Aug 21, 2018 at 01:44:32PM +0530, Rahul Lakkireddy wrote: > > On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote: > > > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote: > > > > On Tuesd

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

On Mon, 2018-08-13 at 19:21 +0100, luca.bocca...@gmail.com wrote: > Hi all, > > Here is a list of patches targeted for LTS release 16.11.8. Please > help review and test. The planned date for the final release is > August > the 23rd. > Before that, please shout if anyone has objections with these

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

On 22.08.2018 19:55, Ferruh Yigit wrote: On 8/14/2018 1:57 AM, Lu, Wenzhuo wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Monday, August 13, 2018 4:39 PM To: Lu, Wenzhuo ; Thomas Monjalon ; Yigit, Ferruh Cc: dev@dpdk.org Subject: R

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On 23-Aug-18 3:57 AM, Tiwei Bie wrote: Deadlock can occur when allocating memory if a vhost-kernel based virtio-user device is in use. Besides, it's possible to have much more than 64 non-contiguous hugepage backed memory regions due to the memory hotplug, which may cause problems when handling V

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] support MAC changes when no live changes allowed

On Wed, Aug 22, 2018 at 6:00 PM, Ferruh Yigit wrote: > On 7/18/2018 9:58 AM, Ferruh Yigit wrote: > > On 7/9/2018 6:14 PM, Alejandro Lucero wrote: > >> This is a patched to fix a functionality coming with the first public > >> release: changing/setting MAC address. > >> > >> The original patch ass

Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach

On 8/22/2018 6:13 PM, Ferruh Yigit wrote: > On 7/24/2018 2:17 PM, Wiles, Keith wrote: >> >> >>> On Jul 19, 2018, at 7:21 AM, ilia.kura...@intel.com wrote: >>> >>> From: Ilia Kurakin >>> >>> The patch changes rx_burst profiling approach: >>> 1. VTune's instrumentation is removed >>> 2. empt

Re: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

On 8/10/2018 7:40 PM, Fiona Trahe wrote: Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. v3 changes - squashed some patches - added mor

Re: [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit

> -Original Message- > From: Archbold, Brian > Sent: Wednesday, August 22, 2018 7:05 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Archbold, Brian ; > sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix duplicate exit > > In interactive mode, when the "qui

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On Thu, 23 Aug 2018 at 10:05, Burakov, Anatoly wrote: > > On 23-Aug-18 3:57 AM, Tiwei Bie wrote: > > Deadlock can occur when allocating memory if a vhost-kernel > > based virtio-user device is in use. Besides, it's possible > > to have much more than 64 non-contiguous hugepage backed > > memory re

Re: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

23/08/2018 13:12, Akhil Goyal: > Patchset applied to dpdk-next-crypto. > > Subject for "doc/qat: fix typos and make cosmetic changes" changed to > "doc/qat: correct typo and make cosmetic changes" > > to avoid git log error. Which error? Lack of Fixes tag? As a committer, you must be sure the F

Re: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

Hi Thomas, On 8/23/2018 4:54 PM, Thomas Monjalon wrote: 23/08/2018 13:12, Akhil Goyal: Patchset applied to dpdk-next-crypto. Subject for "doc/qat: fix typos and make cosmetic changes" changed to "doc/qat: correct typo and make cosmetic changes" to avoid git log error. Which error? Lack of

Re: [dpdk-dev] 17.11.4 patches review and test

23/08/2018 02:19, Yongseok Koh: > For the patchset, > - "mem: add function for checking memsegs IOVAs addresses" > This is adding a new API, so I don't expect any API/ABI breakage, but want > to > double-confirm with Thomas. Thomas? Yes, adding a function is not breaking API/ABI.

Re: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options

23/08/2018 13:28, Akhil Goyal: > Hi Thomas, > > On 8/23/2018 4:54 PM, Thomas Monjalon wrote: > > > 23/08/2018 13:12, Akhil Goyal: > >> Patchset applied to dpdk-next-crypto. > >> > >> Subject for "doc/qat: fix typos and make cosmetic changes" changed to > >> "doc/qat: correct typo and make cosmet

Re: [dpdk-dev] [PATCH v3] net/tap: add queues when attaching from secondary process

On 7/20/2018 12:15 PM, Thomas Monjalon wrote: > From: Raslan Darawsheh > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronizati

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

On 7/30/2018 4:30 PM, Andrew Rybchenko wrote: > On 30.07.2018 17:40, Jerin Jacob wrote: >> -Original Message- >>> Date: Mon, 30 Jul 2018 14:12:12 + >>> From: "Ananyev, Konstantin" >>> To: Jerin Jacob >>> CC: Thomas Monjalon , "dev@dpdk.org" , >>> "Yigit, Ferruh" , "shah...@mellanox.

[dpdk-dev] [PATCH 00/11] introduce telemetry library

This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

[dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

This patch adds the infrastructure and initial code for the telemetry library. A virtual device is used for telemetry, which is included in this patch. To use telemetry, a command-line argument must be used - "--vdev=telemetry". Control threads are used to get CPU cycles for telemetry, which are

[dpdk-dev] [PATCH 02/11] telemetry: add initial connection socket

This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold

[dpdk-dev] [PATCH 03/11] telemetry: add client feature and sockets

This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a client socket setup for f

[dpdk-dev] [PATCH 05/11] telemetry: update metrics before sending stats

This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent patch. Signed-off-by:

[dpdk-dev] [PATCH 06/11] telemetry: format json response when sending stats

This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold --- lib/librte_telemetry/rte_tel

[dpdk-dev] [PATCH 04/11] telemetry: add parser for client socket messages

This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent patch, however the

[dpdk-dev] [PATCH 07/11] telemetry: add tests for telemetry api

This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in the Telemetry API suc

[dpdk-dev] [PATCH 08/11] telemetry: add vdev kvargs for selftest

This patch adds functionality to run the selftest by passing in an argument to vdev, "selftest". To run the tests that were added in the previous patch, the argument "selftest=1" must be added to the vdev arguments. This will enable the user to run telemetry with or without tests, as required. Si

[dpdk-dev] [PATCH 09/11] doc: add telemetry documentation

This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold --- doc/guides/howto/index.rst | 1 + doc/guides/howto/telemetry.rst | 86

[dpdk-dev] [PATCH 11/11] telemetry: add collectd plugin patch

This patch adds the patch for the collectd plugin developed for use with the DPDK Telemetry library. The patch is included here to allow users to apply the patch to collectd when using DPDK Telemetry. Further details on applying the collectd patch can be found in the collectd patch commit message.

[dpdk-dev] [PATCH 10/11] usertools: add client python script for telemetry

This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py "file_path". This script is

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

On 7/5/2018 1:34 PM, Wiles, Keith wrote: > > >> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon wrote: >> >> 04/07/2018 21:47, Ferruh Yigit: >>> On 6/12/2018 3:02 PM, Ophir Munk wrote: Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 a

Re: [dpdk-dev] [RFC] ethdev: add generic L2/L3 tunnel encapsulation actions

On 7/30/2018 5:19 PM, Ori Kam wrote: > Currenlty the encap/decap actions only support encapsulation > of VXLAN and NVGRE L2 packets. > There is a need to add more L2 tunnels and also L3 tunnels. > > One issue with the current approch is the duplication of code. > For example the code for handling

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

On Tue, 2018-08-21 at 10:40 +0800, Tiwei Bie wrote: > On Mon, Aug 20, 2018 at 05:45:35PM +0100, Luca Boccassi wrote: > > On Mon, 2018-08-20 at 16:18 +0800, Tiwei Bie wrote: > > > On Thu, Aug 16, 2018 at 07:49:43PM +0100, Luca Boccassi wrote: > > > > On Thu, 2018-08-16 at 19:47 +0100, Luca Boccassi

Re: [dpdk-dev] [PATCH] crypto/qat: fix typo

On 8/10/2018 8:50 PM, Trahe, Fiona wrote: Corrected subject - only 1 patch here. -Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 4:19 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: [PATCH 1/2] crypto

Re: [dpdk-dev] [PATCH] compress/qat: use compression specific driver name

On 8/13/2018 8:08 PM, Jozwiak, TomaszX wrote: -Original Message- From: Trahe, Fiona Sent: Friday, August 10, 2018 5:18 PM To: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo ; Jozwiak, TomaszX Cc: Trahe, Fiona Subject: [PATCH] compress/qat: use compression specific driver

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support

On 7/25/2018 3:19 PM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/esp.c | 3 +++ examples/ipsec-secgw/sa.c| 11 ++- 3 files changed, 15 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

On 8/1/2018 10:03 PM, Stephen Hemminger wrote: > On Wed, 1 Aug 2018 18:03:04 + > Yongseok Koh wrote: > >>> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger >>> wrote: >>> >>> On Tue, 31 Jul 2018 18:48:40 +0200 >>> Adrien Mazarguil wrote: >>> On Tue, Jul 31, 2018 at 09:30:54AM -0700,

Re: [dpdk-dev] [dpdk-announce] CFP for DPDK Summit Userspace

The agenda for this event is now available at: https://dpdkuserspace2018.sched.com/. All of the proposals that were submitted were of a very high standard, so it was a difficult job to decide which ones to accept/reject. Anybody who had a proposal that was rejected should consider resubmitting

Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device

On 2018-08-19 08:11, Jerin Jacob wrote: > I would like to include this driver for v18.08. Please send the next > the version in order to complete review before giving RC1 pull request. > I've been working on a test bench with real packet I/O and some more reasonable load to verify load balancing

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On 8/6/2018 4:50 PM, Chas Williams wrote: > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon wrote: > >> 02/08/2018 15:38, Doherty, Declan: >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote: When a bonding port is stopped also stop and deactivate all slaves. Otherwise slaves will be still lis

Re: [dpdk-dev] [PATCH] net/bonding: add support to match on 0x88A8 ethertype

On 8/16/2018 1:56 PM, Chas Williams wrote: > On Tue, Aug 7, 2018 at 4:11 AM wangyunjian wrote: > >> From: Yunjian Wang >> >> We assume VLAN ethtertype is 0x8100 in get_vlan_offset() function, >> but it could be 0x88A8 if QinQ is supported. >> >> Signed-off-by: Yunjian Wang >> > > Acked-by: Cha

Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device

-Original Message- > Date: Thu, 23 Aug 2018 15:08:29 +0200 > From: Mattias Rönnblom > To: Jerin Jacob > CC: dev@dpdk.org, bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) > event device > User-Agent: Mozilla/5.0 (X11; Linux x86_64; r

Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter

On 8/3/2018 2:36 PM, Adrien Mazarguil wrote: > This is a follow up to the "Flow API helpers enhancements" series submitted > almost a year ago [1]. The new title is due to the reduced scope of this > version. > > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a > temporary so

Re: [dpdk-dev] [PATCH v1 1/1] crypto/openssl: replace macros by static inline functions

On 7/31/2018 7:46 PM, Ashish Gupta wrote: Replace macros by static inline functions in openssl version compatibility layer Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h | 265 ++-

Re: [dpdk-dev] [PATCH] app/testbbdev: fix inputs mbuf creation issue

On 8/17/2018 12:49 PM, Kamil Chalupnik wrote: Omitting inputs and outputs mbuf creation for BaseBand Null Device as inputs and outputs data do not exist for Null Device Fixes: b2a4654f082b ("mempool: check for zero size creation") Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Kamil Chalu

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support

On 7/25/2018 3:19 PM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/esp.c | 3 +++ examples/ipsec-secgw/sa.c| 11 ++- 3 files changed, 15 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v1 1/1] crypto/openssl: replace macros by static inline functions

On 7/31/2018 7:46 PM, Ashish Gupta wrote: Replace macros by static inline functions in openssl version compatibility layer Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

On 8/7/2018 3:20 PM, Jack Min wrote: > There is a need to offload rewrite MAC address for both destination and source > from the matched flow > > The proposed actions could make above easily achieved > > > Signed-off-by: Xiaoyu Min mailto:jack...@mellanox.com>> Looks good to me. @Adrien, @Andr

Re: [dpdk-dev] [RFC] ethdev: add generic TTL rewrite actions

On 8/7/2018 3:20 PM, Jack Min wrote: > There is a need to rewrite TTL by decrease or just set it directly, > and it's not necessary to check if the final result is zero or not. > > This is slightly different from the one defined by openflow and > make the actions more generic. > > > > > Signed

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On 23-Aug-18 12:19 PM, Sean Harte wrote: On Thu, 23 Aug 2018 at 10:05, Burakov, Anatoly wrote: On 23-Aug-18 3:57 AM, Tiwei Bie wrote: Deadlock can occur when allocating memory if a vhost-kernel based virtio-user device is in use. Besides, it's possible to have much more than 64 non-contiguous

Re: [dpdk-dev] [PATCH 1/4] netvsc: chimney buffer size error handling

On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > Fix the error handling in setting up transmit buffer. > If setting up chimney buffer fails, then it is not connected so > no need to send disconnect. > > Allow for some unused area if full area is not used. > > Signed-off-by: Stephen Hemminger sub

Re: [dpdk-dev] [PATCH 2/4] bus/vmbus: add host latency tuning function

On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > Add vmbus API to allow tuning the scan interval on the host side. > > Signed-off-by: Stephen Hemminger <...> > @@ -20,6 +20,7 @@ DPDK_18.08 { > rte_vmbus_probe; > rte_vmbus_register; > rte_vmbus_scan; > + rte_vmbus_set_latenc

Re: [dpdk-dev] [PATCH 4/4] netvsc: implement tx_done_cleanup

On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > Add tx_done_cleanup ethdev hook to allow application to > control if/when it wants completions to be handled. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/netvsc/hn_ethdev.c | 1 + > drivers/net/netvsc/hn_rndis.c | 2 +- > drivers/ne

Re: [dpdk-dev] [PATCH 0/4] netvsc performance enhancements

On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > Some more netvsc performance related changes. > The biggest benefit comes from lowering the hypervisor polling rate > from 100us to 50us. Supporting tx_done_cleanup can also help some > applications get through the send completions faster. > > Steph

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit wrote: > On 8/6/2018 4:50 PM, Chas Williams wrote: > > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon > wrote: > > > >> 02/08/2018 15:38, Doherty, Declan: > >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote: > When a bonding port is stopped also stop

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On Thu, 23 Aug 2018 at 15:01, Burakov, Anatoly wrote: > > On 23-Aug-18 12:19 PM, Sean Harte wrote: > > On Thu, 23 Aug 2018 at 10:05, Burakov, Anatoly > > wrote: > >> > >> On 23-Aug-18 3:57 AM, Tiwei Bie wrote: > >>> Deadlock can occur when allocating memory if a vhost-kernel > >>> based virtio-us

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

On 8/13/2018 9:03 AM, Dekel Peled wrote: > Adding relevant maintainers. > >> -Original Message- >> From: Dekel Peled [mailto:dek...@mellanox.com] >> Sent: Monday, August 13, 2018 10:47 AM >> To: dev@dpdk.org >> Cc: Ori Kam ; Shahaf Shuler >> >> Subject: [RFC] ethdev: support metadata as

Re: [dpdk-dev] [PATCH 1/4] netvsc: chimney buffer size error handling

On Thu, 23 Aug 2018 15:45:17 +0100 Ferruh Yigit wrote: > On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > > Fix the error handling in setting up transmit buffer. > > If setting up chimney buffer fails, then it is not connected so > > no need to send disconnect. > > > > Allow for some unused area

Re: [dpdk-dev] [PATCH 2/4] bus/vmbus: add host latency tuning function

On Thu, 23 Aug 2018 15:45:44 +0100 Ferruh Yigit wrote: > On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > > Add vmbus API to allow tuning the scan interval on the host side. > > > > Signed-off-by: Stephen Hemminger > > <...> > > > @@ -20,6 +20,7 @@ DPDK_18.08 { > > rte_vmbus_probe; > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

On Thu, Aug 23, 2018 at 3:28 AM Matan Azrad wrote: > Hi > > From: Eric Kinzie > > On Wed Aug 22 11:42:37 + 2018, Matan Azrad wrote: > > > Hi Luca > > > > > > From: Luca Boccassi > > > > On Wed, 2018-08-22 at 07:09 +, Matan Azrad wrote: > > > > > Hi Chas > > > > > > > > > > From: Chas Will

Re: [dpdk-dev] [PATCH v3] netvsc: resize event buffer as needed

On 8/14/2018 5:45 PM, Stephen Hemminger wrote: > The event buffer was changed to be a fixed size value, > had a couple of issues. The big one is that rte_free was still > being called for a pointer that was not setup with rte_malloc(). > > The event buffer was also too small to handle heavy receiv

[dpdk-dev] 17.11.4 will be released on Aug 30

Hi, all Testings seem to be still ongoing, there was a compilation error fixed and there were missing patches. Therefore, I'll postpone the release by a week. I'll release -rc2 on this Friday (or weekend) and GA will be on Aug 30 if I get testing results by the time. Thanks for your understandi

Re: [dpdk-dev] 17.11.4 patches review and test

> On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: > > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: >> Hi Yonngseok, >> >> There is a patchset aimed at 17.11.x: >> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fcover%2F42741%2F&da

Re: [dpdk-dev] [PATCH v3 0/6] PMD driver for AF_XDP

Hi Zhang Qi, I'm not familiar with DPDK code, but I'm curious about the benefits of using AF_XDP pmd, specifically I have a couple questions: 1) With zero-copy driver support, is AF_XDP pmd expects to have similar performance than other pmd? Since AF_XDP is still using native device driver, isn't

Re: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx

On 8/17/2018 5:06 PM, santosh wrote: > > On Friday 17 August 2018 08:00 PM, Jerin Jacob wrote: >> LMTST does not guarantee packet content get synced with L2C when >> HW access the packet for transmitting. >> >> Adding coherent IO write barrier will make sure HW sees the correct >> packet if its mo

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix style and syntax errors in flow API guide

On 8/23/2018 9:05 AM, Ilya Maximets wrote: > Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") > Cc: sta...@dpdk.org > > Signed-off-by: Ilya Maximets Acked-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix style and syntax errors in flow API guide

On 8/23/2018 5:32 PM, Ferruh Yigit wrote: > On 8/23/2018 9:05 AM, Ilya Maximets wrote: >> Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Ilya Maximets > > Acked-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [RFC 01/10] vhost: define postcopy protocol flag

Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index b02673d4a..b3cc6990d 100644 --- a/lib/librte_vhost/rte_vhost.h +++ b/lib

[dpdk-dev] [RFC 00/10] vhost: add postcopy live-migration support

This RFC adds support for postcopy live-migration. With classic live-migration, the VM runs on source while its content is being migrated to destination. When pages already migrated to destination are dirtied by the source, they get copied until both source and destination memory converge. At that

[dpdk-dev] [RFC 04/10] vhost: introduce postcopy's advise message

This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 2 ++ lib/librte_vhost/vhost_user.c | 37 +++ lib/librte_vhost

[dpdk-dev] [RFC 03/10] vhost: enable fds passing when sending vhost-user messages

Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/lib/librte_

[dpdk-dev] [RFC 02/10] vhost: add number of fds to vhost-user messages and use it

As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This is preliminary work to support sending fds to Qemu. Signed-off-by: Dr. David Alan Gilbert Si

[dpdk-dev] [RFC 05/10] vhost: add support for postcopy's listen message

Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 18 ++ lib/librte_vhost/vhost_user.h | 4 +++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b

[dpdk-dev] [RFC 06/10] vhost: register new regions with userfaultfd

Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index d93febbc3..1c75d8015 100644 --- a/lib/librte_vhos

[dpdk-dev] [RFC 07/10] vhost: avoid useless VhostUserMemory copy

The VHOST_USER_SET_MEM_TABLE payload is copied when handled, whereas it could directly be referenced. This is not very important, but next, we'll need to update the payload and send it back to Qemu. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost

[dpdk-dev] [RFC 08/10] vhost: send userfault range addresses back to qemu

Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 48 --- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 0861feff1..29e3e2a07

[dpdk-dev] [RFC 10/10] vhost: enable postcopy protocol feature

Enable postcopy protocol feature except if dequeue zero-copy is enabled. In this case, guest memory requires to be populated, which is not compatible with userfaultfd. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 7 +++ lib/librte_

[dpdk-dev] [RFC 09/10] vhost: add support to postcopy's end request

The master sends this message before stopping handling userfaults, so that the backend closes the userfaultfd. The master waits for the slave to acknowledge the request with an empty 64bits payload for synchronization purpose. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH 0/8] Improve running DPDK without hugetlbfs mounpoint

This patchset further improves DPDK support for running without hugetlbfs mountpoints. First of all, it enables using memfd-created hugepages in in-memory mode. This way, instead of anonymous hugepages, we can get proper fd's for each page (or for the entire segment, if we're using single-file seg

[dpdk-dev] [PATCH 1/8] fbarray: fix detach in noshconf mode

In noshconf mode, no shared files are created, but we're still trying to unlink them, resulting in detach/destroy failure even though it should have succeeded. Fix it by exiting early in noshconf mode. Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode") Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH 8/8] mem: support using memfd segments for in-memory mode

Enable using memfd-created segments if supported by the system. This will allow having real fd's for pages but without hugetlbfs mounts, which will enable in-memory mode to be used with virtio. The implementation is mostly piggy-backing on existing real-fd code, except that we no longer need to u

[dpdk-dev] [PATCH 4/8] memalloc: rename lock list to fd list

Previously, we were only using lock lists to store per-page lock fd's because we cannot use modern fcntl() file description locks to lock parts of the page in single file segments mode. Now, we will be using this list to store either lock fd's (along with memseg list fd) in single file segments mo

[dpdk-dev] [PATCH 7/8] mem: add external API to retrieve page fd from EAL

Now that we can retrieve page fd's internally, we can expose it as an external API. This will add two flavors of API - thread-safe and non-thread-safe. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 47 ++ lib/librte_eal/common/include/rte_mem

[dpdk-dev] [PATCH 5/8] memalloc: track page fd's in non-single file mode

Previously, we were only tracking lock file fd's in single-file segments mode, but did not track fd's in non-single file mode because we didn't need to (mmap() call still kept the lock). Now that we are going to expose these fd's to the world, we need to have access to them, so track them even in n

[dpdk-dev] [PATCH 3/8] mem: raise maximum fd limit unconditionally

Previously, when we allocated hugepages, we closed the fd's corresponding to them after we've done our mappings. Since we did mmap(), we didn't actually lose the reference, but file descriptors used for mmap() do not count against the fd limit. Since we are going to store all of our fd's, we will h

[dpdk-dev] [PATCH 2/8] eal: don't allow legacy mode with in-memory mode

In-memory mode was never meant to support legacy mode, because we cannot sort anonymous pages anyway. Fixes: 72b49ff623c4 ("mem: support --in-memory mode") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_options.c | 6 ++ 1 file changed, 6 insertions(

[dpdk-dev] [PATCH 6/8] memalloc: add EAL-internal API to get and set segment fd's

Enable setting and retrieving segment fd's internally. For now, retrieving fd's will not be used anywhere until we get an external API, but it will be useful for things like virtio, where we wish to share segment fd's. Setting segment fd's will not be available as a public API at this time, but i

Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device

On 2018-08-23 15:44, Jerin Jacob wrote: -Original Message- Date: Thu, 23 Aug 2018 15:08:29 +0200 From: Mattias Rönnblom To: Jerin Jacob CC: dev@dpdk.org, bruce.richard...@intel.com Subject: Re: [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device User-Agent: Moz

Re: [dpdk-dev] [RFC v2] ethdev: add flow metadata

> On Aug 20, 2018, at 8:45 AM, Ferruh Yigit wrote: > > On 6/26/2018 9:54 AM, Xueming Li wrote: >> Currently, rte_flow pattern only match packet header fields. >> This patch adds additional data to match the packet. >> >> For example, in egress direction, to do an action depending on the VM >> i

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > rte_errno is a per thread variable and is widely used as an > error indicator, which means a function could affect > other functions' results by setting rte_errno carelessly > > During rxq setup, an EINVAL rte_errno is expected since >

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

On Wed, Aug 22, 2018 at 04:31:14PM +0300, Andrew Rybchenko wrote: > On 13.08.2018 10:46, Dekel Peled wrote: > > Current implementation of rte_flow allows match pattern of flow rule, > > based on packet data or header fields. > > This limits the application use of match patterns. > > > > For exampl

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

On Wed, Aug 22, 2018 at 12:13:19PM +, Ananyev, Konstantin wrote: > Hi Dekel, > > > > > > > > > > > > > > > > -Original Message- > > > > > From: Dekel Peled [mailto:dek...@mellanox.com] > > > > > Sent: Monday, August 13, 2018 10:47 AM > > > > > To: dev@dpdk.org > > > > > Cc: Ori Kam ; S

[dpdk-dev] [PATCH] net/mlx5: fix interrupt completion queue index wrapping

Rxq cq_ci was 16 bits while hardware is expecting to wrap around 24 bits, this caused interrupt failure after burst of packets. Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: Shahaf Shuler Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- drivers/net/mlx5/mlx

Re: [dpdk-dev] [PATCH 07/11] telemetry: add tests for telemetry api

On Thu, 23 Aug 2018 13:08:09 +0100 Ciara Power wrote: > This patch adds all tests for the Telemetry API. > The tests added include a parser test, selftest, and socket > messaging tests. > > The parser tests pass valid and invalid messages to the parser > to ensure the correct return values are r

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > + > +static int > +telemetry_probe(struct rte_vdev_device *vdev) > +{ > + int ret; > + > + RTE_SET_USED(vdev); > + ret = rte_telemetry_init(rte_socket_id()); > + if (ret < 0) { > + printf("Error - Telemetry initia

  1   2   >