On 8/6/2018 4:50 PM, Chas Williams wrote:
> On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon <tho...@monjalon.net> wrote:
>
>> 02/08/2018 15:38, Doherty, Declan:
>>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
>>>> When a bonding port is stopped also stop and deactivate all slaves.
>>>> Otherwise slaves will be still listed as active.
>>>>
>>>> Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
>>>> Cc: sta...@dpdk.org
>>>>
>>>> Signed-off-by: Radu Nicolau <radu.nico...@intel.com>
>>>
>>> Acked-by: Declan Doherty <declan.dohe...@intel.com>
>>
>> Waiting for opinion from the other bonding maintainer (Chas)
>> who started to review and has some doubts.
>>
>
> The slaves being listed as active is not a bug. If the slaves are not
> deactivated, then they should be considered activated. Previously,
> stopping the bonding PMD just reset the active slave count. That's
> not the right way to deactivate slaves. This was fixed by 69bce062132b.
>
> This patch is new behavior of explicitly deactivating the slaves when
> the bonding PMD is stopped.
>
> As I mentioned, I think this makes life difficult for those of us using
> an external state machine. However, that should probably be fixed
> differently then.
>
>
>>
>> Chas, please do you agree with Declan's ack?
>>
>>
>>
> Change the Fixes line.
Hi Chas,
Are you OK with the rest of the patch if Fixes line fixed?
If already have a proposed fixes line I can fix it while merging.
Thanks,
ferruh
