On 26/06/2018 08:08, Qi Zhang wrote:
The patch implemented the ops scan_one for vdev bus, it gives two benifits
1. Improve scan efficiency when a device is attached as hotplug, since no
need to pupulate a new device by iterating all devargs in devargs_list.
2. It also avoid sync IPC invoke (whi
Acked-by: Ori Kam
> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Thursday, June 21, 2018 10:14 AM
> To: dev@dpdk.org; Adrien Mazarguil ;
> Wenzhuo Lu ; Jingjing Wu
> ; Bernard Iremonger
> ; Mohammad Abdul Awal
> ; Ori Kam ;
> Stephen Hemminger
>
Implement EAL alarm API support for FreeBSD. The implementation
is largely identical to that of Linux version, with one key
difference.
The alarm API is a little Linux-centric in that it is expecting
the alarm API to manage alarm timeouts without involvement of the
interrupt thread. This works on
From: Jianfeng Tan
Alarm API is going to be used by IPC internally. However, because
memory subsystem depends on IPC, alarm API cannot use rte_malloc as
it creates a circular dependency.
To avoid such chicken and egg problem, we change to use glibc malloc
in the alarm API.
Signed-off-by: Jianfe
From: Jianfeng Tan
IPC uses interrupts API internally, and memory subsystem uses IPC.
Therefore, IPC should not use rte_malloc to avoid circular dependency.
Switch to using regular glibc malloc in interrupts API.
Signed-off-by: Jianfeng Tan
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/li
From: Jianfeng Tan
Next commit will make asynchronous IPC requests rely on alarm API,
which in turn relies on interrupts to work. Therefore, move the EAL
interrupt initialization before IPC initialization to avoid breaking
IPC in the next commit.
Signed-off-by: Jianfeng Tan
Signed-off-by: Anato
Previously, we were using two IPC threads - one to handle messages
and synchronous requests, and another to handle asynchronous requests.
To handle replies for an async request, rte_mp_handle woke up the
rte_mp_handle_async thread to process through pthread_cond variable.
Change it to handle async
Add interrupt thread to FreeBSD. It is largely a copy-paste from
Linuxapp interrupt thread, except for a few key differences:
* Use kevent instead of epoll
* Do not recreate the event queue on adding/removing interrupt
sources, add/remove them to/from the queue on the fly instead
* No support fo
For asynchronous requests, user callback may be triggered either from
IPC thread or from interrupt thread. Because of this, delivery of
other interrupt-based events such as alarms may not be possible inside
the asynchronous IPC request callback handler. Document this
limitation.
Signed-off-by: Ana
As previously discussed [1], IPC threads need to be removed and their
workload moved to interrupt thread. However, due to upcoming changes
for multiprocess hotplug, it was decided to leave one IPC thread in
place for now to avoid deadlocks on memory allocation attempts [2].
FreeBSD did not have an
On 6/20/2018 7:22 PM, Ferruh Yigit wrote:
> On 6/19/2018 3:37 PM, ido goshen wrote:
>> Fixes: 4c173302c307 ("pcap: add new driver")
>> Cc: sta...@dpdk.org
>>
>> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
>> and not loop num_of_queue times
>> The num_of_queue loop is al
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Saturday, June 23, 2018 9:09 AM
> To: Iremonger, Bernard ; dev@dpdk.org
> Cc: ai...@redhat.com; jan.scheur...@ericsson.com; vkapl...@redhat.com;
> Richardson, Bruce ; tho...@monjalon.net;
>
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Saturday, June 23, 2018 9:09 AM
> To: Iremonger, Bernard ; dev@dpdk.org
> Cc: ai...@redhat.com; jan.scheur...@ericsson.com; vkapl...@redhat.com;
> Richardson, Bruce ; tho...@monjalon.net;
>
2018-06-26 13:07 GMT+02:00 Daria Kolistratova :
> When the number of rx queues is 0
> (what can be when application does not receive)
> failed with SIGFPE. It happens when the application
> is also requesting ETH_MQ_RX_RSS_FLAG in the
> rte_dev->data->dev_conf.rxmode.mq_mode.
> Fixed adding zero rx
Ack.
Thanks
Shally
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 26 June 2018 14:50
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATC
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 26 June 2018 14:53
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 5/6] crypto/
The threshold of buffer replenishment for vectorized Rx burst is a constant
value (64). If the size of Rx queue is comparatively small, device could
run out of buffers. For example, if the size of Rx queue is 128, buffers
are replenished only twice per a wraparound. This can cause jitter in
receivi
mlx5_rx_poll_len() returns Rx hash result extracted from either mini CQE or
regular CQE. As mini CQE may not have the hash result if configured
otherwise, it shouldn't assume the first DWORD of mini CQE is always hash
result. mlx5_rx_poll_len() is changed to return pointer to the mini CQE if
compre
Stride index is added to mlx5_mini_cqe8 structure and WQE ID is added to
mlx5_cqe structure.
Signed-off-by: Yongseok Koh
Acked-by: Shahaf Shuler
---
drivers/net/mlx5/mlx5_prm.h | 9 +++--
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/dr
> On Jun 26, 2018, at 4:37 AM, Yongseok Koh wrote:
>
> Stride index is added to mlx5_mini_cqe8 structure and WQE ID is added to
> mlx5_cqe structure.
>
> Signed-off-by: Yongseok Koh
> Acked-by: Shahaf Shuler
> ---
Please disregard this patchset. It has been sent mistakenly.
Will send out v2.
Tuesday, June 19, 2018 4:05 AM, Ferruh Yigit:
> Subject: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header
>
> Macro moved to header to be able to convert logging usage in header.
> And since it has been moved to public header changed naming and added
> RTE prefix, ethdev_log -> RTE_ETHDE
From: Liang Ma
1. Abstract
For packet processing workloads such as DPDK polling is continuous.
This means CPU cores always show 100% busy independent of how much work
those cores are doing. It is critical to accurately determine how busy
a core is hugely important for the following reasons:
On 26-Jun-18 8:08 AM, Qi Zhang wrote:
When hot plug a new device, it is not necessary to scan everything
on the bus since the devname and devargs are already there. So new
rte_bus ops "scan_one" is introduced, bus driver can implement this
function to simplify the hotplug process.
Signed-off-by:
From: Liang Ma
Add the support for new traffic pattern aware power control
power management API.
Example:
./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3
-P --config="(0,0,xx),(1,0,xx)" --empty-poll
Please Reference l3fwd-power document for all parameter except
empty-pol
Tuesday, June 19, 2018 12:36 AM
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Tuesday, June 19, 2018 12:36 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v3 1/3] testpmd: add ability to set tx IP and UD
Hi Qi
Please see comments\questions..
From: Qi Zhang
> Add driver API rte_eth_release_port_private to support the requirement that
> an ethdev only be released on secondary process, so only local state be set to
> unused , share data will not be reset so primary process can still use it.
>
> Sig
Hi Stephan,
Tuesday, June 19, 2018 12:36 AM, Stephen Hemminger:
> Subject: [dpdk-dev] [PATCH v3 1/3] testpmd: add ability to set tx IP and UDP
> parameters
>
> Use RFC standard values for Tx only test as defaults.
> But let the user override those values on command line.
I think it is a good fl
On 26-Jun-18 8:08 AM, Qi Zhang wrote:
Introduce new API rte_eal_register_mp_init that help to register
a callback function which will be invoked right after multi-process
channel be established (rte_mp_channel_init). Typically the API
will be used by other module that want it's mp channel action
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 26 June 2018 03:04
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 1/6] lib/cry
Hi Jeff
Please see comments...
From: Jeff Guo
> Sent: Friday, June 22, 2018 2:51 PM
> To: step...@networkplumber.org; bruce.richard...@intel.com;
> ferruh.yi...@intel.com; konstantin.anan...@intel.com;
> gaetan.ri...@6wind.com; jingjing...@intel.com; Thomas Monjalon
> ; Mordechay Haimovsky ;
> Ma
On 26-Jun-18 8:08 AM, Qi Zhang wrote:
The sample code demonstrate device (ethdev only) management
at multi-process envrionment. User can attach/detach a device
on primary process and see it is synced on secondary process
automatically, also user can lock a device to prevent it be
detached or unlo
On 26-Jun-18 8:08 AM, Qi Zhang wrote:
We are going to introduce the solution to handle different hotplug
cases in multi-process situation, it include below scenario:
1. Attach a share device from primary
2. Detach a share device from primary
3. Attach a share device from secondary
4. Detach a sh
On 26-Jun-18 10:56 AM, Olivier Matz wrote:
rte_eal_mbuf_default_mempool_ops() is replaced by
rte_mbuf_best_mempool_ops().
Signed-off-by: Olivier Matz
---
Reviewed-by: Anatoly Burakov
--
Thanks,
Anatoly
HI Maxime, Jens
Saturday, June 23, 2018 11:09 AM, Maxime Coquelin:
> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
> simulate a noisy neighbour
>
> From: Jens Freimann
>
> This adds a new forwarding mode to testpmd to simulate more realistic
> behavior of a guest machine en
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 26, 2018 8:09 PM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: Re: [PATCH v4 06/24] ethde
26/06/2018 13:41, Shahaf Shuler:
> Tuesday, June 19, 2018 4:05 AM, Ferruh Yigit:
> > Subject: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header
> >
> > Macro moved to header to be able to convert logging usage in header.
> > And since it has been moved to public header changed naming and
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 26, 2018 7:48 PM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: Re: [PATCH v4 01/24] eal:
mlx5_rx_poll_len() returns Rx hash result extracted from either mini CQE or
regular CQE. As mini CQE may not have the hash result if configured
otherwise, it shouldn't assume the first DWORD of mini CQE is always hash
result. mlx5_rx_poll_len() is changed to return pointer to the mini CQE if
compre
For the RFC,
https://mails.dpdk.org/archives/dev/2018-June/103664.html
Yongseok Koh (5):
net/mlx5: change return value of Rx completion poll
net/mlx5: add new fields in Rx completion entry
net/mlx5: add warning message for Multi-Packet RQ
net/mlx5: use stride index in Rx completion ent
Stride index is added to mlx5_mini_cqe8 structure and WQE ID is added to
mlx5_cqe structure.
Signed-off-by: Yongseok Koh
Acked-by: Shahaf Shuler
---
drivers/net/mlx5/mlx5_prm.h | 9 +++--
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/dr
Multi-Packet Receive Queue is to receive multiple packets on a single large
buffer. The number of consumed strides in CQE is accumulated to keep track
of the current stride index. However, it is safer to directly use stride
index in CQE to avoid out-of-order situation which can possibly be caused
b
If WQE ID is used in CQE for Multi-Packet RQ, the ratio of CQE compression
drops a little bit. In order to reach to 100Gbps with 64B traffic, it is
needed to further save PCIe bandwidth by increasing the number of strides
in a WQE. It is now 64 by default but adjustable by a PMD parameter -
mprq_l
If Multi-Packet RQ is enabled but not supported by device or
kernel/library, print out a warning message.
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 49b4
Hi Nelio,
> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Thursday, June 21, 2018 8:14 AM
> To: dev@dpdk.org; Adrien Mazarguil ; Lu,
> Wenzhuo ; Wu, Jingjing ;
> Iremonger, Bernard ; Awal, Mohammad Abdul
> ; Ori Kam ;
> Stephen Hemminger
> Subject
Hi Pavan,
Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh:
> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev
> args
>
> Currently, the only way of supplying device argument to a pci device is to
> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible
Hi Nelio,
> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Thursday, June 21, 2018 8:14 AM
> To: dev@dpdk.org; Adrien Mazarguil ; Lu,
> Wenzhuo ; Wu, Jingjing ;
> Iremonger, Bernard ; Awal, Mohammad Abdul
> ; Ori Kam ;
> Stephen Hemminger
> Subject
On 26-Jun-18 1:19 PM, Zhang, Qi Z wrote:
-Original Message-
From: Burakov, Anatoly
Sent: Tuesday, June 26, 2018 8:09 PM
To: Zhang, Qi Z ; tho...@monjalon.net
Cc: Ananyev, Konstantin ; dev@dpdk.org;
Richardson, Bruce ; Yigit, Ferruh
; Shelton, Benjamin H
; Vangati, Narender
Subject: Re
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 26, 2018 8:50 PM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: Re: [PATCH v4 06/24] ethde
On 26/6/2018 12:40 PM, Radu Nicolau wrote:
From: Liang Ma
Add the support for new traffic pattern aware power control
power management API.
Example:
./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3
-P --config="(0,0,xx),(1,0,xx)" --empty-poll
Please Reference l3fwd-p
On 26/6/2018 12:40 PM, Radu Nicolau wrote:
From: Liang Ma
1. Abstract
For packet processing workloads such as DPDK polling is continuous.
This means CPU cores always show 100% busy independent of how much work
those cores are doing. It is critical to accurately determine how busy
a core is
On 26-Jun-18 1:58 PM, Zhang, Qi Z wrote:
my understand is peer is identified by a string (or filename)
what I mean is clone the content of the buffer that peer point to ,
So I don't need to worry if the original peer be used to point to some other
data
As far as the application is concerned,
Hi Adrien,
Better late than never, please find below some comments
about your patch.
On Thu, Apr 19, 2018 at 05:13:53PM +0200, Adrien Mazarguil wrote:
> Disclaimer: this patch must not be confused with the CLI library [1]
> (work in progress) that will eventually supersede librte_cmdline itself
>
Getting the bar size is required for NFP CPP interface configuration.
However, this information can be obtained from the VFIO or UIO driver
instead of accessing the sysfs resource file.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 27 +-
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 26, 2018 9:21 PM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: Re: [PATCH v4 06/24] ethde
Hi Matan:
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Tuesday, June 26, 2018 7:50 PM
> To: Zhang, Qi Z ; Thomas Monjalon
> ; Burakov, Anatoly
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati,
NFP CPP interface dinamically configures NFP CPP BARs for accessing
any NFP chip component from user space. This requires to map PCI BAR
regions specifically. However, this does not require to do such map
over the usual map done by VFIO or UIO drivers with the device PCI
BARs.
This patch avoids th
> -Original Message-
> From: Zhang, Qi Z
> Sent: Tuesday, June 26, 2018 9:29 PM
> To: 'Matan Azrad' ; Thomas Monjalon
> ; Burakov, Anatoly
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: RE: [dpdk-
> I noticed a bad behavior change (in addition to many good ones):
> ctrl-c now quits the application, and this was not the case before.
> I often use ctrl-c to delete the line I'm currently editing. Please
> see at the end a proposition to restore this feature.
And now, ladies and gentlemen, the
Hello,
is there any progress on this?
Thank you,
Maxim.
On 19.06.2018 12:20, Elo, Matias (Nokia - FI/Espoo) wrote:
I think this should handle the unlink case you mention, however perhaps you
have identified a genuine bug. If you have more info or a sample config / app
that easily demonstrat
On 6/26/2018 1:17 PM, Shahaf Shuler wrote:
> HI Maxime, Jens
>
> Saturday, June 23, 2018 11:09 AM, Maxime Coquelin:
>> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
>> simulate a noisy neighbour
>>
>> From: Jens Freimann
>>
>> This adds a new forwarding mode to testpmd to sim
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, June 26, 2018 12:38 PM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; step...@networkplumber.org; De Lara Guarch, Pablo
> ; sta...@dpdk.org
> Subject: [PATCH v3] kni: fix build with gcc 8.1
>
> Error observed when CONFIG_RTE_KNI_KMOD_
On 26-Jun-18 2:25 PM, Zhang, Qi Z wrote:
-Original Message-
From: Burakov, Anatoly
Sent: Tuesday, June 26, 2018 9:21 PM
To: Zhang, Qi Z ; tho...@monjalon.net
Cc: Ananyev, Konstantin ; dev@dpdk.org;
Richardson, Bruce ; Yigit, Ferruh
; Shelton, Benjamin H
; Vangati, Narender
Subject: Re
> -Original Message-
> From: Burakov, Anatoly
> Sent: Tuesday, June 26, 2018 9:46 PM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: Re: [PATCH v4 06/24] ethde
Hi Yipeng,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yipeng Wang
> Sent: Friday, June 8, 2018 11:51 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara,
> John ; Richardson, Bruce
> ; honnappa.nagaraha...@arm.com;
> vgu...@caviumne
On 26-Jun-18 3:24 PM, Zhang, Qi Z wrote:
-Original Message-
From: Burakov, Anatoly
Sent: Tuesday, June 26, 2018 9:46 PM
To: Zhang, Qi Z ; tho...@monjalon.net
Cc: Ananyev, Konstantin ; dev@dpdk.org;
Richardson, Bruce ; Yigit, Ferruh
; Shelton, Benjamin H
; Vangati, Narender
Subject: Re
On Fri, Jun 22, 2018 at 11:19:14AM +0100, Mohammad Abdul Awal wrote:
> On 22/06/2018 10:08, Nélio Laranjeiro wrote:
> > On Fri, Jun 22, 2018 at 09:51:15AM +0100, Mohammad Abdul Awal wrote:
> > >
> > > On 22/06/2018 09:31, Nélio Laranjeiro wrote:
> > > > On Fri, Jun 22, 2018 at 08:42:10AM +0100, Mo
Hi,
On Tue, Jun 26, 2018 at 12:48:42PM +, Iremonger, Bernard wrote:
> Hi Nelio,
>
> > -Original Message-
> > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> > Sent: Thursday, June 21, 2018 8:14 AM
> > To: dev@dpdk.org; Adrien Mazarguil ; Lu,
> > Wenzhuo ; Wu, Jingjing ;
>
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> Patchset against dpdk-next-net contains bug fixes,
> some code refactoring and style cleanup.
>
> Please apply.
>
> Ajit Khaparde (15):
> net/bnxt: fix clear port stats
> net/bnxt: add Tx batching support
> net/bnxt: Rx processing optimization
>
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> We are not cleaning up all the memory and also not unregistering
> the driver during device close operation. This patch fixes the issue.
>
> Fixes: 893074951314 (net/bnxt: free memory in close operation)
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ajit K
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> Add support for StingRay VF device 0xd800
Can you please document new supported device on doc/guides/nics/bnxt.rst
> Signed-off-by: Ajit Khaparde
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> From: Scott Branden
>
> Cleanup alignment, brackets, debug string style of bnxt_rxr
>
> Signed-off-by: Scott Branden
> Reviewed-by: Randy Schacher
> Reviewed-by: Ajit Khaparde
> ---
> drivers/net/bnxt/bnxt_rxr.c | 58
> --
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> In preparation of more rte_flow support it has been decided to
> separate out filter and flow into their own files. Functionally the
> same.
>
> Signed-off-by: Michael Wildt
> Signed-off-by: Scott Branden
> Signed-off-by: Ajit Khaparde
Preferred pa
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> From: Jay Ding
>
> Add checking for VNIC id before sending message to firmware in
> bnxt_hwrm_vnic_plcmode_cfg().
Can you please add more information, when fw_vnic_id == INVALID_HW_RING_ID, what
does it mean to have fw_vnic_id == INVALID_HW_RING_ID,
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> From: Rob Miller
>
> update HWRM API to v1.9.2.9
Does it make sense to update release notes to document this update?
>
> Signed-off-by: Rob Miller
> Reviewed-by: Scott Branden
> Reviewed-by: Ajit Kumar Khaparde
> Reviewed-by: Randy Schacher
> S
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> In bnxt_free_filter_mem(), check the filter type and call the
> appropriate HWRM command to clear the filter from HW.
Just to double check, is this check to fix an issue? If so do you want to
backport the fix into stable trees?
>
> Signed-off-by: Aji
hi, gaetan,
thanks for your review, see comment as bellow
On 6/22/2018 8:59 PM, Gaëtan Rivet wrote:
Hi Jeff,
Sorry, I followed this development from afar,
I have a remark regarding this API, I think it can be made simpler.
Details below.
On Fri, Jun 22, 2018 at 07:51:05PM +0800, Jeff Guo wro
On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> There is no need to update hardware configuration if new MTU is
> not greater than the max data the mbuf can accommodate.
If app sets a smaller MTU won't it expect that HW will drop received packets
bigger than provided size? Will this logic work if HW
hi, matan
thanks for your review, see comment.
On 6/26/2018 7:58 PM, Matan Azrad wrote:
Hi Jeff
Please see comments...
From: Jeff Guo
Sent: Friday, June 22, 2018 2:51 PM
To: step...@networkplumber.org; bruce.richard...@intel.com;
ferruh.yi...@intel.com; konstantin.anan...@intel.com;
gaetan.r
When a hardware device is removed physically or the software disables
it, the hot unplug occur. App need to call ether dev API to detach the
device, to unplug the device at the bus level and make access to the device
invalid. But the problem is that, the removal of the device from the
software list
When hot unplug device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt d
This patch introduces a failure handler mechanism to handle device
hot unplug event. When device be hot plug out, the device resource
become invalid, if this resource is still be unexpected read/write,
system will crash.
This patch let framework help application to handle this fault. When
sigbus e
Use testpmd for example, to show how an application smoothly handle
failure when device being hot unplug. If app have enabled the device event
monitor and register the hot plug event’s callback before running, once
app detect the removal event, the callback would be called. It will first
stop the p
On 6/26/2018 1:48 PM, Shahaf Shuler wrote:
> Hi Pavan,
>
> Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh:
>> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev
>> args
>>
>> Currently, the only way of supplying device argument to a pci device is to
>> whitelist it i.e. -w 00
Hi Yipeng,
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, June 8, 2018 11:51 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara,
> John ; Richardson, Bruce
> ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subje
On 6/26/2018 1:25 PM, Thomas Monjalon wrote:
> 26/06/2018 13:41, Shahaf Shuler:
>> Tuesday, June 19, 2018 4:05 AM, Ferruh Yigit:
>>> Subject: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header
>>>
>>> Macro moved to header to be able to convert logging usage in header.
>>> And since it has
On 6/20/2018 9:37 AM, Alex Kiselev wrote:
> add functions to add/remove MAC addresses
> Signed-off-by: Alex Kiselev
Acked-by: Declan Doherty
Acked-by: Chas Williams
Applied to dpdk-next-net/master, thanks.
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, June 8, 2018 11:51 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara,
> John ; Richardson, Bruce
> ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATC
vhost: vhost_user.c code cleanup
This patchesries introduce a set of code redesigns in vhost_user.c.
The goal is to unify and simplify vhost-user message handling. The
patches do not intend to introduce any functional changes.
---
Nikolay Nikolaev (5):
vhost: unify VhostUserMsg usage
Use the typedef version of struct VhostUserMsg. Also unify the related
parameter name.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 50 +
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c
Add new functions to handle the unsupported vhost message types:
- vhost_user_set_vring_err
- vhost_user_set_log_fd
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/v
As VhostUserMsg structure is resued to generate the reply, move the
relevant fields update into the respective message handling functions.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff
Each vhost-user message handlign function will return an int result
which is described in the new enum vh_result: error, OK and reply.
All functions will now have two arguments, virtio_net double pointer
and VhostUserMsg pointer.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c
Introduce vhost_message_handlers, which maps the message request
type to the message handler. Then replace the switch construct
with a map and call.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 144 -
1 file changed, 55 insertions(+
ethdev layer introduced checks for application requested RSS hash
functions and returns error for ones unsupported by hardware
This check breaks some sample applications which blindly configures
RSS hash functions without checking underlying hardware support.
Updated examples to mask out unsuppor
On Tue, Jun 26, 2018 at 12:26:05PM +, Zhang, Qi Z wrote:
>
>
> > -Original Message-
> > From: Burakov, Anatoly
> > Sent: Tuesday, June 26, 2018 7:48 PM
> > To: Zhang, Qi Z ; tho...@monjalon.net
> > Cc: Ananyev, Konstantin ; dev@dpdk.org;
> > Richardson, Bruce ; Yigit, Ferruh
> > ; She
From: Daria Kolistratova
When the number of rx queues is 0
(what can be when application does not receive)
failed with SIGFPE. It happens when the application
is also requesting ETH_MQ_RX_RSS_FLAG in the
rte_dev->data->dev_conf.rxmode.mq_mode.
Fixed adding zero rx queues check.
Signed-off-by: Da
On 6/26/2018 6:38 PM, Ferruh Yigit wrote:
> From: Daria Kolistratova
I re-send the Daria's patch, somehow it didn't appeared in mail list and
patchwork.
>
> When the number of rx queues is 0
> (what can be when application does not receive)
> failed with SIGFPE. It happens when the application
Hi Zhang
From: Zhang, Qi Z
> Sent: Tuesday, June 26, 2018 4:30 PM
> To: Matan Azrad ; Thomas Monjalon
> ; Burakov, Anatoly
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Richardson, Bruce ; Yigit, Ferruh
> ; Shelton, Benjamin H
> ; Vangati, Narender
>
> Subject: RE: [dpdk-dev] [PATCH v4 03/24] et
This patchset introduces a new EAL API for querying devices,
filtered by arbitrary properties.
The following elements are introduced to this end:
* A new object, "rte_class", is used to describe
the device class abstraction layer (eth, crypto, ...).
* Both rte_bus and rte_class now offer a
rte_devargs_parse becomes non-variadic,
rte_devargs_parsef becomes the variadic version, to be used to compose
device strings.
Signed-off-by: Gaetan Rivet
---
drivers/net/failsafe/failsafe_args.c| 2 +-
drivers/net/failsafe/failsafe_eal.c | 2 +-
lib/librte_eal/common/eal_commo
101 - 200 of 246 matches
Mail list logo
