On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > From: Scott Branden <scott.bran...@broadcom.com> > > Cleanup alignment, brackets, debug string style of bnxt_rxr > > Signed-off-by: Scott Branden <scott.bran...@broadcom.com> > Reviewed-by: Randy Schacher <stuart.schac...@broadcom.com> > Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > --- > drivers/net/bnxt/bnxt_rxr.c | 58 > ++++++++++++++++++++++++--------------------- > drivers/net/bnxt/bnxt_rxr.h | 6 +++-- > 2 files changed, 35 insertions(+), 29 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index e4d473f4b..13928c388 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -72,7 +72,6 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue > *rxq, > if (rx_buf == NULL) > PMD_DRV_LOG(ERR, "Jumbo Frame. rx_buf is NULL\n"); > > - > rx_buf->mbuf = mbuf; > mbuf->data_off = RTE_PKTMBUF_HEADROOM; > > @@ -82,7 +81,7 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue > *rxq, > } > > static inline void bnxt_reuse_rx_mbuf(struct bnxt_rx_ring_info *rxr, > - struct rte_mbuf *mbuf) > + struct rte_mbuf *mbuf)
Hi Scott, Since this patch is only for syntax updates, should we expect this to follow DPDK coding convention [1]? It seems you have align new line to parenthesis but according dpdk coding style new line should have a tab: http://doc.dpdk.org/guides/contributing/coding_style.html#definitions This is same for other syntax fix patches. Note: The coding style discussion is never to end and I don't have any intention to have one, I believe what matters is consistency, please check coding style documentation before sending syntax fix patches. Also I believe syntax fix patches are not best idea, unless it is fixing a real readability issue. It corrupts the git history and makes harder to backport fixes. Specially when it is not contributing the consistency as well I suggest dropping the patch. [1] http://doc.dpdk.org/guides/contributing/coding_style.html
