On 6/19/2018 10:30 PM, Ajit Khaparde wrote:
> We are not cleaning up all the memory and also not unregistering
> the driver during device close operation. This patch fixes the issue.
>
> Fixes: 893074951314 (net/bnxt: free memory in close operation)
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
<...>
> @@ -3408,13 +3410,15 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
> }
>
> static int
> -bnxt_dev_uninit(struct rte_eth_dev *eth_dev) {
> +bnxt_dev_uninit(struct rte_eth_dev *eth_dev)
> +{
> struct bnxt *bp = eth_dev->data->dev_private;
> int rc;
>
> if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> return -EPERM;
>
> + PMD_DRV_LOG(INFO, "Calling Device uninit\n");
This looks like can be a debug message, what do you think?
<...>
> @@ -3456,7 +3469,7 @@ static int bnxt_pci_remove(struct rte_pci_device
> *pci_dev)
> static struct rte_pci_driver bnxt_rte_pmd = {
> .id_table = bnxt_pci_id_map,
> .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
> - RTE_PCI_DRV_INTR_LSC,
> + RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV,
Is Remove interrupts really supported? I can't find the related code in the
driver.
You need to call _rte_eth_dev_callback_process() for RTE_ETH_EVENT_INTR_RMV
where you handle the interrupt.
And announce the feature "Removal event" in bnxt.ini
