Re: [dpdk-dev] [PATCH] maintainers: change maintainership

2018-06-23 Thread Thomas Monjalon
22/06/2018 17:25, Ferruh Yigit: > On 6/22/2018 10:13 AM, Helin Zhang wrote: > > Xiaoyun Li has agreed to take over the maintainership of example > > application tep_termination, as Jijiang Liu is no longer working > > on that. > > > > Signed-off-by: Helin Zhang > > Acked-by: Ferruh Yigit > > T

Re: [dpdk-dev] [PATCH v2] net/i40e: remove VF interrupt handler

2018-06-23 Thread Stephen Hemminger
On Fri, 22 Jun 2018 08:44:14 +0800 Qi Zhang wrote: > For i40evf, internal rx interrupt and adminq interrupt share the same > source, that cause a lot cpu cycles be wasted on interrupt handler > on rx path. This is complained by customers which require low latency > (when set I40E_ITR_INTERVAL to

[dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-06-23 Thread Kumar, Ravi1
Hi, As the memory subsystem in DPDK 18.05 is reworked, it has introduced a problem for AMD EPYC 2P platforms. The issue is that DPDK 18.05 only works with up to 4 NUMAs. For AMD EPYC 2P platforms, DPDK now only works with P0 (NUMA 0-3) and does not work with P1 (NUMA 4-7). The problem can be f

Re: [dpdk-dev] netvsc PMD driver update plan

2018-06-23 Thread Stephen Hemminger
On Fri, 22 Jun 2018 09:17:37 +0200 Thomas Monjalon wrote: > 22/06/2018 01:32, Stephen Hemminger: > > I have some updates to the netvsc driver that use external mbuf's and fix > > a couple of bugs. Would you rather: > > * new (V11) version consolidating those > > * sequence of patches agai

Re: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions

2018-06-23 Thread Verma, Shally
Hi Pablo >-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal >Sent: 21 June 2018 18:29 >To: Pablo de Lara ; declan.dohe...@intel.com; >ravi1.ku...@amd.com; Jacob, Jerin >; roy.fan.zh...@intel.com; >fiona.tr...@intel.com; t...@semihalf.com; >jianjay.z...@

Re: [dpdk-dev] [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev

2018-06-23 Thread Verma, Shally
Hi Pablo >-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 15 June 2018 14:10 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; >Athreya, Narayana Prasad >; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v3 1/6]

Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count

2018-06-23 Thread Maxime Coquelin
On 06/15/2018 03:48 PM, Maxime Coquelin wrote: The log_cache_nb_elem was never incremented, resulting in all dirty pages to be missed during live migration. Fixes: c16915b87109 ("vhost: improve dirty pages logging performance") Cc:sta...@dpdk.org Reported-by: Peng He Cc: Ilya Maximets Signed

Re: [dpdk-dev] [PATCH] vhost: fix potential null pointer dereference

2018-06-23 Thread Maxime Coquelin
On 06/22/2018 05:53 AM, Tiwei Bie wrote: Coverity issue: 293097 Fixes: d90cf7d111ac ("vhost: support host notifier") Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost_user.c | 2 ++ 1 file changed, 2 insertions(+) Applied to dpdk-next-virtio/master. Thanks, Maxime

[dpdk-dev] [PATCH v2 0/7] vhost: generalize buffer vectors

2018-06-23 Thread Maxime Coquelin
This second revision fixes the arguments swapped in copy_mbuf_to_desc call. This series is again preliminray work to ease packed ring layout integration. Main changes are using vector buffres also in the dequeue path, and perform IOVA to HVA translation at vectors fill time. I still have to run

[dpdk-dev] [PATCH v2 2/7] vhost: make gpa to hpa failure an error

2018-06-23 Thread Maxime Coquelin
CVE-2018-1059 fix makes sure gpa contiguous memory is also contiguous in hva space. Incidentally, it also makes sure it is contiguous in hpa space. So we can simplify the code by making gpa contiguous memory discontiguous in hpa space an error. Signed-off-by: Maxime Coquelin --- lib/librte_vhos

[dpdk-dev] [PATCH v2 1/7] vhost: use shadow used ring in dequeue path

2018-06-23 Thread Maxime Coquelin
Relax used ring contention by reusing the shadow used ring feature used by enqueue path. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 45 ++- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/lib/librte_vhost/virtio_net.

[dpdk-dev] [PATCH v2 3/7] vhost: use buffer vectors in dequeue path

2018-06-23 Thread Maxime Coquelin
To ease packed ring layout integration, this patch makes the dequeue path to re-use buffer vectors implemented for enqueue path. Doing this, copy_desc_to_mbuf() is now ring layout type agnostic. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 143 ++---

[dpdk-dev] [PATCH v2 6/7] vhost: prefetch first descriptor in dequeue path

2018-06-23 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 0980efe53..115bb885d 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -1076,6

[dpdk-dev] [PATCH v2 5/7] vhost: improve prefetching in dequeue path

2018-06-23 Thread Maxime Coquelin
This is an optimization to prefetch next buffer while the current one is being processed. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c i

[dpdk-dev] [PATCH v2 4/7] vhost: translate iovas at vectors fill time

2018-06-23 Thread Maxime Coquelin
This patch aims at simplifying the desc to mbuf and mbuf to desc copy functions. It performs the iova to hva translations at vectors fill time. Doing this, in case desc buffer isn't contiguous in hva space, it gets split into multiple vectors. Signed-off-by: Maxime Coquelin --- lib/librte_vhost

[dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-23 Thread Maxime Coquelin
From: Jens Freimann This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footpri

[dpdk-dev] [PATCH v4 0/2] testpmd: simulating noisy host environment

2018-06-23 Thread Maxime Coquelin
This forth version is a rebase of Jen's v3, fixing meson build and checkpatch errors. Some checkpatch warnings remain to keep consistency with other code. This series adds a new forwarding mode 'noisy'. It proposes enhancements to testpmd to simulate more realistic behavior of a guest machine eng

[dpdk-dev] [PATCH v4 2/2] testpmd: update testpmd doc to include noisy forwarding mode

2018-06-23 Thread Maxime Coquelin
From: Jens Freimann Signed-off-by: Jens Freimann --- doc/guides/testpmd_app_ug/run_app.rst | 27 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +-- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/d

[dpdk-dev] [PATCH v2 7/7] vhost: improve prefetching in enqueue path

2018-06-23 Thread Maxime Coquelin
This is an optimization to prefetch next buffer while the current one is being processed. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.

Re: [dpdk-dev] netvsc PMD driver update plan

2018-06-23 Thread Thomas Monjalon
22/06/2018 18:58, Stephen Hemminger: > On Fri, 22 Jun 2018 09:17:37 +0200 > Thomas Monjalon wrote: > > > 22/06/2018 01:32, Stephen Hemminger: > > > I have some updates to the netvsc driver that use external mbuf's and fix > > > a couple of bugs. Would you rather: > > > * new (V11) version conso

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-06-23 Thread Verma, Shally
Hi Pablo >-Original Message- >From: Verma, Shally >Sent: 18 June 2018 11:00 >To: 'De Lara Guarch, Pablo' >Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; >Athreya, Narayana Prasad >; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto suppor

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-06-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Saturday, June 23, 2018 1:42 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-06-23 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 23 June 2018 23:47 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; >Athreya, Narayana Prasad >; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/

[dpdk-dev] [PATCH 1/3] net/qede: fix unicast MAC address handling in VF

2018-06-23 Thread Rasesh Mody
From: Shahed Shaikh We did not register unicast mac configuration handlers for VF causing failure in bonding of VFs. Also, mac_addr_set operation requires mac_remove followed by mad_add. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- driv

[dpdk-dev] [PATCH 2/3] net/qede: fix legacy interrupt mode

2018-06-23 Thread Rasesh Mody
From: Shahed Shaikh qede pmd does not have support for legacy interrupt mode. This causes slow path completion failure with uio_pci_generic module, since it uses legacy interrupt (INTx) mode. Fix this issue by installing legacy interrupt handler. Fixes: ec94dbc57362 ("qede: add base driver") Cc

[dpdk-dev] [PATCH 3/3] net/qede: remove primary MAC removal

2018-06-23 Thread Rasesh Mody
This was added to dev_stop when set MTU requested vport restart. We are not requiring vport restart any more with set MTU as it just needs vport to be inactive and doesn't need the port reconfigured. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Rasesh Mody --- drivers/net/

[dpdk-dev] [PATCH v5 1/2] net/tap: calculate checksums of multi segs packets

2018-06-23 Thread Ophir Munk
Prior to this commit IP/UDP/TCP checksum offload calculations were skipped in case of a multi segments packet. This commit enables TAP checksum calculations for multi segments packets. The only restriction is that the first segment must contain headers of layers 3 (IP) and 4 (UDP or TCP) Reviewed-

[dpdk-dev] [PATCH v5 0/2] TAP TSO

2018-06-23 Thread Ophir Munk
v1: - Initial release v2: - Fixing cksum errors - TCP segment size refers to TCP payload size (not including l2,l3,l4 headers) v3 (8 May 2018): - Bug fixing in case input mbuf is segmented - Following review comments by Raslan Darawsha This patch implements TAP TSO (TSP segmentation offload) i

[dpdk-dev] [PATCH v5 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-23 Thread Ophir Munk
This commit implements TCP segmentation offload in TAP. librte_gso library is used to segment large TCP payloads (e.g. packets of 64K bytes size) into smaller MTU size buffers. By supporting TSO offload capability in software a TAP device can be used as a failsafe sub device and be paired with anot

[dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one

2018-06-23 Thread Shahaf Shuler
The generic tunnel TSO was depended in the regular one capabilities to be enabled. Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_txq.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_txq