Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 15 June 2018 14:10 >To: Verma, Shally <shally.ve...@cavium.com> >Cc: Trahe, Fiona <fiona.tr...@intel.com>; akhil.go...@nxp.com; dev@dpdk.org; >Athreya, Narayana Prasad ><narayanaprasad.athr...@cavium.com>; Sahu, Sunila <sunila.s...@cavium.com>; >Gupta, Ashish <ashish.gu...@cavium.com> >Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev > //snip
> >... > >> +/** >> + * Asymmetric Cryptographic Operation. >> + * >> + * Structure describing asymmetric crypto operation params. >> + * >> + */ >> +struct rte_crypto_asym_op { >> + struct rte_cryptodev_asym_session *session; >> + /**< Handle for the initialised session context */ >> + > >Looking at the xform structure, it looks like a chain of xforms is possible. >Looking at this union, this case wouldn't be possible, as only one item from >the union can be set. [Shally] xforms, which support chaining, would need to have op_type in their respective xform struct. Example struct rte_crypto_dh_xform, where app can chain Deffie-hellman public and/or shared secret compute and DSA sign compute. +struct rte_crypto_dh_xform { + enum rte_crypto_asym_op_type type; + /**< Setup xform for key generate or shared secret compute */ and DSA xforms struct test_cryptodev_asym illustrates how to setup chained dh+dsa ops. Thanks Shally > //snip