Re: [dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:16:44 +0300 Arnon Warshavsky wrote: > replace panic calls with log and return value. > Local functions to this file, > changing from void to int are non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- >

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:16:53 +0300 Arnon Warshavsky wrote: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes comments, and alerts in the case > of a positive balance between additions and removals.

Re: [dpdk-dev] [PATCH v3 0/5] fix control thread affinities

2018-04-24 Thread Thomas Monjalon
> Olivier Matz (5): > eal: use sizeof to avoid a double use of a define > eal: new function to create control threads > eal: set name when creating a control thread > eal: set affinity for control threads > examples: use new API to create control threads Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/6] mempool: add bucket driver

2018-04-24 Thread Thomas Monjalon
Can we have this patchset in 18.05-rc1? Or is it candidate to rc2? 16/04/2018 15:33, Andrew Rybchenko: > The patch series adds bucket mempool driver which allows to allocate > (both physically and virtually) contiguous blocks of objects and adds > mempool API to do it. It is still capable to provi

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Thomas Monjalon
25/04/2018 00:52, Stephen Hemminger: > On Wed, 25 Apr 2018 01:16:53 +0300 > Arnon Warshavsky wrote: > > > This patch adds a new function that is called > > per every checked patch, > > and alerts for new instances of rte_panic/rte_exit. > > The check excludes comments, and alerts in the case > >

Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-24 Thread Stephen Hemminger
On Wed, 25 Apr 2018 01:03:20 +0200 Thomas Monjalon wrote: > 25/04/2018 00:52, Stephen Hemminger: > > On Wed, 25 Apr 2018 01:16:53 +0300 > > Arnon Warshavsky wrote: > > > > > This patch adds a new function that is called > > > per every checked patch, > > > and alerts for new instances of rte_

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > Hi Andrew, Yongseok, > > > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > On 04/2

Re: [dpdk-dev] [PATCH v2 3/5] eal: make eal_log_level save private

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > +int rte_eal_log_save_regexp(const char *regex, int tmp) The prefix rte_log_ is preferred over rte_eal_log_.

Re: [dpdk-dev] [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > /* enable all PMD logs (whose identifier string starts with "pmd") */ > - rte_log_set_level_regexp("pmd.*", RTE_LOG_DEBUG); > + rte_log_set_level_match("pmd.*", RTE_LOG_DEBUG); The function name in the doc above does not match (sic) the new function name be

Re: [dpdk-dev] [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Thomas Monjalon
24/04/2018 18:58, Stephen Hemminger: > +/* set log level based on glob (file match) pattern */ > +int > +rte_log_set_level_pattern(const char *pattern, uint32_t level) This new function is not listed in the map file.

Re: [dpdk-dev] [PATCH v5 05/10] test: remove devargs unit tests

2018-04-24 Thread Thomas Monjalon
24/04/2018 01:54, Gaetan Rivet: > --- > MAINTAINERS | 1 - > test/test/Makefile | 1 - > test/test/test_devargs.c | 103 > --- > 3 files changed, 105 deletions(-) > delete mode 100644 test/test/test_devargs.c The file must be re

Re: [dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI > devices too > > The DPCI devices have o

[dpdk-dev] [PATCH] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-24 Thread Qi Zhang
After add RSS hash offload check, default rss_hf will fail on devices that not support all bits, the patch introduce RSS negotiate flag, when it is set, RSS configuration will negotiate with device capability. By default negotiate is turn on, so it will not break exist PMD. It can be disabled by "-

Re: [dpdk-dev] [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to release notes

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to > release notes > > Signed-off-by: Nipun Gupt

Re: [dpdk-dev] [PATCH v5 10/10] devargs: rename legacy API

2018-04-24 Thread Thomas Monjalon
24/04/2018 01:54, Gaetan Rivet: > + struct rte_devargs da = {0}; It fails with clang. I suggest replacing with memset.

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Hu, Jiayu
Hi Ophir, > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 9:53 PM > To: Hu, Jiayu ; Ananyev, Konstantin > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking

Re: [dpdk-dev] [PATCH v5 00/10] devargs cleanup

2018-04-24 Thread Thomas Monjalon
> Gaetan Rivet (10): > devargs: introduce iterator > bus/vdev: do not reference devargs list > bus/pci: do not reference devargs list > net/vdev_netvsc: do not reference devargs list > test: remove devargs unit tests > devargs: make devargs list private > devargs: make parsing variadi

Re: [dpdk-dev] TCP GSO support above IPv6

2018-04-24 Thread Hu, Jiayu
Hi, > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 7:13 AM > To: Hu, Jiayu ; dev@dpdk.org; Mark Kavanagh > > Cc: Thomas Monjalon ; Olga Shern > > Subject: RE: TCP GSO support above IPv6 > > Hi, > Please see inline > > > -Origin

Re: [dpdk-dev] [PATCH v1 2/2] eal: add last init priority

2018-04-24 Thread Thomas Monjalon
> > Add the priority RTE_PRIORITY_LAST, used for initialization routines > > meant to be run after all other constructors. > > > > This priority becomes the default priority for all DPDK constructors. > > > > Signed-off-by: Gaetan Rivet > > --- > > Acked-by: Shreyansh Jain Applied, thanks

[dpdk-dev] [PATCH] vhost: fix vDPA set features

2018-04-24 Thread Xiao Wang
We should call set_features callback after setting features in virtio_net structure, otherwise vDPA driver cannot get the right features. Fixes: 07718b4f87aa ("vhost: adapt library for selective datapath") Signed-off-by: Xiao Wang --- lib/librte_vhost/vhost_user.c | 10 +- 1 file change

Re: [dpdk-dev] [PATCH v2] eal: abstract away the auxiliary vector

2018-04-24 Thread Thomas Monjalon
11/04/2018 23:34, Thomas Monjalon: > Anyone to review, please? > > 02/04/2018 20:24, Aaron Conole: > > Rather than attempting to load the contents of the auxv directly, > > prefer to use an exposed API - and if that doesn't exist then attempt > > to load the vector. This is because on some system

[dpdk-dev] [PATCH v5 2/2] app/testpmd: conserve offload flags of mbuf

2018-04-24 Thread Yongseok Koh
This patch is to accommodate an experimental feature of mbuf - external buffer attachment. If mbuf is attached to an external buffer, its ol_flags will have EXT_ATTACHED_MBUF set. Without enabling/using the feature, everything remains same. If PMD delivers Rx packets with non-direct mbuf, ol_flags

[dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as

[dpdk-dev] [PATCH v3 0/5] log level control enhancements

2018-04-24 Thread Stephen Hemminger
This patch set improves the log-level option in EAL. It adds symbolic names for log levels (error, info, debug, etc) and shell style matching of log levels. --log-level='pmd.ixgbe.*:debug' The original syntax (which is maintained for compatibility) used numeric values, comma as separator and re

[dpdk-dev] [PATCH v3 3/5] eal: make eal_log_level save private

2018-04-24 Thread Stephen Hemminger
We don't want format of eal log level saved values to be visible in ABI. Move to private storage in eal_common_log. Includes minor optimization. Compile the regular expression for each log match once, rather than each time it is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/e

[dpdk-dev] [PATCH v3 4/5] log: add ability to match dynamic log based on shell pattern

2018-04-24 Thread Stephen Hemminger
Regular expressions are not the best way to match a hierarchical pattern like dynamic log levels. And the separator for dynamic log levels is period which is the regex wildcard character. A better solution is to use filename matching 'globbing' so that log levels match like file paths. For compati

[dpdk-dev] [PATCH v3 2/5] eal: allow symbolic log levels

2018-04-24 Thread Stephen Hemminger
Much easeier to remember names than numbers. Allows --log-level=pmd.net.ixgbe.*,debug Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 67 -- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v3 1/5] eal: make syslog facility table const

2018-04-24 Thread Stephen Hemminger
The mapping fro facility name to value can be const. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index

[dpdk-dev] [PATCH v3 5/5] doc: update guides for current preferrred log level syntax

2018-04-24 Thread Stephen Hemminger
Use symbolic names and match rather than numbers and regex in the guides. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/dpaa2_sec.rst | 2 +- doc/guides/cryptodevs/dpaa_sec.rst | 2 +- doc/guides/faq/faq.rst | 23 ++- doc/guides/nics/dpaa2.rst

Re: [dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too

2018-04-24 Thread Shreyansh Jain
Hi Nipun, Apologies for delay in review. 2 quick comments inline. > -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 3/9] bus/fslmc: keep Tx qu

Re: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue data

2018-04-24 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Thursday, April 19, 2018 3:08 PM > To: dev@dpdk.org > Cc: Bie, Tiwei ; y...@fridaylinux.org; > maxime.coque...@redhat.com; m...@redhat.com; j...@freimann.org > Subject: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

2018-04-24 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Saturday, April 7, 2018 8:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh Jain > Cc: dev@dpdk.org; Nipun Gupta > Subject: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command > interface driver > > Signed-off-by: Nipun Gup

Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup

2018-04-24 Thread Zhang, Qi Z
Hi Thomas: > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 25, 2018 3:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Xing, Beilei ; Wu, Jingjing ; > Lu, Wenzhuo ; Yigit, Ferruh > ; Doherty, Declan > Subject: Re: [dpd

[dpdk-dev] [PATCH] eventdev: convert eth Rx adapter files to SPDX license tag

2018-04-24 Thread Nikhil Rao
Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.h | 32 +++--- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 2 files changed, 7 insertions(+), 29 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_even

Re: [dpdk-dev] [PATCH 1/2] eal: fix potential negative return

2018-04-24 Thread Tan, Jianfeng
On 4/17/2018 11:42 PM, Anatoly Burakov wrote: Value returned by rte_socket_id_by_idx() may be negative, which would result in negative array index access. Coverity issue: 272600 Fixes: b666f17858a3 ("mem: read hugepage counts from node-specific sysfs path") Cc: anatoly.bura...@intel.com Sign

Re: [dpdk-dev] rte_hash thread safe

2018-04-24 Thread Shyam Shrivastav
You can look at hash table support under librte_table, we are using it for tcp stateful and syncache table (16 bytes key), supports optimized burst look ups, pretty good performance at line rate with up to half a billion entries in syn cache lru table and 33 million in flows ext table. However the

<    1   2   3