Hi, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Thursday, April 19, 2018 3:08 PM > To: dev@dpdk.org > Cc: Bie, Tiwei <tiwei....@intel.com>; y...@fridaylinux.org; > maxime.coque...@redhat.com; m...@redhat.com; j...@freimann.org > Subject: [dpdk-dev] [PATCH v4 05/20] net/virtio: dump packed virtqueue data > > Add support to dump packed virtqueue data to the > VIRTQUEUE_DUMP() macro. > > Signed-off-by: Jens Freimann <jfreim...@redhat.com> > --- > drivers/net/virtio/virtqueue.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 081b27a52..ea804c9c7 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -379,6 +379,12 @@ virtqueue_notify(struct virtqueue *vq) > > #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP > #define VIRTQUEUE_DUMP(vq) do { \ > + if (vtpci_packed_queue((vq)->hw)) { \ > + PMD_INIT_LOG(DEBUG, \ > + "VQ: - size=%d; free=%d; last_used_idx=%d;" \
Miss a "," after the output format. "last_used_idx" is a stranger here. > + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \ The "nused" is not declared yet here. BRs, Xiao > + break; \ > + } \ > uint16_t used_idx, nused; \ > used_idx = (vq)->vq_ring.used->idx; \ > nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ > -- > 2.14.3
