Hi Thomas: > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 25, 2018 3:36 AM > To: Zhang, Qi Z <qi.z.zh...@intel.com> > Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.anan...@intel.com>; > Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > Lu, Wenzhuo <wenzhuo...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Doherty, Declan <declan.dohe...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup > > 10/04/2018 15:59, Thomas Monjalon: > > > --- a/lib/librte_ether/rte_ethdev.h > > > +++ b/lib/librte_ether/rte_ethdev.h > > > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred > setup > > > +rx queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002 > /**< > > > +Deferred setup tx queue */ > > > > Please use RTE_ETH_ prefix.
Actually I saw all the offload flag is started with DEV_, so Should I still need rename to RTE_ETH_DEV_CAPA_***? > > Qi, you missed this comment. > It must be fixed by a new patch, please. > > And the field must mention the related flags prefix. OK I will add this. Regards Qi
