On 4/23/2018 12:23 PM, Alejandro Lucero wrote:
> PMDs have the responsabilty of releasing mbufs sent through xmit burst
> function. NFP PMD attaches those sent mbufs to the TX ring structure,
> and it is at the next time a specific ring descriptor is going to be
> used when the previous linked mbuf
Hi Kamil,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Wednesday, April 18, 2018 10:26 AM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING
> printouts
>
On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> Hi Ophir,
>
> On Tue, Apr 10, 2018 at 06:17:00AM +, Ophir Munk wrote:
>> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
>> The net result of failsafe Tx capabilities is the logical AND of Tx
>> capabilities among all failsafe
After add RSS hash offload check, default rss_hf will fail on
devices that not support all bits, the patch take rss_hf as
a suggest value and only set bits that device supported base on
rte_eth_dev_get_info.
Fixes: 527624c663f8 ("ethdev: add supported hash function check")
Signed-off-by: Qi Zhang
Hi Kamil,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Wednesday, April 4, 2018 3:06 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
>
> From: "Chalupnik, K
On 4/10/2018 4:39 PM, Matan Azrad wrote:
> It is OK for me.
Converting this to explicit ack:
Acked-by: Matan Azrad
> Thanks.
>
> From: Ophir Munk, Tuesday, April 10, 2018 6:36 PM
>> Hi.
>> Discussed with Thomas.
>> Please consider the following commit message:
>>
>> net/vdev_netvsc: shorten dev
On Tue, Apr 24, 2018 at 03:17:31PM +0100, Ferruh Yigit wrote:
> On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> > Hi Ophir,
> >
> > On Tue, Apr 10, 2018 at 06:17:00AM +, Ophir Munk wrote:
> >> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> >> The net result of failsafe T
> -Original Message-
> From: Ophir Munk [mailto:ophi...@mellanox.com]
> Sent: Tuesday, April 24, 2018 2:42 PM
> To: Ananyev, Konstantin ; Hu, Jiayu
> ; dev@dpdk.org
> Cc: Thomas Monjalon ; Olga Shern ;
> Pascal Mazon ;
> sta...@dpdk.org
> Subject: RE: [PATCH v1] gso: fix marking TCP che
On Tue, Apr 24, 2018 at 01:32:55PM +0100, Bruce Richardson wrote:
> To simplify testing with the meson and ninja builds, we can add a script
> to set up and do multiple builds. Currently this script sets up:
>
> * clang and gcc builds
> * builds using static and shared linkage for binaries (libs a
On Tue, Apr 24, 2018 at 01:32:55PM +0100, Bruce Richardson wrote:
> To simplify testing with the meson and ninja builds, we can add a script
> to set up and do multiple builds. Currently this script sets up:
>
> * clang and gcc builds
> * builds using static and shared linkage for binaries (libs a
On 4/24/2018 3:18 PM, Qi Zhang wrote:
> After add RSS hash offload check, default rss_hf will fail on
> devices that not support all bits, the patch take rss_hf as
> a suggest value and only set bits that device supported base on
> rte_eth_dev_get_info.
>
> Fixes: 527624c663f8 ("ethdev: add suppor
Many parts of dpdk use their own management threads. Introduce a new
wrapper for thread creation that will be extended in next commits to set
the name and affinity.
To be consistent with other DPDK APIs, the return value is negative in
case of error, which was not the case for pthread_create().
S
Some parts of dpdk use their own management threads. Most of the time,
the affinity of the thread is not properly set: it should not be scheduled
on the dataplane cores, because interrupting them can cause packet losses.
This patchset introduces a new wrapper for thread creation that does
the job
Only a cosmetic change: the *_LEN defines are already used
when defining the buffer. Using sizeof() ensures that the length
stays consistent, even if the definition is modified.
Signed-off-by: Olivier Matz
Reviewed-by: Anatoly Burakov
---
examples/tep_termination/main.c | 2 +-
exa
The management threads must not bother the dataplane or service cores.
Set the affinity of these threads accordingly.
Signed-off-by: Olivier Matz
Reviewed-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_thread.c | 22 +-
lib/librte_eal/common/include/rte_lcore.h |
To avoid code duplication, add a parameter to rte_ctrl_thread_create()
to specify the name of the thread.
This requires to add a wrapper for the thread start routine in
rte_thread_init(), which will first wait that the thread is configured.
Signed-off-by: Olivier Matz
---
drivers/net/kni/rte_et
A new API was introduced to create control thread:
rte_ctrl_thread_create(). Use it in examples when relevant.
While at it, change the prototype of the thread start functions: it's
not a good idea to cast it in (void *) since the compiler won't check
that the prototype is compatible.
Signed-off-b
On 4/24/2018 1:44 PM, Qi Zhang wrote:
> v8:
> - re-order in default.ini and i40e.ini.
> - rebase
>
> v7:
> - update default.ini and i40e.ini.
> - rename runtime_queue_setup_capa to dev_capa for generic.
> - testpmd queue setup command be moved to "ports" command group.
> - remove ring_size and off
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Wednesday, April 4, 2018 3:06 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH] app/bbdev: update test vectors
>
> From: "Chalupnik, KamilX"
>
On Tue, 24 Apr 2018 09:41:53 +0300
Arnon Warshavsky wrote:
> + if (cryptodev->data->dev_private == NULL) {
> + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for
> private device data",
> + __func__);
dpaa2_sec is already doing private log ty
Thank you all for explaining. My updates are uncommon; Adding concept
of quiescent threads should be worst case loss of 1 full burst cpu
cycles on the threads. This should be acceptable infrequent delay in
packet processing.
I need data on performance of librcu lookups under infrequent updates,
On 4/24/2018 1:54 PM, Doherty, Declan wrote:
> Firstly, apologies on the very large delay on reviewing this. This looks
> good to me and I've verified that flow configuration propagates as
> expected to bonded slaves using IXGBE PMDs for testing.
>
> I had to do some minor rebasing to get the pa
On Tue, 24 Apr 2018 09:41:57 +0300
Arnon Warshavsky wrote:
> diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> index 8fb6138..6e08705 100644
> --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.
On Tue, 24 Apr 2018 09:41:57 +0300
Arnon Warshavsky wrote:
> + if (eventdev->data->dev_private == NULL) {
> + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for
> private device data",
> + __func__);
> + return -E
From: Sunil Kumar Kori
Fixes: 0ebce6129bc6 ("net/dpaa2: support new ethdev offload APIs")
Signed-off-by: Sunil Kumar Kori
Signed-off-by: Hemant Agrawal
---
drivers/net/dpaa2/dpaa2_ethdev.c | 88 +++-
1 file changed, 60 insertions(+), 28 deletions(-)
diff -
From: Sunil Kumar Kori
Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
Signed-off-by: Sunil Kumar Kori
---
drivers/net/dpaa/dpaa_ethdev.c | 89 +++---
1 file changed, 57 insertions(+), 32 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_eth
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, April 24, 2018 1:28 PM
> To: Ananyev, Konstantin ; Thomas Monjalon
> ; dev@dpdk.org
> Cc: Ajit Khaparde ; Jerin Jacob
> ; Shijith Thotton
> ; Santosh Shukla
> ; Rahul Lakkireddy
> ; John Daley ; Lu, Wenzhuo
> ; Xing, Beilei
>
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Tuesday, April 17, 2018 3:40 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups
>
This patch is
Hi,
On Mon, Apr 23, 2018 at 06:29:57PM -0700, Yongseok Koh wrote:
> On Mon, Apr 23, 2018 at 06:18:43PM +0200, Olivier Matz wrote:
> > I'm a bit afraid about ABI breakage, we need to check that a
> > 18.02-compiled application still works well with this change.
>
> I had the same concern so I made
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday 24 April 2018 15:57
> To: Chalupnik, KamilX ; dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: update test vectors
>
>
>
> > -Original Message-
> > From: dev [m
This patchset replaces the fcntl()-based locking used in
the original DPDK memory hotplug patchset, to an flock()-
and lockfile-based implementation, due to numerous (well,
one, really) problems with how fcntl() locks work.
Long story short, fcntl() locks will be dropped if any
fd referring to loc
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking parts of a file, which is useful
for single-file segments mode, where locking the entire file
isn't as useful because we still need to grow and shrink
Currently, memseg lists for secondary process are allocated on
sync (triggered by init), when they are accessed for the first
time. Move this initialization to a separate init stage for
memalloc.
Signed-off-by: Anatoly Burakov
Acked-by: Bruce Richardson
---
lib/librte_eal/bsdapp/eal/eal_memallo
v5 (Adrien):
While the previous version (v4) looked fine, I noticed several issues and
inconsistencies while testing it. I decided to take over Qi Zhang's series
to hasten things for RC1.
Please have a look at individual patches, where I summarized the changes for
each of them.
v4:
- Change to O
From: Qi Zhang
- RTE_FLOW_ITEM_TYPE_ARP_ETH_IPV4: matches an ARP header for Ethernet/IPv4.
- RTE_FLOW_ITEM_TYPE_IPV6_EXT: matches the presence of any IPv6 extension
header.
- RTE_FLOW_ITEM_TYPE_ICMP6: matches any ICMPv6 header.
- RTE_FLOW_ITEM_TYPE_ICMP6_ND_NS: matches an ICMPv6 neighbor dis
From: Qi Zhang
Add support for the following OpenFlow-defined actions:
- RTE_FLOW_ACTION_OF_SET_MPLS_TTL: MPLS TTL.
- RTE_FLOW_ACTION_OF_DEC_MPLS_TTL: decrement MPLS TTL.
- RTE_FLOW_ACTION_OF_SET_NW_TTL: IP TTL.
- RTE_FLOW_ACTION_OF_DEC_NW_TTL: decrement IP TTL.
- RTE_FLOW_ACTION_OF_COPY_TTL
From: Qi Zhang
Add support for the following OpenFlow-defined actions:
- RTE_FLOW_ACTION_OF_POP_VLAN: pop the outer VLAN tag.
- RTE_FLOW_ACTION_OF_PUSH_VLAN: push a new VLAN tag.
- RTE_FLOW_ACTION_OF_SET_VLAN_VID: set the 802.1q VLAN id.
- RTE_FLOW_ACTION_OF_SET_VLAN_PCP: set the 802.1q prior
Hi Andrew, Yongseok,
On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
> On 04/24/2018 04:38 AM, Yongseok Koh wrote:
> > This patch introduces a new way of attaching an external buffer to a mbuf.
> >
> > Attaching an external buffer is quite similar to mbuf indirection in
> > repl
On 24-Apr-18 3:46 PM, Olivier Matz wrote:
To avoid code duplication, add a parameter to rte_ctrl_thread_create()
to specify the name of the thread.
This requires to add a wrapper for the thread start routine in
rte_thread_init(), which will first wait that the thread is configured.
Signed-off-b
On 4/24/2018 3:39 PM, Ferruh Yigit wrote:
> On 4/24/2018 3:18 PM, Qi Zhang wrote:
>> After add RSS hash offload check, default rss_hf will fail on
>> devices that not support all bits, the patch take rss_hf as
>> a suggest value and only set bits that device supported base on
>> rte_eth_dev_get_inf
On 4/24/2018 4:20 PM, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Tuesday, April 24, 2018 1:28 PM
>> To: Ananyev, Konstantin ; Thomas Monjalon
>> ; dev@dpdk.org
>> Cc: Ajit Khaparde ; Jerin Jacob
>> ; Shijith Thotton
>> ; Santosh Shukla
>> ; Rah
Hi,
> Declan Doherty (4):
> ethdev: Add tunnel encap/decap actions
> ethdev: Add group JUMP action
> ethdev: add mark flow item to rte_flow_item_types
> ethdev: add shared counter support to rte_flow
No specific comment.
It is only an API without any PMD implementation.
Which PMDs are pl
On Tue, 24 Apr 2018 16:54:21 +0100
Anatoly Burakov wrote:
> One of the ways to work around this was using OFD locks,
> but they are only supported on kernels 3.15+,
Maybe time to move to next LTS kernel (3.16)?
16/04/2018 15:05, Declan Doherty:
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> +/**
> + * Default values for switch domain id when ethdev does not support switch
> + * domain definitions.
values -> value
> + */
> +#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID (0)
>
On 4/24/2018 4:06 PM, Hemant Agrawal wrote:
> From: Sunil Kumar Kori
>
> Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
>
> Signed-off-by: Sunil Kumar Kori
> ---
> drivers/net/dpaa/dpaa_ethdev.c | 89
> +++---
> 1 file changed, 57 inserti
Sunday, April 8, 2018 3:41 PM, Xueming Li:
> Subject: [dpdk-dev] [PATCH 0/3] mlx5 support Tx generic tunnel checksum
> and TSO
>
> This patchset introduced Tx generic tunnel checksum and TSO offload to mlx5
> PMD.
>
> This patchset relies on new ethdev API of:
> https://emea01.safelinks.pro
This patch set improves the log-level option in EAL.
It adds symbolic names for log levels (error, info, debug, etc)
and shell style matching of log levels.
--log-level='pmd.ixgbe.*:debug'
The original syntax (which is maintained for compatibility)
used numeric values, comma as separator and re
The mapping fro facility name to value can be const.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/common/eal_common_options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_options.c
b/lib/librte_eal/common/eal_common_options.c
index
Much easeier to remember names than numbers. Allows
--log-level=pmd.net.ixgbe.*,debug
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/common/eal_common_options.c | 67 --
1 file changed, 50 insertions(+), 17 deletions(-)
diff --git a/lib/librte_eal/common/eal_com
We don't want format of eal log level saved values to be visible
in ABI. Move to private storage in eal_common_log.
Includes minor optimization. Compile the regular expression for
each log match once, rather than each time it is used.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/common/e
Regular expressions are not the best way to match a hierarchical
pattern like dynamic log levels. And the separator for dynamic
log levels is period which is the regex wildcard character.
A better solution is to use filename matching 'globbing' so
that log levels match like file paths. For compati
Use symbolic names and match rather than numbers and regex
in the guides.
Signed-off-by: Stephen Hemminger
---
doc/guides/cryptodevs/dpaa2_sec.rst | 2 +-
doc/guides/cryptodevs/dpaa_sec.rst | 2 +-
doc/guides/faq/faq.rst | 23 ++-
doc/guides/nics/dpaa2.rst
On 4/24/2018 2:21 PM, De Lara Guarch, Pablo wrote:
>
>
>> -Original Message-
>> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Monday, March 12, 2018 7:32 PM
>> To: Pascal Mazon
>> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org
>> Subject: [dpdk-stabl
From: Sunil Kumar Kori
Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
Signed-off-by: Sunil Kumar Kori
---
drivers/net/dpaa/dpaa_ethdev.c | 87 +++---
1 file changed, 56 insertions(+), 31 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_eth
From: Sunil Kumar Kori
Fixes: 0ebce6129bc6 ("net/dpaa2: support new ethdev offload APIs")
Signed-off-by: Sunil Kumar Kori
Signed-off-by: Hemant Agrawal
---
drivers/net/dpaa2/dpaa2_ethdev.c | 88 +++-
1 file changed, 60 insertions(+), 28 deletions(-)
diff -
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Tuesday, April 24, 2018 4:30 PM
> To: Chalupnik, KamilX ; dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queu
HI Ferruh,
> Hi Hemant,
>
> Overall this looks good to me, thanks.
>
> Only I would like to ask if you prefer to replace nodis and not_supported
> checks.
>
> Because with current order, if an offlaod requested that both has not
> supported
> offload and not enable all nodis offloads, this w
On 24-Apr-18 5:32 PM, Stephen Hemminger wrote:
On Tue, 24 Apr 2018 16:54:21 +0100
Anatoly Burakov wrote:
One of the ways to work around this was using OFD locks,
but they are only supported on kernels 3.15+,
Maybe time to move to next LTS kernel (3.16)?
I'm all for it, but it's not my cal
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Tuesday, April 17, 2018 3:27 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement
> test
>
> New te
16/04/2018 15:05, Declan Doherty:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -348,7 +348,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
> rte_eth_dev_shared_data_prepare();
>
> rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Tuesday, April 17, 2018 3:34 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo
> software driver
Op
It is not clear if tap PMD supports queue specific offloads, removing
the related code.
Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
Cc: mo...@mellanox.com
Signed-off-by: Ferruh Yigit
---
Cc: Ophir Munk
v2:
* rebased
v3:
* t
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Tuesday, April 17, 2018 3:44 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software
> driver
>
> Update
On 4/23/2018 12:32 PM, Ophir Munk wrote:
> Hi Ferruh,
> The exact same setup works without your patch (done before sending my first
> email).
> I started debugging your patch and noticed you have dropped the setting of
> txq->csum which always remains 0 therefore [1] is never executed.
I see it
On 4/24/2018 6:16 PM, Hemant Agrawal wrote:
> From: Sunil Kumar Kori
>
> Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
>
> Signed-off-by: Sunil Kumar Kori
Series applied to dpdk-next-net/master, thanks.
On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> The basic operations for ports enumeration should not be
> considered as experimental in DPDK 18.05.
>
> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> It uses the function the rte_eth_find_next_owned_by() to get
> only ownerless por
On 04/24/2018 07:02 PM, Olivier Matz wrote:
Hi Andrew, Yongseok,
On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
On 04/24/2018 04:38 AM, Yongseok Koh wrote:
This patch introduces a new way of attaching an external buffer to a mbuf.
Attaching an external buffer is quite simil
On Tue, Apr 24, 2018 at 05:13:46PM +0100, Ferruh Yigit wrote:
> On 4/24/2018 3:39 PM, Ferruh Yigit wrote:
> > On 4/24/2018 3:18 PM, Qi Zhang wrote:
> >> After add RSS hash offload check, default rss_hf will fail on
> >> devices that not support all bits, the patch take rss_hf as
> >> a suggest valu
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday 24 April 2018 18:56
> To: Chalupnik, KamilX ; dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo
> Software driver
>
>
>
> > -Original Message-
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday 24 April 2018 18:45
> To: Chalupnik, KamilX ; dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost
> measurement test
>
>
>
> > -Original Messag
On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote:
> On 04/24/2018 07:02 PM, Olivier Matz wrote:
> > Hi Andrew, Yongseok,
> >
> > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
> > > On 04/24/2018 04:38 AM, Yongseok Koh wrote:
> > > > This patch introduces a new w
>
>
> > + if (cryptodev->data->dev_private == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone
> for private device data",
> > + __func__);
>
> dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro.
>
> You should go th
Thanks. Same as with dpaa
On Tue, Apr 24, 2018 at 6:06 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Tue, 24 Apr 2018 09:41:57 +0300
> Arnon Warshavsky wrote:
>
> > + if (eventdev->data->dev_private == NULL) {
> > + RTE_LOG(CRIT, EAL, "%s(): Cann
10/04/2018 15:59, Thomas Monjalon:
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x0001
> > +/**< Deferred setup rx queue */
> > +#define DEV_RUNTIME_TX_QUEUE_SETUP 0x0002
> > +/**< Deferred setup tx queue */
>
> Ple
16/04/2018 15:06, Declan Doherty:
> Add new device flag to specify that an ethdev port is a port representor.
> Extend rte_eth_dev_info structure to expose device flags to the user which
> enables applications to discover if a port is a representor port.
[...]
> --- a/lib/librte_ether/rte_ethdev.c
16/04/2018 15:06, Declan Doherty:
> From: Remy Horton
>
> Introduces a new structure, rte_eth_devargs, to support generic
> ethdev arguments common across NET PMDs, with a new API
> rte_eth_devargs_parse API to support PMD parsing these arguments.
Most of the parsing functions should be removed
16/04/2018 15:06, Declan Doherty:
> +/**
> + * Array of switch domains available for allocation. Array is sized to
> + * RTE_MAX_ETHPORTS elements as there cannot be more active switch domains
> than
> + * ethdev ports in a single process.
> + */
> +struct rte_eth_dev_switch {
> + enum rte_eth
24/04/2018 19:25, Burakov, Anatoly:
> On 24-Apr-18 5:32 PM, Stephen Hemminger wrote:
> > On Tue, 24 Apr 2018 16:54:21 +0100
> > Anatoly Burakov wrote:
> >
> >> One of the ways to work around this was using OFD locks,
> >> but they are only supported on kernels 3.15+,
> >
> > Maybe time to move t
24/04/2018 21:15, Olivier Matz:
> On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote:
> > On 04/24/2018 07:02 PM, Olivier Matz wrote:
> > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
> > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote:
> > > > > + * Returns TRUE
On Tue, 24 Apr 2018 22:05:10 +0200
Thomas Monjalon wrote:
> 24/04/2018 19:25, Burakov, Anatoly:
> > On 24-Apr-18 5:32 PM, Stephen Hemminger wrote:
> > > On Tue, 24 Apr 2018 16:54:21 +0100
> > > Anatoly Burakov wrote:
> > >
> > >> One of the ways to work around this was using OFD locks,
> >
On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote:
> 24/04/2018 21:15, Olivier Matz:
> > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote:
> > > On 04/24/2018 07:02 PM, Olivier Matz wrote:
> > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
> > >
Hi,
First, this is my summary after the survey answers and comments:
1/ allow "forgetting" port offloads in queue offloads setup
2/ update documentation, applications and remove checks in PMDs for 18.05-rc2
3/ an offload enabled at port level, cannot be disabled at queue level
4/ The queue cap
Using private api `guest_channel_host_connect()`
will cause shared library build failure.
So revert the changes done.
Fixes: d550a8cc31 ("app/test: enhance power manager unit tests")
Signed-off-by: Jananee Parthasarathy
Signed-off-by: Reshma Pattan
---
test/test/test_power_kvm_vm.c | 47 ++
24/04/2018 23:53, Yongseok Koh:
> On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote:
> > 24/04/2018 21:15, Olivier Matz:
> > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote:
> > > > On 04/24/2018 07:02 PM, Olivier Matz wrote:
> > > > > On Tue, Apr 24, 2018 at 03:28:
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++
The purpose of this patch series is to cleanup the library code
from paths that end up aborting the process,
and move to checking error values, in order to allow the running process
perform an orderly teardown or other mitigation of the event.
This patch modifies the majority of rte_panic calls
un
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15 +-
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15 ++--
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev_
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions(+),
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal/lin
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a/
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp/e
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 78 +++
lib/librte_e
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95 +
On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote:
> On 04/24/2018 04:38 AM, Yongseok Koh wrote:
[...]
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 06eceba37..7f6507a66 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbu
24/04/2018 14:51, Pattan, Reshma:
> From: Hunt, David
> > On 24/4/2018 12:23 PM, Pattan, Reshma wrote:
> > > From: Richardson, Bruce
> > >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote:
> > >>> 11/04/2018 16:14, Reshma Pattan:
> > Unit Testcases are added for power_acpi_cpu_
Hi Thomas,
I sent it few mins back. Can you check and apply
Thanks,
Reshma
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, April 24, 2018 11:34 PM
> To: Pattan, Reshma
> Cc: dev@dpdk.org; Hunt, David ; Richardson, Bruce
> ; Parthasarathy, Jana
title changed to "test/power: fix build with shared library"
25/04/2018 00:10, Reshma Pattan:
> Using private api `guest_channel_host_connect()`
> will cause shared library build failure.
Adding the log:
test_power_kvm_vm.c:(.text+0x2cb):
undefined reference to `guest_chan
101 - 200 of 236 matches
Mail list logo
