> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Tuesday, April 17, 2018 3:27 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX
> <kamilx.chalup...@intel.com>
> Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement
> test
>
> New test created to measure offload cost.
> Changes were introduced in API, turbo software driver and test application.
>
Shouldn't this be generic to bbdev/baseband drivers in general and not just
turbo?
> Signed-off-by: KamilX Chalupnik <kamilx.chalup...@intel.com>
...
> --- a/lib/librte_bbdev/rte_bbdev.h
> +++ b/lib/librte_bbdev/rte_bbdev.h
> @@ -239,6 +239,10 @@ struct rte_bbdev_stats {
> uint64_t enqueue_err_count;
> /** Total error count on operations dequeued */
> uint64_t dequeue_err_count;
> +#ifdef RTE_TEST_BBDEV
> + /** It stores turbo decoder/encoder working time. */
> + uint64_t turbo_perf_time;
> +#endif
I don't think it is a good idea to use RTE_TEST_BBDEV here.
This macro is used to enable/disable the compilation of the bbdev test app,
so I think it should not be used in the API/PMDs.
Also, this looks too specific for the Turbo SW PMD to be exposed
as a generic statistic.
> };
>
> /**
> --
> 2.5.5
>
