Hi Kamil, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Wednesday, April 4, 2018 3:06 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX > <kamilx.chalup...@intel.com> > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > From: "Chalupnik, KamilX" <kamilx.chalup...@intel.com> > > Support for linking with dynamic library added in Baseband Device test > application > > Signed-off-by: KamilX Chalupnik <kamilx.chalup...@intel.com> > --- > app/test-bbdev/Makefile | 4 ++++ > doc/guides/tools/testbbdev.rst | 7 +++++++ > 2 files changed, 11 insertions(+) > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile index > 6da0c8e..26c9a4b 100644 > --- a/app/test-bbdev/Makefile > +++ b/app/test-bbdev/Makefile > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) += > test_bbdev_vector.c > > LDLIBS += -lm > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y) > +LDLIBS += -lrte_pmd_bbdev_turbo_sw > +endif
This is already done in mk/rte.app.mk, so it should not be needed. > + > include $(RTE_SDK)/mk/rte.app.mk > diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst > index 2ccc646..8a13cbd 100644 > --- a/doc/guides/tools/testbbdev.rst > +++ b/doc/guides/tools/testbbdev.rst > @@ -36,6 +36,13 @@ The user must have all libraries, modules, updates and > compilers installed in the system prior to this, as described in the earlier > chapters in this Getting Started Guide. > > +Compiling the Application with DPDK built as shared library > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Setting flag in config/common_base file: > + > + ``CONFIG_RTE_BUILD_SHARED_LIB=y`` I don't think this is necessary to document. This is global for all applications and libraries in DPDK, and none of them document individually this. In a nutshell, I think this patch is not necessary. Thanks, Pablo
