[dpdk-dev] [PATCH 00/23] net/sfc: support equal stride super-buffer Rx mode

2018-04-19 Thread Andrew Rybchenko
Add support for dedicated DPDK firmware variant which has equal stride super-buffer Rx mode. The Rx mode uses bucket mempool manager which supports allocation of contiguos block of mbufs. It allows to achieve higher packet rate on Rx than traditional single packet Rx mode. Also the Rx mode suppor

[dpdk-dev] [PATCH 07/23] net/sfc: prepare EF10 Rx event parser to be reused

2018-04-19 Thread Andrew Rybchenko
Equal stride super-buffer Rx mode will be handled by the dedicated Rx datapath and the mode has almost the same Rx event structure as single packet Rx mode. Restructure the code to allow the common parts to be shared. Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov Reviewed-by: Andy Mor

[dpdk-dev] [PATCH 04/23] net/sfc/base: support equal stride super-buffer Rx mode

2018-04-19 Thread Andrew Rybchenko
Equal stride super-buffer Rx mode is supported by DPDK firmware variant. One Rx descriptor provides many Rx buffers to firmware. Rx buffers follow each other with specified stride. Also it supports head of line blocking with timeout to address drops when no Rx descriptors are available. So it gives

[dpdk-dev] [PATCH 14/23] net/sfc: check mempool when equal stride super-buffer used

2018-04-19 Thread Andrew Rybchenko
Equal stride super-buffer requires mempool with contiguous object block allocation mechanism. Bucket mempool is the only which provides it. Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ef10_essb_rx.c | 13 + 1 file changed, 13 insertions(+) diff -

[dpdk-dev] [PATCH 10/23] net/sfc: allow one Rx queue entry carry many packet buffers

2018-04-19 Thread Andrew Rybchenko
One HW Rx descriptor has many packet buffers in the case of equal stride super-buffer Rx modes. Each packet buffer is still treated as separate SW Rx descriptor. rxq_entries is the size of HW Rx ring whereas nb_rx_desc is the number of SW Rx descriptors. Signed-off-by: Andrew Rybchenko Reviewed-b

[dpdk-dev] [PATCH 20/23] net/sfc/base: get max supported value for action MARK

2018-04-19 Thread Andrew Rybchenko
From: Roman Zhukov The mark value for MATCH_ACTION_MARK has a maximum value. Requesting a value larger than the maximum will cause the filter insertion to fail with EINVAL. This patch allows the driver to check the value at the filter validation. Signed-off-by: Roman Zhukov Signed-off-by: Andre

[dpdk-dev] [PATCH 17/23] net/sfc: support flow marks in equal stride super-buffer Rx

2018-04-19 Thread Andrew Rybchenko
Equal stride super-buffer Rx mode allows to mark packets in HW using filters. Process the data on datapath and advertise corresponding features to allow flow API support to implement it. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_rx.h| 2 ++ drivers/net/sfc/sfc_ef10_essb

[dpdk-dev] [PATCH 11/23] net/sfc: allow to take mbuf pool into account when sizing

2018-04-19 Thread Andrew Rybchenko
The new argument will be used by the equal stride super-buffer Rx datapath. Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_dp_rx.h | 4 +++- drivers/net/sfc/sfc_ef10_rx.c | 1 + drivers/net/sfc/sfc_rx.c | 5 +++-- 3 files changed, 7 insertions(+), 3 delet

[dpdk-dev] [PATCH 16/23] net/sfc: add Rx descriptor wait timeout

2018-04-19 Thread Andrew Rybchenko
Add device argument to customize Rx descriptor wait timeout which is supported in DPDK firmware variant only in equal stride super-buffer Rx mode only. Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- doc/guides/nics/sfc_efx.rst | 12 drivers/net/sfc/sfc.c| 31 +

[dpdk-dev] [PATCH 15/23] net/sfc: support DPDK firmware variant

2018-04-19 Thread Andrew Rybchenko
DPDK firmware variant supports equal stride super-buffer Rx mode which provides higher packet rate and packet marks but requires dedicated mempool manager with contiguous object block allocation (e.g. bucket). Also the firmware supports subvariant without checksumming on Tx which allows to reach h

Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL PMD to meson

2018-04-19 Thread Tomasz Duszynski
On Thu, Apr 19, 2018 at 11:31:54AM +, De Lara Guarch, Pablo wrote: > Hi Tomasz, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Monday, April 16, 2018 7:08 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; d...@marvell.com;

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-19 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Thursday, April 19, 2018 7:15 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > On Thu, Apr 19, 2018 at 10:21:26AM +, Xueming(Steven) Li wrote: > >

[dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check

2018-04-19 Thread Juhamatti Kuusisaari
Handle properly a case where DPDK_MAINTAINER_PATH is set to point to a directory. Signed-off-by: Juhamatti Kuusisaari --- devtools/get-maintainer.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh index 1e9eabd..b91604

[dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check

2018-04-19 Thread Juhamatti Kuusisaari
Handle properly a case where DPDK_PATCH_PATH is set to point to a directory. Signed-off-by: Juhamatti Kuusisaari --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 7676a6b..2bb5458 100755 ---

Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option

2018-04-19 Thread Tomasz Duszynski
On Thu, Apr 19, 2018 at 01:05:11PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote: > > Since not cluttering environment and keeping all relevant > > settings local to the cross build is reasonable get > > MUSDK library installation path from a meso

Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL PMD to meson

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 01:40:23PM +0200, Tomasz Duszynski wrote: > On Thu, Apr 19, 2018 at 11:31:54AM +, De Lara Guarch, Pablo wrote: > > Hi Tomasz, > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > > > Sent: Monday, April 16, 20

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > On Wed, Apr 18, 2018 at 07:03:06PM +0100, Ferruh Yigit wrote: > > On 4/18/2018 6:55 PM, Pavan Nikhilesh wrote: > > > On Wed, Apr 18, 2018 at 06:43:11PM +0100, Ferruh Yigit wrote: > > >> On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: >

Re: [dpdk-dev] [v2, 2/3] cryptodev: support session private data setting

2018-04-19 Thread Verma, Shally
>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Abhinandan Gujjar >Sent: 16 April 2018 12:25 >To: pablo.de.lara.gua...@intel.com; declan.dohe...@intel.com; Jacob, Jerin >; >hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org >Cc: narender.vang...@intel.com

Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote: > Since not cluttering environment and keeping all relevant > settings local to the cross build is reasonable get > MUSDK library installation path from a meson option. > > Signed-off-by: Tomasz Duszynski > --- Applied and squashe

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-19 Thread Nélio Laranjeiro
On Thu, Apr 19, 2018 at 11:53:05AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Thursday, April 19, 2018 7:15 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXL

[dpdk-dev] [PATCH v2] crypto/mrvl: add MRVL PMD to meson

2018-04-19 Thread Tomasz Duszynski
Add MRVL CRYPTO PMD to meson build system. Signed-off-by: Tomasz Duszynski --- v2: - Get lib path from meson option instead of env variable drivers/crypto/meson.build | 2 +- drivers/crypto/mrvl/meson.build | 21 + 2 files changed, 22 insertions(+), 1 deletion(-) crea

[dpdk-dev] [PATCH 0/2] Fix file locking in EAL memory

2018-04-19 Thread Anatoly Burakov
This patchset replaces the fcntl()-based locking used in the original DPDK memory hotplug patchset, to an flock()- and lockfile-based implementation, due to numerous (well, one, really) problems with how fcntl() locks work. Long story short, fcntl() locks will be dropped if any fd referring to loc

[dpdk-dev] [PATCH 1/2] mem: add memalloc init stage

2018-04-19 Thread Anatoly Burakov
Currently, memseg lists for secondary process are allocated on sync (triggered by init), when they are accessed for the first time. Move this initialization to a separate init stage for memalloc. Signed-off-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memalloc.c | 6 +++ lib/librte_e

[dpdk-dev] [PATCH] bus/fslmc: fix the compilation with clang 3.4

2018-04-19 Thread Hemant Agrawal
error: redefinition of typedef 'dma_addr_t' is a C11 feature [-Werror,-Wtypedef-redefinition] Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/include/fsl_qbman_base.h | 2 -- drivers/crypto/dpaa2_sec/dpaa2_sec_dps

[dpdk-dev] Segmentation fault when creating a hash table in the example of pipeline (ROUTING type)

2018-04-19 Thread Victor Huertas
Hi all, I have tried to run the pipeline example with a ROUTING pipeline where I configured n_arp_entries=8 as well as the arp_key_offset = 192. It compiles perfectly but when it reaches the line where the rte_pipeline_table_create is (see below a fragment of the source code of the pipeline_routi

Re: [dpdk-dev] [PATCH v3 3/4] net/netvsc: add documentation

2018-04-19 Thread Hemant Agrawal
Hi Ferruh, > On 4/18/2018 5:03 PM, Stephen Hemminger wrote: > > On Wed, 18 Apr 2018 14:25:22 +0100 > > Ferruh Yigit wrote: > > > >> On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > >>> Matching documentation for new netvsc device. > >>> > >>> Signed-off-by: Stephen Hemminger > >>> --- > >>> doc

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-19 Thread Hemant Agrawal
> 18/04/2018 10:56, Bruce Richardson: > > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > > > 18/04/2018 00:11, Scott Branden: > > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > > > 17/04/2018 23:49, Stephen Hemminger: > > > > >> IMHO would have been better to use the ke

Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote: > Since not cluttering environment and keeping all relevant > settings local to the cross build is reasonable get > MUSDK library installation path from a meson option. > > Signed-off-by: Tomasz Duszynski > --- > drivers/net/mvpp2

[dpdk-dev] [PATCH 2/2] mem: revert to using flock() and add per-segment lockfiles

2018-04-19 Thread Anatoly Burakov
The original implementation used flock() locks, but was later switched to using fcntl() locks for page locking, because fcntl() locks allow locking parts of a file, which is useful for single-file segments mode, where locking the entire file isn't as useful because we still need to grow and shrink

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-19 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Thursday, April 19, 2018 8:19 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > On Thu, Apr 19, 2018 at 11:53:05AM +, Xueming(Steven) Li wrote: > >

Re: [dpdk-dev] Segmentation fault when creating a hash table in the example of pipeline (ROUTING type)

2018-04-19 Thread Shyam Shrivastav
I have been using librte_pipeline, librte_table though only acl and hash_key16 part, and firewall part of ip_pipeline in my project for quite sometime. I have never used or worked on other parts of ip_pipeline app like routing. Obviously issue is due to bad memory access at some point. Here are my

Re: [dpdk-dev] [PATCH v4 2/6] ethdev: Add jump action type to rte_flow

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:19PM +0100, Declan Doherty wrote: > Add jump action type which defines an action which allows a matched > flow to be redirect to the specified group. This allows physical and > logical flow table/group hierarchies to be managed through rte_flow. > > Signed-off-by: Dec

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:18PM +0100, Declan Doherty wrote: > Add new flow action types and associated action data structure to > support the encapsulation and decapsulation of VXLAN/NVGRE tunnel > endpoints. > > The RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP or > RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP action

Re: [dpdk-dev] [PATCH v4 3/6] testpmd: add jump action

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:20PM +0100, Declan Doherty wrote: > Add support for specificaiton of new JUMP action to testpmd's flow Typo on "specificaiton". > cli, and update the testpmd documentation to describe this new > action. > > Signed-off-by: Declan Doherty Beside minor nits below, th

Re: [dpdk-dev] [PATCH v4 5/6] testpmd: add support for MARK flow item

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:22PM +0100, Declan Doherty wrote: > Add support for specificaiton of new MARK flow item in testpmd's cli, > and update testpmd documentation to describe new MARK flow item support. > > Signed-off-by: Declan Doherty specificaiton => specification, however you should

Re: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow item types

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:21PM +0100, Declan Doherty wrote: > Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables > flow patterns to specify arbitrary integer values to match aginst Typo on "aginst". > which are set by the RTE_FLOW_ACTION_TYPE_MARK action in a > previously mat

Re: [dpdk-dev] [PATCH v4 6/6] ethdev: add shared counter support to rte_flow

2018-04-19 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 10:04:23PM +0100, Declan Doherty wrote: > Add rte_flow_action_count action data structure to enable shared > counters across multiple flows on a single port or across multiple > flows on multiple ports within the same switch domain. Also this enables > multiple count actions

Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5

2018-04-19 Thread Maxime Coquelin
Hi Luca, Yuanhan, On 03/02/2018 12:20 AM, Lee Roberts wrote: Fix kni compilation under RHEL 7.5. Signed-off-by: Lee Roberts --- lib/librte_eal/linuxapp/kni/compat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/c

Re: [dpdk-dev] [PATCH] maintainers: call out subtree for bbdev and security

2018-04-19 Thread De Lara Guarch, Pablo
Hi Amr, > -Original Message- > From: Mokhtar, Amr > Sent: Friday, April 13, 2018 8:28 PM > To: De Lara Guarch, Pablo ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] maintainers: call out subtree for bbdev and > security > > Hi Pablo, Thomas, > There are some u

Re: [dpdk-dev] [PATCH] bus/fslmc: fix the compilation with clang 3.4

2018-04-19 Thread Maxime Coquelin
Hi Hemant, On 04/19/2018 02:32 PM, Hemant Agrawal wrote: error: redefinition of typedef 'dma_addr_t' is a C11 feature [-Werror,-Wtypedef-redefinition] Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/include/fs

Re: [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote: > Handle properly a case where DPDK_PATCH_PATH is set > to point to a directory. > > Signed-off-by: Juhamatti Kuusisaari For series, Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote: > Handle properly a case where DPDK_MAINTAINER_PATH is set > to point to a directory. > > Signed-off-by: Juhamatti Kuusisaari > --- > devtools/get-maintainer.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom

2018-04-19 Thread Ferruh Yigit
On 3/21/2018 11:06 AM, Zijie Pan wrote: > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -201,6 +201,8 @@ DPDK_18.02 { > global: > > rte_eth_dev_filter_ctrl; > + rte_eth_dev_get_module_info; > + rte_eth_dev_get_module_eeprom;

Re: [dpdk-dev] [PATCH v3 0/5] get the information and data of EEPROM

2018-04-19 Thread Ferruh Yigit
On 3/21/2018 11:06 AM, Zijie Pan wrote: > Add APIs to read information from the DPDK applictions. > It can be used to dump the EEPROM of plugin modules (SFP+, QSFP, etc.). > > Two APIs are introduced to access eeprom: > - rte_eth_dev_get_module_info > - rte_eth_dev_get_module_eeprom > > Applicati

Re: [dpdk-dev] [PATCH v2] crypto/mrvl: add MRVL PMD to meson

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 02:21:14PM +0200, Tomasz Duszynski wrote: > Add MRVL CRYPTO PMD to meson build system. > > Signed-off-by: Tomasz Duszynski > --- > v2: > - Get lib path from meson option instead of env variable > > drivers/crypto/meson.build | 2 +- > drivers/crypto/mrvl/meson.buil

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-19 Thread Nélio Laranjeiro
On Thu, Apr 19, 2018 at 12:49:41PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Thursday, April 19, 2018 8:19 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXL

Re: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver

2018-04-19 Thread Arnon Warshavsky
Sure.Will change that in v5 On Thu, Apr 19, 2018 at 1:53 PM, Trahe, Fiona wrote: > Hi Arnon, > Can you change subject to crypto/dpaa:... please as it's only affecting > that driver. > Fiona > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Arnon Warshavsky

Re: [dpdk-dev] [PATCH v6 00/11] Bunch of flow API-related fixes

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 11:07 AM, Adrien Mazarguil wrote: > This series contains several fixes for rte_flow and its implementation in > PMDs and testpmd. Upcoming work on the flow API depends on it. > > v6 changes: > > - No change, rebased series and updated/fixed commit messages. > > v5 changes: > > - No

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: replace panic calls with log and retrun value. typo: return v4 static size calculation function changed to return success/fail code in addition to filling the size result. Signed-off-by: Arnon Warshavsky --- Please do not add version notes t

Re: [dpdk-dev] [PATCH v6 00/11] Bunch of flow API-related fixes

2018-04-19 Thread Ferruh Yigit
On 4/19/2018 3:03 PM, Ferruh Yigit wrote: > On 4/19/2018 11:07 AM, Adrien Mazarguil wrote: >> This series contains several fixes for rte_flow and its implementation in >> PMDs and testpmd. Upcoming work on the flow API depends on it. >> >> v6 changes: >> >> - No change, rebased series and updated/f

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Arnon Warshavsky
Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? On Thu, Apr 19, 2018 at 5:03 PM, Burakov, Anatoly wrote: > On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: > >> replace panic calls with log and retrun value. >> > > typo: return > > >> v4 >>

Re: [dpdk-dev] [PATCH v3 0/5] get the information and data of EEPROM

2018-04-19 Thread Remy Horton
On 19/04/2018 14:36, Ferruh Yigit wrote: [..] Zijie Pan (5): ethdev: add access to eeprom examples/ethtool: add a new command module-eeprom net/ixgbe: add module EEPROM callbacks for ixgbe net/e1000: add module EEPROM callbacks for e1000 net/i40e: add module EEPROM callbacks for i40e

Re: [dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform

2018-04-19 Thread Trahe, Fiona
Hi Pablo, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, March 29, 2018 4:56 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform > > The

Re: [dpdk-dev] [PATCH 2/3] crypto/zuc: remove unnecessary check

2018-04-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, March 29, 2018 4:56 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 2/3] crypto/zuc: remove unnecessary check > > When processing o

Re: [dpdk-dev] [PATCH 1/3] crypto/zuc: do not set default op status

2018-04-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, March 29, 2018 4:56 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/3] crypto/zuc: do not set default op status > > When crypto o

Re: [dpdk-dev] [PATCH v5 0/4] introduce new tunnel types

2018-04-19 Thread Xueming(Steven) Li
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 18, 2018 11:11 PM > To: Xueming(Steven) Li ; Lu, Wenzhuo > ; Wu, Jingjing > ; Thomas Monjalon ; Adrien > Mazarguil > > Cc: Nélio Laranjeiro ; Shahaf Shuler > ; dev@dpdk.org; > Olivier Matz > Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform

2018-04-19 Thread De Lara Guarch, Pablo
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Thursday, April 19, 2018 3:23 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform > > Hi Pab

Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation

2018-04-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mokhtar, Amr > Sent: Friday, April 13, 2018 8:31 PM > To: Chalupnik, KamilX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation > > > > -Original Message- > > From: C

Re: [dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-19 Thread Shailja Pandey
The two code fragments are doing two different ways the first is using a loop to create possible more then one replication and the second one is not, correct? The loop can cause performance hits, but should be small. Sorry for the confusion, for memcpy version also we are using a loop outside o

Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software driver

2018-04-19 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mokhtar, Amr > Sent: Tuesday, April 17, 2018 5:56 PM > To: Chalupnik, KamilX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software > driver > > > > -Original Message

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > > v4 > static size calculation function changed to return success/fail code > in addition to filling the size result. > fyi - this patch doesn't apply on master branch without fuzz > Signed-off-b

Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: Local functions to this file, changing from void to int are non-abi-breaking. For handling the single function that cannot change from void to int due to abi, where this is the only place it is called in, I added a state variable that is being checked

Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages

2018-04-19 Thread Maxime Coquelin
Hi Changpeng, Tomasz, Any chance that you resubmit the series now that the Qemu changes adding a protocol feature flag has been accepted? Cheers, Maxime On 03/28/2018 12:56 PM, Maxime Coquelin wrote: On 03/28/2018 12:23 PM, Liu, Changpeng wrote: -Original Message- From: Maxime Coq

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? Generally, cover letter should give general outline (i.e. "fixed 32 bit compile"), while notes for individual patches should be more specific

Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-19 Thread Arnon Warshavsky
Copy on the commit message and volatile. Regarding the new function defunct_and_remain_in_endless_loop () I don't think I can put that in a separate patch without breaking the current patch independence. On Thu, Apr 19, 2018 at 5:39 PM, Burakov, Anatoly wrote: > On 19-Apr-18 7:01 AM, Arnon Wa

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add more protocol support in flow API

2018-04-19 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 02:10:39PM +0800, Qi Zhang wrote: > Add new protocol header match support as below > > RTE_FLOW_ITEM_TYPE_ARP_IPV4 > - matches an IPv4 ARP header > RTE_FLOW_ITEM_TYPE_IPV6_EXT > - matches an IPv6 extension header with any type. > RTE_FLOW_ITEM_TYPE_ICMP6 >

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: add packet field set aciton in flow API

2018-04-19 Thread Adrien Mazarguil
Typo in commit title: aciton => action On Mon, Apr 16, 2018 at 02:10:40PM +0800, Qi Zhang wrote: > Add new action RTE_FLOW_ACTION_TYPE_FIELD_SET, it is used to > modify fields of specific protocol layer of the packet, the > action only apply on packets that contain the requireds protocol > layer.

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: add VLAN and MPLS pop push action in flow API

2018-04-19 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 02:10:42PM +0800, Qi Zhang wrote: > Add couple Openflow frienldy VLAN/MPLS push/pop actions. Openflow => OpenFlow frienldy => friendly > > RTE_FLOW_ACTION_VLAN_POP - pop a VLAN header. > RTE_FLOW_ACTION_VLAN_PUSH - push a VLAN header. > RTE_FLOW_ACTION_MPLS_POP - pop a MP

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in flow API

2018-04-19 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 02:10:41PM +0800, Qi Zhang wrote: > Add couple OpenFlow frienldy TTL change actions. frienldy => friendly > > RTE_FLOW_ACTION_MLPS_TTL_DEC - decrement MPLS TTL. > RTE_FLOW_ACTION_IP_TTL_DEC - decrement IP TTL. > RTE_FLOW_ACTION_TTL_COPY_OUT - copy TTL outwards. > RTE_FLOW

Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote: On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? Generally, cover letter should give general outline (i.e. "fixed 32 bit compile"), while notes

Re: [dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format

2018-04-19 Thread Maxime Coquelin
On 04/19/2018 03:07 AM, Takanari Hayama wrote: On 2018/04/13 1:43, Junjie Chen wrote: Update license to SPDX, also add Intel license. Signed-off-by: Junjie Chen --- drivers/net/vhost/rte_eth_vhost.c | 34 +++--- drivers/net/vhost/rte_eth_vhost.h | 35 +++--

[dpdk-dev] [PATCH v2 0/3] ZUC PMD fixes

2018-04-19 Thread Pablo de Lara
ZUC library provides an API to encrypt buffers in parallel with different keys. However, the PMD was developed assuming that all needed to share the same session (therefore, the same key). This patchset fixes this behaviour by allowing multiple buffers with different keys to be processed in parall

[dpdk-dev] [PATCH v2 1/3] crypto/zuc: do not set default op status

2018-04-19 Thread Pablo de Lara
When crypto operations are allocated from the operation pool, their status get reset to NOT_PROCESSED. Therefore, there is no need to set this status again. Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe ---

[dpdk-dev] [PATCH v2 2/3] crypto/zuc: remove unnecessary check

2018-04-19 Thread Pablo de Lara
When processing operations, the operation type was being checked to avoid if it was set to NOT SUPPORTED. In data path, doing so is not required since that is already checked when creating the crypto session, so that case will not ever happen. Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC l

[dpdk-dev] [PATCH v2 3/3] crypto/zuc: batch ops with same transform

2018-04-19 Thread Pablo de Lara
The ZUC API to encrypt packets does not require the operations to share the same key. Currently, the operations were being batched only when they shared the same key, but this is not needed. Instead, now operations will be batched based on the transform (cipher only, auth only...). Fixes: cf7685d

Re: [dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings

2018-04-19 Thread Maxime Coquelin
Hi Tomasz, On 03/28/2018 11:31 AM, Kulasek, TomaszX wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, March 28, 2018 10:57 To: Kulasek, TomaszX ; y...@fridaylinux.org Cc: Verkamp, Daniel ; Harris, James R ; Wodkowski, PawelX

Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-19 Thread Burakov, Anatoly
On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote: Copy on the commit message  and volatile. Regarding the new function defunct_and_remain_in_endless_loop () I don't think I can put that in a separate patch without breaking the current patch independence. How so? Just leave some panic instances i

Re: [dpdk-dev] [PATCH v5 0/4] introduce new tunnel types

2018-04-19 Thread Thomas Monjalon
19/04/2018 16:24, Xueming(Steven) Li: > From: Iremonger, Bernard > > I have just cloned the current dpdk master, patch 3 still fails to apply, > > dpdk-dev-v5-3-4-app-testpmd- > > introduce-new-tunnel-VXLAN-GPE.patch > > > > git am ./dpdk-dev-v5-3-4-app-testpmd-introduce-new-tunnel-VXLAN-GPE.pat

[dpdk-dev] [RFC 0/8] remove IPC threads

2018-04-19 Thread Jianfeng Tan
As discussed here, http://dpdk.org/dev/patchwork/patch/36579/, we will try best to avoid thread creation in the library. Now we have two threads for IPC, rte_mp_handle and rte_mp_handle_async. This patchset is to finish the job. This patchset: - is rebased on commit 34345a9b69bb ("eventdev: fix bu

[dpdk-dev] [RFC 2/8] ipc: fix timeout not properly handled in async

2018-04-19 Thread Jianfeng Tan
In original implementation, timeout event for an async request will be ignored. As a result, an async request will never trigger the action if it cannot receive any reply any more. We fix this by counting timeout as a processed reply. Fixes: f05e26051c15 ("eal: add IPC asynchronous request") Sig

[dpdk-dev] [RFC 1/8] ipc: clearn up code

2018-04-19 Thread Jianfeng Tan
Following below commit, we change some internal function and variable names: commit ce3a7312357b ("eal: rename IPC request as synchronous one") Also use calloc to supersede malloc + memset for code clean up. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_proc.c | 82

[dpdk-dev] [RFC 3/8] eal/linux: use glibc malloc in alarm

2018-04-19 Thread Jianfeng Tan
We will reply on alarm API for async IPC request as following patch indicates. rte_malloc could require async IPC request. To avoid such chicken or the egg causality dilemma, we change to use glibc malloc in alarm implimentation. Signed-off-by: Jianfeng Tan --- lib/librte_eal/linuxapp/eal/eal_a

[dpdk-dev] [RFC 4/8] ipc: remove IPC thread for async request

2018-04-19 Thread Jianfeng Tan
As discussed here, http://dpdk.org/dev/patchwork/patch/36579/, we remove IPC threads, rte_mp_handle and rte_mp_handle_async. This patch targets to remove thread rte_mp_handle_async. Previously, to handle replies for an async request, rte_mp_handle wakes up the rte_mp_handle_async thread to process

[dpdk-dev] [RFC 5/8] eal/linux: use glibc malloc in interrupt handling

2018-04-19 Thread Jianfeng Tan
We will rely on interrupt thread to implement IPC; and IPC initialization is in very early stage, when memory subsystem is not initialized yet. So we change to use glibc malloc/free. Signed-off-by: Jianfeng Tan --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 13 + 1 file changed,

[dpdk-dev] [RFC 6/8] eal: bring forward init of interrupt handling

2018-04-19 Thread Jianfeng Tan
IPC will reply on interrupt handling, so we move forward the init of interrupt handling. Signed-off-by: Jianfeng Tan --- lib/librte_eal/linuxapp/eal/eal.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/e

[dpdk-dev] [RFC 7/8] eal: add IPC type for interrupt thread

2018-04-19 Thread Jianfeng Tan
We are going to merge IPC into interrupt thread. This patch adds IPC type for interrupt thread. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 test/test/test_interrupts.c

[dpdk-dev] [RFC 8/8] ipc: remove IPC thread for message read

2018-04-19 Thread Jianfeng Tan
As discussed here, http://dpdk.org/dev/patchwork/patch/36579/, we remove IPC thread, rte_mp_handle, in this patch. Previously, to handle requests from peer(s), or replies for a request (sync or async) by itself, thread rte_mp_handle will blockly readmsg on the unix socket for incoming messages. No

[dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-04-19 Thread Adrien Mazarguil
Disclaimer: this patch must not be confused with the CLI library [1] (work in progress) that will eventually supersede librte_cmdline itself with a different API. Rather, it modifies librte_cmdline to delegate all the heavy lifting (terminal and history handling), strips unused features and re-imp

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > > On Wed, Apr 18, 2018 at 07:03:06PM +0100, Ferruh Yigit wrote: > > > On 4/18/2018 6:55 PM, Pavan Nikhilesh wrote: > > > > On Wed, Apr 18, 2018 at 06:43:11PM +0100,

Re: [dpdk-dev] [RFC 0/8] remove IPC threads

2018-04-19 Thread Thomas Monjalon
19/04/2018 17:03, Jianfeng Tan: > As discussed here, http://dpdk.org/dev/patchwork/patch/36579/, we will > try best to avoid thread creation in the library. Now we have two threads > for IPC, rte_mp_handle and rte_mp_handle_async. This patchset is to > finish the job. Thanks for working on it. >

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, April 19, 2018 12:04 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Laatz, Kevin > ; Singh, Jasvinder > Subject: [PATCH] examples/ip_pipeline: fix resource leak > > Closing the fd_server file descriptor on error to fix the

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, April 19, 2018 12:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Laatz, Kevin > ; Singh, Jasvinder > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a NULL te

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, April 19, 2018 12:01 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Laatz, Kevin > ; Singh, Jasvinder > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a NULL te

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Bruce Richardson
On Thu, Apr 19, 2018 at 08:48:33PM +0530, Pavan Nikhilesh wrote: > On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > > > On Wed, Apr 18, 2018 at 07:03:06PM +0100, Ferruh Yigit wrote: > > > > On 4/18/2018 6:55 PM,

Re: [dpdk-dev] [PATCH v4 0/5] handle seq no overflow in IPsec offload

2018-04-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Wednesday, April 11, 2018 7:41 AM > To: Akhil Goyal ; Doherty, Declan > ; Wu, Jingjing ; Nicolau, > Radu ; Thomas Monjalon ; > Lu, Wenzhuo > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad

Re: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build

2018-04-19 Thread Hemant Agrawal
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > When cross-compiling, if no kernel_dir was specified, then the kernel modules > were still being compiled for the build machine. Fix this by only building > modules > on cross-compile when we

[dpdk-dev] [PATCH v4 1/2] ethdev: add supported hash function check

2018-04-19 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- lib/librte_ether/rte_ethdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

[dpdk-dev] [PATCH v4 2/2] app/testpmd: new parameter for port config all rss command

2018-04-19 Thread Xueming Li
This patches add "default" parameter to "port config all rss" command. "default" means all supported hash types reported by device info. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 13 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++- 2 files ch

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-19 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 10:30 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only confi

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Thu, Apr 19, 2018 at 04:37:23PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 08:48:33PM +0530, Pavan Nikhilesh wrote: > > On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > > > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > > > > On Wed, Apr 18, 2

<    1   2   3   >