Re: [dpdk-dev] [PATCH v4 11/11] doc: update mlx5 guide on tunnel offloading

2018-04-18 Thread Nélio Laranjeiro
On Tue, Apr 17, 2018 at 11:14:36PM +0800, Xueming Li wrote: > Remove tunnel limitations, add new hardware tunnel offload features. > > Signed-off-by: Xueming Li > --- > doc/guides/nics/features/default.ini | 1 + > doc/guides/nics/features/mlx5.ini| 3 +++ > doc/guides/nics/mlx5.rst

Re: [dpdk-dev] [PATCH v2 0/4] Hyper-V Netvsc PMD

2018-04-18 Thread Raslan Darawsheh
I'm facing this on gcc version 5.4.0 on 64bit. Kindest regards, Raslan Darawsheh -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, April 17, 2018 7:22 PM To: Raslan Darawsheh Cc: dev@dpdk.org; Stephen Hemminger ; Thomas Monjalon Subject: Re:

Re: [dpdk-dev] [PATCH v2 2/3] net/szedata2: add support for new NIC

2018-04-18 Thread Matej Vido
On 13.04.2018 18:29, Ferruh Yigit wrote: On 4/13/2018 4:03 PM, Jan Remeš wrote: It is mentioned on the website with the packages itself. The current version works with the reworked PMD - there is a headline which says: "DPDK from 18.05" (since we expect the patches to land in the upcoming releas

Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-18 Thread Thomas Monjalon
18/04/2018 04:43, Chen, Junjie J: > Thanks to point this out. I agree for the title change. > > Do you want me to send v2 patch? Or you can handle it when committing? > > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > > we obeserve rte_movX is not inline when do

[dpdk-dev] [PATCH] examples/performance-thread: convert license headers to SPDX

2018-04-18 Thread Pablo de Lara
Convert dual license headers with Intel and Hasan Alayli names to SPDX. Signed-off-by: Pablo de Lara --- examples/performance-thread/common/arch/x86/ctx.c | 62 ++ examples/performance-thread/common/lthread.c | 61 ++--- examples/performance-thread/comm

Re: [dpdk-dev] [PATCH 01/30] crypto/qat: use SPDX license

2018-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, April 6, 2018 7:52 PM > To: dev@dpdk.org; De Lara Guarch, Pablo > Cc: Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH 01/30] crypto/qat: use SPDX license > > Use SPDK license for dual-licensed files and update license date i

Re: [dpdk-dev] [PATCH 2/2] net/mlx4: fix alignment of Memory Region

2018-04-18 Thread Adrien Mazarguil
On Tue, Apr 17, 2018 at 11:39:14AM -0700, Yongseok Koh wrote: > The memory region is [start, end), so if the memseg of 'end' isn't > allocated yet, the returned memseg will have zero entries and this will > make 'end' zero (nil). > > Fixes: c2fe5823224a ("net/mlx4: use virt2memseg instead of itera

[dpdk-dev] [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable

2018-04-18 Thread Rosen Xu
v4 updates: === - Add some comments for this patch v3 updates: === - Move modification from device close to device disable - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous, so unicast/multicast promiscuous disable should set before reset. v2 updates:

[dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming Li
"port config all rss all" command will fail on PMD that not support any of hard coding RSS hash types. This patch changed hard coding hash types to supported types retrieved from device info. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 7 +++ 1 file changed, 7 insertions(+) diff

[dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check

2018-04-18 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- lib/librte_ether/rte_ethdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

Re: [dpdk-dev] [PATCH v5 2/4] ethdev: introduce new tunnel VXLAN-GPE

2018-04-18 Thread Adrien Mazarguil
On Tue, Apr 17, 2018 at 10:56:52PM +0200, Thomas Monjalon wrote: > 17/04/2018 17:04, Xueming Li: > > +struct rte_flow_item_vxlan_gpe { > > + uint8_t flags; /**< Normally 0x0c (I and P flags). */ > > + uint8_t rsvd0[2]; /**< Reserved, normally 0x. */ > > + uint8_t protocol; /**< Protocol t

Re: [dpdk-dev] [PATCH v4 01/16] ethdev: add error types to flow API

2018-04-18 Thread Adrien Mazarguil
On Tue, Apr 17, 2018 at 08:37:31PM +0100, Ferruh Yigit wrote: > On 4/16/2018 5:22 PM, Adrien Mazarguil wrote: > > These enable more precise reporting of objects responsible for errors. > > > > This breaks ABI compatibility for the following public functions: > > > > - rte_flow_create() > > - rte_

Re: [dpdk-dev] [PATCH 0/4] Fixes for coverity issues in fbarray

2018-04-18 Thread Adrien Mazarguil
On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote: > This patchset fixes a number of Coverity issues introduced > in recent DPDK memory hotplug patchset. > > Coverity issues fixed: > - 272564 - error condition not checked > - 272579 - dereference before null check > - 272586 - error

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Bruce Richardson
On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > 18/04/2018 00:11, Scott Branden: > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > 17/04/2018 23:49, Stephen Hemminger: > > >> IMHO would have been better to use the kernel SPDX style and > > >> keep the check but that appears

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ferruh Yigit
On 4/12/2018 5:23 PM, Ferruh Yigit wrote: > On 4/5/2018 6:49 PM, Thomas Monjalon wrote: >> Pascal, Moti, Ophir, >> please comment. > > Hi Moti, > > Any comment? This has been asked many times now. Hi Moti, Ophir, You have not responded why queue specific offload added in other thread. And you a

Re: [dpdk-dev] [PATCH v3] mem: fix memory leaks of hugedir and replace snprintf

2018-04-18 Thread Thomas Monjalon
18/04/2018 05:09, Yangchao Zhou: > The hugedir returned by get_hugepage_dir is allocated by strdup > but not released. Replace snprintf with a more suitable strlcpy. > > Coverity issue: 272585 > Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") > > Signed-off-by: Yangchao Zh

[dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip frag process log

2018-04-18 Thread Li Han
in ip_frag_process,some IP_FRAG_LOG content is wrong Signed-off-by: Li Han --- lib/librte_ip_frag/ip_frag_internal.c | 10 +- ...40e-add-null-point-check-and-fix-mem-leak.patch | 150 +++ ...1000-add-null-point-check-for-rte_zmalloc.patch | 65 ...qat-add-

Re: [dpdk-dev] reply: [disscussion] A problem about dpdk backup-mode bond switching with mlx4 VF devices

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 01:55:41AM +, chenchanghu wrote: > Hi, Adrien Mazarguil, > > Thanks for your reply very much. > > It means in our tests, when ‘ifconfig eth7 down’, the expect result is the > bond primary netdevice will switch to eth8. > > However, we find the bond primary is not

Re: [dpdk-dev] [dpdk-web] [PATCH v2] update stable releases roadmap

2018-04-18 Thread Ferruh Yigit
On 4/11/2018 12:28 AM, Thomas Monjalon wrote: > - Typically a new stable release version follows a mainline release > - by 1-2 weeks, depending on the test results. > + The first stable release (.1) of a branch should follow > + its mainline release (.0) by at least two months, > +

Re: [dpdk-dev] [dpdk-web] [PATCH v2] update stable releases roadmap

2018-04-18 Thread Thomas Monjalon
18/04/2018 11:05, Ferruh Yigit: > On 4/11/2018 12:28 AM, Thomas Monjalon wrote: > > - Typically a new stable release version follows a mainline release > > - by 1-2 weeks, depending on the test results. > > + The first stable release (.1) of a branch should follow > > + its mainline release

[dpdk-dev] 答复: reply: [disscussion] A problem about dpdk backup-mode bond switching with mlx4 VF devices

2018-04-18 Thread chenchanghu
Thanks very much, OK, we will test again with recent dpdk version. -邮件原件- 发件人: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] 发送时间: 2018年4月18日 17:05 收件人: chenchanghu 抄送: dev@dpdk.org; nelio.laranje...@6wind.com; Zhoujingbin (Robin, Cloud Networking) ; Zhoulei (G) ; yangleyuan 主题

[dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip frag process log

2018-04-18 Thread Li Han
in ip_frag_process,some IP_FRAG_LOG content is wrong Signed-off-by: Li Han --- lib/librte_ip_frag/ip_frag_internal.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_ip_frag/ip_frag_internal.c b/lib/librte_ip_frag/ip_frag_internal.c index 7397aa6..2560c77 1

Re: [dpdk-dev] [PATCH v4 01/16] ethdev: add error types to flow API

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 9:41 AM, Adrien Mazarguil wrote: > On Tue, Apr 17, 2018 at 08:37:31PM +0100, Ferruh Yigit wrote: >> On 4/16/2018 5:22 PM, Adrien Mazarguil wrote: >>> These enable more precise reporting of objects responsible for errors. >>> >>> This breaks ABI compatibility for the following public fu

Re: [dpdk-dev] [PATCH v3] mem: fix memory leaks of hugedir and replace snprintf

2018-04-18 Thread Burakov, Anatoly
On 18-Apr-18 10:00 AM, Thomas Monjalon wrote: 18/04/2018 05:09, Yangchao Zhou: The hugedir returned by get_hugepage_dir is allocated by strdup but not released. Replace snprintf with a more suitable strlcpy. Coverity issue: 272585 Fixes: cb97d93e9d3b ("mem: share hugepage info primary and sec

[dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING printouts

2018-04-18 Thread KamilX Chalupnik
Improper WARNING printouts in BBDev Test Application removed Signed-off-by: KamilX Chalupnik v2: - apply patch failure fixed --- app/test-bbdev/test_bbdev_perf.c | 2 +- app/test-bbdev/test_bbdev_vector.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ophir Munk
Hi Ferruh, Sorry for the delayed response. I would like to verify the correctness of this patch by running several internal tests. Is a reply by Monday OK with you? Regards, Ophir > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 18, 2018

Re: [dpdk-dev] [PATCH v11 00/10] crypto: add virtio poll mode driver

2018-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Tuesday, April 17, 2018 10:23 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawe

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage print

2018-04-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Tuesday, April 17, 2018 10:02 AM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan > Cc: Jerin Jacob ; Narayana Prasad > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-sec

[dpdk-dev] [PATCH v2 00/10] Coverity fixes for EAL memory

2018-04-18 Thread Anatoly Burakov
This patchset fixes a host of coverity issues in memory subsystem introduced with recent DPDK memory hotplug patchset. Coverity issues fixed: - 272601 - leaking fd - 272560 - double close fd - 272568 - leaking fd - 272570 - leaking fd - 272589 - dereference before null check - 272602 - freeing wro

[dpdk-dev] [PATCH v2 04/10] mem: fix potential resource leak

2018-04-18 Thread Anatoly Burakov
We close fd if we managed to find it in the list of allocated segment lists (which should always be the case under normal conditions), but if we didn't, the fd was leaking. Close it if we couldn't find it in the segment list. This is not an issue as if the segment is zero length, we're getting rid

[dpdk-dev] [PATCH v2 02/10] mem: fix resource leak

2018-04-18 Thread Anatoly Burakov
Coverity issue: 272601 Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Cc: anatoly.bura...@intel.com Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/libr

[dpdk-dev] [PATCH v2 07/10] mem: fix potential bad unmap

2018-04-18 Thread Anatoly Burakov
Previously, if mmap failed to map page address at requested address, we were attempting to unmap the wrong address. Fix it by unmapping our actual mapped address, and jump further to avoid unmapping memory that is not allocated. Coverity issue: 272602 Fixes: 582bed1e1d1d ("mem: support mapping hu

[dpdk-dev] [PATCH v2 01/10] mem: use strlcpy instead of snprintf

2018-04-18 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- Notes: One other instance of using snprintf is left alone as it is expected to be addressed by another patch [1]. [1] http://dpdk.org/dev/patchwork/patch/38301/ lib/librte_eal/common/eal_common_memalloc.c | 5 +++-- 1 file changed, 3 insertion

[dpdk-dev] [PATCH v2 03/10] mem: fix potential double close

2018-04-18 Thread Anatoly Burakov
We were closing descriptor before checking if mapping has failed, but if it did, we did a second close afterwards. Fix it by moving closing descriptor to after we check if mmap has succeeded. Coverity issue: 272560 Fixes: 2a04139f66b4 ("eal: add single file segments option") Cc: anatoly.bura...@i

[dpdk-dev] [PATCH v2 10/10] mem: fix possible use-after-free

2018-04-18 Thread Anatoly Burakov
If user has specified a flag to unmap the area right after mapping it, we were passing an already-unmapped pointer to RTE_LOG. This is not an issue since RTE_LOG doesn't actually dereference the pointer, but fix it anyway by moving call to RTE_LOG to before unmap. Coverity issue: 272584 Fixes: b7

[dpdk-dev] [PATCH v2 08/10] mem: fix statement having no effect

2018-04-18 Thread Anatoly Burakov
Coverity reports these lines as having no effect. Technically, we do want for those lines to have no effect, however they would've likely been optimized out. Add volatile qualifiers to ensure the code has effects. Coverity issue: 272608 Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runt

[dpdk-dev] [PATCH v2 09/10] mem: fix negative return value

2018-04-18 Thread Anatoly Burakov
Although unlikely during normal operation, rte_socket_id_by_idx() may return a negative value, which would've caused an out-of-bounds read. Fix it by making socket ID signed, and check for negative return. Coverity issue: 272577 Coverity issue: 272578 Fixes: 66cc45e293ed ("mem: replace memseg wit

[dpdk-dev] [PATCH v2 06/10] mem: fix comparing pointer to value

2018-04-18 Thread Anatoly Burakov
Previous code had an old rebase leftover from the time when oldpolicy was an actual int, instead of a pointer. Fix it to do comparison with dereferencing the pointer. Coverity issue: 272589 Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") Cc: anatoly.bura...@intel.com Signed-off

[dpdk-dev] [PATCH v2 05/10] mem: fix potential resource leak

2018-04-18 Thread Anatoly Burakov
Normally, tailq entry should have a valid fd by the time we attempt to map the segment. However, in case it doesn't, we're leaking fd, so fix it. Coverity issue: 272570 Fixes: 2a04139f66b4 ("eal: add single file segments option") Cc: anatoly.bura...@intel.com Signed-off-by: Anatoly Burakov ---

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 7:49 AM, Tan, Jianfeng wrote: > Hi Ferruh, > > > On 4/17/2018 7:26 PM, Ferruh Yigit wrote: >> On 4/17/2018 5:54 AM, Tiwei Bie wrote: >>> On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote: On 4/14/2018 11:55 AM, Tiwei Bie wrote: > On Fri, Apr 13, 2018 at 10:53:55PM

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Kuusisaari, Juhamatti
Hello, > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > > 18/04/2018 00:11, Scott Branden: > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > > 17/04/2018 23:49, Stephen Hemminger: > > > >> IMHO would have been better to use the kernel SPDX style and keep > > > >> the ch

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Alejandro Lucero
On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > I was just wondering, if device device PCI sysfs resource files or VFIO > group /dev files require to change > > permissions for non-root users, does it not make sense to adjust also > /var/lock in the system?

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 10:40 AM, Ophir Munk wrote: > Hi Ferruh, > Sorry for the delayed response. > > I would like to verify the correctness of this patch by running several > internal tests. > Is a reply by Monday OK with you? Monday can be late to include patch into rc1, any chance to do earlier? > >

[dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check

2018-04-18 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- lib/librte_ether/rte_ethdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

[dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming Li
"port config all rss all" command will fail on PMD that not support any of hard coding RSS hash types. This patch changed hard coding hash types to supported types retrieved from device info. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 7 +++ 1 file changed, 7 insertions(+) diff

[dpdk-dev] [PATCH 0/2] implement set_mc_addr devop

2018-04-18 Thread Nelio Laranjeiro
Support eth_dev_ops.set_mc_addr_list(). Nelio Laranjeiro (2): net/mlx5: split MAC address add/remove code net/mlx5: implement multicast add list devop drivers/net/mlx5/mlx5.c| 2 + drivers/net/mlx5/mlx5.h| 2 + drivers/net/mlx5/mlx5_defs.h | 7 +- drivers/net/mlx5/mlx

[dpdk-dev] [PATCH 2/2] net/mlx5: implement multicast add list devop

2018-04-18 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 2 ++ drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_defs.h | 5 +++- drivers/net/mlx5/mlx5_mac.c | 52 4 files changed, 60 insertions(+), 1 deletion(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 1/2] net/mlx5: split MAC address add/remove code

2018-04-18 Thread Nelio Laranjeiro
Move some code in DPDK callbacks to add/remove MAC addresses to internal function. This modification will be necessary to handle implement the devop set_mc_addr_list. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_defs.h | 4 +- drivers/net/mlx5/mlx5_ethdev.c | 2 +- drivers/net/

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-18 Thread Tiwei Bie
On Wed, Apr 18, 2018 at 11:42:56AM +0100, Ferruh Yigit wrote: > On 4/18/2018 7:49 AM, Tan, Jianfeng wrote: > > Hi Ferruh, > > > > > > On 4/17/2018 7:26 PM, Ferruh Yigit wrote: > >> On 4/17/2018 5:54 AM, Tiwei Bie wrote: > >>> On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote: > On

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 12:36 PM, Tiwei Bie wrote: > On Wed, Apr 18, 2018 at 11:42:56AM +0100, Ferruh Yigit wrote: >> On 4/18/2018 7:49 AM, Tan, Jianfeng wrote: >>> Hi Ferruh, >>> >>> >>> On 4/17/2018 7:26 PM, Ferruh Yigit wrote: On 4/17/2018 5:54 AM, Tiwei Bie wrote: > On Mon, Apr 16, 2018 at 05:10:

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check

2018-04-18 Thread Xueming(Steven) Li
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 18, 2018 6:01 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Shahaf Shuler ; Nelio Laranjeiro > ; > Wenzhuo Lu ; Jingjing Wu > Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function >

Re: [dpdk-dev] [PATCH v5 0/4] introduce new tunnel types

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 18, 2018 12:05 AM > To: Xueming(Steven) Li ; Lu, Wenzhuo > ; Wu, Jingjing > ; Thomas Monjalon ; Adrien > Mazarguil > > Cc: Nélio Laranjeiro ; Shahaf Shuler > ; dev@dpdk.org; > Olivier Matz > Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable

2018-04-18 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Rosen > Sent: Wednesday, April 18, 2018 4:12 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Helin > ; Zhang, Qi Z ; Wu, Jingjing > > Subject: [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at > device disable > > v4 updates: > ==

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-18 Thread Tiwei Bie
On Wed, Apr 18, 2018 at 12:44:54PM +0100, Ferruh Yigit wrote: > On 4/18/2018 12:36 PM, Tiwei Bie wrote: > > On Wed, Apr 18, 2018 at 11:42:56AM +0100, Ferruh Yigit wrote: > >> On 4/18/2018 7:49 AM, Tan, Jianfeng wrote: > >>> Hi Ferruh, > >>> > >>> > >>> On 4/17/2018 7:26 PM, Ferruh Yigit wrote: > >>

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check

2018-04-18 Thread Thomas Monjalon
18/04/2018 13:55, Xueming(Steven) Li: > From: Thomas Monjalon > > 17/04/2018 16:24, Xueming Li: > > > + /* Check that device supports requested rss hash functions. */ > > > + if ((dev_info.flow_type_rss_offloads | > > > + dev_conf->rx_adv_conf.rss_conf.rss_hf) != > > > + dev_info.flow_typ

Re: [dpdk-dev] [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

2018-04-18 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Wednesday, April 18, 2018 9:42 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Yao, > Lei A ; Wu, Yanglong > Subject: [PATCH v2] net/i40e: fix I40e start failing for missing JUMBO_FRAME > offload > > JUMBO_FRAME offload should be set

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 1:08 PM, Tiwei Bie wrote: > On Wed, Apr 18, 2018 at 12:44:54PM +0100, Ferruh Yigit wrote: >> On 4/18/2018 12:36 PM, Tiwei Bie wrote: >>> On Wed, Apr 18, 2018 at 11:42:56AM +0100, Ferruh Yigit wrote: On 4/18/2018 7:49 AM, Tan, Jianfeng wrote: > Hi Ferruh, > > > On 4

[dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Juhamatti Kuusisaari
Handle properly a case where DPDK_PATCH_PATH is set to point to a directory. Signed-off-by: Juhamatti Kuusisaari --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 7676a6b..2bb5458 100755 ---

Re: [dpdk-dev] [PATCH v4 05/16] ethdev: alter behavior of flow API actions

2018-04-18 Thread Andrew Rybchenko
On 04/16/2018 07:22 PM, Adrien Mazarguil wrote: This patch makes the following changes to flow rule actions: - List order now matters, they are redefined as performed first to last instead of "all simultaneously". - Repeated actions are now supported (e.g. specifying QUEUE multiple times

Re: [dpdk-dev] [dpdk-web] [PATCH v2] update stable releases roadmap

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 10:14 AM, Thomas Monjalon wrote: > 18/04/2018 11:05, Ferruh Yigit: >> On 4/11/2018 12:28 AM, Thomas Monjalon wrote: >>> - Typically a new stable release version follows a mainline release >>> - by 1-2 weeks, depending on the test results. >>> + The first stable release (.1) of a

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Aaron Conole
Alejandro Lucero writes: > On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole wrote: > > Alejandro Lucero writes: > > > I was just wondering, if device device PCI sysfs resource files or VFIO > group /dev files > require to change > > permissions for non-root users, does it not make sense to ad

Re: [dpdk-dev] [PATCH v11 00/10] crypto: add virtio poll mode driver

2018-04-18 Thread Zhoujian (jay)
> -Original Message- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] > Sent: Wednesday, April 18, 2018 6:01 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: Zhang, Roy Fan ; tho...@monjalon.net; Gonglei > (Arei) ; Zeng, Xin ; > Huangweidong (C) ; wangxin (U) > ; longpeng

Re: [dpdk-dev] [PATCH v3 1/4] bus/vmbus: add hyper-v virtual bus support

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > This patch adds support for an additional bus type Virtual Machine BUS > (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 > and Azure. Most of this code was extracted from FreeBSD and some of > this is fr

Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > The driver supports Hyper-V networking directly like > virtio for KVM or vmxnet3 for VMware. > > This code is based off of the FreeBSD driver. The file and variable > names are kept the same to help with understanding

Re: [dpdk-dev] [PATCH v3 3/4] net/netvsc: add documentation

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > Matching documentation for new netvsc device. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/nics/index.rst | 1 + > doc/guides/nics/netvsc.rst | 97 ++ > doc/guides/rel_notes/release_18_

Re: [dpdk-dev] [PATCH v3 0/4] Hyper-V Netvsc PMD

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > This is a revised version of the Hyper-V native bus (VMBus) > and network device (netvsc) drivers. This virtual device > is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 > and Azure. Most of this code was extracted from FreeBSD and so

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
Hi Xueming, On Wed, Apr 18, 2018 at 07:06:48PM +0800, Xueming Li wrote: > "port config all rss all" command will fail on PMD that not support any > of hard coding RSS hash types. This patch changed hard coding hash types > to supported types retrieved from device info. > > Signed-off-by: Xueming

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Bruce Richardson
On Wed, Apr 18, 2018 at 10:49:07AM +, Kuusisaari, Juhamatti wrote: > > Hello, > > > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > > > 18/04/2018 00:11, Scott Branden: > > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > > > 17/04/2018 23:49, Stephen Hemminger: > > >

Re: [dpdk-dev] [dpdk-web] [PATCH v2] update stable releases roadmap

2018-04-18 Thread Thomas Monjalon
18/04/2018 14:28, Ferruh Yigit: > On 4/18/2018 10:14 AM, Thomas Monjalon wrote: > > 18/04/2018 11:05, Ferruh Yigit: > >> On 4/11/2018 12:28 AM, Thomas Monjalon wrote: > >>> - Typically a new stable release version follows a mainline release > >>> - by 1-2 weeks, depending on the test results. > >>>

Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote: > Handle properly a case where DPDK_PATCH_PATH is set > to point to a directory. > > Signed-off-by: Juhamatti Kuusisaari Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v6 0/2] support Tx generic tunnel checksum and TSO

2018-04-18 Thread Xueming Li
V6: - Comments update according to maillist discussion. V5: - Removed duplicated testpmd patch in other pathset. - More comments on PKT_TX_TUNNEL_IP and PKT_TX_TUNNEL_UDP V4: - Removed DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM and DEV_TX_OFFLOAD_GENERIC_TNL_TSO - Replaced with DEV_TX_OFFLOAD_IP_TNL_TSO -

[dpdk-dev] [PATCH V20 0/4] add hot plug recovery mechanism

2018-04-18 Thread Jeff Guo
At the prior, device event monitor framework have been introduced, the typical usage of it is for device hot plug. If we want application would not be break down when device hot plug in or out, we still need some measures to do recovery to do preparation for device detach, so that we will not enco

[dpdk-dev] [PATCH V20 1/4] bus/pci: introduce device hot unplug handle

2018-04-18 Thread Jeff Guo
As of device hot unplug, we need some preparatory measures so that we will not encounter memory fault after device be plug out of the system, and also let we could recover the running data path but not been break. This patch allows the buses to handle device hot unplug event. The patch only enable

[dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-04-18 Thread Jeff Guo
This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let eal help application to handle this fault, when sigbus error oc

[dpdk-dev] [PATCH V20 3/4] igb_uio: fix uio release issue when hot unplug

2018-04-18 Thread Jeff Guo
when device being hot unplug, release a none exist uio resource will result kernel null pointer error, so this patch will check if device has been remove before release uio release procedure, if so just return back. Signed-off-by: Jeff Guo --- v20->v19: split patch independently. --- kernel/linu

[dpdk-dev] [PATCH V20 4/4] app/testpmd: show example to handler hot unplug

2018-04-18 Thread Jeff Guo
Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. Once app detect the removal event, the callback would be called, it first stop the packet forwarding, then stop the port, close the port and finally detach the port. Signed-off-by: Jeff Guo -

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 5:35 AM, Kuusisaari, Juhamatti wrote: > Hello Ferruh, > >> On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote: >>> Support for PCAP MAC address using physical interface MAC. >>> Support for getting proper link status, speed and duplex. >>> >>> Signed-off-by: Juhamatti Kuusisaari >>> --

[dpdk-dev] [PATCH v2 0/3] net/mlx5: implement set_mc_addr devop

2018-04-18 Thread Nelio Laranjeiro
Support eth_dev_ops.set_mc_addr_list(). Changes in v2: Simplify the code and are even more verifications. Nelio Laranjeiro (3): net/mlx5: more checks on MAC addresses net/mlx5: split MAC address add/remove code net/mlx5: implement multicast add list devop drivers/net/mlx5/mlx5.c|

[dpdk-dev] [PATCH v2 2/3] net/mlx5: split MAC address add/remove code

2018-04-18 Thread Nelio Laranjeiro
Move some code in DPDK callbacks to add/remove MAC addresses to internal function. This modification will be necessary to handle implement the devop set_mc_addr_list. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_defs.h | 4 +- drivers/net/mlx5/mlx5_ethdev.c | 2 +- drivers/net/

[dpdk-dev] [PATCH v2 1/3] net/mlx5: more checks on MAC addresses

2018-04-18 Thread Nelio Laranjeiro
Verify MAC address before further process. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_mac.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index edc7a32ae..f24b5f759 100644 --- a/drivers

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Thomas Monjalon
18/04/2018 10:56, Bruce Richardson: > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > > 18/04/2018 00:11, Scott Branden: > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > > 17/04/2018 23:49, Stephen Hemminger: > > > >> IMHO would have been better to use the kernel SPDX sty

[dpdk-dev] [PATCH v2 3/3] net/mlx5: implement multicast add list devop

2018-04-18 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 2 ++ drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_defs.h | 5 - drivers/net/mlx5/mlx5_mac.c | 33 + 4 files changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 9:26 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config

[dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-18 Thread Xueming Li
This patch introduce new TX offload flags for device that supports IP or UDP tunneled packet L3/L4 checksum and TSO offload. It will be used for non-standard tunnels. The support from the device is for inner and outer checksums on IPV4/TCP/UDP and TSO for *any packet with the following format*:

[dpdk-dev] [PATCH v6 2/2] app/testpmd: testpmd support Tx generic tunnel offloads

2018-04-18 Thread Xueming Li
"show port cap" and "csum parse tunnel" command support TX generic tunnel offloads Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 14 -- app/test-pmd/config.c | 17 + 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node

2018-04-18 Thread Singh, Jasvinder
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, April 16, 2018 11:58 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH] examples/ip_pipeline: fix logically dead node > > Coverity issue: 272567 > Fixes: d75c371e9b46 ("examples/ip_pipeline

Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Thomas Monjalon
18/04/2018 15:30, Ferruh Yigit: > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote: > > Handle properly a case where DPDK_PATCH_PATH is set > > to point to a directory. > > > > Signed-off-by: Juhamatti Kuusisaari > > Acked-by: Ferruh Yigit Funny bug, I didn't thought that "test -x" is positive

Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Thomas Monjalon
18/04/2018 16:06, Thomas Monjalon: > 18/04/2018 15:30, Ferruh Yigit: > > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote: > > > Handle properly a case where DPDK_PATCH_PATH is set > > > to point to a directory. > > > > > > Signed-off-by: Juhamatti Kuusisaari > > > > Acked-by: Ferruh Yigit > >

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-18 Thread Flavio Leitner
On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote: > My vote is to work with udev and not try to replace it. > > Driverctl works well. Just not for bifurcated driver I second that. We also have other system configs to care about like kernel parameters and hugepage configuration w

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 9:26 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config

Re: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING printouts

2018-04-18 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Wednesday 18 April 2018 10:26 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [PATCH v2] app/bbdev: remove improper WARNING printouts > > Improper WARNING printouts in BBDev Test Application removed > > Signed

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 01:54:20PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 9:26 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas > > Mon

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming(Steven) Li
+Olivier > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 10:17 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: on

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-18 Thread Thomas Monjalon
18/04/2018 15:58, Xueming Li: > This patch introduce new TX offload flags for device that supports > IP or UDP tunneled packet L3/L4 checksum and TSO offload. > It will be used for non-standard tunnels. > > The support from the device is for inner and outer checksums on > IPV4/TCP/UDP and TSO for

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 02:10:45PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 9:26 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas > > Mon

Re: [dpdk-dev] [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Wednesday, April 18, 2018 2:51 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification > > On Tue, Apr 17, 2018 at 11:14:29PM +0800, Xueming Li w

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Wednesday, April 18, 2018 2:49 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > On Tue, Apr 17, 2018 at 11:14:28PM +0800, Xueming Li wrote: > > This p

Re: [dpdk-dev] [PATCH v2 0/3] net/mlx5: implement set_mc_addr devop

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 03:50:03PM +0200, Nelio Laranjeiro wrote: > Support eth_dev_ops.set_mc_addr_list(). > > Changes in v2: > > Simplify the code and are even more verifications. > > Nelio Laranjeiro (3): > net/mlx5: more checks on MAC addresses > net/mlx5: split MAC address add/remove co

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 02:26:30PM +, Xueming(Steven) Li wrote: > +Olivier > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 10:17 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas

Re: [dpdk-dev] [PATCH v4 05/16] ethdev: alter behavior of flow API actions

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 03:26:00PM +0300, Andrew Rybchenko wrote: > On 04/16/2018 07:22 PM, Adrien Mazarguil wrote: > > This patch makes the following changes to flow rule actions: > > > > - List order now matters, they are redefined as performed first to last > >instead of "all simultaneously

  1   2   >