18/04/2018 04:43, Chen, Junjie J: > Thanks to point this out. I agree for the title change. > > Do you want me to send v2 patch? Or you can handle it when committing? > > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > > we obeserve rte_movX is not inline when doing performance profiling, > > > > so use *always_inline* keyword to force gcc to inline the function. > > > > > > > > Signed-off-by: Chen, Junjie <junjie.j.c...@intel.com> > > > > --- > > > > .../common/include/arch/x86/rte_memcpy.h | 22 > > +++++++++++----------- > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > The title should start with "eal/x86:" > > > Something like that: > > > eal/x86: force inlining of memcpy sub-functions > > > > > > Bruce, Konstantin, any review of the content/optimization? > > > > > No objection here. > > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Applied, thanks
