On 4/17/2018 10:53 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <step...@networkplumber.org>
>
> The driver supports Hyper-V networking directly like
> virtio for KVM or vmxnet3 for VMware.
>
> This code is based off of the FreeBSD driver. The file and variable
> names are kept the same to help with understanding (with most of the
> BSD style warts removed).
>
> Signed-off-by: Stephen Hemminger <sthem...@microsoft.com>
> ---
> MAINTAINERS | 7 +
> config/common_base | 8 +
> config/common_linuxapp | 2 +-
> drivers/net/Makefile | 1 +
> drivers/net/netvsc/Makefile | 23 +
> drivers/net/netvsc/hn_ethdev.c | 760 ++++++++++
> drivers/net/netvsc/hn_logs.h | 35 +
> drivers/net/netvsc/hn_nvs.c | 533 +++++++
> drivers/net/netvsc/hn_nvs.h | 243 ++++
> drivers/net/netvsc/hn_rndis.c | 1101 +++++++++++++++
> drivers/net/netvsc/hn_rndis.h | 26 +
> drivers/net/netvsc/hn_rxtx.c | 1221 +++++++++++++++++
> drivers/net/netvsc/hn_var.h | 140 ++
> drivers/net/netvsc/ndis.h | 378 +++++
> drivers/net/netvsc/rndis.h | 414 ++++++
> drivers/net/netvsc/rte_pmd_netvsc_version.map | 5 +
> mk/rte.app.mk | 1 +
Can you please add .ini file (doc/guides/nics/features/*.ini) to document PMD
features?
<...>
> @@ -479,6 +479,13 @@ F: drivers/net/enic/
> F: doc/guides/nics/enic.rst
> F: doc/guides/nics/features/enic.ini
>
> +Hyper-V netvsc
> +M: Stephen Hemminger <sthem...@microsoft.com>
> +M: K. Y. Srinivasan" <k...@microsoft.com>
Is " a typo?
<...>
> +/* XXX Why is this not generic in RTE? */
> +static int
> +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev,
> + struct rte_eth_link *link)
> +{
It is indeed generic now thanks to you :)
Can you switch to your generic functions?
<...>
> +/* enables testpmd to collect per queue stats. */
> +static int
> +hn_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *eth_dev,
> + __rte_unused uint16_t queue_id,
> + __rte_unused uint8_t stat_idx,
> + __rte_unused uint8_t is_rx)
> +{
> + return 0;
> +}
IS this dev_ops needed at all?
<...>
> @@ -0,0 +1,5 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +
> +DPDK_18.02 {
v18.05
