Re: [dpdk-dev] [PATCH v1] net/mlx: control netdevices through ioctl only

2018-02-28 Thread Shahaf Shuler
Friday, February 9, 2018 10:34 PM, Marcelo Ricardo Leitner: > > On Thu, Feb 08, 2018 at 05:37:06PM +0100, Adrien Mazarguil wrote: > > Several control operations implemented by these PMDs affect netdevices > > through sysfs, itself subject to file system permission checks > > enforced by the kernel

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix flow creation with a single target queue

2018-02-28 Thread Shahaf Shuler
Wednesday, February 14, 2018 5:40 PM, Adrien Mazarguil > On Wed, Feb 14, 2018 at 04:04:45PM +0100, Nelio Laranjeiro wrote: > > Adding a pattern targeting a single queues wrongly behaves as it is an > > RSS request, ending by creating several Verbs flows rules to match the > > RSS configuration. > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads cap query

2018-02-28 Thread Shahaf Shuler
Monday, February 26, 2018 10:13 AM, Nélio Laranjeiro: > On Sun, Feb 25, 2018 at 09:28:37AM +0200, Shahaf Shuler wrote: > > The query for the tunnel stateless offloads is wrongly implemented > > because of: > > > > 1. It was using the device id to query for the offloads. > > 2. It was using a compil

Re: [dpdk-dev] [PATCH 3/4] net/virtio-user: support server mode

2018-02-28 Thread Maxime Coquelin
On 02/28/2018 02:53 AM, Yang, Zhiyong wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, February 28, 2018 2:02 AM To: Yang, Zhiyong ; dev@dpdk.org; y...@fridaylinux.org; Tan, Jianfeng ; Bie, Tiwei ; Wang, Zhihong Cc: Wang, Dong1 Su

Re: [dpdk-dev] [PATCH 1/4] vhost: move fdset functions from fd_man.c to fd_man.h

2018-02-28 Thread Maxime Coquelin
On 02/28/2018 02:36 AM, Yang, Zhiyong wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, February 28, 2018 1:52 AM To: Yang, Zhiyong ; dev@dpdk.org; y...@fridaylinux.org; Tan, Jianfeng ; Bie, Tiwei ; Wang, Zhihong Cc: Wang, Dong1 Su

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

2018-02-28 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, February 26, 2018 7:22 PM > To: Jerin Jacob ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil ; Eads, Gage ; > hemant.agra...@nxp.com; narayanaprasad.athr...@cavium

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

2018-02-28 Thread Nicolau, Radu
Hi, > -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, February 27, 2018 11:32 AM > To: Nicolau, Radu ; Akhil Goyal > ; Doherty, Declan > Cc: Jerin Jacob ; Narayana Prasad > ; Nelio Laranjeiro > ; dev@dpdk.org > Subject: Re: [PATCH 1/5] lib

Re: [dpdk-dev] [PATCH v3 1/5] eal: add internal flag indicating init has completed

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 2:12 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 1/5] eal: add internal flag indicating init has completed Currently, primary process initiali

Re: [dpdk-dev] [PATCH v3 2/5] eal: don't process IPC messages before init finished

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 1:09 AM, Tan, Jianfeng wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 2/5] eal: don't process IPC messages before init finished It is not possible for a primary process to re

Re: [dpdk-dev] [PATCH v3 2/5] eal: don't process IPC messages before init finished

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 4:00 AM, Wiles, Keith wrote: + struct message_queue_entry *cur_msg, *next_msg, *new_msg = NULL; while (1) { - if (read_msg(&msg, &sa) == 0) - process_msg(&msg, &sa); + /* we want to process all messages in order of t

Re: [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause

2018-02-28 Thread Chao Zhu
> -Original Message- > From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] > Sent: 2018年2月27日 23:14 > To: dev@dpdk.org > Cc: Chao Zhu ; sta...@dpdk.org; > tho...@monjalon.net; Gowrishankar Muthukrishnan > > Subject: [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with e

Re: [dpdk-dev] [PATCH v3 3/5] eal: use locks to determine if secondary process is active

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 1:26 AM, Tan, Jianfeng wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 3/5] eal: use locks to determine if secondary process is active Previously, IPC would remove sockets it

Re: [dpdk-dev] [PATCH v3 3/5] eal: use locks to determine if secondary process is active

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 4:17 AM, Wiles, Keith wrote: On Feb 27, 2018, at 8:35 AM, Anatoly Burakov wrote: Previously, IPC would remove sockets it considers to be "inactive" based on whether they have responded. Change this to create lock files in addition to socket files, so that we can determine if sec

Re: [dpdk-dev] [PATCH v3 4/5] eal: prevent secondary process init while sending messages

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 1:58 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 4/5] eal: prevent secondary process init while sending messages Currently, it is possible to

Re: [dpdk-dev] [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC

2018-02-28 Thread Burakov, Anatoly
On 28-Feb-18 1:52 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC Currently, filter value is hardcoded and

Re: [dpdk-dev] [PATCH] eal: add asynchronous request API to DPDK IPC

2018-02-28 Thread Burakov, Anatoly
On 27-Feb-18 2:59 PM, Anatoly Burakov wrote: This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller. Under the hood, we create a separate thread to deal with replies to asynchronous requests, that will just wait to be noti

Re: [dpdk-dev] [PATCH v2] app/pdump: check for ports

2018-02-28 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Monday, February 26, 2018 6:23 AM > To: dev@dpdk.org; Pattan, Reshma > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [PATCH v2] app/pdump: check for ports > > In case of application build with shared library mode unless option '-

[dpdk-dev] [RFC 1/2] sched: new APIs for per-subport queue sizes

2018-02-28 Thread alangordondewar
From: Alan Dewar Added new APIs to allow the maximum queue sizes for each traffic class to be configured on a per-subport basis, rather than all subport's inheriting their maximum queue sizes from their parent port. Added new sched unit-test to exercise the new APIs. Signed-off-by: Alan Dewar

[dpdk-dev] [RFC 2/2] sched: support per-subport wred configurations

2018-02-28 Thread alangordondewar
From: Alan Dewar Move the WRED queue configuration parameters from rte_sched_port_params into rte_sched_subport_params so that we can have different WRED configuations on each subport. Updated sched unit-test to exercise new functionality. Signed-off-by: Alan Dewar --- lib/librte_sched/rte_sc

[dpdk-dev] [PATCH 0/5] Initial compressdev unit tests

2018-02-28 Thread Pablo de Lara
Added initial tests for Compressdev library. The tests are performed compressing a test buffer (or multiple test buffers) with compressdev or Zlib, and decompressing it/them with the other library (if compression is done with compressdev, decompression is done with Zlib, and viceversa). Tests adde

[dpdk-dev] [PATCH 1/5] compressdev: add const for xform in session init

2018-02-28 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- lib/librte_compressdev/rte_compressdev.c | 2 +- lib/librte_compressdev/rte_compressdev.h | 2 +- lib/librte_compressdev/rte_compressdev_pmd.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_compressdev/rte_compressdev.c

[dpdk-dev] [PATCH 2/5] test/compress: add initial unit tests

2018-02-28 Thread Pablo de Lara
This commit introduces the initial tests for compressdev, performing basic compression and decompression operations of sample test buffers, using the Zlib library in one direction and compressdev in another direction, to make sure that the library is compatible with Zlib. Due to the use of Zlib AP

[dpdk-dev] [PATCH 4/5] test/compress: add multi level test

2018-02-28 Thread Pablo de Lara
Add test that checks if all compression levels are supported and compress a buffer correctly. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 33 + 1 file changed, 33 insertions(+) diff --git a/test/test/test_compressdev.c b/test/test/test_compres

[dpdk-dev] [PATCH 3/5] test/compress: add multi op test

2018-02-28 Thread Pablo de Lara
Add test that checks if multiple operations with different buffers can be handled on a single enqueue call. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 366 --- 1 file changed, 240 insertions(+), 126 deletions(-) diff --git a/test/test

[dpdk-dev] [PATCH 5/5] test/compress: add multi session test

2018-02-28 Thread Pablo de Lara
Add test that checks if multiple sessions can be handled on a single enqueue call. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 280 +++ 1 file changed, 202 insertions(+), 78 deletions(-) diff --git a/test/test/test_compressdev.c b/test

Re: [dpdk-dev] [RFC] testpmd: handle UFO packets

2018-02-28 Thread Jason Wang
On 2018年02月24日 17:35, Jianfeng Tan wrote: Mostly likely, we will make UFO as a kind of GSO engine. For short term, we can just call APIs in librte_ip_frag to fragment. To test: 1. start testpmd with two vhost port. $ set fwd csum $ start 2. start vm0 connected to vhost0; $ ifconfig xx

Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms

2018-02-28 Thread Bruce Richardson
On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: > Signed-off-by: Akhil Goyal > Signed-off-by: Hemant Agrawal > --- Thanks for this. Some comments inline below. /Bruce > app/test-pmd/meson.build | 3 +++ > config/arm/arm64_dpaa2_linuxapp_gcc | 13 + >

Re: [dpdk-dev] [PATCH 6/7] bus/fslmc: enabling dpaa2 compilation for other platforms

2018-02-28 Thread Bruce Richardson
On Tue, Feb 27, 2018 at 10:55:51PM +0530, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++ > 1 file changed, 14 insertions(+) > With these patches should config/common_base be changed to enable all these drivers globally

Re: [dpdk-dev] [RFC] testpmd: handle UFO packets

2018-02-28 Thread Tan, Jianfeng
Hi Jason, On 2/28/2018 10:10 PM, Jason Wang wrote: On 2018年02月24日 17:35, Jianfeng Tan wrote: Mostly likely, we will make UFO as a kind of GSO engine. For short term, we can just call APIs in librte_ip_frag to fragment. To test: 1. start testpmd with two vhost port. $ set fwd csum $ st

[dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

2018-02-28 Thread Tomasz Duszynski
MRVL Crypto PMD supports most of the hash algorithms covered by test suites thus specific bits should be set in pmd_masks. Otherwise blockcipher authonly test returns success even though no real tests have been executed. Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") Cc: sta...@d

Re: [dpdk-dev] [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC

2018-02-28 Thread Tan, Jianfeng
On 2/28/2018 6:21 PM, Burakov, Anatoly wrote: On 28-Feb-18 1:52 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value

[dpdk-dev] [PATCH v2 01/10] net/mlx5: fix sriov flag

2018-02-28 Thread Nelio Laranjeiro
priv_get_num_vfs() was used to help the PMD in prefetching the mbuf in datapath when the PMD was behaving in VF mode. This knowledge is no more used. Fixes: 528a9fbec6de ("net/mlx5: support ConnectX-5 devices") Cc: ys...@mellanox.com Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --

[dpdk-dev] [PATCH v2 00/10] net/mlx5: clean driver

2018-02-28 Thread Nelio Laranjeiro
- Removes unused SR-IOV flag. - Adds missing documentation on some functions. - Removes the spin-lock on the private structure. - Standardize the return values of all functions as discussed on the mailing list [1]. [1] https://dpdk.org/ml/archives/dev/2018-January/087991.html Nelio Laranjeiro (

[dpdk-dev] [PATCH v2 03/10] net/mlx5: mark parameters with unused attribute

2018-02-28 Thread Nelio Laranjeiro
Replaces all (void)foo; by __rte_unused macro except when variables are under #if statements. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 4 ++-- drivers/net/mlx5/mlx5_ethdev.c | 18 +-- drivers/net/mlx5/mlx5_flow.c| 25

[dpdk-dev] [PATCH v2 02/10] net/mlx5: name parameters in function prototypes

2018-02-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 191 --- drivers/net/mlx5/mlx5_rxtx.h | 162 2 files changed, 195 insertions(+), 158 deletions(-) diff --git a/drivers/net/m

[dpdk-dev] [PATCH v2 05/10] net/mlx5: add missing function documentation

2018-02-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 18 ++ drivers/net/mlx5/mlx5_mr.c | 7 +-- drivers/net/mlx5/mlx5_rxq.c | 20 drivers/net/mlx5/mlx5_trigger.c | 30 ++ dr

[dpdk-dev] [PATCH v2 04/10] net/mlx5: normalize function prototypes

2018-02-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 2 +- drivers/net/mlx5/mlx5_mr.c | 11 ++- drivers/net/mlx5/mlx5_rxq.c | 16 drivers/net/mlx5/mlx5_txq.c | 8 4 files changed, 19 insertions(+), 18 deletions(-)

[dpdk-dev] [PATCH v2 06/10] net/mlx5: remove useless empty lines

2018-02-28 Thread Nelio Laranjeiro
Some empty lines have been added in the middle of the code without any reason. This commit removes them. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c| 20 drivers/net/mlx5/mlx5_ethdev.c | 7 --- drivers/net/mlx5/mlx5_m

[dpdk-dev] [PATCH v2 09/10] net/mlx5: change non failing function return values

2018-02-28 Thread Nelio Laranjeiro
These functions return int although they are not supposed to fail, resulting in unnecessary checks in their callers. Some are returning error where is should be a boolean. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 4 ++-- drivers/net/mlx5/

[dpdk-dev] [PATCH v2 07/10] net/mlx5: remove control path locks

2018-02-28 Thread Nelio Laranjeiro
In priv struct only the memory region needs to be protected against concurrent access between the control plane and the data plane. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 2 -- drivers/net/mlx5/mlx5.h | 43 +-

[dpdk-dev] [PATCH v2 10/10] net/mlx5: standardize on negative errno values

2018-02-28 Thread Nelio Laranjeiro
Set rte_errno systematically as well. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 88 ++- drivers/net/mlx5/mlx5_ethdev.c | 231 - drivers/net/mlx5/mlx5_flow.c| 317 +++-

Re: [dpdk-dev] [PATCH v3 4/5] eal: prevent secondary process init while sending messages

2018-02-28 Thread Tan, Jianfeng
On 2/28/2018 6:19 PM, Burakov, Anatoly wrote: On 28-Feb-18 1:58 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Tuesday, February 27, 2018 10:36 PM To: dev@dpdk.org Cc: Tan, Jianfeng Subject: [PATCH v3 4/5] eal: prevent secondary process init whil

Re: [dpdk-dev] [PATCH 6/7] bus/fslmc: enabling dpaa2 compilation for other platforms

2018-02-28 Thread Hemant Agrawal
On 2/28/2018 8:15 PM, Bruce Richardson wrote: On Tue, Feb 27, 2018 at 10:55:51PM +0530, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++ 1 file changed, 14 insertions(+) With these patches should config/common_base be ch

Re: [dpdk-dev] [PATCH 6/7] bus/fslmc: enabling dpaa2 compilation for other platforms

2018-02-28 Thread Richardson, Bruce
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Wednesday, February 28, 2018 4:02 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; tho...@monjalon.net; shreyansh.j...@nxp.com > Subject: Re: [PATCH 6/7] bus/fslmc: enabling dpaa2 compilation for other > pl

[dpdk-dev] [PATCH v1] net/mlx4: fix 'show port info all' during detach

2018-02-28 Thread Ophir Munk
The following scenario causes a crash in function mlx4_get_ifname 1. On testpmd startup mlx4 device is probed and started 2. mlx4 sriov is disabled. As a result an RMV event is sent to testpmd which closes the device and nullify the priv struct members. 3. Running 'show port info all' in testpmd re

[dpdk-dev] [PATCH] mk: allow renaming of build directories

2018-02-28 Thread Bruce Richardson
When building using make, the Makefile in the build directory contained the name of the build directory to be passed as an "O=" parameter to the DPDK SDK makefiles. Unfortunately, this meant that the compilation would always fail if the build directory was renamed. To remove this limitation, we can

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-02-28 Thread Kevin Traynor
On 02/26/2018 11:34 AM, Luca Boccassi wrote: > Hi all, > > Here is a list of patches targeted for LTS release 16.11.5. Please > help review and test. The planned date for the final release is March > the 5th, pending results from regression tests. > Before that, please shout if anyone has objectio

[dpdk-dev] [PATCH v2 0/7] cxgbe: bug fixes and updates

2018-02-28 Thread Rahul Lakkireddy
Patch 1 reworks rte_eth_dev allocation for other ports under same PF. Patch 2 fixes secondary process initialization failure. Patches 3 and 4 allow configuring RSS hash and key. Patch 5 updates link Forward Error Correction (FEC) to support IEEE 802.3 standard based FEC selection. Patches 6 and

[dpdk-dev] [PATCH v2 1/7] cxgbe: rework rte_eth_dev allocation

2018-02-28 Thread Rahul Lakkireddy
Rework rte_eth_dev allocation for other ports under same PF. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - Split rte_eth_dev allocation rework from patch 1. drivers/net/cxgbe/base/adapter.h | 28 ++--- drivers/net/cxgbe/cxgbe_main.c | 53 +

[dpdk-dev] [PATCH v2 2/7] cxgbe: fix secondary process initialization

2018-02-28 Thread Rahul Lakkireddy
From: Kumar Sanghvi Attach to rte_eth_dev devices allocated by Primary process for Ports other than Port-0 in the secondary process. Save the Primary rte_eth_dev device eth_dev_data as part of txq structure needed for tx path. Fixes: 8318984927ff ("cxgbe: add pmd skeleton") Signed-off-by: Kumar

[dpdk-dev] [PATCH v2 3/7] cxgbe: add support to update RSS hash configuration and key

2018-02-28 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add firmware API for updating RSS hash configuration and key. Move RSS hash configuration from cxgb4_write_rss() to a separate function cxgbe_write_rss_conf(). Also, rename cxgb4_write_rss() to cxgbe_write_rss() for consistency. Original work by Surendra Mobiya Signed-off

[dpdk-dev] [PATCH v2 4/7] cxgbe: add support to get programmed RSS hash configuration and key

2018-02-28 Thread Rahul Lakkireddy
From: Kumar Sanghvi Original work by Surendra Mobiya Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- v2: - No changes. drivers/net/cxgbe/base/common.h | 3 +++ drivers/net/cxgbe/base/t4_hw.c | 46 ++ drivers/net/cxgbe/cxgbe_ethdev.c | 53

[dpdk-dev] [PATCH v2 5/7] cxgbe: update link Forward Error Correction (FEC)

2018-02-28 Thread Rahul Lakkireddy
From: Kumar Sanghvi Normally, firmware reads various Forward Error Correction parameters from a Transceiver Module i2c EPROM and uses a couple of IEEE Standards (802.3bj for 100Gb/s and 802.3by for 25Gb/s) to interpret those parameters and come up with supported and default FEC settings. Firmware

[dpdk-dev] [PATCH v2 6/7] cxgbe: update link configuration for 32-bit port capability

2018-02-28 Thread Rahul Lakkireddy
Update link configuration API to prepare for 32-bit port capability support. Continue using 16-bit port capability for older firmware. Original work by Surendra Mobiya Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v2: - No changes. drivers/net/cxgbe/base/common.h |

[dpdk-dev] [PATCH v2 7/7] cxgbe: rework and use 32-bit port capability

2018-02-28 Thread Rahul Lakkireddy
The new code uses the new 32-bit Port Capabilities exclusively and only translates to/from the old 16-bit Port Capabilities at the last point possible when talking to older Firmware. For the old versus new Firmware issue, we use the new FW_PARAMS_CMD[PFVF, CAPS32] command to tell the Firmware that

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-28 Thread Trahe, Fiona
Hi Ahmed, Shally, So just to capture what we concluded in the call today: - There's no requirement for a device-agnostic session to facilitate load-balancing. - For stateful data a stream is compulsory. Xform is passed to stream on creation. So no need for a session in stateful op. Re s

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-02-28 Thread Luca Boccassi
On Wed, 2018-02-28 at 17:12 +, Kevin Traynor wrote: > On 02/26/2018 11:34 AM, Luca Boccassi wrote: > > Hi all, > > > > Here is a list of patches targeted for LTS release 16.11.5. Please > > help review and test. The planned date for the final release is > > March > > the 5th, pending results f

[dpdk-dev] [dpdk-announce] git repository for DPDK on Windows

2018-02-28 Thread Thomas Monjalon
According to the Technical Board approval today, the repository to prepare the port of DPDK to Microsoft Windows is open on dpdk.org: http://dpdk.org/browse/draft/dpdk-draft-windows/ The maintainer of this repository is Jason Messer. Good luck for the next steps of this major work! 19/0

[dpdk-dev] [dpdk-announce] DPDK Bangalore Summit March 9th 2018, one week to go

2018-02-28 Thread Tibrewala, Sujata
Agenda [1] for DPDK Summit Bangalore 2018 March 9th | Leela Palace, Bangalore, India is announced The agenda covers many interesting topics such as Hardware assist with DPDK, VM optimizations, Memzone Monitor, Data Plane Corruption, Service Function Chaining, OVN, OVS hardware offload, SPDK,

[dpdk-dev] [dpdk-announce] DPDK hands on lab Bangalore March 10th 2018, one week to go

2018-02-28 Thread Tibrewala, Sujata
Hi, Agenda for the DPDK hands on lab Bangalore has been published. Please apply to attend at [1]. If you want to stay in touch with our local Bangalore DPDK events do not forget to join our meet up group at [2]. DPDK hands on Lab What are latest new features DPDK brings into 2018? We will pro

Re: [dpdk-dev] [RFC 6/7] net/af_xdp: load BPF file

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:35:53 +0800 Qi Zhang wrote: > diff --git a/drivers/net/af_xdp/Makefile b/drivers/net/af_xdp/Makefile > index ac38e20bf..a642786de 100644 > --- a/drivers/net/af_xdp/Makefile > +++ b/drivers/net/af_xdp/Makefile > @@ -42,7 +42,10 @@ EXPORT_MAP := rte_pmd_af_xdp_version.map >

Re: [dpdk-dev] [RFC 6/7] net/af_xdp: load BPF file

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:35:53 +0800 Qi Zhang wrote: > + return 1; > + > + /* clear all kprobes */ > + i = system("echo \"\" > /sys/kernel/debug/tracing/kprobe_events"); Serious ick. Assumes run as root. And should be done directly not via system().

[dpdk-dev] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command

2018-02-28 Thread Ajit Khaparde
When the vnic_tpa_cfg HWRM command is sent to the FW, we are not passing the VNIC ID in case of disable. This can cause the FW to return an error. Correct VNIC ID needs to be passed for both enable and disable. Fixes: 0958d8b6435d ("net/bnxt: support LRO") Cc: sta...@dpdk.org Signed-off-by: Ajit

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:00 +0800 Qi Zhang wrote: > iff --git a/drivers/net/af_xdp/Makefile b/drivers/net/af_xdp/Makefile > new file mode 100644 > index 0..ac38e20bf > --- /dev/null > +++ b/drivers/net/af_xdp/Makefile > @@ -0,0 +1,56 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2014 Jo

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:00 +0800 Qi Zhang wrote: > struct pmd_internals { > + int sfd; > + int if_index; > + char if_name[0x100]; why not IFNAMSIZ? > + struct ether_addr eth_addr; > + struct xdp_queue rx; > + struct xdp_queue tx; > + struct xdp_umem *umem; > +

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:00 +0800 Qi Zhang wrote: > + > +static void *get_pkt_data(struct pmd_internals *internals, > + uint32_t index, > + uint32_t offset) > +{ > + return (uint8_t *)(internals->umem->buffer + > +(index <<

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:00 +0800 Qi Zhang wrote: > + > +static uint16_t > +eth_af_xdp_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > +{ > + struct pmd_internals *internals = queue; > + struct xdp_queue *rxq = &internals->rx; > + struct rte_mbuf *mbuf; > + unsigned l

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, March 1, 2018 7:42 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; magnus.karls...@intei.com; Topel, Bjorn > > Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver > > On Tue, 27 Feb 2

Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

2018-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, March 1, 2018 7:45 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; magnus.karls...@intei.com; Topel, Bjorn > > Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver > > On Tue, 27 Feb 2

Re: [dpdk-dev] [RFC 4/7] net/af_xdp: use mbuf mempool for buffer management

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:03 +0800 Qi Zhang wrote: > +static uint32_t > +mbuf_to_idx(struct pmd_internals *internals, struct rte_mbuf *mbuf) > +{ > + return (uint32_t)(((uint64_t)mbuf->buf_addr - > +(uint64_t)internals->umem->buffer) >> > + intern

Re: [dpdk-dev] [RFC 6/7] net/af_xdp: load BPF file

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 17:33:05 +0800 Qi Zhang wrote: > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/net/af_xdp/bpf_load.c b/drivers/net/af_xdp/bpf_load.c > new file mode 100644 > index 0..aa632207f > --- /dev/null > +++ b/drivers/net/af_xdp/bpf_load.c > @@ -0,0 +1,798 @@ > +// S

Re: [dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-28 Thread Jason Wang
On 2018年02月27日 17:32, Qi Zhang wrote: The RFC patches add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below link for detail AF_XDP introduction: https://fosdem.org/2018/schedule/event/af_xdp/ https://lwn.net/Articles/745934/ This patchset

Re: [dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, March 1, 2018 10:52 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: magnus.karls...@intei.com; Topel, Bjorn > Subject: Re: [dpdk-dev] [RFC 0/7] PMD driver for AF_XDP > > > > On 2018年02月27日 17:32, Qi Zhang

Re: [dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-28 Thread Zhang, Qi Z
+Magnus, since a typo in my first batch in email address. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 1, 2018 12:19 PM > To: Jason Wang ; dev@dpdk.org > Cc: magnus.karls...@intei.com; Topel, Bjorn > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH 1/4] vhost: move fdset functions from fd_man.c to fd_man.h

2018-02-28 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, February 28, 2018 4:45 PM > To: Yang, Zhiyong; dev@dpdk.org; y...@fridaylinux.org; Tan, Jianfeng; Bie, > Tiwei; Wang, Zhihong > Cc: Wang, Dong1 > Subject: Re: [PATCH 1/4] vhost: move fdset

Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms

2018-02-28 Thread Hemant Agrawal
On 2/28/2018 8:14 PM, Bruce Richardson wrote: On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote: Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- Thanks for this. Some comments inline below. /Bruce .. diff --git a/drivers/bus/fslmc/meson.build b/drivers/bus/fsl

[dpdk-dev] [PATCH] net/avf: convert to new RX/TX offload API

2018-02-28 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/avf/avf_ethdev.c | 6 +++--- drivers/net/avf/avf_rxtx.c | 6 +++--- drivers/net/avf/avf_rxtx.h | 10 +++--- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index 4df6617

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-28 Thread Verma, Shally
Hi Fiona >-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 01 March 2018 00:09 >To: Verma, Shally ; Ahmed Mansour >; dev@dpdk.org >Cc: De Lara Guarch, Pablo ; Athreya, Narayana >Prasad ; >Gupta, Ashish ; Sahu, Sunila >; Challa, Mahipal >; Jain, Deepak K ; Hem

[dpdk-dev] [PATCH v2 01/10] event/dpaa: fix include header

2018-02-28 Thread Hemant Agrawal
rte_cycles.h shall be included instead of rte_cycles_64.h dpaa_eventdev.c:32:27: fatal error: rte_cycles_64.h: No such file or directory Fixes: 9caac5dd1e7f ("event/dpaa: introduce PMD") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 2 +- 1 file cha

[dpdk-dev] [PATCH v2 00/10] meson build support for dpaaX

2018-02-28 Thread Hemant Agrawal
This patch series enables the meson build support for dpaa and dpaa2 platforms. Earlier dpaaX was only compiled for armv8 target. This patch series first prepares the dpaaX drivers to be compiled for non-ARM platform as well. v2: - handle review comments from Bruce - move the dpaaX compilati

[dpdk-dev] [PATCH v2 02/10] bus/dpaa: fix the BE compilation issue

2018-02-28 Thread Hemant Agrawal
The array pointers were used without index. Fixes: b9083ea5e084 ("net/dpaa: further push mode optimizations") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c| 5 +++-- drivers/bus/dpaa/base/qbman/qman_driver.c | 5 + 2 files changed, 4 insert

[dpdk-dev] [PATCH v2 03/10] dpaa: prepare for 32 bit compilation

2018-02-28 Thread Hemant Agrawal
This patch prepares the dpaa drivers for compilation on 32 bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 2 +- drivers/bus/dpaa/base/qbman/bman_driver.c | 2 +- drivers/bus/dpaa/dpaa_bus.c | 3 +-- drivers/crypto/dpaa_sec/dpaa_sec.c

[dpdk-dev] [PATCH v2 04/10] dpaa2: prepare for 32 bit compilation

2018-02-28 Thread Hemant Agrawal
This patch prepare the dpaa2 drivers for compilation on 32 bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 10 ++--- drivers/bus/fslmc/mc/fsl_mc_cmd.h | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c| 4 +- drivers/bus/fslmc/portal/dpa

[dpdk-dev] [PATCH v2 05/10] bus/fslmc: add 32 bit functional support for ARM

2018-02-28 Thread Hemant Agrawal
This patch adds the functional logic to make the dpaa2 drivers work on 32bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys.h | 30 -- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 9 + 2 files changed, 37 insertions(+), 2 dele

[dpdk-dev] [PATCH v2 06/10] bus/dpaa: enabling dpaa compilation for other platforms

2018-02-28 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h index 53707bb..e4b5702 100644 --- a/drivers/bus/dpaa/inclu

[dpdk-dev] [PATCH v2 07/10] bus/fslmc: enabling dpaa2 compilation for other platforms

2018-02-28 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h index 5640b04..fa6977f 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys

[dpdk-dev] [PATCH v2 08/10] config: add dpaaX build support in common linuxapp

2018-02-28 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/common_armv8a_linuxapp | 58 --- config/common_linuxapp| 37 +++ 2 files changed, 37 insertions(+), 58 deletions(-) diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_l

[dpdk-dev] [PATCH v2 09/10] build: add meson support for dpaaX platforms

2018-02-28 Thread Hemant Agrawal
Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- app/test-pmd/meson.build | 3 +++ config/arm/meson.build | 13 + config/rte_config.h | 12 +++- drivers/bus/dpaa/meson.build | 29 + dr

[dpdk-dev] [PATCH v2 10/10] build: add meson cross compile config for dpaaX

2018-02-28 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/arm/arm64_dpaa2_linuxapp_gcc | 13 + config/arm/arm64_dpaa_linuxapp_gcc | 14 ++ 2 files changed, 27 insertions(+) create mode 100644 config/arm/arm64_dpaa2_linuxapp_gcc create mode 100644 config/arm/arm64_dpaa_linuxapp_gcc diff

Re: [dpdk-dev] [RFC 0/7] PMD driver for AF_XDP

2018-02-28 Thread Jason Wang
On 2018年03月01日 12:20, Zhang, Qi Z wrote: +Magnus, since a typo in my first batch in email address. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z Sent: Thursday, March 1, 2018 12:19 PM To: Jason Wang;dev@dpdk.org Cc:magnus.karls...@intei.com; Topel