On 28-Feb-18 1:52 AM, Tan, Jianfeng wrote:
Hi Anatoly,
-----Original Message-----
From: Burakov, Anatoly
Sent: Tuesday, February 27, 2018 10:36 PM
To: dev@dpdk.org
Cc: Tan, Jianfeng
Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC
Currently, filter value is hardcoded and disconnected from actual
value returned by eal_mp_socket_path().
I can understand the hardcode is not good. But why it's not consistent with the
actual value returned from eal_mp_socket_path()?
It is consistent. It's just that it's disconnected from the value
returned by eal_mp_socket_path(). Meaning, if you change how
eal_mp_socket_path() works, you'll also have to update the filter (or
you may forget to do it and have a bug). This patch makes it so that
mp_filter value is automatically updated, should you change internal
workings of eal_mp_socket_path().
Fix this to generate filter
value by deriving it from eal_mp_socket_path() instead.
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Anyway, I think your way looks good to me, so
Acked-by: Jianfeng Tan <jianfeng....@intel.com>
Thanks,
Jianfeng
--
Thanks,
Anatoly
