Re: [dpdk-dev] [PATCH] build: add support for detecting march on ARM

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Sat, 30 Dec 2017 22:07:54 +0530 > From: Pavan Nikhilesh > To: bruce.richard...@intel.com, bl...@debian.org, > harry.van.haa...@intel.com, jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] build: add support for det

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

2018-01-08 Thread Matan Azrad
Hi Guo I answered for the 2 threads here. From: Guo, Jia, Monday, January 8, 2018 7:27 AM > On 1/3/2018 1:02 AM, Matan Azrad wrote: > > Hi Jeff > > > > Maybe I'm touching in previous discussions but please see some > comments\questions. > > > > From: Jeff Guo: > >> This patch aim to add a genera

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

2018-01-08 Thread Zhao1, Wei
Hi, zhangqi > -Original Message- > From: Zhang, Qi Z > Sent: Friday, December 22, 2017 12:36 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API > > Hi Wei: > > Please check my comment below. > Besides, there s

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

2018-01-08 Thread Zhao1, Wei
Hi, zhangqi > -Original Message- > From: Zhao1, Wei > Sent: Monday, January 8, 2018 4:30 PM > To: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API > > Hi, zhangqi > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, December

[dpdk-dev] [PATCH v2] net/i40e: move RSS to flow API

2018-01-08 Thread Wei Zhao
Rte_flow actually defined to include RSS, but till now, RSS is out of rte_flow. This patch is to move i40e existing RSS to rte_flow. This patch also enable queue region configuration using flow API for i40e. Signed-off-by: Wei Zhao --- v2: -change some code style. --- drivers/net/i40e/i40e_eth

[dpdk-dev] [PATCH v3] lib/librte_meter: add meter configuration profile

2018-01-08 Thread Jasvinder Singh
From: Cristian Dumitrescu This patch adds api for meter configuration profiles. For a given meter object, the parameters such as the rates and sizes for the token buckets are defined as configuration profile parameters. This helps in reducing the memory footprint of a meter object which results i

[dpdk-dev] [PATCH v3] meter: add meter configuration profile api

2018-01-08 Thread Jasvinder Singh
This patch set adds support for meter configuration profiles. Benefits: simplified configuration procedure, improved performance. Q1: What is the configuration profile and why does it make sense? A1: The configuration profile represents the set of configuration parameters for a given meter obj

Re: [dpdk-dev] [PATCH v3 10/11] test: register eventdev selftest

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:37 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 10/11] test: register event

Re: [dpdk-dev] [PATCH v3 02/11] eventdev: add API to perform self test

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:29 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 02/11] eventdev: add API to

Re: [dpdk-dev] [PATCH v3 03/11] event/octeontx: move eventdev octeontx test to driver

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:30 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 03/11] event/octeontx: move

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] security: fix device operation type

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Nelio > Laranjeiro > Sent: Friday, November 24, 2017 12:07 PM > To: Akhil Goyal > Cc: Doherty, Declan ; dev@dpdk.org; Gaetan > Rivet ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2 1/3] security: f

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > Sent: Monday, December 11, 2017 2:16 PM > To: De Lara Guarch, Pablo > Cc: Akhil Goyal ; Doherty, Declan > ; dev@dpdk.org; Gaetan Rivet > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] security: fix device operation type

2018-01-08 Thread Akhil Goyal
On 1/8/2018 3:28 PM, De Lara Guarch, Pablo wrote: -Original Message- From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro Sent: Friday, November 24, 2017 12:07 PM To: Akhil Goyal Cc: Doherty, Declan ; dev@dpdk.org; Gaetan Rivet ; sta...@dpdk.org Subject: Re: [dp

Re: [dpdk-dev] [PATCH v3 05/11] event/octeontx: update octeontx eventdev selftest ops

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:32 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 05/11] event/octeontx: upda

Re: [dpdk-dev] [PATCH 1/3] lib/librte_security: added get size

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Doherty, Declan > ; akhil.go...@nxp.com; Nicolau, Radu > > Subject: [PATCH 1/3] li

Re: [dpdk-dev] [PATCH v3 06/11] event/octeontx: add selftest to device arguments

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:33 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 06/11] event/octeontx: add

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: implemented security session get size

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Doherty, Declan > ; akhil.go...@nxp.com; Nicolau, Radu > > Subject: [PATCH 2/3] ne

Re: [dpdk-dev] [PATCH v1] service: fix memory leak by rte_service_init

2018-01-08 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Sunday, December 31, 2017 2:46 PM > To: dev@dpdk.org; Van Haaren, Harry > Cc: Jain, Deepak K ; Varghese, Vipin > > Subject: [PATCH v1] service: fix memory leak by rte_service_init > > This patch fixes the memory leak created by rte_service_init, when > run from se

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: metering and policing CLI clean up

2018-01-08 Thread Singh, Jasvinder
> -Original Message- > From: Wu, Jingjing > Sent: Sunday, January 7, 2018 2:25 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; Mcnamara, John > > Subject: RE: [PATCH 1/3] app/testpmd: metering and policing CLI clean up > > > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports

2018-01-08 Thread Gaëtan Rivet
Hi Matan, Thanks for the patches. A remark however: On Sun, Jan 07, 2018 at 09:45:50AM +, Matan Azrad wrote: > Fail-safe PMD sub devices management is based on ethdev port mechanism. > So, the sub-devices management structures are exposed to other DPDK > entities which may use them in paralle

Re: [dpdk-dev] [PATCH v3 02/11] eventdev: add API to perform self test

2018-01-08 Thread Pavan Nikhilesh
Hi Jerin, Thanks for the review, will send out a v4 addressing the comments. On Mon, Jan 08, 2018 at 03:26:23PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Tue, 26 Dec 2017 00:47:29 +0530 > > From: Pavan Nikhilesh > > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@inte

[dpdk-dev] [PATCH 01/25] net/i40e/base: add new PHY type

2018-01-08 Thread Qi Zhang
Add new PHY type I40E_PHY_TYPE_NOT_SUPPORTED_HIGH_TEMP, it will be set by firmware if device module not meet the thermal requirements. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h

[dpdk-dev] [PATCH 03/25] net/i40e/base: add (Q)SFP module memory access definitions

2018-01-08 Thread Qi Zhang
Add definations used for accessing and interrupting contents of (Q)SFP module internal EEPROM memory. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_t

[dpdk-dev] [PATCH 00/25] net/i40e: update base code

2018-01-08 Thread Qi Zhang
The patchset update i40e base code base on latest CID drop cid-i40e.2018.01.02.tar.gz, couple issues are fixed, include: NVM lock issue, LED blink issue, LLDP configuration read issue unaligned data issue on non-x86 platform and some compile issue with GCC 6.3. Aslo a new AQ command that help softw

[dpdk-dev] [PATCH 02/25] net/i40e/base: add capability macros

2018-01-08 Thread Qi Zhang
Add capability macros for 25G AOC/ACC PHYS. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index dca725afd..42b2d9166 100644 --- a/drivers/net/i40e/base/i

[dpdk-dev] [PATCH 06/25] net/i40e/base: add byte swaps in PHY register access

2018-01-08 Thread Qi Zhang
Add byte swap commandwhen transferring data between memory and firmware while using PHY register access functions. Endianness also need to be handled correctly during these swaps. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH 04/25] net/i40e/base: release spinlock before function returns

2018-01-08 Thread Qi Zhang
Fix a bug that adminq spin lock is not be released before function i40e_nvmupd_command returns. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_nvm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40

[dpdk-dev] [PATCH 05/25] net/i40e/base: retry AQC to overcome IRCRead hangs

2018-01-08 Thread Qi Zhang
When the I2C is busy, the PHY reads are delayed. The firmware will return EGAIN in these cases with an expectation that the SW will trigger the reads again. This patch retries the operation for a maximum period of 500ms Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 42 +++

[dpdk-dev] [PATCH 08/25] net/i40e/base: code refactoring for LED blink

2018-01-08 Thread Qi Zhang
Code refactory, wrap repeated code in function. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 202 1 file changed, 87 insertions(+), 115 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH 07/25] net/i40e/base: add macro for 25G device

2018-01-08 Thread Qi Zhang
Add Macro to idenfity 25G device by device ID Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_devids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/base/i40e_devids.h b/drivers/net/i40e/base/i40e_devids.h index f4a878423..66ff1ccfc 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH 09/25] net/i40e/base: add link speed convert function

2018-01-08 Thread Qi Zhang
Introduce a helper function which can convert the AdminQ link speed definition into a virtchnl definition. This can then be used by host driver implementations in order to safely convert to the interface recognized by the virtual functions. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_

[dpdk-dev] [PATCH 10/25] net/i40e/base: add AQ command for DCB parameters

2018-01-08 Thread Qi Zhang
Add new Adminq command i40e_aqc_opc_set_dcb_parameters that help to get DCB parameters in data structure i40e_aqc_set_dcb_parameters. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 drivers/net/i40e/base/i40e_common.c | 27 +++ d

[dpdk-dev] [PATCH 11/25] net/i40e/base: fix NVM lock

2018-01-08 Thread Qi Zhang
NVM lock is only required at below situation: 1. its X722 device or 2. API version >= 1.5 or may have issue at firmware downgrade. Fixes: c5846a125b26 ("net/i40e/base: fix NVM access interfering") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ dr

[dpdk-dev] [PATCH 14/25] net/i40e/base: enable AQ event get in NVM update

2018-01-08 Thread Qi Zhang
This patch adds new I40E_NVMUPD_GET_AQ_EVENT state to allow retrieval of AdminQ events as a result. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c| 2 +- drivers/net/i40e/base/i40e_nvm.c | 125 + drivers/net/i40e/base/i40e_prototype.h

[dpdk-dev] [PATCH 15/25] net/i40e/base: fix link LED blink

2018-01-08 Thread Qi Zhang
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identyfying the port, since Activity LED may be blinking for different r

[dpdk-dev] [PATCH 12/25] net/i40e/base: code clean

2018-01-08 Thread Qi Zhang
1. Cleanup logical in __i40e_read_nvm_word and reuse it in i40e_read_nvm_word. 2. Change couple functions to static so we can remove uncessary function declarations 3. Cleanup logical in i40e_validate_nvm_checksum. 4. Minor code style fix. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_a

[dpdk-dev] [PATCH 17/25] net/i40e/base: enhanced loopback AQ command

2018-01-08 Thread Qi Zhang
Enhanced loopback AQ command to allow variety of loopback modes. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 21 +++-- drivers/net/i40e/base/i40e_common.c | 12 drivers/net/i40e/base/i40e_diag.c | 17 +++-- drivers/net/

[dpdk-dev] [PATCH 13/25] net/i40e/base: add NVM update preservation flags

2018-01-08 Thread Qi Zhang
Add preservation flags support on X722 devices for NVM update AdminQ function wrapper. Add new parameter and handling to nvm update admin queue function intended to allow nvmupdate tool to configure the preservation flags in the AdminQ command. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i

[dpdk-dev] [PATCH 16/25] net/i40e/base: add defines for flat NVM

2018-01-08 Thread Qi Zhang
New control bits were defined for flat NVM structure. One for pointing which NVM bank is currently used and one used as indicator of structure type. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type

[dpdk-dev] [PATCH 18/25] net/i40e/base: add rearrange process AQ command

2018-01-08 Thread Qi Zhang
Add new AQ command that help to inform software how advanced rearrangement process is. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH 20/25] net/i40e/base: fix compile issue for GCC 6.3

2018-01-08 Thread Qi Zhang
When using GCC 6.3.0 and EXTRA_CFLAGS=-Og, the compiler is not smart enough to see that when you have an integrated VF that just one of the if statemets has to be true so that ntu is always set. Fix the way that the code is for integrated VFs so that the compiler won't complain. Fixes: 9783eb15eb9

[dpdk-dev] [PATCH 19/25] net/i40e/base: add AQ critical error type

2018-01-08 Thread Qi Zhang
The FW has the ability to return a critical error on every AQ command. So add the new return type as critical error to sync with firmware. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.c | 17 + drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i4

[dpdk-dev] [PATCH 21/25] net/i40e/base: code clean

2018-01-08 Thread Qi Zhang
1. Add more debug information in PF reset 2. Remove some redandant code. 3. clean incorrect function comments 4. minor code style fix. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_adminq.h | 3 --- drivers/net/i40e/base/i40e_common.c | 42 + drivers

[dpdk-dev] [PATCH 23/25] net/i40e/base: fix unaligned data issue

2018-01-08 Thread Qi Zhang
This fix prevents errors or warnings while accessing unaligned 32-bit data words on non-x86 platforms during getting link info from firmware. Fixes: e8228f1a16b7 ("net/i40e/base: report supported link modes") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c |

[dpdk-dev] [PATCH 22/25] net/i40e/base: fix reading LLDP configuration

2018-01-08 Thread Qi Zhang
Previous method for reading LLDP config was based on hard-coded offsets. It happened to work, because of structured architecture of the NVM memory. In the new approach, known as FLAT, we need to calculate the absolute address, instead of using relative values. Needed defines for memory location wer

[dpdk-dev] [PATCH 24/25] net/i40e: rename a field

2018-01-08 Thread Qi Zhang
Rename virtchnl_vf_resource's vf_offload_flags to vf_cap_flags. The new name is more generic, so more than just offloading capabilities can be added. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/i40e_common.c | 4 ++-- drivers/net/i40e/base/virtchnl.h| 4 ++-- drivers/net/i40e/i40e_pf.c

[dpdk-dev] [PATCH 25/25] net/i40e/base: update README file

2018-01-08 Thread Qi Zhang
Update README file to specify the version of CID drop. Signed-off-by: Qi Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 59e76c216..247ba11d4 100644 --- a/drivers/net/i40e

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Gaëtan Rivet
Hi Matan, Sorry for the delay on this. On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, December 20, 2017 12:22 AM > > To: Matan Azrad > > Cc: Adrien Mazarguil ;

Re: [dpdk-dev] [PATCH 3/3] examples/ipsec_secgw: create session mempools for ethdevs

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Doherty, Declan > ; akhil.go...@nxp.com; Nicolau, Radu > > Subject: [PATCH 3/3] ex

Re: [dpdk-dev] [PATCH] build: add support for detecting march on ARM

2018-01-08 Thread Pavan Nikhilesh
On Mon, Jan 08, 2018 at 01:43:07PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Sat, 30 Dec 2017 22:07:54 +0530 > > From: Pavan Nikhilesh > > To: bruce.richard...@intel.com, bl...@debian.org, > > harry.van.haa...@intel.com, jerin.ja...@caviumnetworks.com > > Cc: dev@dpdk.org,

Re: [dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, December 19, 2017 12:46 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > shreyansh.j...@nxp.com; Nipun Gupta > Subject: Re: [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path > >

Re: [dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path

2018-01-08 Thread Akhil Goyal
On 1/8/2018 4:43 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] Sent: Tuesday, December 19, 2017 12:46 PM To: Akhil Goyal ; dev@dpdk.org Cc: De Lara Guarch, Pablo ; shreyansh.j...@nxp.com; Nipun Gupta Subject: Re: [PATCH 5/5] c

Re: [dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports

2018-01-08 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Sent: Monday, January 8, 2018 12:33 PM > Hi Matan, > > Thanks for the patches. A remark however: > > On Sun, Jan 07, 2018 at 09:45:50AM +, Matan Azrad wrote: > > Fail-safe PMD sub devices management is based on ethdev port > mechanism. > > So, the sub-devices ma

Re: [dpdk-dev] [PATCH v3 01/11] eal: add common test assert macros

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Tue, 26 Dec 2017 00:47:28 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 01/11] eal: add common test

Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library

2018-01-08 Thread Liang, Ma
On 08 Jan 12:16, Jerin Jacob wrote: > -Original Message- > > Date: Fri, 22 Dec 2017 16:02:42 + > > From: Sean Harte > > To: Liang Ma > > Cc: jerin.ja...@caviumnetworks.com, dev@dpdk.org, > > harry.van.haa...@intel.com, Bruce Richardson , > > deepak.k.j...@intel.com, john.ge...@intel

Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Jan 2018 11:19:57 + > From: "Liang, Ma" > To: Jerin Jacob > CC: Sean Harte , dev@dpdk.org, > harry.van.haa...@intel.com, Bruce Richardson , > deepak.k.j...@intel.com, john.ge...@intel.com, "Mccarthy, Peter" > > Subject: Re: [PATCH v4 1/8] event/op

Re: [dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, January 8, 2018 11:17 AM > To: De Lara Guarch, Pablo ; Hemant > Agrawal ; dev@dpdk.org > Cc: shreyansh.j...@nxp.com; Nipun Gupta > Subject: Re: [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path > > On 1/

Re: [dpdk-dev] [PATCH 1/3] lib/librte_security: added get size

2018-01-08 Thread Akhil Goyal
On 12/12/2017 6:20 PM, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- lib/librte_security/rte_security.c | 7 +++ lib/librte_security/rte_security.h | 12 lib/librte_security/rte_security_driver.h| 14 ++ lib/librte_security/rte_sec

Re: [dpdk-dev] [PATCH v2 12/12] doc: add DPAA eventdev guide

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Fri, 22 Dec 2017 20:47:25 +0530 > From: Sunil Kumar Kori > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, hemant.agra...@nxp.com > Subject: [PATCH v2 12/12] doc: add DPAA eventdev guide > X-Mailer: git-send-email 2.9.3 > > Signed-off-by: Sunil Kumar Kori

Re: [dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports

2018-01-08 Thread Gaëtan Rivet
On Mon, Jan 08, 2018 at 11:16:37AM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Sent: Monday, January 8, 2018 12:33 PM > > Hi Matan, > > > > Thanks for the patches. A remark however: > > > > On Sun, Jan 07, 2018 at 09:45:50AM +, Matan Azrad wrote: > > > Fail-safe PMD sub dev

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

2018-01-08 Thread Gaëtan Rivet
Hi Matan, On Sun, Jan 07, 2018 at 09:45:51AM +, Matan Azrad wrote: > Testpmd should not use ethdev ports which are managed by other DPDK > entities. > > Set Testpmd ownership to each port which is not used by other entity and > prevent any usage of ethdev ports which are not owned by Testpmd.

Re: [dpdk-dev] Thread safety in rte_acl

2018-01-08 Thread Ananyev, Konstantin
> > Hi, I have two questions : 1. Is it safe that multiple threads will run > "rte_acl_classify" in parallel (on the same ctx )? Yes. > 2. Is it safe that one > thread will run "rte_acl_classify" when another thread tries to add new > rules to same ctx? thanks, Just add new rules is safe, b

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix l3fwd start failed on

2018-01-08 Thread Ananyev, Konstantin
> -Original Message- > From: Wu, Yanglong > Sent: Monday, January 8, 2018 3:06 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wu, Yanglong > > Subject: [PATCH v5] net/ixgbe: fix l3fwd start failed on > > L3fwd start failed on PF, for tx_q check failed. > That occurred when the SRIOV

Re: [dpdk-dev] [PATCH] ethdev: fix setting of MAC address

2018-01-08 Thread Ferruh Yigit
On 1/3/2018 2:12 PM, Andrew Rybchenko wrote: > On 01/03/2018 04:54 PM, Olivier Matz wrote: >> On Wed, Jan 03, 2018 at 02:43:59PM +0100, Olivier Matz wrote: >>> I've walked through the PMDs as suggested by Andrew, and there was >>> indeed some conflicts with the initial patch. I've just submitted th

[dpdk-dev] ??????RE: Thread safety in rte_acl

2018-01-08 Thread ????????
>> 2. Is it safe that one >> thread will run "rte_acl_classify" when another thread tries to add new >> rules to same ctx? thanks, >Just add new rules is safe, but applying them (calling rte_acl_build()) is not. In my case, there are two process sharing hugepage memory??struct rte_acl_ctx??,

Re: [dpdk-dev] [PATCH v1] [app/procinfo] fix memory leak - PCAP & service

2018-01-08 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Vipin Varghese > Sent: Sunday, December 31, 2017 3:54 PM > To: dev@dpdk.org > Cc: Hunt, David ; Jain, Deepak K > ; Varghese, Vipin > Subject: [dpdk-dev] [PATCH v1] [app/procinfo] fix memory leak - PCAP & > service > > When procinfo uses the P

Re: [dpdk-dev] 回复:RE: Thread safety in rte_acl

2018-01-08 Thread Ananyev, Konstantin
>> 2. Is it safe that one >> thread will run  "rte_acl_classify" when another thread tries to add new >> rules to same ctx? thanks, >Just add new rules is safe, but applying them (calling rte_acl_build()) is not. > In my case, there are two process sharing hugepage memory(struct > rte_acl_ct

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

2018-01-08 Thread Matan Azrad
From: Gaëtan Rivet, Monday, January 8, 2018 1:40 PM > Hi Matan, > > On Sun, Jan 07, 2018 at 09:45:51AM +, Matan Azrad wrote: > > Testpmd should not use ethdev ports which are managed by other DPDK > > entities. > > > > Set Testpmd ownership to each port which is not used by other entity > >

Re: [dpdk-dev] [PATCH] ethdev: fix link autonegotiation value

2018-01-08 Thread Ferruh Yigit
On 1/5/2018 5:38 PM, Thomas Monjalon wrote: > There are 3 kind of link data in ethdev: > - capabilities (rte_eth_dev_info) > - configuration (rte_eth_conf) > - status (rte_eth_link) > > A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and > configuration (rte_et

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] security: fix device operation type

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Nelio > Laranjeiro > Sent: Thursday, November 23, 2017 10:03 AM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; Gaetan Rivet ; > sta...@dpdk.org > Subject: [dpdk-stable] [PATCH v2 1/3] security: f

Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Thursday, November 23, 2017 10:03 AM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; Gaetan Rivet ; De Lara > Guarch, Pablo ; sta...@dpdk.org > Subject: [PATCH v2 2/3] crypto: fix pedantic

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/3] security: fix pedantic compilation

2018-01-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Nelio > Laranjeiro > Sent: Thursday, November 23, 2017 10:03 AM > To: Akhil Goyal ; Doherty, Declan > > Cc: dev@dpdk.org; Gaetan Rivet ; > sta...@dpdk.org > Subject: [dpdk-stable] [PATCH v2 3/3] security: f

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, January 8, 2018 12:58 PM > Hi Matan, > > Sorry for the delay on this. > It's OK in spite of I need to fetch it back :) > On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azrad wrote: > > Hi Gaetan > > > > > -Original Message- > > > From: Gaëtan Rive

Re: [dpdk-dev] [PATCH v6 2/3] net/virtio: add packet injection method

2018-01-08 Thread Yuanhan Liu
On Sun, Jan 07, 2018 at 04:05:12AM -0800, Xiao Wang wrote: > + /* > + * App management thread and virtio interrupt handler thread > + * both can change the 'started' flag, this lock is meant to > + * avoid such a contention. > + */ > + rte_spinlock_t state_lock; Why not

Re: [dpdk-dev] [PATCH v6 1/3] net/virtio: make control queue thread-safe

2018-01-08 Thread Yuanhan Liu
On Sun, Jan 07, 2018 at 04:05:11AM -0800, Xiao Wang wrote: > diff --git a/drivers/net/virtio/virtio_rxtx.h > b/drivers/net/virtio/virtio_rxtx.h > index 54f1e849b..71b5798b0 100644 > --- a/drivers/net/virtio/virtio_rxtx.h > +++ b/drivers/net/virtio/virtio_rxtx.h > @@ -84,6 +84,7 @@ struct virtnet_c

Re: [dpdk-dev] 回复:RE: Thread safety in rte_acl

2018-01-08 Thread Ramia, Kannan Babu
You can look at the source of anyone of the applications in samplevnf project in OPNFV which uses the active/shadow method for dynamically modifying the rules and applying them. Regards Kannan Babu -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sent: Monday

[dpdk-dev] Napatech pmd

2018-01-08 Thread Finn Christensen
Hi Thomas, Thanks for bringing this discussion up again. The Napatech PMD is build on top of our proprietary driver. The reason is basically that we utilize many years of driver development and thus reuses the FPGA controlling code in the DPDK PMD. The Napatech driver suite is still closed sou

[dpdk-dev] [PATCH 0/2] app/testpmd: fix invalid rxq and txq nubmer setting

2018-01-08 Thread Wei Dai
If an invlaid number of RX or TX queues is configured from testpmd command like "port config all rxq number" or "port config all txq number". The global variable rxq or txq is updated by the invalid input. This can cause testpmd crash. For example, if the maximum number of RX or TX queues is 4, tes

[dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid txq number setting

2018-01-08 Thread Wei Dai
If an invalid TX queue is configured from testpmd command like "port config all txq number", the global variable txq is updated by this invalid value. It may cause testpmd crash. This patch restores its last correct value when an invalid txq number configured is detected. Fixes: ce8d561418d4 ("app

[dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq number setting

2018-01-08 Thread Wei Dai
If an invalid RX queue is configured from testpmd command like "port config all rxq number", the global variable rxq is updated by this invalid value. It may cause testpmd crash. This patch restores its last correct value when an invalid rxq number configured is detected. Fixes: ce8d561418d4 ("app

Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time

2018-01-08 Thread Ferruh Yigit
On 12/26/2017 3:24 PM, Wei Dai wrote: > Without this patch, the number of queues per i40e VF is defined as 4 > by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base. > It is fixed value determined in building time and can't be changed > during run time. > With this patch, the number o

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

2018-01-08 Thread Gaëtan Rivet
On Mon, Jan 08, 2018 at 12:30:19PM +, Matan Azrad wrote: > > > From: Gaëtan Rivet, Monday, January 8, 2018 1:40 PM > > Hi Matan, > > > > On Sun, Jan 07, 2018 at 09:45:51AM +, Matan Azrad wrote: > > > Testpmd should not use ethdev ports which are managed by other DPDK > > > entities. > >

[dpdk-dev] [PATCH 2/2] net/sfc: change license to BSD-3-Clause

2018-01-08 Thread Andrew Rybchenko
Change license from BSD-2-Clause to BSD-3-Clause. Bump copyright year. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/Makefile | 26 ++ drivers/net/sfc/efsys.h | 26 ++ drivers/net/sfc/sfc.c | 26 ++

[dpdk-dev] [PATCH 1/2] net/sfc/base: change license to BSD-3-Clause

2018-01-08 Thread Andrew Rybchenko
Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause. Bump copyright year. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/README| 24 ++-- drivers/net/sfc/base/ef10_ev.c | 30 +++--- drivers/net/sfc/base/ef10_filter.c

Re: [dpdk-dev] [PATCH] app/eventdev: fix event device queue count

2018-01-08 Thread Jerin Jacob
-Original Message- > Date: Thu, 28 Dec 2017 16:26:53 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] app/eventdev: fix event device queue count > X-Mail

[dpdk-dev] ??????RE: ??????RE: Thread safety in rte_acl

2018-01-08 Thread ????????
Thanks very much! -- -- ??: "Ramia, Kannan Babu";; : 2018??1??8??(??) 9:06 ??: ""<1534057...@qq.com>;"Ananyev, Konstantin";"dev"; : RE: [dpdk-dev] ??RE: Thread safety in rte_acl You can look at the source of

[dpdk-dev] ??????RE: ??????RE: Thread safety in rte_acl

2018-01-08 Thread ????????
>> 2. Is it safe that one >> thread will run "rte_acl_classify" when another thread tries to add new >> rules to same ctx? thanks, >Just add new rules is safe, but applying them (calling rte_acl_build()) is not. > In my case, there are two process sharing hugepage memory??struct > rte_acl_ctx?

Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call()

2018-01-08 Thread Yuanhan Liu
On Wed, Jan 03, 2018 at 09:17:32AM +0100, Maxime Coquelin wrote: > >>Reviewed-by: Maxime Coquelin > > > > From 3.2. Managing ABI updates, General Guidelines: > > > > New APIs will be marked as experimental for at least one release to > > allow any issues found by users of the new API to be fix

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Gaëtan Rivet
On Mon, Jan 08, 2018 at 12:55:49PM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Monday, January 8, 2018 12:58 PM > > Hi Matan, > > > > Sorry for the delay on this. > > > > It's OK in spite of I need to fetch it back :) > > > On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azra

[dpdk-dev] [PATCH v4 01/11] eal: add common test assert macros

2018-01-08 Thread Pavan Nikhilesh
Adding common test assertion macros for unit testing. Taken from test/test.h. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v4 Changes: - add SPDX licence tags. - change octeontx selftest name to 'ssovf_evdev_selftest' v3 Changes: - add eventdev driver specific selftest to te

[dpdk-dev] [PATCH v4 02/11] eventdev: add API to perform self test

2018-01-08 Thread Pavan Nikhilesh
Add API to perform self test on the underlying event device driver. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_eventdev.c | 10 ++ lib/librte_eventdev/rte_eventdev.h | 12 lib/librte_event

[dpdk-dev] [PATCH v4 03/11] event/octeontx: move eventdev octeontx test to driver

2018-01-08 Thread Pavan Nikhilesh
Move octeontx eventdev specific test (test_eventdev_octeontx.c) to driver/event/octeontx. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- .../event/octeontx/ssovf_evdev_selftest.c| 0 test/test/Makefile

[dpdk-dev] [PATCH v4 04/11] event/octeontx: modify octeontx eventdev test

2018-01-08 Thread Pavan Nikhilesh
Modify test_eventdev_octeontx to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_evdev_selftest.c | 457 +- 1 file changed, 234 insertions(+), 223 deletions(-) diff --git a/drivers/event/octeontx/ssovf

[dpdk-dev] [PATCH v4 05/11] event/octeontx: update octeontx eventdev selftest ops

2018-01-08 Thread Pavan Nikhilesh
Update octeontx eventdev ops to invoke selftest when application invokes `rte_event_dev_selftest`. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/event/octeontx/Makefile | 3 ++- drivers/event/octeontx/ssovf_evdev.c | 2 ++ drivers/event/octeontx/ssovf_evdev.h | 4 3

[dpdk-dev] [PATCH v4 06/11] event/octeontx: add selftest to device arguments

2018-01-08 Thread Pavan Nikhilesh
Add selftest as a device argument that can be enabled by suppling 'self_test=1' as a vdev parameter --vdev="event_octeontx,self_test=1" The selftest is run after vdev creation is successfully complete. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/event/octeontx/Mak

[dpdk-dev] [PATCH v4 07/11] event/sw: move eventdev software test to driver

2018-01-08 Thread Pavan Nikhilesh
Move software eventdev specific test (test_eventdev_sw) to driver/event/sw/. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- test/test/test_eventdev_sw.c => drivers/event/sw/sw_evdev_selftest.c | 0 test/test/Makefile | 1 - 2 file

[dpdk-dev] [PATCH v4 08/11] event/sw: modify eventdev software test

2018-01-08 Thread Pavan Nikhilesh
Modify test_eventdev_sw to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev_selftest.c | 70 ++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v4 09/11] event/sw: update software eventdev selftest ops

2018-01-08 Thread Pavan Nikhilesh
Update software eventdev ops to invoke selftest when application invokes `rte_event_dev_selftest`. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- drivers/event/sw/Makefile | 2 ++ drivers/event/sw/sw_evdev.c | 2 ++ drivers/event/sw/sw_evdev.h | 1 + 3 files changed, 5 insertio

[dpdk-dev] [PATCH v4 10/11] test: register eventdev selftest

2018-01-08 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- test/test/test_eventdev.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c index f8ee1bef6..7465251dc 100644 --- a/test/test/test_eventdev.c +++ b/test/test/t

[dpdk-dev] [PATCH v4 11/11] doc: update eventdev documentation

2018-01-08 Thread Pavan Nikhilesh
Update octeontx eventdev documentation to include new selftest feature. Signed-off-by: Pavan Nikhilesh Acked-by: Marko Kovacevic --- doc/guides/eventdevs/octeontx.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/oct

  1   2   3   >