> -----Original Message-----
> From: Nicolau, Radu
> Sent: Tuesday, December 12, 2017 12:50 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Yigit, Ferruh
> <ferruh.yi...@intel.com>; Gonzalez Monroy, Sergio
> <sergio.gonzalez.mon...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>; Doherty, Declan
> <declan.dohe...@intel.com>; akhil.go...@nxp.com; Nicolau, Radu
> <radu.nico...@intel.com>
> Subject: [PATCH 1/3] lib/librte_security: added get size
Title should be "security: add get session size function", or something similar
(use verb in infinitive form).
Secondly, I would add a short description of what this is doing.
Also, I have a comment inline in the code below.
Lastly, if any of the maintainers of the security library has any problems with
this patch, please shout.
>
> Signed-off-by: Radu Nicolau <radu.nico...@intel.com>
> ---
> lib/librte_security/rte_security.c | 7 +++++++
> lib/librte_security/rte_security.h | 12 ++++++++++++
> lib/librte_security/rte_security_driver.h | 14 ++++++++++++++
> lib/librte_security/rte_security_version.map | 1 +
> 4 files changed, 34 insertions(+)
>
> diff --git a/lib/librte_security/rte_security.c
> b/lib/librte_security/rte_security.c
> index 1227fca..56f2345 100644
> --- a/lib/librte_security/rte_security.c
> +++ b/lib/librte_security/rte_security.c
> @@ -70,6 +70,13 @@ rte_security_session_update(struct rte_security_ctx
> *instance,
> return instance->ops->session_update(instance->device, sess, conf);
> }
>
> +unsigned int
> +rte_security_session_get_size(struct rte_security_ctx *instance) {
> + RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_get_size, 0);
> + return instance->ops->session_get_size(instance->device);
Session get size returns an "int", but this function returns "unsigned int",
I think they should be the same type.
Thanks,
Pablo
