Hi Jerin, Thanks for the review, will send out a v4 addressing the comments.
On Mon, Jan 08, 2018 at 03:26:23PM +0530, Jerin Jacob wrote: > -----Original Message----- > > Date: Tue, 26 Dec 2017 00:47:29 +0530 > > From: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > > gage.e...@intel.com, liang.j...@intel.com > > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v3 02/11] eventdev: add API to perform self test > > X-Mailer: git-send-email 2.14.1 > > > > Add API to perform self test on the underlying event device driver. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > Acked-by: Harry van Haaren <harry.van.haa...@intel.com> > > --- > > + * Start eventdev selftest. > > + * > > + * @return > > + * Return 0 on success. > > + */ > > +typedef int (*eventdev_selftest) > > + (void); > > I think, The (void) need not to be in a separate line. > > With above change: > Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
