[dpdk-dev] [PATCH v3] examples/l3fwd: pass flow arguments when start app

2017-10-18 Thread Xiaoyun Li
To make the performance can be tuning on different NICs or platforms. We need to make the number of descriptors as arguments when starting l3fwd application. Signed-off-by: Xiaoyun Li --- v3 *Delete added Rx/Tx threshold arguments. v2 * Modify commit log. * Update the change in guides doc. doc

[dpdk-dev] [PktGen] remove mbuf refcnt verification

2017-10-18 Thread Xueming Li
To improve performance, dpdk drivers are using raw mbuf apis w/o refcnt reset when returning packet to pool. This patch remove refcnt validation when allocating mbufs from pool. Signed-off-by: Xueming Li --- lib/common/mbuf.h | 20 1 file changed, 20 deletions(-) diff --git

Re: [dpdk-dev] [PATCH 2/3] event/octeontx: add support for event Rx adapter

2017-10-18 Thread Pavan Nikhilesh Bhagavatula
On Tue, Oct 17, 2017 at 04:41:44PM +0530, Rao, Nikhil wrote: > > static __rte_always_inline uint16_t > > ssows_get_work(struct ssows *ws, struct rte_event *ev) > > { > >@@ -62,9 +86,10 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev) > > ws->cur_tt = sched_type_queue & 0x3; > >

Re: [dpdk-dev] [PATCH v2 02/18] eal: remove generic devtype

2017-10-18 Thread Gaëtan Rivet
Hello Aaron, On Tue, Oct 17, 2017 at 02:16:59PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > The devtype is now entirely defined by the device bus. As such, it is > > already characterized by the bus identifier within an rte_devargs. > > > > The rte_devtype enum can disappear, along w

Re: [dpdk-dev] [PATCH v2 00/18] devargs cleanup

2017-10-18 Thread Gaëtan Rivet
On Tue, Oct 17, 2017 at 02:18:02PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > The use of rte_devargs is inconsistent in the light of new functionalities > > such as device hotplug. > > > > Most of its API is still experimental and needs stabilization. > > Older functions were depreca

[dpdk-dev] [PATCH v2 2/3] event/octeontx: add support for event Rx adapter

2017-10-18 Thread Pavan Nikhilesh
Add Rx adapter queue add and delete API for both generic eth_devices as well as HW backed eth_octeontx which supports direct event injection to event device. The HW injected event needs to be converted into mbuf, previously this was done in eth_octeontx during rx_burst now it is moved to event_octe

[dpdk-dev] [PATCH v2 1/3] net/octeontx: add support for event Rx adapter

2017-10-18 Thread Pavan Nikhilesh
Add functions to modify and delete qos responsible for mapping eth queues to event queues used for configuring event Rx adapter. The mbox functions have been moved from octeontx_pkivf.c to octeontx_pkivf.h to allow event_octeontx to access them. Signed-off-by: Pavan Nikhilesh --- v2 changes: -

[dpdk-dev] [PATCH v2 3/3] doc: add event octeontx Rx adapter limitation

2017-10-18 Thread Pavan Nikhilesh
Add limitaion when using eth_octeontx as Rx adapter with event_octeontx. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/octeontx.rst index b43d515..4412bfa 100

Re: [dpdk-dev] [PATCH 3/3] doc: add event octeontx Rx adapter limitation

2017-10-18 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Tuesday, October 17, 2017 9:53 AM > To: santosh.shu...@caviumnetworks.com; jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 3/3] doc: add eve

Re: [dpdk-dev] [PATCH v2 3/3] doc: add event octeontx Rx adapter limitation

2017-10-18 Thread Mcnamara, John
Acked-by: John McNamara

Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-18 Thread Gaëtan Rivet
On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > Parsing operations should not happen in performance critical sections. > > Headers should not propose implementations unless duly required. > > > > Signed-off-by: Gaetan Rivet > > --- > > Can these cleanu

[dpdk-dev] [PATCH] net/mrvl: update copyright holders

2017-10-18 Thread Tomasz Duszynski
Add Marvell International Ltd. to the copyright holders. Signed-off-by: Tomasz Duszynski --- doc/guides/nics/mrvl.rst | 5 +++-- drivers/net/mrvl/Makefile | 6 -- drivers/net/mrvl/mrvl_ethdev.c | 4 +++- drivers/net/mrvl/mrvl_ethdev.h | 6 -- drivers/net/mrvl/mrvl_qos.c| 6

[dpdk-dev] [PATCH] crypto/mrvl: update copyright holders

2017-10-18 Thread Tomasz Duszynski
Add Marvell International Ltd. to the copyright holders. Signed-off-by: Tomasz Duszynski --- doc/guides/cryptodevs/mrvl.rst | 5 +++-- drivers/crypto/mrvl/Makefile | 6 -- drivers/crypto/mrvl/rte_mrvl_compat.h | 6 -- drivers/crypto/mrvl/rte_mrvl_pmd.c

Re: [dpdk-dev] [PATCH 3/3] doc: add event octeontx Rx adapter limitation

2017-10-18 Thread Pavan Nikhilesh Bhagavatula
On Wed, Oct 18, 2017 at 08:48:57AM +, Mcnamara, John wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > > Sent: Tuesday, October 17, 2017 9:53 AM > > To: santosh.shu...@caviumnetworks.com; jerin.ja...@caviumnetworks.com > > Cc: d

Re: [dpdk-dev] [PATCH 8/8] doc: update port id type

2017-10-18 Thread Van Haaren, Harry
> From: Mcnamara, John > Sent: Friday, October 13, 2017 4:41 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > ; Van Haaren, Harry > Subject: RE: [dpdk-dev] [PATCH 8/8] doc: update port id type > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk

[dpdk-dev] [PATCH] doc: add event eth Rx adapter programmer's guide

2017-10-18 Thread Nikhil Rao
Add programmer's guide doc to explain the use of the Event Ethernet Rx Adapter library. Signed-off-by: Nikhil Rao --- .../prog_guide/event_ethernet_rx_adapter.rst | 160 + doc/guides/prog_guide/index.rst| 1 + 2 files changed, 161 insertions(+) cr

[dpdk-dev] [PATCH] doc: add event eth Rx adapter library

2017-10-18 Thread Nikhil Rao
Signed-off-by: Nikhil Rao --- doc/guides/rel_notes/release_17_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8db35f5..b767da4 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++ b/doc/guide

[dpdk-dev] [PATCH v8 1/2] doc: add generic compilation doc for all sample apps

2017-10-18 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

[dpdk-dev] [PATCH v8 2/2] doc: add new introduction to sample app guides

2017-10-18 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic --- V8: Fixed Build issue (John) doc/guides/sample_app_ug/index.rst | 2 + doc/guides/sample_app_ug/intro.rst | 153 +++-- 2 files changed, 115 insertions(+), 40 deleti

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote: > > > Since a number of libraries depend on the maths lib, as well as > > > adding it > > > to the project args, we

[dpdk-dev] [PATCH] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath

2017-10-18 Thread Andrew Rybchenko
From: Ivan Malov Tx reap mechanism on EF10 native datapath was altered by one of the recent patches to introduce performance optimisations using the common technique of freeing mbuf segments in bulks. >From this perspective, the way of associating SW descriptors with individual mbuf segments rat

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread Zhiyong Yang
Fix port id issue and remove unnecessary cast. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- examples/l2fwd-crypto/main.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/e

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > > On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote: > > > > Since a number of libraries depend

[dpdk-dev] [PATCH v2] doc: add event eth Rx adapter programmer's guide

2017-10-18 Thread Nikhil Rao
Add programmer's guide doc to explain the use of the Event Ethernet Rx Adapter library. Signed-off-by: Nikhil Rao --- v2: Update MAINTAINERS MAINTAINERS| 2 +- .../prog_guide/event_ethernet_rx_adapter.rst | 160 + doc/guides/pr

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Luca Boccassi
On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 17:12 +0100,

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, Thanks for the patch. Some comments below. On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed ou

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed out and the return code from fflush() must be

Re: [dpdk-dev] [PATCH 2/2] power: check if userspace governor is available

2017-10-18 Thread Hunt, David
Hi Radoslaw, On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: Since for new Intel CPU's kernel use intel_pstate driver, which does not offer userspace governor, it is vise to check typo here, "wise" the userspace governor availability before trying to perform governor switch. The outcome fr

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Thomas Monjalon
18/10/2017 11:51, Bruce Richardson: > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote:

[dpdk-dev] [PATCH] doc: update release note for DPAA PMD support

2017-10-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/release_17_11.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8db35f5..966af7c 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++

[dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo frames and switched to the new offload API.

2017-10-18 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 32 +--- 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_u

[dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-18 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2a58378..5fd5acf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -920,6 +920,7 @@ F: examples/helloworld/ F: doc/guides/sample_app_ug/hello_world.rst M: Sergio Gonzale

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread santosh
Hi Thomas, On Monday 09 October 2017 02:49 PM, santosh wrote: > On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: >> 09/10/2017 07:46, santosh: >>> On Monday 09 October 2017 10:31 AM, santosh wrote: Hi Thomas, On Sunday 08 October 2017 10:13 PM, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 19:11

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 01:20:11PM +0200, Thomas Monjalon wrote: > 18/10/2017 11:51, Bruce Richardson: > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > On Tue, Oct 17, 2017 at 07:17:09PM +0100, Luca Boccassi wrote: > > > > On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi

[dpdk-dev] [PATCH 0/8] app/eventdev: add event eth Rx adapter support

2017-10-18 Thread Pavan Nikhilesh
The eventdev application uses producer lcores to inject packets as events into the event device. This approach is suitable for doing synthetic performance benchmarks. In most real-world scenarios the packets are received by an Ethernet device. The Event Ethernet Rx Adapter library enables packet t

[dpdk-dev] [PATCH 4/8] app/eventdev: add ethernet device setup helpers

2017-10-18 Thread Pavan Nikhilesh
Add ethernet device setup functions to configure ethdev ports incase prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 72 app/test-eventdev/test_perf_com

[dpdk-dev] [PATCH 2/8] app/eventdev: modify app setup to support ethdev

2017-10-18 Thread Pavan Nikhilesh
Modify app setup to accommodate event port and queue setup based on the number of ethernet ports. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 18 ++ app/test-eventdev/test_perf_common.c | 27 +-- app/test-eventdev/test_perf_co

[dpdk-dev] [PATCH 3/8] app/eventdev: add pktmbuf pool for ethdev

2017-10-18 Thread Pavan Nikhilesh
Add pktmbuf pool creation used when configuring ethernet device as event producer. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/t

[dpdk-dev] [PATCH 1/8] app/eventdev: add ethernet device producer option

2017-10-18 Thread Pavan Nikhilesh
Add command line option --prod_type_ethdev to specify that the events are generated by ethernet device. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_options.c | 11 +++ app/test-eventdev/evt_options.h | 29 + app/test-eventdev/test_perf_c

[dpdk-dev] [PATCH 6/8] app/eventdev: add event Rx adapter setup

2017-10-18 Thread Pavan Nikhilesh
Add functions to setup and configure Rx adapter based on the number of ethdev ports setup. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 97 ++-- app/test-eventdev/test_perf_common.h | 1 + 2 files changed, 84 insertions(+), 14 deletio

[dpdk-dev] [PATCH 5/8] app/eventdev: add ethernet device tear down

2017-10-18 Thread Pavan Nikhilesh
Add ethernet device destroy functions to stop and close ethdev ports if they are configured when prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 13 + app/test-eventdev/test_per

[dpdk-dev] [PATCH 7/8] app/eventdev: add service core configuration

2017-10-18 Thread Pavan Nikhilesh
Add service core configuration for Rx adapter. The configuration picks the least used service core to run the service on. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 41 app/test-eventdev/test_perf_atq.c| 12 +++ app/

[dpdk-dev] [PATCH 8/8] doc: update app eventdev options

2017-10-18 Thread Pavan Nikhilesh
Update documentation about new --prod_type_ethdev option in app/eventdev. Signed-off-by: Pavan Nikhilesh --- doc/guides/tools/testeventdev.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/tools/testeventdev.rst b/doc/guides/tools/testeventdev.rst index 34b1c31

Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: queue region set and flush

2017-10-18 Thread Chilikin, Andrey
Hi Wei, Is there number of RX queues configured for the port? If main_vsi->nb_used_qps reflects number of enabled RX queues, then it can be used. Regards, Andrey > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, October 18, 2017 4:01 AM > To: Chilikin, Andrey ; dev@dpdk.org >

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type

2017-10-18 Thread De Lara Guarch, Pablo
Hi Zhiyong, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Wednesday, October 18, 2017 10:50 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > Fix port id

Re: [dpdk-dev] [PATCH] doc: update release note for DPAA PMD support

2017-10-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Wednesday, October 18, 2017 12:45 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > Shreyansh Jain > Subject: [dpdk-dev] [PATCH] doc: update release note for DPAA PMD > sup

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 14:17, santosh: > Hi Thomas, > > > On Monday 09 October 2017 02:49 PM, santosh wrote: > > On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > >> 09/10/2017 07:46, santosh: > >>> On Monday 09 October 2017 10:31 AM, santosh wrote: > Hi Thomas, > > > On Sunday

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Radoslaw Biernacki
Hi David, Thank you for comments. On 18 October 2017 at 12:33, Hunt, David wrote: > Hi Radoslaw, > > > On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: > >> This patch fixes the bug caused by improper use of buffered >> stdio file access for switching the CPU frequency and >> governor. Each wri

Re: [dpdk-dev] [PATCH 2/2] power: check if userspace governor is available

2017-10-18 Thread Radoslaw Biernacki
Hi David, On 18 October 2017 at 12:53, Hunt, David wrote: > Hi Radoslaw, > > > On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: > >> Since for new Intel CPU's kernel use intel_pstate driver, >> which does not offer userspace governor, it is vise to check >> > > typo here, "wise" > > the userspac

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread santosh
On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > 18/10/2017 14:17, santosh: >> Hi Thomas, >> >> >> On Monday 09 October 2017 02:49 PM, santosh wrote: >>> On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: 09/10/2017 07:46, santosh: > On Monday 09 October 2017 10:31

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > > On Wed, Oct 18, 2017 at 10:35:48AM +0100, Bruce Richardson wrote: > > > > On Tue, Oct 17, 2017 at 0

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 16:02, santosh: > > On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > > 18/10/2017 14:17, santosh: > >> Hi Thomas, > >> > >> > >> On Monday 09 October 2017 02:49 PM, santosh wrote: > >>> On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > 09/10/2017 07:46, sa

Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-18 Thread Aaron Conole
Gaëtan Rivet writes: > On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: >> Gaetan Rivet writes: >> >> > Parsing operations should not happen in performance critical sections. >> > Headers should not propose implementations unless duly required. >> > >> > Signed-off-by: Gaetan Rivet

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Jerin Jacob
-Original Message- > Date: Wed, 18 Oct 2017 19:32:44 +0530 > From: santosh > To: Thomas Monjalon , John McNamara > > Cc: dev@dpdk.org, olivier.m...@6wind.com, jerin.ja...@caviumnetworks.com, > hemant.agra...@nxp.com, ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc:

[dpdk-dev] [ dpdk-dev ] PF set mac address api

2017-10-18 Thread Harouat, Karim (Nokia - FR/Lannion)
Hello Could someone advise me the more appropriate api to use to set pf mac address please ? It is to set it after the pf is bound. Specially for fm10k pf please The search tool on online document is not efficient to find it. thanks Best Regards, Cordialement Karim H

[dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Cristian Dumitrescu
Main changes: 1. The key_mask parameter is added to all the hash tables that were previously missing it, as well to the hash compute function. This was first started in DPDK 2.0, but was only implemented for a couple of hash tables. The benefit of this approach is that it allows for bette

[dpdk-dev] [PATCH v3 01/18] test: removing calls to deprecated hash tables

2017-10-18 Thread Cristian Dumitrescu
Removing calls to hash tables that are going to be removed later. The calls are removed from test/test, test/test-pipeline, examples/ip_pipeline. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 18 +++--- test/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v3 02/18] librte_table: remove deprecated 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 8-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- .../ip_pipe

[dpdk-dev] [PATCH v3 03/18] librte_table: remove deprecated 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 16-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte

[dpdk-dev] [PATCH v3 04/18] librte_table: remove deprecated variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key extendible bucket hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte_table/rt

[dpdk-dev] [PATCH v3 05/18] librte_table: remove deprecated variable size key lru hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key Least Recently Used (LRU) hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 4 - lib/librte_table/rte_tabl

[dpdk-dev] [PATCH v3 07/18] librte_table: add unified params structure and mask-based hash func

2017-10-18 Thread Cristian Dumitrescu
Add unified parameter structure for all hash tables in librte_table. Add mask-based hash function prototype, which is input parameter for all hash tables. Renamed the non-mask-based hash function prototype and all the calls to it (to be removed later). Signed-off-by: Cristian Dumitrescu --- ..

[dpdk-dev] [PATCH v3 08/18] librte_table: rework variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key extendible bucket (EXT) hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 12 +- lib/librte_table/rte_table_hash.h | 3

[dpdk-dev] [PATCH v3 09/18] librte_table: rework variable size key lru hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key LRU hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 26 lib/librte_table/rte_table_hash_lru.c | 277 +- test/t

[dpdk-dev] [PATCH v3 11/18] librte_table: rework 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 16-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- lib/librte_table/rte_table_hash.h

[dpdk-dev] [PATCH v3 10/18] librte_table: rework 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 8-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- .../ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH v3 06/18] librte_table: rename cuckoo hash table ops

2017-10-18 Thread Cristian Dumitrescu
The dosig particle is eliminated from the cuckoo hash ops name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 3 +-- lib/librte_table/rte_table_hash_cuckoo.c | 6 ++--- test/test-pipeline/pipeline_hash.c | 2 +- test/test/test_table_combined.c

[dpdk-dev] [PATCH v3 12/18] librte_table: rework 32-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 32-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 50 - lib/librte_table/rte_table_hash_key32.c | 386 ++

[dpdk-dev] [PATCH v3 14/18] test: add mask-based hash functions

2017-10-18 Thread Cristian Dumitrescu
Introduce mask-based hash functions in hash_func.h. Propagate their usage in test/test, test/test-pipeline and examples/ip_pipeline. Remove the non-mask-based hash function prototype from API (which was previously used as build workaround). Signed-off-by: Cristian Dumitrescu --- examples/ip_pi

[dpdk-dev] [PATCH v3 13/18] librte_table: rework cuckoo hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the cuckoo hash table to use the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 26 -- lib/librte_table/rte_table_hash_cuckoo.c | 149 +-- test/test-pipeline/pipeline_hash.c | 18 ++

[dpdk-dev] [PATCH v3 15/18] librte_table: cosmetic enhancements in api file

2017-10-18 Thread Cristian Dumitrescu
Consolidated hash tables into functional groups. Minor changes in comments. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/lib/librte_table/rte_table_hash.h b/lib/li

[dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for librte_table

2017-10-18 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) mode change 100644 => 100755 doc/guides/rel_notes/deprecation.rst diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst old mode 100644 new

[dpdk-dev] [PATCH v3 17/18] librte_table: map file updates

2017-10-18 Thread Cristian Dumitrescu
Updated map file to current API. Several API items were removed, so not using inheritance. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_version.map | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) mode change 100644 => 100755 lib/librte_table/rt

[dpdk-dev] [PATCH v3 16/18] librte_table: copyright cosmetic updates

2017-10-18 Thread Cristian Dumitrescu
Removed incorrect white spaces and updated year in copyrigh headers. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 2 +- lib/librte_table/rte_table_hash_cuckoo.c | 52 lib/librte_table/rte_table_hash_ext.c| 52

[dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Cristian Dumitrescu
Main changes: 1. The key_mask parameter is added to all the hash tables that were previously missing it, as well to the hash compute function. This was first started in DPDK 2.0, but was only implemented for a couple of hash tables. The benefit of this approach is that it allows for bette

[dpdk-dev] [PATCH v3 01/18] test: removing calls to deprecated hash tables

2017-10-18 Thread Cristian Dumitrescu
Removing calls to hash tables that are going to be removed later. The calls are removed from test/test, test/test-pipeline, examples/ip_pipeline. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 18 +++--- test/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v3 02/18] librte_table: remove deprecated 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 8-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- .../ip_pipe

[dpdk-dev] [PATCH v3 03/18] librte_table: remove deprecated 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the 16-byte key hash tables (both extendable bucket and LRU) are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte

[dpdk-dev] [PATCH v3 05/18] librte_table: remove deprecated variable size key lru hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key Least Recently Used (LRU) hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 4 - lib/librte_table/rte_tabl

[dpdk-dev] [PATCH v3 04/18] librte_table: remove deprecated variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
The non-dosig version of the variable size key extendible bucket hash tables are removed. The remaining hash tables are renamed to eliminate the dosig particle from their name. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 2 +- lib/librte_table/rt

[dpdk-dev] [PATCH v3 07/18] librte_table: add unified params structure and mask-based hash func

2017-10-18 Thread Cristian Dumitrescu
Add unified parameter structure for all hash tables in librte_table. Add mask-based hash function prototype, which is input parameter for all hash tables. Renamed the non-mask-based hash function prototype and all the calls to it (to be removed later). Signed-off-by: Cristian Dumitrescu --- ..

[dpdk-dev] [PATCH v3 08/18] librte_table: rework variable size key ext hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key extendible bucket (EXT) hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 12 +- lib/librte_table/rte_table_hash.h | 3

[dpdk-dev] [PATCH v3 06/18] librte_table: rename cuckoo hash table ops

2017-10-18 Thread Cristian Dumitrescu
The dosig particle is eliminated from the cuckoo hash ops name. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 3 +-- lib/librte_table/rte_table_hash_cuckoo.c | 6 ++--- test/test-pipeline/pipeline_hash.c | 2 +- test/test/test_table_combined.c

[dpdk-dev] [PATCH v3 16/18] librte_table: copyright cosmetic updates

2017-10-18 Thread Cristian Dumitrescu
Removed incorrect white spaces and updated year in copyrigh headers. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 2 +- lib/librte_table/rte_table_hash_cuckoo.c | 52 lib/librte_table/rte_table_hash_ext.c| 52

[dpdk-dev] [PATCH v3 09/18] librte_table: rework variable size key lru hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the variable size key LRU hash table to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 26 lib/librte_table/rte_table_hash_lru.c | 277 +- test/t

[dpdk-dev] [PATCH v3 15/18] librte_table: cosmetic enhancements in api file

2017-10-18 Thread Cristian Dumitrescu
Consolidated hash tables into functional groups. Minor changes in comments. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/lib/librte_table/rte_table_hash.h b/lib/li

[dpdk-dev] [PATCH v3 17/18] librte_table: map file updates

2017-10-18 Thread Cristian Dumitrescu
Updated map file to current API. Several API items were removed, so not using inheritance. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_version.map | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_version.

[dpdk-dev] [PATCH v3 18/18] doc: remove deprecation notice for librte_table

2017-10-18 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 52058f5..2ea19e7 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guid

[dpdk-dev] [PATCH v3 10/18] librte_table: rework 8-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 8-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- .../ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH v3 12/18] librte_table: rework 32-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 32-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h | 50 - lib/librte_table/rte_table_hash_key32.c | 386 ++

[dpdk-dev] [PATCH v3 11/18] librte_table: rework 16-byte key hash tables

2017-10-18 Thread Cristian Dumitrescu
Rework for the 16-byte key hash tables (both the extendible bucket and LRU)to use the mask-based hash function and the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- .../pipeline/pipeline_flow_classification_be.c | 14 +- lib/librte_table/rte_table_hash.h

[dpdk-dev] [PATCH v3 14/18] test: add mask-based hash functions

2017-10-18 Thread Cristian Dumitrescu
Introduce mask-based hash functions in hash_func.h. Propagate their usage in test/test, test/test-pipeline and examples/ip_pipeline. Remove the non-mask-based hash function prototype from API (which was previously used as build workaround). Signed-off-by: Cristian Dumitrescu --- examples/ip_pi

[dpdk-dev] [PATCH v3 13/18] librte_table: rework cuckoo hash table

2017-10-18 Thread Cristian Dumitrescu
Rework for the cuckoo hash table to use the unified parameter structure. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash.h| 26 -- lib/librte_table/rte_table_hash_cuckoo.c | 149 +-- test/test-pipeline/pipeline_hash.c | 18 ++

Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device

2017-10-18 Thread Thomas Monjalon
18/10/2017 16:36, Jerin Jacob: > From: santosh > > > > On Wednesday 18 October 2017 07:15 PM, Thomas Monjalon wrote: > > > 18/10/2017 14:17, santosh: > > >> Hi Thomas, > > >> > > >> > > >> On Monday 09 October 2017 02:49 PM, santosh wrote: > > >>> On Monday 09 October 2017 02:18 PM, Thomas Monjal

Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file

2017-10-18 Thread Luca Boccassi
On Wed, 2017-10-18 at 15:20 +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2017 at 01:24:54PM +0100, Bruce Richardson wrote: > > On Wed, Oct 18, 2017 at 11:14:07AM +0100, Luca Boccassi wrote: > > > On Wed, 2017-10-18 at 10:51 +0100, Bruce Richardson wrote: > > > > On Wed, Oct 18, 2017 at 10:35:48

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: set ip6_plen to the proper value

2017-10-18 Thread Sergio Gonzalez Monroy
On 13/10/2017 09:04, Tomasz Duszynski wrote: ipv6 payload length header field should contain only the number of bytes following the ipv6 header and not the entire packet size. Fixes: f159e70b0922 ("examples/ipsec-secgw: support transport mode") Fixes: 906257e965b7 ("examples/ipsec-secgw: support

Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-18 Thread Sergio Gonzalez Monroy
On 18/10/2017 13:06, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2a58378..5fd5acf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -920,6 +920,7 @@ F: examples/helloworld/ F: doc/guides/samp

Re: [dpdk-dev] [PATCH v3 00/18] librte_table: add key mask for hash tables

2017-10-18 Thread Dumitrescu, Cristian
> Cristian Dumitrescu (18): > test: removing calls to deprecated hash tables > librte_table: remove deprecated 8-byte key hash tables > librte_table: remove deprecated 16-byte key hash tables > librte_table: remove deprecated variable size key ext hash tables > librte_table: remove deprec

[dpdk-dev] [pull-request] next-pipeline 17.11 pre-rc2

2017-10-18 Thread Cristian Dumitrescu
The following changes since commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114: igb_uio: fix build with kernel <= 3.17 (2017-10-16 13:07:11 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 32ba3d320664a84bbd4575af3d85b78

  1   2   >