Gaëtan Rivet <gaetan.ri...@6wind.com> writes: > On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: >> Gaetan Rivet <gaetan.ri...@6wind.com> writes: >> >> > Parsing operations should not happen in performance critical sections. >> > Headers should not propose implementations unless duly required. >> > >> > Signed-off-by: Gaetan Rivet <gaetan.ri...@6wind.com> >> > --- >> >> Can these cleanups be done before the move in patch 3? > > Sure. > > I wanted to minimize the changes before moving the code. If I had rework > to do on these patches, I wanted to avoid having to redo the move and > verify the changes were properly propagated.
I use 'git rebase -i' to do changes; it can take care of moving through a stack of changes. > But if it is necessary, these changes can happen before moving the whole > lot. I think it's better to do all the changes before hand. If there is a change that could be part of a bug fix, it can be easily backported to stable branches.
