Hi Zhiyong, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Wednesday, October 18, 2017 10:50 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; Yang, Zhiyong > <zhiyong.y...@intel.com> > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > Fix port id issue and remove unnecessary cast. > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>
Actually, I think we can extend this patch to declare all variables related to port ids to uint16_t. I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", "dst_port". Rest of the patch looks good to me, so you can keep the ack if you are doing a v2. Acked-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
