Re: [dpdk-dev] [PATCH v2 0/6] NXP DPAA2: Refactor bus scan/probe code

2017-09-25 Thread Hemant Agrawal
HI Thomas, Ferruh has reviewed it. If you don't have any further comments on it, will you please apply this patchset to the main tree, so that other dependent patches can be applied to respective next trees? Regards, Hemant > -Original Message- > From: Shreyansh Jain

Re: [dpdk-dev] [PATCH v4 4/4] net/softnic: add TM hierarchy related ops

2017-09-25 Thread Lu, Wenzhuo
Hi Jasvinder, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Monday, September 18, 2017 5:10 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Yigit, Ferruh > ; tho...@monjalon.net > Subject: [dpdk-dev] [PATCH v4 4/4] net/softnic: add

Re: [dpdk-dev] [PATCH v4 0/2] Dynamically configure mempool handle

2017-09-25 Thread Olivier MATZ
Hi Santosh, On Tue, Sep 19, 2017 at 01:58:14PM +0530, santosh wrote: > Hi Olivier, > > > On Wednesday 13 September 2017 03:30 PM, santosh wrote: > > Hi Olivier, > > > > > > On Monday 11 September 2017 08:48 PM, Santosh Shukla wrote: > >> v4: > >> - Includes v3 review coment changes. > >> Patch

Re: [dpdk-dev] [PATCH v4 1/2] eal: allow user to override default pool handle

2017-09-25 Thread Olivier MATZ
On Mon, Sep 11, 2017 at 08:48:36PM +0530, Santosh Shukla wrote: > DPDK has support for both sw and hw mempool and > currently user is limited to use ring_mp_mc pool. > In case user want to use other pool handle, > need to update config RTE_MEMPOOL_OPS_DEFAULT, then > build and run with desired pool

[dpdk-dev] [PATCH v3] librte_eal: fix wrong assert for arm and ppc

2017-09-25 Thread Lukasz Majczak
The assertion of return value from the open() function is done against 0, while it is a correct value - open() returns -1 in case of an error. It causes problems while trying to run as a daemon, in which case, this call to open() will return 0 as a valid descriptor. Fixes: b94e5c9406b5 ("eal/arm:

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-25 Thread Olivier MATZ
Hi, On Mon, Sep 11, 2017 at 08:48:37PM +0530, Santosh Shukla wrote: > Now that dpdk supports more than one mempool drivers and > each mempool driver works best for specific PMD, example: > - sw ring based mempool for Intel PMD drivers. > - dpaa2 HW mempool manager for dpaa2 PMD driver. > - fpa HW

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush

2017-09-25 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 20, 2017 6:36 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush > > On 9/15/2017 4:13 AM, Wei Zhao wrote: > > This feature enable queue

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-25 Thread Olivier MATZ
On Thu, Sep 21, 2017 at 02:24:28PM +0200, Eelco Chaudron wrote: > On 19/09/17 09:28, Olivier MATZ wrote: > > Hi, > > > > On Thu, Sep 14, 2017 at 09:22:38AM +0200, Eelco Chaudron wrote: > > > On 13/09/17 11:39, Thomas Monjalon wrote: > > > > 12/09/2017 15:08, Eelco Chaudron: > > > > > Call the mloc

Re: [dpdk-dev] Cannot allocate mempool with --no-huge since DPDK 16.07

2017-09-25 Thread Olivier MATZ
Hi Tom, On Thu, Sep 21, 2017 at 05:21:08PM +0200, tom.barbe...@ulg.ac.be wrote: > Hi all, > > I get a EINVAL since DPDK 16.07 when trying to allocate a mempool with > rte_pktmbuf_pool_create. This is when I use --no-huge --vdev=eth_ring0. But > this happens before accessing the virtual device i

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) Yes, that case is missed. What do you think about following one: @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, unsigne

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Andrew Rybchenko
On 09/25/2017 11:42 AM, Ferruh Yigit wrote: On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: Failure happens on build using: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) Yes, that case is missed. What do you think about following one: @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_de

Re: [dpdk-dev] [PATCH v4] devtools: rework abi checker script

2017-09-25 Thread Olivier MATZ
On Thu, Sep 21, 2017 at 11:40:35AM -0400, Neil Horman wrote: > On Wed, Sep 20, 2017 at 11:12:53AM +0200, Olivier Matz wrote: > > The initial version of the script had some limitations: > > - cannot work on a non-clean workspace > > - environment variables are not documented > > - no compilation log

Re: [dpdk-dev] [PATCH v3 1/8] mbuf: support GTP in software packet type parser

2017-09-25 Thread Olivier MATZ
On Sat, Sep 23, 2017 at 06:35:07AM +0800, Beilei Xing wrote: > Add support of GTP-C and GTP-U tunnels in rte_net_get_ptype(). > > Signed-off-by: Beilei Xing Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for configuration of queue region

2017-09-25 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 20, 2017 6:46 PM > To: Zhao1, Wei ; dev@dpdk.org; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for > configuration of queue region > > On 9/15/2017 4:13 AM, Wei Zhao wrote:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: fix dereference before null check

2017-09-25 Thread Jastrzebski, MichalX K
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 22, 2017 6:39 PM > To: Jastrzebski, MichalX K ; > skh...@vmware.com > Cc: dev@dpdk.org; Jain, Deepak K ; Kulasek, > TomaszX ; yongw...@vmware.com; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] net/vmxnet3: fix der

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 8:40 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, September 20, 2017 6:36 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and > flush >> >> On 9/15/2017 4:13 AM, W

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Bruce Richardson
On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > > Failure happens on build using: > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > Yes, that case is missed. What do you think about following one: > > @@ -561,7 +561,7 @@ rte_pmd_i

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for configuration of queue region

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:25 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, September 20, 2017 6:46 PM >> To: Zhao1, Wei ; dev@dpdk.org; Wu, Jingjing >> >> Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for >> configuration of queu

Re: [dpdk-dev] [PATCH v3 3/6] net/i40e: implement dynamic mapping of sw flow types to hw pctypes

2017-09-25 Thread Xing, Beilei
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, September 20, 2017 10:33 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: [PATCH v3 3/6] net/i40e: implement dynamic mapping of sw flow > types to hw pctypes >

Re: [dpdk-dev] [PATCH v1 10/10] net/i40e: set register for no drop

2017-09-25 Thread Hunt, David
On 25/9/2017 3:50 AM, Wu, Jingjing wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt Sent: Saturday, August 26, 2017 12:02 AM To: dev@dpdk.org Cc: Hunt, David ; Marjanovic, Nemanja ; Sexton, Rory Subject: [dpdk-dev] [PATCH v1 10/10] net/i40e: s

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:40 AM, Bruce Richardson wrote: > On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: >> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >>> Failure happens on build using: >>> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >> >> Yes, that case is missed. What do you think about

Re: [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id to PF Id

2017-09-25 Thread Hunt, David
On 25/9/2017 3:43 AM, Wu, Jingjing wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt Sent: Saturday, August 26, 2017 12:02 AM To: dev@dpdk.org Cc: Hunt, David ; Marjanovic, Nemanja ; Sexton, Rory Subject: [dpdk-dev] [PATCH v1 01/10] net/i40e: ad

Re: [dpdk-dev] [PATCH v1 02/10] net/i40e: add API to get received packet count

2017-09-25 Thread Hunt, David
On 25/9/2017 3:47 AM, Wu, Jingjing wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt Sent: Saturday, August 26, 2017 12:02 AM To: dev@dpdk.org Cc: Hunt, David ; Marjanovic, Nemanja ; Sexton, Rory Subject: [dpdk-dev] [PATCH v1 02/10] net/i40e: a

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: fix dereference before null check

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:27 AM, Jastrzebski, MichalX K wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, September 22, 2017 6:39 PM >> To: Jastrzebski, MichalX K ; >> skh...@vmware.com >> Cc: dev@dpdk.org; Jain, Deepak K ; Kulasek, >> TomaszX ; yongw...@vmware.com; >> sta...@dpdk.

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 10:53 AM, Ferruh Yigit wrote: > On 9/25/2017 10:40 AM, Bruce Richardson wrote: >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: >>> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: Failure happens on build using: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >>> >>>

Re: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-25 Thread Hu, Jiayu
Hi Lei, > -Original Message- > From: Yao, Lei A > Sent: Wednesday, September 20, 2017 3:00 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; Tan, Jianfeng ; > Wu, Jingjing ; Hu, Jiayu > Subject: RE: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight >

Re: [dpdk-dev] [PATCH 0/2] Multiple Pktmbuf mempool support

2017-09-25 Thread Olivier MATZ
Hi Hemant, On Fri, Sep 22, 2017 at 12:43:36PM +0530, Hemant Agrawal wrote: > On 7/4/2017 5:52 PM, Hemant Agrawal wrote: > > This patch is in addition to the patch series[1] submitted by > > Santosh to allow application to set mempool handle. > > > > The existing pktmbuf pool create api only suppo

Re: [dpdk-dev] [PATCH] test/logs: fix dynamic log levels testing

2017-09-25 Thread Olivier MATZ
On Thu, Sep 21, 2017 at 08:44:09PM +0200, Radoslaw Biernacki wrote: > This patch fixes the dynamic log levels testing in logs_autotest. > Introduction of rte_log_set_level() in patch c1b5fa94a46f was done > with parameter RTE_LOG_EMERG which caused all RTE_LOG() calls an > early return due to all g

Re: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable

2017-09-25 Thread Dumitrescu, Cristian
... > diff --git a/config/common_base b/config/common_base > index 5e97a08..2626557 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -666,6 +666,13 @@ CONFIG_RTE_SCHED_COLLECT_STATS=n > CONFIG_RTE_SCHED_SUBPORT_TC_OV=n > CONFIG_RTE_SCHED_PORT_N_GRINDERS=8 > CONFIG_RTE_SCHED_VE

Re: [dpdk-dev] [PATCH] rte_sched: don't count RED-drops as tail-drops

2017-09-25 Thread Dumitrescu, Cristian
> > Packets that are RED-dropped are not Tail-dropped, so the n_pkts_dropped > counter should not be incremented when the n_pkts_red_dropped counter > is. > Hi Alan, Not really: * The n_pkts_dropped counter is intended to be incremented every time a packet is dropped, regardless of the drop ca

Re: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-25 Thread Ferruh Yigit
On 9/3/2017 7:30 AM, Jiayu Hu wrote: > The GRO library provides two modes to reassemble packets. Currently, the > csum forwarding engine has supported to use the lightweight mode to > reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode > for TCP/IPv4 GRO in the csum forwarding e

Re: [dpdk-dev] [PATCH v4] devtools: rework abi checker script

2017-09-25 Thread Neil Horman
On Mon, Sep 25, 2017 at 11:11:20AM +0200, Olivier MATZ wrote: > On Thu, Sep 21, 2017 at 11:40:35AM -0400, Neil Horman wrote: > > On Wed, Sep 20, 2017 at 11:12:53AM +0200, Olivier Matz wrote: > > > The initial version of the script had some limitations: > > > - cannot work on a non-clean workspace >

Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide

2017-09-25 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, September 23, 2017 5:55 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Rosen, Rami > > Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide > > This patch fixes a trivial typo in

Re: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP guide

2017-09-25 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, September 20, 2017 2:03 PM > To: Pascal Mazon > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP > guide > > The flow API is supported

Re: [dpdk-dev] [PATCH v6 3/8] mempool: add flags arg in xmem size and usage

2017-09-25 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 09:00:37PM +0530, Santosh Shukla wrote: > xmem_size and xmem_usage need to know the status of mempool flags, > so add 'flags' arg in _xmem_size/usage() api. > > Following patch will make use of that. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob Acked-b

Re: [dpdk-dev] [PATCH v6 5/8] mempool: get the mempool capability

2017-09-25 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 09:00:39PM +0530, Santosh Shukla wrote: > Allow the mempool driver to advertise his pool capabilities. > For that pupose, an api(rte_mempool_ops_get_capabilities) > and ->get_capabilities() handler has been introduced. > - Upon ->get_capabilities() call, mempool driver will

Re: [dpdk-dev] [PATCH v6 7/8] mempool: introduce block size align flag

2017-09-25 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 09:00:41PM +0530, Santosh Shukla wrote: > Some mempool hw like octeontx/fpa block, demands block size > (/total_elem_sz) aligned object start address. > > Introducing an MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag. > If this flag is set: > - Align object start address(vaddr) to

Re: [dpdk-dev] [PATCH v5 1/5] net/bonding: remove bonding APIs using ABI versioning

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > There are two bonding APIs using ABI versioning, and both have > port_id as parameter. Since we are already breaking ABI, no need > to keep older versions of APIs. > > Signed-off-by: Zhiyong Yang Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the original code and remove so

Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-25 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: > HW pool manager e.g. Octeontx SoC demands s/w to program start and end > address of pool. Currently, there is no such api in external mempool. > Introducing rte_mempool_ops_register_memory_area api which will let HW(pool > manager) t

Re: [dpdk-dev] [PATCH v3 5/6] app/testpmd: add new commands to manipulate with pctype mapping

2017-09-25 Thread Xing, Beilei
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, September 20, 2017 10:33 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: [PATCH v3 5/6] app/testpmd: add new commands to manipulate > with pctype mapping >

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the original code and remove so

Re: [dpdk-dev] [PATCH v3 7/7] doc: add membership documentation

2017-09-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yipeng Wang > Sent: Wednesday, September 6, 2017 1:00 AM > To: dev@dpdk.org > Cc: Tai, Charlie ; Gobriel, Sameh > ; Wang, Ren ; Wang, > Yipeng1 ; Mcnamara, John > > Subject: [dpdk-dev] [PATCH v3 7/7] doc: add mem

[dpdk-dev] [PATCH v2 1/8] net/i40e: add API to convert VF MAC to VSI index

2017-09-25 Thread David Hunt
From: "Sexton, Rory" Need a way to convert a vf id to a pf id on the host so as to query the pf for relevant statistics which are used for the frequency changes in the vm_power_manager app. Used when profiles are passed down from the guest to the host, allowing the host to map the vfs to pfs. Si

[dpdk-dev] [PATCH v2] Policy Based Power Control for Guest

2017-09-25 Thread David Hunt
Policy Based Power Control for Guest This patchset adds the facility for a guest VM to send a policy down to the host that will allow the host to scale up/down cpu frequencies depending on the policy criteria independently of the DPDK app running in the guest. This differs from the previous vm_po

[dpdk-dev] [PATCH v2 2/8] lib/librte_power: add extra msg type for policies

2017-09-25 Thread David Hunt
Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt --- lib/librte_power/channel_commands.h | 52 + 1 file changed, 52 insertions(+) diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h in

[dpdk-dev] [PATCH v2 3/8] examples/vm_power_mgr: add vcpu to pcpu mapping

2017-09-25 Thread David Hunt
Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt --- examples/vm_power_manager/channel_manager.c | 61 + examples/vm_power_manager/channel_manager.h | 25 2 files changed, 86 insertions(+) diff --git a/examples/vm_p

[dpdk-dev] [PATCH v2 4/8] examples/vm_power_mgr: add scale to medium freq fn

2017-09-25 Thread David Hunt
Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt --- examples/vm_power_manager/power_manager.c | 15 +++ examples/vm_power_manager/power_manager.h | 13 + 2 files changed, 28 insertions(+) diff --git a/examples/vm_power_manager/powe

[dpdk-dev] [PATCH v2 5/8] examples/vm_power_mgr: add policy to channels

2017-09-25 Thread David Hunt
From: "Sexton, Rory" Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt --- examples/vm_power_manager/channel_monitor.c | 331 +++- examples/vm_power_manager/channel_monitor.h | 20 ++ 2 files changed, 345 insertions(+), 6 deletions

[dpdk-dev] [PATCH v2 6/8] examples/vm_power_mgr: add port initialisation

2017-09-25 Thread David Hunt
We need to initialise the port's we're monitoring to be able to see the throughput. Signed-off-by: Nemanja Marjanovic Signed-off-by: David Hunt --- examples/vm_power_manager/main.c | 220 +++ 1 file changed, 220 insertions(+) diff --git a/examples/vm_power_m

[dpdk-dev] [PATCH v2 7/8] examples/guest_cli: add send policy to host

2017-09-25 Thread David Hunt
From: "Sexton, Rory" Here we're adding an example of setting up a policy, and allowing the vm_cli_guest app to send it to the host using the cli command "send_policy now" Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt --- .../guest_cli/vm_power_cli_gue

[dpdk-dev] [PATCH v2 8/8] examples/vm_power_mgr: set MAC address of VF

2017-09-25 Thread David Hunt
We need to set vf mac from the host, so that they will be in sync on the guest and the host. Otherwise, we'll have a random mac on the guest, and a 00:00:00:00:00:00 mac on the host. Signed-off-by: David Hunt --- examples/vm_power_manager/main.c | 60 +++- 1 f

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 11:06 AM, Ferruh Yigit wrote: > On 9/25/2017 10:53 AM, Ferruh Yigit wrote: >> On 9/25/2017 10:40 AM, Bruce Richardson wrote: >>> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: >

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > Failure happens on build using: > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") > > Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 1:52 PM, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >> Failure happens on build using: >> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) >> >> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") >> >> Signed-off-by: Andrew Rybchenko > > Reviewed

Re: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP guide

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 12:23 PM, Mcnamara, John wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Wednesday, September 20, 2017 2:03 PM >> To: Pascal Mazon >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] doc: add Linux flower suppo

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix assignment of enum values

2017-09-25 Thread Ferruh Yigit
On 9/23/2017 3:05 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, September 23, 2017 12:48 AM >> To: Jastrzebski, MichalX K ; Wu, Jingjing >> ; Xing, Beilei >> Cc: dev@dpdk.org; Jain, Deepak K ; Kulasek, TomaszX >> ; sta...@dpdk.org >> Subject:

[dpdk-dev] [PATCH] example: add new service cores sample application

2017-09-25 Thread Harry van Haaren
This commit adds a new sample app, which showcases the value of running services. In particular it allows the application to dynamically schedule services to service-cores. The sample app itself registers a number of dummy services, and applies different profiles to them at runtime. Note that this

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: get back RX flow functionality

2017-09-25 Thread Ferruh Yigit
On 8/3/2017 9:49 AM, Vasily Philipov wrote: > Getting hw directly on RX fast path without verbs call. > > Now the number of scatters is calculating on the fly, according to the > maximum expected packet size. > > Signed-off-by: Vasily Philipov I will update series as superseded with [1], please

Re: [dpdk-dev] [PATCH v2] net/ark:add null point check

2017-09-25 Thread Ed Czeck
Thank you. > In function ark_config_device(), there are several malloc without null > point check. Fix it by adding null point check. Acked-by: Ed Czeck

Re: [dpdk-dev] [PATCH v2] net/ark:add null point check

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 2:47 PM, Ed Czeck wrote: <...> >> In function ark_config_device(), there are several malloc without null >> point check. Fix it by adding null point check. > Signed-off-by: Yong Wang > Acked-by: Ed Czeck Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 1/7] member: implement main API

2017-09-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yipeng Wang > Sent: Wednesday, September 6, 2017 1:00 AM > To: dev@dpdk.org > Cc: Tai, Charlie ; Gobriel, Sameh > ; Wang, Ren ; Wang, > Yipeng1 ; Mcnamara, John > > Subject: [dpdk-dev] [PATCH v3 1/7] member: impl

Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-09-25 Thread Shreyansh Jain
On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote: Hello Ferruh, On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal <...> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_ver

Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter

2017-09-25 Thread Thomas Monjalon
25/09/2017 12:06, Ferruh Yigit: > On 9/25/2017 10:53 AM, Ferruh Yigit wrote: > > On 9/25/2017 10:40 AM, Bruce Richardson wrote: > >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > >>> It is a little to late for this, I already sent a pull-request with this > >>> patch. So fix will

[dpdk-dev] [PATCH v2] vfio: refactor PCI BAR mapping

2017-09-25 Thread Jonas Pfefferle
Split pci_vfio_map_resource for primary and secondary processes. Save all relevant mapping data in primary process to allow the secondary process to perform mappings. Signed-off-by: Jonas Pfefferle --- v2: * fix zero size and offset when trying to mmap non msix bar lib/librte_eal/common/include

Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 3:32 PM, Shreyansh Jain wrote: > On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote: >> Hello Ferruh, >> >> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain Signed-off-by: Hemant

[dpdk-dev] [PATCH v3 00/13] Move PCI away from the EAL

2017-09-25 Thread Gaetan Rivet
Hi all, Here is a new version of the PCI bus move out of the EAL. The EAL PCI implementation is divided in two parts: - librte_pci: library offering helpers to handle PCI objects - librte_bus_pci: bus driver for PCI devices This allows other libraries / tools to use PCI elements (location,

[dpdk-dev] [PATCH v3 01/13] eal: expose rte_eal_using_phys_addrs

2017-09-25 Thread Gaetan Rivet
This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from bool to int. Signed-off-by: Gaetan Rivet ---

[dpdk-dev] [PATCH v3 02/13] ethdev: remove useless PCI dependency

2017-09-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 1849a3b..5092b82 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -47,7 +47,6 @@ #

[dpdk-dev] [PATCH v3 03/13] bus: properly include rte_debug

2017-09-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index 08bec2d..9d1be8a 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v3 05/13] lib: include rte_bus_pci

2017-09-25 Thread Gaetan Rivet
Devices and drivers are now defined within the bus-specific PCI header. Update the libraries, as structuraly unsound as it may be. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev_pci.h | 1 + lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 + 2 files changed, 2 insertions(+)

[dpdk-dev] [PATCH v3 07/13] test: include rte_bus_pci

2017-09-25 Thread Gaetan Rivet
Devices and drivers are now defined within the bus-specific PCI header. Update test applications. Signed-off-by: Gaetan Rivet --- test/test/test_kni.c| 1 + test/test/virtual_pmd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/test/test/test_kni.c b/test/test/test_kni.c index db17fdf

[dpdk-dev] [PATCH v3 06/13] drivers: include rte_bus_pci

2017-09-25 Thread Gaetan Rivet
Devices and drivers are now defined within the bus-specific PCI header. Update drivers. Signed-off-by: Gaetan Rivet --- drivers/bus/pci/bsd/rte_pci.c| 1 + drivers/bus/pci/linux/rte_pci.c | 1 + drivers/bus/pci/linux/rte_pci_uio.c | 1 + drivers/bus/pci/linux/rte_pci_vf

[dpdk-dev] [PATCH v3 08/13] app/testpmd: include rte_bus_pci

2017-09-25 Thread Gaetan Rivet
Devices and drivers are now defined within the bus-specific PCI header. Update applications. Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 1d1ee75..d0613b5 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v3 09/13] cryptodev: move PCI specific helpers to drivers/crypto

2017-09-25 Thread Gaetan Rivet
Those helpers rely on the PCI bus driver implementation. Other similar libraries relied on the bus-specifics being handled in inlined functions, to be compiled on demand by drivers, once the proper PCI dependency has been settled. This seems unsafe. Move the PCI-specific helpers out of the lib dir

[dpdk-dev] [PATCH v3 10/13] pci: avoid inlining functions

2017-09-25 Thread Gaetan Rivet
Parsing operations should not happen in performance critical sections. Headers should not propose implementations unless duly required. Signed-off-by: Gaetan Rivet --- lib/librte_pci/include/rte_pci.h | 69 -- lib/librte_pci/rte_pci.c | 65

[dpdk-dev] [PATCH v3 11/13] pci: avoid over-complicated macro

2017-09-25 Thread Gaetan Rivet
Using a macro helps writing the code to the detriment of the reader in this case. This is backward. Write once, read many. The few LOCs gained is not worth the opacity of the implementation. Signed-off-by: Gaetan Rivet --- lib/librte_pci/rte_pci.c | 65 ++

[dpdk-dev] [PATCH v3 12/13] pci: deprecate misnamed functions

2017-09-25 Thread Gaetan Rivet
Rename misnamed functions and describe the change in a deprecation notice. Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/deprecation.rst | 10 ++ lib/librte_pci/include/rte_pci.h | 63 lib/librte_pci/rte_pci.c | 26 +++

[dpdk-dev] [PATCH v3 13/13] doc: add notes on EAL PCI API update

2017-09-25 Thread Gaetan Rivet
Add a section related to EAL API changes to 17.11 release notes. Signed-off-by: Gaetan Rivet Acked-by: John McNamara --- doc/guides/rel_notes/release_17_11.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/

Re: [dpdk-dev] [PATCH] example: add new service cores sample application

2017-09-25 Thread Eads, Gage
Neat example. Looks good overall, I just have a few questions. > +#define PROFILE_SERVICE_PER_CORE 8 Any reason not to use 5 here? That would remove a few zeroes from the profiles[] initializers. > +static int > +apply_profile(int profile_id) > +{ > + uint32_t i; > + uint32_t

[dpdk-dev] Issue with pktgen-dpdk replaying >1500bytes pcap on MCX4

2017-09-25 Thread Damien Clabaut
Hello DPDK devs, I am sending this message here as I did not find a bugtracker on the website. If this is the wrong place, I would kindly apologize and ask you to redirect me to the proper place, Thank you. Description of the issue: I am using pktgen-dpdk to replay a pcap file containing

Re: [dpdk-dev] [PATCH v4 1/2] eal: allow user to override default pool handle

2017-09-25 Thread santosh
On Monday 25 September 2017 08:28 AM, Olivier MATZ wrote: > On Mon, Sep 11, 2017 at 08:48:36PM +0530, Santosh Shukla wrote: >> DPDK has support for both sw and hw mempool and >> currently user is limited to use ring_mp_mc pool. >> In case user want to use other pool handle, >> need to update confi

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-25 Thread santosh
Hi Olivier, On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: > Hi, > > On Mon, Sep 11, 2017 at 08:48:37PM +0530, Santosh Shukla wrote: >> Now that dpdk supports more than one mempool drivers and >> each mempool driver works best for specific PMD, example: >> - sw ring based mempool for I

Re: [dpdk-dev] [PATCH v4 0/2] Dynamically configure mempool handle

2017-09-25 Thread santosh
On Monday 25 September 2017 08:24 AM, Olivier MATZ wrote: > Hi Santosh, > > On Tue, Sep 19, 2017 at 01:58:14PM +0530, santosh wrote: >> Hi Olivier, >> >> >> On Wednesday 13 September 2017 03:30 PM, santosh wrote: >>> Hi Olivier, >>> >>> >>> On Monday 11 September 2017 08:48 PM, Santosh Shukla wrot

Re: [dpdk-dev] [PATCH v6 7/8] mempool: introduce block size align flag

2017-09-25 Thread santosh
On Monday 25 September 2017 12:32 PM, Olivier MATZ wrote: > On Thu, Sep 07, 2017 at 09:00:41PM +0530, Santosh Shukla wrote: >> Some mempool hw like octeontx/fpa block, demands block size >> (/total_elem_sz) aligned object start address. >> >> Introducing an MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag.

Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-25 Thread santosh
On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote: > On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: >> HW pool manager e.g. Octeontx SoC demands s/w to program start and end >> address of pool. Currently, there is no such api in external mempool. >> Introducing rte_mempool_

Re: [dpdk-dev] Issue with pktgen-dpdk replaying >1500bytes pcap on MCX4

2017-09-25 Thread Yongseok Koh
Hi, Damien Can you please let me know the versions of your SW - pktgen-dpdk, DPDK and MLNX_OFED? Also Firmware version if available. Thanks, Yongseok > On Sep 25, 2017, at 10:19 AM, Damien Clabaut > wrote: > > Hello DPDK devs, > > I am sending this message here as I did not find a bugtracke

Re: [dpdk-dev] [RFC] kni: remove single mempool, single mem_chunk restriction

2017-09-25 Thread Ajeet Gill (ajgill)
Hello Ferruh, I see there might be issue with multi-chunk mempools in the KNI kernel driver. It looks like the logic of calculating the addresses is as following the below method: Va-Pa=Vb-Pb. where V’s are the Virtual addresses and P’s are the physical addresses. But this formula may not be tr

Re: [dpdk-dev] Issue with pktgen-dpdk replaying >1500bytes pcap on MCX4

2017-09-25 Thread Wiles, Keith
> On Sep 25, 2017, at 6:19 PM, Damien Clabaut > wrote: > > Hello DPDK devs, > > I am sending this message here as I did not find a bugtracker on the website. > > If this is the wrong place, I would kindly apologize and ask you to redirect > me to the proper place, > > Thank you. > > Descri

Re: [dpdk-dev] [PATCH v5 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-25 Thread Xing, Beilei
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, September 20, 2017 1:54 AM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: [PATCH v5 1/2] net/i40e: get information about protocols defined in > ddp profile >

Re: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-25 Thread Hu, Jiayu
Hi Lei, > -Original Message- > From: Hu, Jiayu > Sent: Monday, September 25, 2017 6:20 PM > To: Yao, Lei A ; dev@dpdk.org > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; Tan, Jianfeng ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight > mode TCP/IPv4 G

Re: [dpdk-dev] [PATCH v9 0/9] Infrastructure to detect iova mapping on the bus

2017-09-25 Thread santosh
Hi Thomas, On Wednesday 20 September 2017 12:23 PM, Santosh Shukla wrote: > v9: > - Added Tested-By: to series. > - Includes minor changes related to linuxapp api stub in [02/09] > (Suggested by Anatoly) > - Series rebased on tip commit : aee62e90 imo, series is ready to merge, note that octeo

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for configuration of queue region

2017-09-25 Thread Zhao1, Wei
Hi,Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 25, 2017 5:43 PM > To: Zhao1, Wei ; dev@dpdk.org; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for > configuration of queue region > > On 9/25/2017 10:25 AM, Zhao1, Wei wrote:

[dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO

2017-09-25 Thread Jiayu Hu
The GRO library provides two modes to reassemble packets. Currently, the csum forwarding engine has supported to use the lightweight mode to reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode for TCP/IPv4 GRO in the csum forwarding engine. With the command "set port gro on|of